Bill Meier
dd859eada4
asn1 generated dissectors: cleanup #include usage
...
Change-Id: I36b2731d67f9345d2fd0c23800bba7d2be94c387
Reviewed-on: https://code.wireshark.org/review/6008
Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-12-23 05:39:00 +00:00
Michael Mann
cd02af56a1
Eliminate (almost all) proto_tree_add_text calls from ASN.1 dissectors.
...
This mostly involved adding expert info capabilities to many of the dissectors so that they could correctly flag error conditions.
Only remaining proto_tree_add_text calls are in H248.cnf, which has a convoluted way of using hf_ data to make its tree.
Change-Id: I6412150c2ec1977d7fa38f3f0ed416680bdfb141
Reviewed-on: https://code.wireshark.org/review/3500
Petri-Dish: Michael Mann <mmann78@netscape.net>
Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-08-09 01:57:08 +00:00
Michael Mann
9356d5c689
convert to proto_tree_add_subtree[_format] for ASN.1 dissectors
...
Change-Id: I753ca95e2e1b38bad2c09955317e648c525e40ef
Reviewed-on: https://code.wireshark.org/review/2509
Tested-by: Michael Mann <mmann78@netscape.net>
Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-06-22 21:08:21 +00:00
Evan Huus
15a0a63156
batch of manual tvb_length conversions
...
Change-Id: Ifea45514bdba8be5f62b9dc560027077297f631e
Reviewed-on: https://code.wireshark.org/review/2456
Reviewed-by: Evan Huus <eapache@gmail.com>
2014-06-19 19:56:32 +00:00
Michael Mann
14824e6adf
Revert "Fixup: tvb_* -> tvb_captured"
...
https://www.wireshark.org/lists/wireshark-dev/201406/msg00131.html
This reverts commit 246fe2ca4c
.
Change-Id: Ib24bae0198c13a84bd7f731bf4af921212109a8f
Reviewed-on: https://code.wireshark.org/review/2430
Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-06-19 18:25:59 +00:00
Dario Lombardo
246fe2ca4c
Fixup: tvb_* -> tvb_captured
...
Change-Id: I9209c1271967405c34c1b6fa43e1726a4d3a5a3f
Reviewed-on: https://code.wireshark.org/review/2377
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-06-18 14:14:58 +00:00
Jeff Morriss
8c608e6e82
Remove $Id$ from the ASN.1 dissectors and regenerate them.
...
Change-Id: Ie476c6f82f318188b41ed922b92c6fec119ea954
Reviewed-on: https://code.wireshark.org/review/244
Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
Tested-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
2014-02-18 03:05:28 +00:00
Anders Broman
e6d09c1634
Make local functions static. Include *.h when needed.
...
svn path=/trunk/; revision=54201
2013-12-17 22:07:32 +00:00
Pascal Quantin
ea45be32c5
Add a way to retrieve a PER variable bit string length
...
svn path=/trunk/; revision=53382
2013-11-17 13:31:32 +00:00
Michael Mann
60e3e52a53
Have asn1_ctx_t passed into the "h245.gef.name" and "h245.gef.content" subdissectors instead of using pinfo->private_data.
...
svn path=/trunk/; revision=53055
2013-11-03 02:45:22 +00:00
Michael Mann
02a8391535
Require dissector_try_string to pass a data parameter to its subdissectors. There weren't that many calls, so might as well modify the function than create a need for dissector_try_string_new.
...
svn path=/trunk/; revision=53049
2013-11-02 15:52:25 +00:00
Pascal Quantin
f06d7caaa5
Regenerate H.225 dissector
...
svn path=/trunk/; revision=52720
2013-10-20 18:26:08 +00:00
Tomas Kukosa
744f47107e
H.225.0: fix handling of compound parameters in Generic Extensible Framework (H.460.22 did not work well)
...
svn path=/trunk/; revision=52659
2013-10-17 11:24:43 +00:00
Pascal Quantin
7d6899b96b
Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9155 :
...
Ensure that codec_str string is always initialized
svn path=/trunk/; revision=52107
2013-09-16 21:26:03 +00:00
Evan Huus
8b0f1addd9
Apparently one of our major global headers must include emem.h, because I just
...
found a bunch more asn1 dissectors using emem without ever directly including
the header. Convert those to wmem as well, which involves add a number of
#include directives since dissectors do *not* automatically pull in the wmem
headers.
svn path=/trunk/; revision=50066
2013-06-19 23:08:58 +00:00
Pascal Quantin
0ee4d0a00a
Postfix FT_NONE fields with "_element" string to reduce number of incompatible filters in ASN.1 dissectors
...
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2402
svn path=/trunk/; revision=49599
2013-05-27 20:26:49 +00:00
Pascal Quantin
a37c044203
Update the ASN.1 based dissectors following the changes done in r48812
...
svn path=/trunk/; revision=48820
2013-04-11 18:14:53 +00:00
Anders Broman
7c56677cf9
From beroset:
...
remove C++ incompatibilities
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416
svn path=/trunk/; revision=48429
2013-03-19 21:22:31 +00:00
Bill Meier
96a24cc79f
Fix spelling/typos found using a list of commonly misspelled words.
...
The misspellings were mostly in comments but some were
in text strings visible to the user.
svn path=/trunk/; revision=47899
2013-02-26 04:42:26 +00:00
Tomas Kukosa
d19cde439e
Fix H.460.x calling from H.225 - content decoding
...
svn path=/trunk/; revision=47253
2013-01-24 10:11:02 +00:00
Jeff Morriss
09221f45e4
When copying addresses, also copy the (new) hf field.
...
Use SET_ADDRESS in some dissectors that weren't using it (so that the hf field
is correctly initialized).
Introduce a COPY_ADDRESS_SHALLOW (which copies an address without copying the
contents of the data field).
svn path=/trunk/; revision=46602
2012-12-18 23:28:38 +00:00
Jakub Zawadzki
7a9d27c33f
Regenerate asn.1 dissectors.
...
svn path=/trunk/; revision=45110
2012-09-24 19:38:46 +00:00
Jeff Morriss
2552c750e5
We always HAVE_CONFIG_H so don't bother checking whether we have it or not.
...
svn path=/trunk/; revision=45017
2012-09-20 02:03:38 +00:00
Jakub Zawadzki
9d6e413be7
Regenerate all asn.1 dissectors.
...
svn path=/trunk/; revision=44861
2012-09-10 21:42:36 +00:00
Jakub Zawadzki
bf81b42e1e
Update Free Software Foundation address.
...
(COPYING will be updated in next commit)
svn path=/trunk/; revision=43536
2012-06-28 22:56:06 +00:00
Bill Meier
24cf0aad06
Update generated ASN1 *.[hc] files after recent work done by Jeff Morriss;
...
The only change in each file is in a comment showing the asn2wrs cmd used to build that file.
svn path=/trunk/; revision=39427
2011-10-15 19:27:27 +00:00
Chris Maynard
352cc7a410
Fix bug 5848, " https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5848 ", which was apparently introduced with r27287 ( http://anonsvn.wireshark.org/viewvc/trunk/epan/dissectors/packet-h225.c?r1=26698&r2=27287 ). Regenerate the packet-h225.c dissector. Patch from ericn1234@yahoo.com.
...
Reference: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5848
svn path=/trunk/; revision=38399
2011-08-07 20:50:31 +00:00
Stig Bjørlykke
a7c5d642d5
Regenerate ASN.1 dissectors to update the #line directive.
...
svn path=/trunk/; revision=37118
2011-05-13 08:12:27 +00:00
Guy Harris
a8bc4a0d13
Rename the routines that handle dissector tables with unsigned integer
...
keys to have _uint in their names, to match the routines that handle
dissector tables with string keys. (Using _port can confuse people into
thinking they're intended solely for use with TCP/UDP/etc. ports when,
in fact, they work better for things such as Ethernet types, where the
binding of particular values to particular protocols are a lot
stronger.)
svn path=/trunk/; revision=35224
2010-12-20 05:35:29 +00:00
Bill Meier
b78ec52693
Use value_string_ext fcns to access certain value_string arrays;
...
Sort certain value_string arrays so the values are in ascending order;
Use val_to_str_ext() instead of for loops to do value_string array lookups (voip_calls.c).
Minor whitespace cleanup.
svn path=/trunk/; revision=34794
2010-11-05 22:44:03 +00:00
Jeff Morriss
81da8e0b6b
Use find_or_create_conversation() in some ASN.1 dissectors
...
svn path=/trunk/; revision=32791
2010-05-13 18:55:31 +00:00
Jeff Morriss
a0c858efcd
Add a little more code to avoid not-very-useful blurbs:
...
- Change spaces in the name to underscores before comparing it to the blurb.
- Check if the type simply as T_ prepended to the name.
- Don't put in a blurb of "NULL".
and regenerate the dissectors.
svn path=/trunk/; revision=32748
2010-05-11 03:53:31 +00:00
Jeff Morriss
8f210cf4e0
Regenerate a few of the ASN.1 dissectors
...
svn path=/trunk/; revision=32742
2010-05-11 02:13:26 +00:00
Tomas Kukosa
05d418eba8
H.225.0 updated to version 7 (2009-12)
...
svn path=/trunk/; revision=32672
2010-05-05 13:14:41 +00:00
Bill Meier
f8b92f8d0b
#include <stdio.h> not needed.
...
svn path=/trunk/; revision=32405
2010-04-06 17:01:14 +00:00
Bill Meier
97d3a8bb10
Remove two unused global variables (one of which was causing a gcc -Wshadow warning).
...
svn path=/trunk/; revision=31690
2010-01-26 23:43:48 +00:00
Anders Broman
ba8d7bd919
Get rid of check_col();
...
svn path=/trunk/; revision=31544
2010-01-17 12:19:02 +00:00
Anders Broman
04d526a914
check_col.diff
...
Remove redundant calls to check_col() in the template files and regenerate.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4394
svn path=/trunk/; revision=31521
2010-01-13 21:27:44 +00:00
Anders Broman
440c3f9261
From Didier Gautheron:
...
check_col.diff
Remove redundant calls to check_col() if it guards only one columns function with one parameter after the column type.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4394
svn path=/trunk/; revision=31519
2010-01-13 20:32:01 +00:00
Guy Harris
8e236e55de
For fields of type FT_ABSOLUTE_TIME, have the "display" value be one of
...
ABSOLUTE_TIME_LOCAL or ABSOLUTE_TIME_UTC, indicating whether to display
the date/time in local time or UTC. (int)ABSOLUTE_TIME_LOCAL ==
(int)BASE_NONE, so there's no source or binary compatiblity issue,
although we might want to eliminate BASE_NONE at some point and have the
BASE_ values used with integral types start at 0, so that you can't
specify BASE_NONE for an integral field.
svn path=/trunk/; revision=31319
2009-12-19 03:17:44 +00:00
Anders Broman
98c852386d
Handle lenght restriction extension of restricted strings.
...
Fixes
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4251
svn path=/trunk/; revision=31047
2009-11-22 17:00:45 +00:00
Kovarththanan Rajaratnam
9490d1b74c
Regenerate asn1 dissectors (no change, only some line offset changes)
...
svn path=/trunk/; revision=30454
2009-10-09 21:34:49 +00:00
Kovarththanan Rajaratnam
65c53fedb6
Don't guard col_append_str with check_col
...
svn path=/trunk/; revision=30125
2009-09-24 20:00:21 +00:00
Kovarththanan Rajaratnam
17c9803cac
Sanitize epan includes
...
svn path=/trunk/; revision=29499
2009-08-21 20:25:24 +00:00
Kovarththanan Rajaratnam
ac463d2697
Don't guard col_clear with col_check
...
svn path=/trunk/; revision=29346
2009-08-09 08:14:59 +00:00
Gerald Combs
931a750908
Add a couple of pointer checks.
...
svn path=/trunk/; revision=29301
2009-08-05 00:36:27 +00:00
Stig Bjørlykke
9733aadcfe
Re-generate asn1 dissectors after hf_register_info cleanup.
...
svn path=/trunk/; revision=28848
2009-06-26 03:59:01 +00:00
Stig Bjørlykke
b228488bc0
From Kovarththanan Rajaratnam via bug 3548:
...
(1) Trailing/leading spaces are removed from 'name's/'blurb's
(2) Duplicate 'blurb's are replaced with NULL
(3) Empty ("") 'blurb's are replaced with NULL
(4) BASE_NONE, NULL, 0x0 are used for 'display', 'strings' and 'bitmask' fields
for FT_NONE, FT_BYTES, FT_IPv4, FT_IPv6, FT_ABSOLUTE_TIME, FT_RELATIVE_TIME,
FT_PROTOCOL, FT_STRING and FT_STRINGZ field types
(5) Only allow non-zero value for 'display' if 'bitmask' is non-zero
svn path=/trunk/; revision=28770
2009-06-18 21:30:42 +00:00
Stig Bjørlykke
c47e788c94
Regenerate all asn2wrs generated dissectors.
...
svn path=/trunk/; revision=28379
2009-05-16 22:07:03 +00:00
Anders Broman
99bbe55222
Make it possible to check for extension marker in SEQUENCE OF and SET OF.
...
Fore some reason the trace in bug https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3360 does not decode properly
if dissecting the exension marker so leave that code #if 0:ed out for now.
svn path=/trunk/; revision=27848
2009-03-25 22:04:23 +00:00