Commit Graph

43900 Commits

Author SHA1 Message Date
Pascal Quantin e52313959b Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8036 :
Check length of Slow Protocol OAM Vendor Specific Event Notification and add an expert info if it is not at least 2 bytes long

svn path=/trunk/; revision=46336
2012-12-02 22:19:37 +00:00
Pascal Quantin 8b5aa91371 Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8037 :
Fix an infinite loop in CSN.1 dissector when having more than 255 padding bits

svn path=/trunk/; revision=46335
2012-12-02 21:37:34 +00:00
Pascal Quantin 51323635aa From Ojab via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8035 :
Wrong packet bytes are selected for ISUP CUG binary code

svn path=/trunk/; revision=46334
2012-12-02 20:49:19 +00:00
Evan Huus 93a15fa28a Actually destroy the pool in epan_dissect_cleanup. There are many cases
where the edt is on the stack, in which case epan_dissect_free never gets
called and we were leaking the pool (although not any of the memory in it).

svn path=/trunk/; revision=46333
2012-12-02 18:16:21 +00:00
Evan Huus d4261b289f Document the new pinfo pool, add a TODO list.
svn path=/trunk/; revision=46332
2012-12-02 17:16:09 +00:00
Evan Huus b9c6f71fe4 Create a wmem pool in pinfo and use it for some address allocations.
A (better?) fix for https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8030

See also thread starting at:
http://www.wireshark.org/lists/wireshark-dev/201212/msg00001.html

svn path=/trunk/; revision=46331
2012-12-02 17:01:04 +00:00
Evan Huus 2461373edd Remove unneeded variable initializers.
svn path=/trunk/; revision=46328
2012-12-02 15:21:53 +00:00
Gerald Combs 0ff0068c48 [Automatic manuf, services and enterprise-numbers update for 2012-12-02]
svn path=/trunk/; revision=46327
2012-12-02 15:03:27 +00:00
Jeff Morriss a41c5abab1 Add SET_ADDRESS and SET_ADDRESS_HF to the list of APIs we (may--if we uncomment the code) check for being called with tvb_get_ptr().
svn path=/trunk/; revision=46326
2012-12-02 05:05:04 +00:00
Jeff Morriss e429065d4e Replace ip_to_str(tvb_get_ptr(...)) with tvb_ip_to_str(...).
svn path=/trunk/; revision=46325
2012-12-02 05:02:11 +00:00
Jeff Morriss 49466f95bc Introduce, and start using, TVB_SET_ADDRESS() and TVB_SET_ADDRESS_HF(). They
are like the non-TVB versions except that they take a TVB and an offset
instead of (frequently) a pointer into the TVB.

Calling tvb_get_ptr() before modifying the rest of the fields should help fix
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7960 (though I can't
reproduce that problem).


Replace a bunch of calls like:

SET_ADDRESS(..., AT_XXX, length, tvb_get_ptr(tvb, offset, length));

with:

TVB_SET_ADDRESS(..., AT_XXX, tvb, offset, length);

svn path=/trunk/; revision=46324
2012-12-02 04:49:13 +00:00
Jeff Morriss da4442d638 Use g_error() to generate an explanatory message (and a core) when
ABORT_ON_DISSECTOR_BUG is set and we pass MAX_TREE_ITEMS.

If ABORT_ON_DISSECTOR_BUG is set and we get an unregistered hf, generate
an explanatory message (and a core).

svn path=/trunk/; revision=46323
2012-12-02 03:34:06 +00:00
Jeff Morriss 2403ef591d Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8033 :
Register hf_btavdtp_number_of_signal_packets.

Remove (unused) hf_btavdtp_header_compression_rfa.

svn path=/trunk/; revision=46322
2012-12-02 03:25:38 +00:00
Jeff Morriss b5d14d6dcd Add an option to control whether tshark builds the tree (\"-T\").
Note the change in behavior: building the tree is now off by default.

Complain (and exit) if we get an argument we don't understand.

svn path=/trunk/; revision=46321
2012-12-02 02:58:29 +00:00
Jeff Morriss a92bbbcd5c Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8030 :
Don't store an AT_STRINGZ address in ep_ allocated memory: that memory is
freed before the addresses may be used.  Use se_ memory instead (no, that's
not really ideal either).

It would appear that several other dissectors have the same problem.

svn path=/trunk/; revision=46320
2012-12-02 02:46:12 +00:00
Evan Huus e2c9d02ba8 Fix typo
svn path=/trunk/; revision=46317
2012-12-01 20:51:20 +00:00
Evan Huus d730f8d348 Add -r option to valgrind script for --show-reachable=yes.
svn path=/trunk/; revision=46316
2012-12-01 20:49:27 +00:00
Evan Huus 7d1a8f8355 Fix potential copy-and-pasto in free_frame_data_sequence that may or may not
be the cause of https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8022

svn path=/trunk/; revision=46315
2012-12-01 18:19:08 +00:00
Evan Huus 400cb55a10 Remove unneeded include.
svn path=/trunk/; revision=46314
2012-12-01 17:48:01 +00:00
Evan Huus b14c53a2a9 Fix some checkAPI warnings and remove some unnecessary variable
initializations.

Also add an $Id$ tag which I somehow missed despite adding the actual
SVN property.

svn path=/trunk/; revision=46313
2012-12-01 17:44:51 +00:00
Evan Huus 2b70657769 Svn properties for the new file.
svn path=/trunk/; revision=46312
2012-12-01 15:42:53 +00:00
Evan Huus 99d5535cb1 From Krishnamurthy Mayya and Nikitha Malgi via
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8019

Dissection support for PW-OAM messages (RFC 6478).

svn path=/trunk/; revision=46311
2012-12-01 15:39:14 +00:00
Gerald Combs 430d616e28 Do a better job of getting the user's attention for temporary messages.
Rename some variables.

svn path=/trunk/; revision=46310
2012-11-30 23:14:53 +00:00
Jeff Morriss 3a0a1d49ea Fix an unitialized-read detected by Valgrind while processing:
https://www.wireshark.org/download/automated/captures/fuzz-2012-11-30-20336.pcap

(I can't reproduce the actual fuzz failure and this uninitialized-read
shouldn't have caused an out-of-memory condition--which is what the buildbot
said the problem with that capture was.)

Also stop marking a variable that is used as unused.

svn path=/trunk/; revision=46309
2012-11-30 20:25:21 +00:00
Jeff Morriss 62857dd6b4 Add addr_resolution_dlg.c
svn path=/trunk/; revision=46308
2012-11-30 16:17:00 +00:00
Anders Broman 5efb100bc4 Add a menu to view the current address resolution.
Future enhancments(?) to save as new hosts file.

svn path=/trunk/; revision=46307
2012-11-30 14:57:50 +00:00
Anders Broman 962aaf121f From Michal Labedzki:
PATCH] USB: Add support for vendor_id/product_id,
 bus_id/device_address and class/subclass/protocol tables

USB subdissectors can be decoded by class/subclass/protocol. If fail try vendor_id/product_id.
bus_id/device_address is intented to use by DecodeBy, so user can decode specified device as need.

Part of:
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5032

svn path=/trunk/; revision=46306
2012-11-30 12:33:37 +00:00
Anders Broman 1a79540fdc From Michal Labedzki:
Bluetooth: Add support for HCI USB transport dissector

Based on Bluetooth Core 4.0 specification

Part of:
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5032

svn path=/trunk/; revision=46305
2012-11-30 11:58:37 +00:00
Anders Broman d67f89f45b From Michal Labedzki:
Couple of coding style changes and fixes for:
warning: declaration of ‘k_frame_number’ shadows a previous local
warning: assignment discards qualifiers from pointer target type

Part of:
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5032

svn path=/trunk/; revision=46304
2012-11-30 11:31:28 +00:00
Stig Bjørlykke 37c7d006ad Added check for missing/empty ProtoField abbrev also in
integer, boolean, time and other cases.

svn path=/trunk/; revision=46302
2012-11-30 11:01:01 +00:00
Anders Broman 79d8f9f5f9 From Mike Morrin:
The gsm rlcmac dissector truncates the 12 bit BSNs to 8 bits when storing them.

Fix this and the handling of BSN2 is refactored to clarify the difference between BSN2 (the stored value) and BSN2_offset (the value transferred at the air interface).

svn path=/trunk/; revision=46301
2012-11-30 09:42:58 +00:00
Pascal Quantin 91576e1f70 Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8023 :
Fix typo in LPPa protocol name

svn path=/trunk/; revision=46300
2012-11-30 08:34:50 +00:00
Gerald Combs a0eb2268a7 select_ifaces and select_current_ifaces haven't been used since r40715.
Presumably it's OK to remove them.

svn path=/trunk/; revision=46299
2012-11-29 22:58:16 +00:00
Martin Mathieson 5e90582d54 Add versions of a function that doesn't need do substitute specifiers.
svn path=/trunk/; revision=46298
2012-11-29 22:25:18 +00:00
Jeff Morriss b39a7b487a Make tap_param.enum_vals const.
svn path=/trunk/; revision=46297
2012-11-29 22:21:23 +00:00
Jeff Morriss 366fe213a2 Add a checkapi target.
svn path=/trunk/; revision=46296
2012-11-29 21:44:38 +00:00
Jeff Morriss 987b122d58 Make an enum_val_t const.
svn path=/trunk/; revision=46295
2012-11-29 21:40:26 +00:00
Jeff Morriss 5ee917aea7 As requested by Anders on -dev: check enum_val_t's for NULL termination.
Also check that they are all const.

svn path=/trunk/; revision=46294
2012-11-29 20:25:15 +00:00
Jeff Morriss 04c9d29799 Make an enum_val_t static.
svn path=/trunk/; revision=46293
2012-11-29 20:21:30 +00:00
Jeff Morriss 0266cceef3 Make all enum_val_t's const.
svn path=/trunk/; revision=46292
2012-11-29 20:15:37 +00:00
Gerald Combs c33b0ad215 Add version info to the top of the SSL debug log.
svn path=/trunk/; revision=46291
2012-11-29 19:20:29 +00:00
Michael Tüxen 749e52d996 The padding of the last parameter is not included in the length of the chunk
as described in RFC 4960, section 3.2.

svn path=/trunk/; revision=46290
2012-11-29 18:09:51 +00:00
Pascal Quantin 6f3c7f1f99 Add missing newline at end of file
svn path=/trunk/; revision=46289
2012-11-29 16:46:41 +00:00
Jeff Morriss 5063663377 Another couple size_t-to-int warning fixes (I hope).
svn path=/trunk/; revision=46288
2012-11-29 16:26:12 +00:00
Bill Meier 0a94d24771 Fix several [-Wshadow] warnings.
svn path=/trunk/; revision=46287
2012-11-29 16:22:54 +00:00
Jeff Morriss 79d3e696a8 (Try to) fix some size_t-to-int warnings.
svn path=/trunk/; revision=46286
2012-11-29 15:39:34 +00:00
Jeff Morriss 10b145c8b5 usb.c is in the dissectors directory.
svn path=/trunk/; revision=46285
2012-11-29 15:34:25 +00:00
Pascal Quantin 0594b41113 Add missing newline at end of file
svn path=/trunk/; revision=46284
2012-11-29 14:57:06 +00:00
Anders Broman 21abe5567c From Michal Labedzki:
USB: Add support for vendor_id/product_id,
 bus_id/device_address and class/subclass/protocol
 tables

USB subdissectors can be decoded by class/subclass/protocol. If fail try vendor_id/product_id.
bus_id/device_address is intented to use by DecodeBy, so user can decode specified device as need.

Part of:
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5032

svn path=/trunk/; revision=46283
2012-11-29 13:59:36 +00:00
Jeff Morriss 910097ffb6 Remove the second definition of a variable. Define an undefined variable.
svn path=/trunk/; revision=46282
2012-11-29 13:54:07 +00:00