Commit Graph

266 Commits

Author SHA1 Message Date
Guy Harris f3944baaf0 Thou shalt terminate thy value_string arrays with {0, NULL}.
svn path=/trunk/; revision=29279
2009-08-03 21:07:08 +00:00
Jaap Keuter e0336d1243 From Ivan Sy:
Support for Host Identity Protocol (HIP) Domain Name System (DNS) Extension.

svn path=/trunk/; revision=29277
2009-08-03 18:23:04 +00:00
Gerald Combs dd28a00a78 From Ivan Sy via bug 3797:
Support for SPF RR (RFC 4408)

- this has the same format as TXT RR (see section 3.1.1) below.
Currently wireshark 1.2.1 shows this as Unknown type 99

svn path=/trunk/; revision=29253
2009-07-31 16:37:53 +00:00
Jaap Keuter 08b2e76773 From Ivan Sy:
Add support for SSHFP RR (RFC 4255).

svn path=/trunk/; revision=29252
2009-07-31 07:05:43 +00:00
Jaap Keuter 0553926fcc From Ivan Sy:
NAPTR RR (RFC 3403) replacement MUST be a fully qualified domain-name.

svn path=/trunk/; revision=29250
2009-07-31 06:51:27 +00:00
Jaap Keuter cde25ec6a2 From Ivan Sy:
Support for DLV RR (RFC 4431) and SHA-256 Digest for DS RR (RFC 4509).

svn path=/trunk/; revision=29226
2009-07-29 07:10:02 +00:00
Stig Bjørlykke 0437f102c3 From Kovarththanan Rajaratnam:
More FT_XXX cleanup.

svn path=/trunk/; revision=28971
2009-07-07 09:02:59 +00:00
Stig Bjørlykke b228488bc0 From Kovarththanan Rajaratnam via bug 3548:
(1) Trailing/leading spaces are removed from 'name's/'blurb's
(2) Duplicate 'blurb's are replaced with NULL
(3) Empty ("") 'blurb's are replaced with NULL
(4) BASE_NONE, NULL, 0x0 are used for 'display', 'strings' and 'bitmask' fields
    for FT_NONE, FT_BYTES, FT_IPv4, FT_IPv6, FT_ABSOLUTE_TIME, FT_RELATIVE_TIME,
    FT_PROTOCOL, FT_STRING and FT_STRINGZ field types
(5) Only allow non-zero value for 'display' if 'bitmask' is non-zero

svn path=/trunk/; revision=28770
2009-06-18 21:30:42 +00:00
Bill Meier 871c9c7152 ep_strbuf usage: ep_strbuf_new_label("") --> ep_strbuf_new_label(NULL);
ep_strbuf_append() --> ep_strbuf_append_c() in a few cases.

svn path=/trunk/; revision=28052
2009-04-14 18:31:02 +00:00
Gerald Combs 772e18dc89 Fixup whitespace.
svn path=/trunk/; revision=27900
2009-03-30 19:39:01 +00:00
Gerald Combs 92ade75cd0 Replace another string pointer dance with a string buffer.
svn path=/trunk/; revision=27895
2009-03-30 17:24:50 +00:00
Stig Bjørlykke c11055cda9 Fixed some data types to remove some warnings in the solaris build.
svn path=/trunk/; revision=27825
2009-03-23 12:41:56 +00:00
Stig Bjørlykke 29f106a07d Added support for LLMNR.
svn path=/trunk/; revision=27425
2009-02-11 13:25:00 +00:00
Bill Meier c544c20956 Fix various typos and spelling errors (mostly in text strings)
svn path=/trunk/; revision=27050
2008-12-18 19:08:49 +00:00
Jaap Keuter bb61056728 From Richard Brodie:
DNSSEC RFC 5155 support patch

svn path=/trunk/; revision=27048
2008-12-18 19:01:08 +00:00
Stig Bjørlykke d0e33bc3c5 Fix some "format not a string literal and no format arguments" warnings.
svn path=/trunk/; revision=26646
2008-10-31 14:07:23 +00:00
Jaap Keuter 8bea3dd9c1 From Derek Morr:
The DNS dissector conflates KEY (used for TSIG) and DNSKEY records. Also, the
DNSKEY dissector doesn't parse the REVOKED flag, defined in RFC 5011.

The attached patch splits KEY and DNSKEY parsing, and adds support for REVOKED.

svn path=/trunk/; revision=26298
2008-09-29 21:40:53 +00:00
Stig Bjørlykke cb51efd25d From Roy Marples (bug 2781 and bug 2796):
Display FQDN binary encoded name as text
Ensure that get_dns_name does not cross packet sub boundry

From me:
Preserve the usage of bootp.fqdn.name as a display filter

svn path=/trunk/; revision=25981
2008-08-11 12:00:27 +00:00
Bill Meier f8e3822738 Fix some warnings reported by gcc -Wshadow ...
Fix some spacing in packet-dcom.c

svn path=/trunk/; revision=25618
2008-06-27 16:15:30 +00:00
Stig Bjørlykke 28ae535b00 Removed even more "statement not reached" warnings.
svn path=/trunk/; revision=24286
2008-02-07 15:44:45 +00:00
Ronnie Sahlberg 83dc65536f dns request/response tracking did not work if tree==NULL we didnt set up
the tracking structures

this makes dns request/response trackign work when you dont have any 
color filters


svn path=/trunk/; revision=22163
2007-06-22 13:23:50 +00:00
Guy Harris 1bc049906a Add some GCC warnings to the standard set, and add some others to the
--enable-extra-gcc-checks set.

If we turn on -pedantic, try turning on -Wno-long-long as well, so that
it's not *so* pedantic that it rejects the 64-bit integral data types
that we explicitly require.

Constify a bunch of stuff, and make some other changes, to get rid of
warnings.

Clean up some indentation.

svn path=/trunk/; revision=21526
2007-04-23 10:59:26 +00:00
Stephen Fisher 8fd3ee0560 Remove almost all of the casts I committed recently and in place of
them, add -Wno-pointer-sign to CFLAGS when gcc will accept it.


svn path=/trunk/; revision=21253
2007-03-28 21:55:11 +00:00
Stephen Fisher ab8f589336 Fix about 100 simple to fix warnings from gcc 4.0 in epan/dissectors
svn path=/trunk/; revision=21233
2007-03-27 22:50:11 +00:00
Jaap Keuter f824a895a4 From Paul Erkkila:
parse NAPTR records in dns dissector (rfc 3403)

svn path=/trunk/; revision=20250
2006-12-31 00:00:06 +00:00
Jörg Mayer dd26a7021b nikai@nikai.net:
Remaining fixes from:
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1225

svn path=/trunk/; revision=19895
2006-11-14 20:32:29 +00:00
Guy Harris a54a816f92 Mark Krochmal says that the class field should be treated in mDNS as a
flag and a 15-bit field even for OPT RRs.

svn path=/trunk/; revision=19882
2006-11-12 23:42:08 +00:00
Guy Harris 43cd0ad045 Flag the question as a "QM" question if the QU flag isn't set.
svn path=/trunk/; revision=19881
2006-11-12 22:35:21 +00:00
Guy Harris 63cd996fa5 mDNS treats the class field as a flag bit and 15 bits of class; display
it as such.

svn path=/trunk/; revision=19879
2006-11-12 22:12:39 +00:00
Ronnie Sahlberg 2d1bb39121 change the signature for the get_pdu_len() function pointer passed to tcp_dissect_pdus() to also include a packet_info pointer.
there are many reasons why some protocols actually need to be able to access the pinfo structure while determining the pdu size



svn path=/trunk/; revision=19751
2006-10-31 09:29:07 +00:00
Ronnie Sahlberg 8fe329094f testdrive the request/response README and implement request/response matching for DNS
svn path=/trunk/; revision=19003
2006-08-23 09:48:16 +00:00
Ronnie Sahlberg feab79e328 change a whole bunch of ethereal into wireshark
svn path=/trunk/; revision=18196
2006-05-21 04:49:01 +00:00
Ronnie Sahlberg f331077a60 waste a couple of bytes per tcp conversation and make the tree for acked_packets (i.e. packets that have interesting tcp properties such as being retransmissions etc) hang off the per conversation tcpd struct instead of being global.
while this should improve performance by unmeasurably little it does have the sideeffect that once we finish the rewrite   tcp analysis might actually work and work well even for tcp over tcp tunnelling. 

this also means that if you include packet-tcp.h   you also need to include emem.h .




svn path=/trunk/; revision=17681
2006-03-20 10:52:53 +00:00
Jaap Keuter 335a8e2831 Fix for bug 724: DNS dissector fails in handling the sign of Altitude in LOC type response (RFC1867)
svn path=/trunk/; revision=17358
2006-02-21 08:14:11 +00:00
Jörg Mayer a052b3a98b packet-bgp.c: Fix incorrect use of g_snprintf return value
mp_addr_to_str was unnecessary 'complex' - simplified it
packet-dns.c: Fix incorrect use of g_snprintf return value
packet-dcm.c: Fix incorrect use of g_snprintf return value
        Someone who understands the protocol should look at the
        "vr, tr might be used uninitialized..." warning.
packet-x11.c: Fix incorrect use of g_snprintf return value
packet-kerberos.c: Fix incorrect use of g_snprintf return value
        Someone should take a look at the
        "longjump might clobber ..." messages
packet-diameter.c: Fix incorrect use of g_snprintf return value
        Get rid of unsigned < 0 check
packet-pgm.c: Fix incorrect use of g_snprintf return value
packet-nbns.c: Fix incorrect use of g_snprintf return value
packet-winsrepl.c: Collateral damage to packet-nbns.c fix
packet-netbios.c: Collateral damage to packet-nbns.c fix
packet-netbios.h: Collateral damage to packet-nbns.c fix
packet-kerberos.c: Collateral damage to packet-nbns.c fix
packet-nbipx.c: Collateral damage to packet-nbns.c fix


svn path=/trunk/; revision=17065
2006-01-20 21:18:18 +00:00
Ronnie Sahlberg 6ea1842885 remove some proto_tree_add_text and replace with proto_tree_add_item() for the TSIG dissection in dns.
create a new dissector table where MAC algorithms for dns/tsig can be registered.


register gssapi for the algorithm "gss.microsoft.com" since this is what w2k uses when performing dns updates.



svn path=/trunk/; revision=16895
2005-12-25 12:03:18 +00:00
Ronnie Sahlberg b5ecbaf8d5 remove one array from the stack
get rid of strcpy and strcat


svn path=/trunk/; revision=16235
2005-10-16 00:27:50 +00:00
Ronnie Sahlberg bc655dfba3 improve get_dns_name now that we have cheap emem allocated buffers
and get rid of a few strcpy()
a whole lot of arrays from the stack
and make the function prototype slightly nicer.



svn path=/trunk/; revision=16166
2005-10-08 12:31:06 +00:00
Guy Harris 39fd819fb4 Don't collide with the "regular" IPv6 defintions in at least some
platforms in ipv6-utils.h.

svn path=/trunk/; revision=15764
2005-09-12 06:21:35 +00:00
Guy Harris 25c4bc9379 Replace tvb_memcpy() calls that extract IPv4 addresses into a guint32,
and that extract IPv6 addresses into a "struct e_in6_addr", with
tvb_get_ipv4() and tvb_get_ipv6() calls - except for some that we
remove, by using proto_tree_add_item(), rather than replacing.

Have epan/tvbuff.h include epan/ipv6-utils.h, to define "struct
e_in6_addr" (not necessary to declare the tvbuff routines, but including
it there means "struct e_in6_addr" is guaranteed to be defined before
those declarations, so we don't get compiler complaints if we define it
*after* those declarations).

svn path=/trunk/; revision=15758
2005-09-11 21:25:37 +00:00
Ronnie Sahlberg 3921146575 replace some g_string_sprintf() with g_snprintf()
remove one static 1kb char array and make it emem ep allocated


svn path=/trunk/; revision=15620
2005-08-30 09:05:44 +00:00
Ulf Lamping 994496a184 several times replacing:
sprintf -> g_snprintf
snprintf -> g_snprintf
vsnprintf -> g_vsnprintf
strdup -> g_strdup

svn path=/trunk/; revision=15412
2005-08-18 19:31:15 +00:00
Ulf Lamping 495eb1b788 snprintf -> g_snprintf
svn path=/trunk/; revision=15398
2005-08-17 23:10:28 +00:00
Ulf Lamping 0dc9fb3d4a various code cleanup:
-use g_snprintf instead of sprintf and snprintf
-use g_strdup_printf where appropriate
-remove #include "snprintf.h" (as only g_snprintf should be used)
-replace some more alloc/realloc/calloc/free with their glib pendants

svn path=/trunk/; revision=15264
2005-08-08 18:50:39 +00:00
Jörg Mayer 5602f5bb83 Make some funtions static. More char -> const char warning fixes
svn path=/trunk/; revision=15146
2005-07-30 01:01:02 +00:00
Guy Harris 81466a539e The name returned by "get_dns_name()" (and thus by
"get_dns_name_type_class()") is null-terminated - and the length
returned is *NOT* the length of the string, it's the length of the chunk
of DNS data extracted by "get_dns_name()", and that chunk could just
point to a later chunk as part of DNS compression.  When running the
name through "format_text()", just use "strlen()" to get the length, so
you don't get a value that's too large *OR* too small (both are
possible - "too large" if it's uncompressed and includes length
informatioin, "too small" if it contains a pointer to a string longer
than the pointer).

When adding a string value to the protocol tree, add the *raw* name, not
the formatted name - the Ethereal display code will format the string's
value as necessary.

Add formatting code for DNS names in replies.

svn path=/trunk/; revision=14793
2005-06-27 07:50:11 +00:00
Guy Harris ab797734dd Get rid of the private "my_match_strval()" routine in many dissectors;
add a "match_strval_idx()" routine that does the same thing, and have
"match_strval()" call it.

Make those routines, and "val_to_str()", return a "const" pointer. 
Update dissectors as necessary to squelch compiler warnings produced by
that.

Use "val_to_str()" rather than using "match_strval()" and then, if the
result is null, substituting a specific string.  Clean up some other
"match_strval()"/"val_to_str()" usages.

Add a null pointer check in the NDPS dissector's "attribute_value()"
routine, as it's not clear that "global_attribute_name" won't be null at
that point.

Make some global variables in the AFS4INT dissector local.

Make some routines not used outside the module they're in static.

Make some tables "static const".

Clean up white space.

Fix Gerald's address in some files.

svn path=/trunk/; revision=14786
2005-06-26 19:56:52 +00:00
Ulf Lamping fdb5b1af02 just to get things straight: a dissector should *never* do any g_assert() calls!
in a simple approach, I've replaced all g_assert() and g_assert_not_reached() calls by their exception throwing counterparts DISSECTOR_ASSERT() and DISSECTOR_ASSERT_NOT_REACHED()

this will replace application crash by showing a dissector bug, which is the desired behaviour

there were some g_assert calls in the protocol registering functions, which might not be acting as expected now, but to be able to simply search for g_assert in the future I've replaced that calls too

one g_assert remained, the one when someone throws an unknown exception "into" packet_frame.c, but IMHO this one should remain.

svn path=/trunk/; revision=14608
2005-06-10 18:28:22 +00:00
Ulf Lamping b59c893573 fix #201 second part: adapt the string length of the unformatted text, so it won't show \000 and beyond
svn path=/trunk/; revision=14550
2005-06-04 11:47:38 +00:00
Ulf Lamping c173da9fec fix #201: add format_text before output of the DNS name, in case it contains invalid chars
svn path=/trunk/; revision=14479
2005-05-29 13:02:57 +00:00
Gerald Combs 4acd84cd85 From Nicolas Dichtel via Vincent Jardin:
Print a couple of missing fields.

svn path=/trunk/; revision=13379
2005-02-10 16:24:12 +00:00
Guy Harris e93d213c7a OPT RRs don't have a class field.
svn path=/trunk/; revision=13016
2005-01-13 07:51:08 +00:00
Guy Harris 4d38774957 Unlike the detailed description of resource record types, the
detailed description of classes is pretty much redundant - remove it.

svn path=/trunk/; revision=12925
2005-01-02 09:40:26 +00:00
Guy Harris ce604cf8f0 From Luis Ontanon: add more filterable fields to DNS, PGM, GTP, and RADIUS.
svn path=/trunk/; revision=12835
2004-12-26 00:22:16 +00:00
Guy Harris 4437245d30 From David Fort: the DNS RR type number for IPSECKEY will be changing to
45, so update the dissector.

svn path=/trunk/; revision=12655
2004-12-02 08:28:10 +00:00
Guy Harris dabae881cd From Yaniv Kaul: increment the offset pointer *after* you use it to put
into the protocol tree the field you're incrementing past.

Update a comment.

svn path=/trunk/; revision=12576
2004-11-22 08:23:00 +00:00
Guy Harris acc3b28324 From Yaniv Kaul: yet *another* place where an NTLMSSP rather than GSSAPI
blob can appear.

svn path=/trunk/; revision=12563
2004-11-21 21:23:30 +00:00
Guy Harris 745937933a Add IPv6 address<->name mappings for AAAA records.
svn path=/trunk/; revision=12538
2004-11-17 10:03:14 +00:00
Guy Harris 366ff47474 Rename some routines and structures to reflect that they're specific to
IPv4; use different data structures for port numbers.

svn path=/trunk/; revision=12536
2004-11-17 08:53:20 +00:00
Guy Harris 8c53b99707 For dynamic DNS updates, give the counts in the message the appropriate
names.

For RRs with a data length of 0 - as can appear in dynamic DNS updates -
don't attempt to display the data.

svn path=/trunk/; revision=12511
2004-11-12 09:46:31 +00:00
Guy Harris eaadcc4c62 Move various tables into the epan directory.
svn path=/trunk/; revision=12130
2004-09-29 00:52:45 +00:00
Guy Harris 0591bac4d2 From David Fort: ipseckey DNS RR support.
svn path=/trunk/; revision=12120
2004-09-28 10:28:01 +00:00
Guy Harris bbe7f89742 Move prefs.c and prefs.h into the epan subdirectory.
svn path=/trunk/; revision=12115
2004-09-27 22:55:15 +00:00
Ulf Lamping d530bd4e14 Prevent the word "desegmentation" at the GUI, but use reassembling at that places, as we also use "defragmentation" and "reassembling". Use reassembling as the general term for such actions.
I (hopefully) didn't changed any protocol fields or preference file names, but only the GUI labels appearing in the protocol display and the protocol preferences.

Also added a note to the protocol preferences (where appropriate), that you have to enable "Allow subdissectors to reassemble TCP streams" at the corresponding protocol settings for TCP reassembling to take effect.

If you encounter any mistakes I've made here, please let me know...

svn path=/trunk/; revision=11784
2004-08-21 09:02:52 +00:00
Guy Harris 3a583aeb59 From Albert Chin: rename resolv.{ch} to addr_resolv.{ch}, so that an
include of <resolv.h> in any system header file gets the system
<resolv.h> (needed for builds on Tru64 with GTK+ 1.2[.x]).

svn path=/trunk/; revision=11615
2004-08-06 19:57:49 +00:00
Gilbert Ramirez 669db206cb Move dissectors to epan/dissectors directory.
Also move ncp222.py, x11-fields, process-x11-fields.pl,
make-reg-dotc, and make-reg-dotc.py.

Adjust #include lines in files that include packet-*.h
files.

svn path=/trunk/; revision=11410
2004-07-18 18:06:47 +00:00