ca01b3a876
Add x509if_frame_end() which is passed to register_frame_end_routine()
...
and which resets our global variables. Remove a boolean which was used
to track a char *; just check if the pointer is NULL instead. Fixes bugs
5754 and 5793, hopefully without breaking anything.
svn path=/trunk/; revision=36608
2011-04-12 20:39:48 +00:00
ef5823c210
Put back in one of the includes removed in r36606: ctype.h for isdigit()
...
function.
svn path=/trunk/; revision=36607
2011-04-12 20:29:42 +00:00
c85689f108
Don't assign to a proto_item * if the value won't be used: Coverity 1034;
...
Comment out two calls to tvb_)get_ephemeral_string since the result is never used: Coverity 1035;
Also:
Remove some unneeded #includes;
Use consistent indentation.
svn path=/trunk/; revision=36606
2011-04-12 20:19:10 +00:00
1bb94ef56d
Added a FALLTHRU comment to avoid a missing break warning.
...
Coverity 437.
svn path=/trunk/; revision=36605
2011-04-12 20:03:21 +00:00
706a2fd0a4
Don't assign to a variable if the value won't be used: Coverity 1002 & 1003.
...
svn path=/trunk/; revision=36604
2011-04-12 19:59:26 +00:00
fa5a06231c
Fix two instances of apparent use of incorrect tree: Coverity 982 & 983;
...
Remove an uneeded line of code: Coverity 984;
#include <string.h> not needed;
Use consistent indentation & do other whitespace cleanup.
svn path=/trunk/; revision=36603
2011-04-12 19:41:26 +00:00
b862371815
Removed some unused variables.
...
svn path=/trunk/; revision=36602
2011-04-12 19:06:51 +00:00
7b43d9c705
Use g_snprintf instead of sprintf: (Part of) Covertiy 665.
...
svn path=/trunk/; revision=36600
2011-04-12 18:29:52 +00:00
ee36a5cfbe
Use g_strlcat instead of strcat: Coverity 632.
...
svn path=/trunk/; revision=36598
2011-04-12 18:16:55 +00:00
bbea8c7cf7
Don't assign to a proto_item * if the value won't be used: Coverity 978;
...
Use what appears to be the intended correct tree for various proto_add...: Coverity 979;
Minor indentation cleanup.
svn path=/trunk/; revision=36594
2011-04-12 17:44:22 +00:00
a90aff50bb
Comment out some (currently ?) unused code: Coverity 969-971;
...
Fix up whitespace & indentation (e.g., "4 space tabs").
svn path=/trunk/; revision=36592
2011-04-12 16:48:58 +00:00
fe8caf9040
Don't assign to a proto_item * if the value won't be used: Coverity 954 & 955;
...
Remove some unneeded #includes;
Minor whitespace cleanup.
svn path=/trunk/; revision=36589
2011-04-12 16:12:03 +00:00
e9618c5548
Don't assign to a proto_item * if the value won't be used: Coverity 933;
...
Fix apparent use of incorrect tree: Coverity 934.
svn path=/trunk/; revision=36588
2011-04-12 16:00:28 +00:00
81672fe2f4
Don't assign to a proto_item * if the value won't be used: Coverity 916-918;
...
Also: use consistent indentation.
svn path=/trunk/; revision=36587
2011-04-12 15:49:29 +00:00
fc600d4bf9
Fix a few cases of proto_item_add_subtree() using the wrong tree: Coverity 916-918;
...
Also: Fix some indentation: e.g., "4 space tabs".
svn path=/trunk/; revision=36585
2011-04-12 15:39:19 +00:00
42f41ddf0b
Corrected switch-case flow.
...
Coverity 1184.
svn path=/trunk/; revision=36579
2011-04-12 09:05:43 +00:00
793d683575
Regenerate the ANSI MAP, LDAP, and TETRA dissectors so that Coverity can
...
locate their template files.
svn path=/trunk/; revision=36569
2011-04-11 23:07:53 +00:00
e7a23fb4fe
Don't assign to a proto_item* that is not used before being overwritten.
...
Coverity 1017.
svn path=/trunk/; revision=36566
2011-04-11 21:40:49 +00:00
deac0b8af4
Show Segment offset number in AM header root item.
...
svn path=/trunk/; revision=36565
2011-04-11 21:34:47 +00:00
a8f1a17b68
- for UL/DL HARQ, show number of ms since previous tx
...
- for SR state-machine problems, show UEId in report
- incomplete beginnings of support for grouping/counting UEs per TTI
svn path=/trunk/; revision=36564
2011-04-11 21:33:33 +00:00
26e4e13c06
Neither checksum_item nor length are used uninitialized, but for some reason,
...
the OSX buildbots think they can be. Initialize them to avoid a build failure.
svn path=/trunk/; revision=36562
2011-04-11 18:40:36 +00:00
5abfa49525
Add conversation tracking and tshark tap support to ICMPv6. Fixes bug 5810.
...
TODO: Add a Wireshark tap or look into possibly using the stats tree instead.
Also, like ICMP, the ICMPv6 payload appears to carry the sender's timestamp, so
it might be possible to make use of this information to estimate the total SRT.
(See bug 5770 for more details.)
svn path=/trunk/; revision=36561
2011-04-11 17:42:01 +00:00
d181b588b7
CID 898: Remove a not really used variable
...
svn path=/trunk/; revision=36560
2011-04-11 17:25:41 +00:00
a6691d79c6
Fix coverity CID 855: remove an unused variable
...
svn path=/trunk/; revision=36559
2011-04-11 17:21:15 +00:00
0e95d4dbf5
Don't assign to a proto_item * if the value won't be used: Coverity 1036;
...
Fix what appears to be a use of an incorrect tree: Coverity 1037;
Also:
- Remove uneeded #includes & re-order #includes;
- Do indentation and whitespace cleanup (e.g., "4 space tabs").
svn path=/trunk/; revision=36558
2011-04-11 15:17:22 +00:00
8d8043e4f6
Don't assign to a proto_item * if the value won't be used: Coverity 912 & 913.
...
svn path=/trunk/; revision=36557
2011-04-11 14:45:54 +00:00
5f57b0d828
Don't assign to a variable if the value won't be used: Coverity 964 & 965;
...
Also:
- Move proto_register...() & proto_reg_handoff...() to the end of the file;
- Remove some unneeded #includes;
- Do some indentation and whitespace cleanup (e.g., "4-space tabs").
svn path=/trunk/; revision=36556
2011-04-11 14:41:14 +00:00
ea8b282a75
Don't assign to a proto_item * if the value won't be used: Coverity 928-932;
...
Also: remove some unneeded #includes.
svn path=/trunk/; revision=36555
2011-04-11 14:28:18 +00:00
a460d35272
Add proto_field_is_referenced. Fixes bug 5816.
...
svn path=/trunk/; revision=36554
2011-04-11 13:44:31 +00:00
50bad80299
Use g_strlcpy() instead of prohibited strncpy() to guarantee NULL-termination.
...
svn path=/trunk/; revision=36553
2011-04-11 13:38:32 +00:00
4fdcc5c180
Rename ws_stat to ws_stat64, and make it take a pointer to a ws_statb64
...
as an argument, along the lines of ws_fstat64, and, on Windows, make it
use _wstati64, to handle 64-bit file sizes.
svn path=/trunk/; revision=36547
2011-04-10 20:59:10 +00:00
332e0263ed
strcpy -> strncpy.
...
Coverity 669.
svn path=/trunk/; revision=36543
2011-04-10 18:29:56 +00:00
d7d45f8072
1.5.1 → 1.5.2. Reenable Babel.
...
svn path=/trunk/; revision=36540
2011-04-10 17:03:43 +00:00
8b8082442d
Build 1.5.1. Temporarily disable the Babel dissector.
...
svn path=/trunk/; revision=36537
2011-04-10 16:42:10 +00:00
aa5349924a
Minor whitespace fix.
...
svn path=/trunk/; revision=36536
2011-04-10 16:40:29 +00:00
0ed0777d86
[Automatic manuf, services and enterprise-numbers update for 2011-04-10]
...
svn path=/trunk/; revision=36534
2011-04-10 15:03:48 +00:00
163e55f306
prefs_register_protocol() not needed since no prefs; Coverity #1185 (UNUSED_VALUE).
...
Also: #include <stdio.h> not needed.
svn path=/trunk/; revision=36533
2011-04-10 15:01:18 +00:00
8f2ce2f308
Do some whitespace cleanup.
...
svn path=/trunk/; revision=36531
2011-04-09 17:18:52 +00:00
e69a4c6e45
Don't assign to a proto_item * if the value won't be used: Coverity 911;
...
Fix bug wherein an item was apparently added to the wrong subtree: Coverity 910;
Remove unneeded #includes;
Do whitespace and indentation cleanup.
svn path=/trunk/; revision=36530
2011-04-09 17:17:47 +00:00
cca5904550
Don't assign to a proto_item * if the value won't be used: Coverity 923-927;
...
Add braces around around certain code sections for indentation purposes;
Do some indentation & whitespace cleanup.
svn path=/trunk/; revision=36529
2011-04-09 17:11:13 +00:00
2674aeb1ff
Don't assign to a proto_item * if the value won't be used: Coverity 891 & 892;
...
Also: #include <stdlib.h> & <string.h> not req'd; fix some indentation.
svn path=/trunk/; revision=36528
2011-04-09 13:44:00 +00:00
c8d2cd3cb5
In packet_list_dissect_and_cache_record(), set the columns to
...
*something* if we get an error reading the packet from the capture file,
rather than leaving them as null (which will cause a crash).
svn path=/trunk/; revision=36527
2011-04-09 04:33:26 +00:00
a5ddd187ca
Fix Coverity CID 557.
...
svn path=/trunk/; revision=36526
2011-04-08 21:21:32 +00:00
1667de16c5
Don't assign to a proto_item * if the value won't be used: Coverity 990;
...
Add some missing code: improves display of "main_opcode" field: Coverity 991, 993 & 994;
Fix bug introduced a while back: "changeinfo4" field details aren't displayed: Coverity 992;
Add missing code so READDIR (V4) details are shown in a subtree (as presumably was originally intended);
Fix some indentation.
svn path=/trunk/; revision=36525
2011-04-08 20:06:56 +00:00
fbe119c3c5
Enhance Vendor Specific Atheros IE
...
* Replace proto_tree_add_ether/boolean by proto_tree_add_item
* use BASE_CUSTOM for XR beacon interval
* use ENC_* macro for encoding
* replace if(...) by switch(...) for type and subtype (more extensible if new (sub)type)
* add expert info when tag_len is incorrect
Fix also a minor issue with tag_end...
svn path=/trunk/; revision=36523
2011-04-08 19:52:04 +00:00
a5b20fbdf6
Add a relative path to the "#line" directives we produce. Regenerate the
...
SNMP and SPNEGO dissectors to see if it helps Coverity locate the
original source files.
svn path=/trunk/; revision=36522
2011-04-08 19:51:39 +00:00
da3f7673db
From Pascal Quantin:
...
Upgrade LTE RRC ASN.1 description to V9.6.0
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5815
svn path=/trunk/; revision=36520
2011-04-08 17:36:53 +00:00
374558c830
From Juliusz Chroboczek via bug #5812 : Dissector for the Babel Routing
...
Protocol (RFC 6126)
svn path=/trunk/; revision=36518
2011-04-08 16:53:02 +00:00
f5c1fc47af
Use tvb_get_ephemeral_string()
...
prefix hf vars with hf_sip
svn path=/trunk/; revision=36516
2011-04-08 11:58:33 +00:00
f989235a87
Use a unique variable name. Fixes Coverity CID 593.
...
svn path=/trunk/; revision=36512
2011-04-07 23:52:37 +00:00
Gerald Combs