Commit graph

48254 commits

Author SHA1 Message Date
Jeff Morriss
2bbe93006f As suggested in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9011 :
Rename packet-cmd.c to packet-cisco-metadata.c .

Assign copyright to the author.

Also add the dissector to cmake (oops, should have been in r51198!).

svn path=/trunk/; revision=51226
2013-08-08 18:56:42 +00:00
Jeff Morriss
77ff8f6d59 Remove a couple of set-but-no-longer-used variables.
svn path=/trunk/; revision=51225
2013-08-08 18:03:29 +00:00
Jeff Morriss
45d2989e8b From Francesco Fondelli via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9024 :
In dissect_rsvp_lsp_attributes() there is a check for invalid Attributes 
TLV length that is no more correct in light of changes described in 
Section 14 of RFC 5420.  This patch fixes that.

svn path=/trunk/; revision=51224
2013-08-08 17:53:11 +00:00
Michael Mann
30e199e2a1 Use convert_proto_tree_add_text.pl to make many more fields filterable.
Someone may want to check that the display filter naming scheme is consistent, I at least tried to make it consistent with the new filters created.
May want to also add subtrees for the bit flags that used to be grouped in a single proto_tree_add_text.

svn path=/trunk/; revision=51223
2013-08-08 17:25:03 +00:00
Martin Mathieson
b882f54f1d Apply same changes to common stats to tshark tap
svn path=/trunk/; revision=51222
2013-08-08 16:56:41 +00:00
Gerald Combs
c00caf8eab Remove catalog.xml. As a comment from Bill Meier in 2010 notes, we don't
seem to use it (and if your Docbook environment isn't set up correctly
the problem should probably be fixed elsewhere).

svn path=/trunk/; revision=51221
2013-08-08 16:41:10 +00:00
Gerald Combs
42ede93b8e Switch from Docbook 4.2 to 4.5. Our documentation builder only has the
4.4 and 4.5 DTDs installed and a quick check using a popular network
protocol analyzer showed that xsltproc was fetching the 4.2 DTDs from
the network instead of the local filesystem.

svn path=/trunk/; revision=51220
2013-08-08 15:58:35 +00:00
Martin Mathieson
aabda8b275 Improve stats of broadcast messages
svn path=/trunk/; revision=51219
2013-08-08 14:45:45 +00:00
Evan Huus
c5319ebc93 One more chunk header alignment fix.
svn path=/trunk/; revision=51218
2013-08-08 12:23:23 +00:00
Evan Huus
0ebe18dcea Make sure our chunk headers are large enough to correctly align the actual data
pointer we return.

svn path=/trunk/; revision=51217
2013-08-08 11:27:39 +00:00
Evan Huus
d8684cf32d When splitting a free chunk, if we don't have room for a free header don't even
bother splitting. This greatly simplifies the logic, trims another 4% off the
fast path, and doesn't actually affect the results at all because of the way we
pad for alignment anyways.

svn path=/trunk/; revision=51216
2013-08-08 11:16:10 +00:00
Stig Bjørlykke
cf6288e21f Added default ignore targets for new asn1 dissectors.
Removed cnf data from atn-cpdlc.asn to make it generate.

svn path=/trunk/; revision=51215
2013-08-08 11:15:45 +00:00
Evan Huus
2d2271f12b Correctly check bounds on dim_max.
Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9019

svn path=/trunk/; revision=51213
2013-08-08 10:50:11 +00:00
Anders Broman
77f4bef154 From Mathias Guettler:
New dissector for Air/Ground Datalink ICAO doc 9705 Ed2: ULCS, CM, CPDLC.

Add the files to the distribution.

svn path=/trunk/; revision=51212
2013-08-08 05:34:22 +00:00
Guy Harris
1219287df3 Rename variables to reflect their use and to avoid a shadowing warning.
Fix some indentation while we're at it.

svn path=/trunk/; revision=51211
2013-08-08 05:14:33 +00:00
Anders Broman
a4d1560fd1 From Mathias Guettler:
New dissector for Air/Ground Datalink ICAO doc 9705 Ed2: ULCS, CM, CPDLC.

Just adding the files to SVN for now.

svn path=/trunk/; revision=51210
2013-08-08 05:09:13 +00:00
Guy Harris
6e0c354769 Clarify what the special cases in wtap_wtap_encap_to_pcap_encap() are
doing.

svn path=/trunk/; revision=51209
2013-08-08 04:57:38 +00:00
Anders Broman
08d223eb71 When dissecting IMSI handle the zero length tvb case, fixes "Malformed Packet: CAMEL (empty IMSI tag)"
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9015

svn path=/trunk/; revision=51208
2013-08-08 04:36:54 +00:00
Anders Broman
fd4a111149 Don't call eth_addr_resolve() unconditionally.
svn path=/trunk/; revision=51207
2013-08-08 04:32:19 +00:00
Anders Broman
812ad4f3bf From Tommy Wu:
-          Show major and Minor version.
-          Correct SPI Name.

svn path=/trunk/; revision=51206
2013-08-08 04:31:07 +00:00
Anders Broman
a46f373c54 Add an application Id.
svn path=/trunk/; revision=51205
2013-08-08 04:30:16 +00:00
Guy Harris
ea72be8607 Speak of the "-d encap:" value as a linktype, rather than a DLT; if a
name is specified, it currently must be a DLT_ name rather than a
LINKTYPE_ name, as we use libpcap to do the mapping and it currently has
no API to map LINKTYPE_ names to values, but if a number is specified,
it could either be a LINKTYPE_ name or a DLT_ name if the two are
different, and we want to encourage the use of LINKTYPE_ values.

Note that in comments.

svn path=/trunk/; revision=51204
2013-08-08 04:29:08 +00:00
Guy Harris
3734d4e2b3 Point to the tcpdump.org link-layer header types page.
svn path=/trunk/; revision=51203
2013-08-08 04:18:20 +00:00
Guy Harris
81865326d0 Rename "dlt_value" to "linktype_value", and give more details in
comments about LINKTYPE_ values vs. DLT_ values.

svn path=/trunk/; revision=51202
2013-08-08 04:16:53 +00:00
Gerald Combs
62c083fe8e Compile on Qt < 5.0.
svn path=/trunk/; revision=51201
2013-08-08 00:46:19 +00:00
Gerald Combs
79454ef9fa Add initial capture filter support.
Add CaptureFilterCombo and CaptureFilterEdit classes, similar to their
display filter counterparts. Add a CaptureFilterSyntaxWorker class which
runs a syntax check in a background thread similar to the threaded code
in capture_dlg.c. Add a bunch of related signal and slot plumbing. Other
minor fixups.

svn path=/trunk/; revision=51200
2013-08-08 00:26:57 +00:00
Jeff Morriss
786adc8522 From Francesco Fondelli via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8954 :
This patch adds XRO (Exclude Routes) support to RSVP dissector.  It
also extends coverage of some new Attribute Flags (LSP_ATTRIBUTES object).

svn path=/trunk/; revision=51199
2013-08-07 23:07:15 +00:00
Jeff Morriss
a018f63bca From Vaibhav Katkade via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9011 :
Add support for the Cisco MetaData (0x8909) ethertype.

From me:

Don't try to register the "eth.type" abbreviation; use "cmd.type" instead.
Add SVN id.
Clean up trailing white space and fix up some indentation.
Don't declare a variable static that need not be.

svn path=/trunk/; revision=51198
2013-08-07 22:52:43 +00:00
Jeff Morriss
c44883cb1a From Роман Донченко via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9018 :
This patch enables Wireshark to correctly decode messages specific to the
selected key exchange method by determining and remembering that method.
It's a little incomplete in that it doesn't support the case where
first_kex_packet_follows is true, but then the current implementation
doesn't either.

It also adds/fixes dissection for the plain Diffie-Hellman key exchange and
DH group exchange messages that were broken/missing, completing support for
both of these key exchange methods.

svn path=/trunk/; revision=51197
2013-08-07 22:20:49 +00:00
Martin Kaiser
07ee14d5c1 fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9020
make sure that the loop counter is always incremented

svn path=/trunk/; revision=51196
2013-08-07 21:17:53 +00:00
Martin Kaiser
2f072ac53c add a range check for dch_id
this should fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9005

svn path=/trunk/; revision=51195
2013-08-07 20:18:11 +00:00
Gerald Combs
6fea3ab734 Make sure we copy our support files to DESTDIR.
svn path=/trunk/; revision=51194
2013-08-07 18:30:21 +00:00
Pascal Quantin
a2452d6926 Fix dissection of FemtoInterfaceMsg media type when it includes a mandatory LV or V IE
svn path=/trunk/; revision=51193
2013-08-07 17:34:49 +00:00
Jeff Morriss
2c81a97d55 Ensure we have both _initialize() and a corresponding _cleanup() routines for
the various name resolvers; put those two routines next to each other.

Add generic addr_resolv_init() and addr_resolv_cleanup() routines which call
all of those internal routines.

Call the generic init/cleanup routine from epan_init() and epan_cleanup().

Create the hash tables for each name resolver in those initialization routines
in order to avoid having to repeatedly check if the table is already created
or not (and to avoid glib warnings if we neglected to perform that check):

http://www.wireshark.org/lists/wireshark-dev/201308/msg00012.html


Don't clean up   hostnames in init_dissection():    it's done already in cleanup_dissection().
Don't initialize hostnames in cleanup_dissection(): it's done already in init_dissection().

svn path=/trunk/; revision=51191
2013-08-07 16:46:08 +00:00
Gerald Combs
2dab57f425 Switch to make-services.py. Fix some variable names and version tests.
svn path=/trunk/; revision=51189
2013-08-07 16:33:39 +00:00
Jeff Morriss
56d05bfd4b It's not necessary to call epan_free() in cf_open(): cf_close() (which is
called by cf_open()) already calls epan_free().

svn path=/trunk/; revision=51188
2013-08-07 16:14:44 +00:00
Alexis La Goutte
c617a6a64b Enhance LISP Dissector (Mapping, Locator and Record type...)
Convert proto_tree_add_text calls to proto_tree_add_item

(the end of my original commit...)

svn path=/trunk/; revision=51187
2013-08-07 13:44:44 +00:00
Jeff Morriss
0995eb9edd Remove some set-but-no-longer-used variables.
svn path=/trunk/; revision=51186
2013-08-07 13:26:05 +00:00
Martin Mathieson
9b85c5b17f Try to fix build by removing proto_tree_add_text() call replaced by items
svn path=/trunk/; revision=51185
2013-08-07 12:56:39 +00:00
Alexis La Goutte
90e273cb91 Enhance BGP Update
Step 4 : Convert proto_tree_add_text calls to proto_tree_add_item and use new name of RFC4271 (  Withdrawn Routes Length ...)

svn path=/trunk/; revision=51184
2013-08-07 12:05:23 +00:00
Alexis La Goutte
b4beea213f Enhance LISP Dissector (Mapping, Locator and Record type...)
Convert proto_tree_add_text calls to proto_tree_add_item

svn path=/trunk/; revision=51183
2013-08-07 12:05:11 +00:00
Alexis La Goutte
8da9a76650 From Matt Texier
Enhance BGP Dissector

Step 3 :Variable consistency and renaming, adding RFC and draft as comments (Preperation for next enhance...)

From me :
Fix some typo/whitespace
Make checkhf happy...

Signed-off-by: Alexis La Goutte <alexis.lagoutte@gmail.com>

svn path=/trunk/; revision=51182
2013-08-07 12:04:04 +00:00
Stig Bjørlykke
aadc33fbab Do not use overlapping memory in g_snprintf.
Use consistent spacing between title and value.

svn path=/trunk/; revision=51181
2013-08-07 10:02:03 +00:00
Anders Broman
4317fade8c From Michael Mann:
the heuristics of NDMP require 28 bytes to be present in order for it to be dissected as NDMP.  NDMP is purely a heuristic dissector because TCPENCAP shares the same TCP port.
Since NDMP officially registered port 10000 with IANA, allow it to use dissector_add_uint() instead of packet-ipsec-tcp.c, and by default have TCPENCAP only rely on its heuristics.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5462

svn path=/trunk/; revision=51180
2013-08-07 04:39:32 +00:00
Anders Broman
907e735f60 From Javier Godoy:
Dissect SCSI OSD attribute identification sense data descriptor.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8971

svn path=/trunk/; revision=51179
2013-08-07 04:28:35 +00:00
Gerald Combs
79713e0ce7 Add a Python version of make-services.pl. Instead of trying to parse the
plain text version of the registry it parses the CSV version (which
should hopefully be more reliable). Tested with Pythons 2.5, 2.6, 2.7,
and 3.3.

Update the services file.

svn path=/trunk/; revision=51178
2013-08-06 23:45:51 +00:00
Jeff Morriss
a1c6c09f8f Get rid of a set-but-unused variable.
Replace tabs with spaces (for consistency).

svn path=/trunk/; revision=51177
2013-08-06 21:44:21 +00:00
Jakub Zawadzki
97bddef1a2 Try to fix compilation under MSVC
__builtin_ctz() with bitmask == 0 is UB, so only do g_assert there.

svn path=/trunk/; revision=51176
2013-08-06 21:06:56 +00:00
Jakub Zawadzki
9cfac1227d Replace hfinfo pointer to same_name_prev, with same_name_prev_id.
svn path=/trunk/; revision=51175
2013-08-06 20:53:47 +00:00
Jakub Zawadzki
72ea2f9c9c Remove hfinfo->bitshift member, add hfinfo_bitshift() to get it.
svn path=/trunk/; revision=51174
2013-08-06 20:10:59 +00:00