Gerald Combs
2efa26e0e1
Fix a double-free bug which was causing a crash. Our decryption buffer
...
length doesn't change, so allocate it just once. Add an expert item for
a successful decryption.
svn path=/trunk/; revision=31571
2010-01-19 19:28:30 +00:00
Guy Harris
982cfc5410
From Jakub Zawadzki: get rid of redundant BYTE_VIEW_WIDTH and
...
BIT_VIEW_WIDTH definitions in favor of BYTES_PER_LINE and BITS_PER_LINE.
While we're at it, move the definition of BYTE_VIEW_SEP down among the
other definitions.
svn path=/trunk/; revision=31570
2010-01-19 19:18:51 +00:00
Guy Harris
4b8554fa3c
From Jakub Zawadzki: fix the return type of hex_view_get_byte().
...
svn path=/trunk/; revision=31569
2010-01-19 19:12:55 +00:00
Guy Harris
92a3647ac4
Get rid of a dead link, use IETF links for what appear to be the last
...
I-Ds for PIMv1 (the next version of the dense-mode draft didn't run on
IGMP).
svn path=/trunk/; revision=31568
2010-01-19 18:53:41 +00:00
Gerald Combs
2799a0216f
Remove an unused variable. Fixup whitespace.
...
svn path=/trunk/; revision=31567
2010-01-19 17:40:52 +00:00
Anders Broman
3e1c4ca38a
Remove an include.
...
svn path=/trunk/; revision=31566
2010-01-19 17:21:19 +00:00
Anders Broman
2dfd8a1e8c
If user data is xml display it.
...
svn path=/trunk/; revision=31565
2010-01-19 17:20:17 +00:00
Stig Bjørlykke
174de72350
Moved expert info for bitstring size constraints below bit values.
...
Enabled bitstring minimum length size check.
svn path=/trunk/; revision=31564
2010-01-19 08:54:13 +00:00
Stig Bjørlykke
6ff81c8f6a
Change group for "Unknown bit(s)" expert info to Undecoded.
...
svn path=/trunk/; revision=31563
2010-01-19 08:11:23 +00:00
Guy Harris
4579732494
Even better - don't use a global variable in the first place, as its
...
value isn't used outside dissect_sss_request().
Get rid of some unused value_strings while we're at it; they duplicate
value_strings in packet-ncp-nmas.c, and if they're really needed here,
there should probably be only one instance, in, for example, the NCP
dissector.
Get rid of some unused variables, use -1 for "to the end of the tvbuff",
don't use "subverb" unless we've actually fetched its value.
svn path=/trunk/; revision=31562
2010-01-19 01:16:02 +00:00
Bill Meier
9b568ea691
Fix gcc -Wshadow warnings
...
svn path=/trunk/; revision=31561
2010-01-19 00:37:39 +00:00
Guy Harris
94b8c6433b
Rewrite the bit about null vs. non-null "tree" dissector arguments a
...
bit, so as not to imply that there's some form of global "mode"
Wireshark is in when it passes a null or non-null pointer (there isn't),
and to explicitly note that there is *no* guarantee about the value of
"tree" on the first call to the dissector. (I.e., please do not build a
mental model of how Wireshark works in that regard, and write your
dissector based on that mental model - you *will* be wrong.)
svn path=/trunk/; revision=31560
2010-01-18 23:21:13 +00:00
Bill Meier
c5614625ee
Fix some gcc -Wshadow warnings ....
...
svn path=/trunk/; revision=31559
2010-01-18 23:16:10 +00:00
Bill Meier
f1d4716d18
Fix gcc -Wshadow warnings ....
...
svn path=/trunk/; revision=31558
2010-01-18 21:50:50 +00:00
Bill Meier
de4c6ff515
Fix a number of gcc _Wshadow warnings
...
svn path=/trunk/; revision=31557
2010-01-18 21:49:47 +00:00
Bill Meier
55669f7127
Fix gcc -Wshadow warnings.
...
[And therefore fixing a benign bug where memory was allocated for sizeof(*p) rather than sizeof(p)].
svn path=/trunk/; revision=31556
2010-01-18 21:37:34 +00:00
Bill Meier
b3685a583a
Use true_false_strings from tfs.c when possible;
...
#include stdio, stdlib & string not req'd;
Fix a gcc -Wshadow warnng
svn path=/trunk/; revision=31555
2010-01-18 20:51:13 +00:00
Stig Bjørlykke
10466c4bbe
Add expert info to unknown bitstring bits when having a named_bits table.
...
svn path=/trunk/; revision=31554
2010-01-18 20:08:56 +00:00
Bill Meier
1c11b9571e
Use consistent indentation; Reformat a few hf[] array entries.
...
svn path=/trunk/; revision=31553
2010-01-18 18:00:23 +00:00
Anders Broman
9a030dda05
Get rid of check_col();
...
svn path=/trunk/; revision=31552
2010-01-17 18:16:06 +00:00
Gerald Combs
fd5ca381c5
[Automatic manuf and enterprise-numbers update for 2010-01-17]
...
svn path=/trunk/; revision=31549
2010-01-17 16:03:29 +00:00
Stig Bjørlykke
1b9b0af135
Added packet-hp-erm.c.
...
svn path=/trunk/; revision=31548
2010-01-17 14:20:53 +00:00
Bill Meier
05eae470b9
Dissector for HP encapsulated remote mirroring.
...
svn path=/trunk/; revision=31547
2010-01-17 14:07:03 +00:00
Anders Broman
a255c08b66
Get rid of check_col();
...
svn path=/trunk/; revision=31546
2010-01-17 12:46:00 +00:00
Anders Broman
d0ced3ccef
Fix a comment.
...
svn path=/trunk/; revision=31545
2010-01-17 12:19:31 +00:00
Anders Broman
ba8d7bd919
Get rid of check_col();
...
svn path=/trunk/; revision=31544
2010-01-17 12:19:02 +00:00
Anders Broman
0d3840e704
Update to version 9.1.0
...
svn path=/trunk/; revision=31543
2010-01-17 09:43:31 +00:00
Stephen Fisher
5531c24c67
Update URL in comments.
...
svn path=/trunk/; revision=31542
2010-01-16 03:34:07 +00:00
Guy Harris
268345f515
Use G_GSIZE_MODIFIER rather than casting to "gulong" and printing with
...
"%lu".
svn path=/trunk/; revision=31541
2010-01-16 02:57:42 +00:00
Guy Harris
969b98fa35
tvb_get_ntohl() doesn't return a long on any platform (it returns a
...
guint32, and on no platform supported by GLib, and thus on no platform
supported by Wireshark, does a guint32 have to be an unsigned long), so
there's no need to cast it to long and print it with %lld.
svn path=/trunk/; revision=31540
2010-01-16 02:39:25 +00:00
Bill Meier
66650422de
For now: Add hack so \r ignored when win-setup.sh is invoked from a cygwin bash shell.
...
See: http://www.mail-archive.com/cygwin-announce@cygwin.com/msg01711.html
Note: another way to do this (as described in the above) might be to
"export the environment variable SHELLOPTS with igncr included in it.
It is read-only from within bash, but you can set it before invoking bash;
once in bash, it auto-tracks the current state of 'set -o igncr'
or 'shopt -s igncr'. If exported, then all bash child processes inherit
the same option settings".
svn path=/trunk/; revision=31538
2010-01-15 21:09:54 +00:00
Jeff Morriss
508fd83368
Show spare bits in decimal, not as booleans.
...
svn path=/trunk/; revision=31537
2010-01-15 19:28:28 +00:00
Stig Bjørlykke
5c4ee8a291
Change col_set_str() call to col_add_str() since the string being passed
...
can be a ep_alloc from val_to_str().
svn path=/trunk/; revision=31536
2010-01-15 14:05:06 +00:00
Stig Bjørlykke
9d918146ff
Changed val_to_str() to val_to_str_const() when used with col_set_str().
...
svn path=/trunk/; revision=31535
2010-01-15 13:51:47 +00:00
Stig Bjørlykke
8255893114
Change col_set_str() call to col_add_str() since the string being passed
...
can be a ep_alloc from val_to_str().
svn path=/trunk/; revision=31534
2010-01-15 13:40:14 +00:00
Anders Broman
4a38ad658c
Get rid of check_col();
...
svn path=/trunk/; revision=31533
2010-01-15 07:32:04 +00:00
Anders Broman
90bf722451
From Chris Costa:
...
tcp.analysis.acks_frame and tcp.analysis.ack_rtt is not reliable.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3311
svn path=/trunk/; revision=31532
2010-01-15 07:20:25 +00:00
Anders Broman
a230916b8e
From Didier Gautheron:
...
Don't use packet without data in sequence analysis.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2054
svn path=/trunk/; revision=31531
2010-01-15 07:07:28 +00:00
Anders Broman
ca43f3cb6a
From Didier Gautheron:
...
Wlan stat: sorting on broadcast is broken if MAC name resolution is disabled.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4398
svn path=/trunk/; revision=31530
2010-01-15 07:01:19 +00:00
Gerald Combs
97c480741d
If we're using threads, time out when reading the file header.
...
svn path=/trunk/; revision=31529
2010-01-14 22:45:12 +00:00
Gerald Combs
b5924db6b8
Set some properties.
...
svn path=/trunk/; revision=31528
2010-01-14 19:48:50 +00:00
Gerasimos Dimitriadis
a72447c0da
Avoid assertion failure when adding a column of type
...
IEEE 802.11 TX rate.
svn path=/trunk/; revision=31527
2010-01-14 18:30:57 +00:00
Gerasimos Dimitriadis
fe1e9d6296
Fix for Bug 3747:
...
use FT_FLOAT for the radiotap data rate because of .5 Mbps granularity
svn path=/trunk/; revision=31526
2010-01-14 18:21:09 +00:00
Stig Bjørlykke
229d8368bc
Set correct locale in make-version.pl instead of in Makefiles.
...
Added back add_custom_command for svnversion.h.
Removed unnecessary text2pcap_CLEAN_FILES.
Fix indent for ps.c command.
svn path=/trunk/; revision=31525
2010-01-14 15:43:33 +00:00
Gerald Combs
0e3ba74734
Fix several buffer overflows found by babi babi. Replace a lot of manual
...
fetching and displaying with proto_tree_add_item().
Use get_dns_name() instead of lwres_get_dns_name(), which fixes a separate
issue.
svn path=/trunk/; revision=31524
2010-01-14 01:22:00 +00:00
Anders Broman
69b7a06578
Remove redundant calls to check_col() in the .cnf files and regenerate.
...
svn path=/trunk/; revision=31523
2010-01-13 21:41:28 +00:00
Michael Tüxen
c273169cbd
Display correct chunk type for unknown chunks.
...
svn path=/trunk/; revision=31522
2010-01-13 21:31:24 +00:00
Anders Broman
04d526a914
check_col.diff
...
Remove redundant calls to check_col() in the template files and regenerate.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4394
svn path=/trunk/; revision=31521
2010-01-13 21:27:44 +00:00
Anders Broman
526891f1b4
From Didier Gautheron:
...
fix a memory leak by using se_strdup rather for g_strdup for column text.
replace col_clear() follow by col_add_str() with the faster col_set_str()
remove redundant check_col() call
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4394
svn path=/trunk/; revision=31520
2010-01-13 21:16:46 +00:00
Anders Broman
440c3f9261
From Didier Gautheron:
...
check_col.diff
Remove redundant calls to check_col() if it guards only one columns function with one parameter after the column type.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4394
svn path=/trunk/; revision=31519
2010-01-13 20:32:01 +00:00