Commit graph

7 commits

Author SHA1 Message Date
Bill Meier
bd4c0f0691 Reformat long lines...
svn path=/trunk/; revision=41384
2012-03-06 22:00:59 +00:00
Bill Meier
57599011da Fix incorrect packet-details display of certain 1 bit FT_BOOLEAN fields.
Also: reformat a few lines.

svn path=/trunk/; revision=41383
2012-03-06 21:12:43 +00:00
Jeff Morriss
5ca357f245 Don't use FT_BOOLEAN with value_strings: the code to generate
representations of former is expecting true_false_strings--which are quite
different than the latter.

svn path=/trunk/; revision=41363
2012-03-06 02:19:23 +00:00
Jeff Morriss
033ad2a5ee Don't use FT_*INT with true_false strings: the code to generate
representations of former is expecting value_strings--which are quite
different than the latter.

svn path=/trunk/; revision=41361
2012-03-06 01:55:21 +00:00
Alexis La Goutte
49d2d91818 Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
svn path=/trunk/; revision=41304
2012-03-02 11:04:51 +00:00
Jeff Morriss
bb9b8880af From Michael Mann via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6893 :
The attached patches fix the following issues:

1. CIP-Motion shouldn't be a heuristic dissector.  CIP-Motion packets are
determined by specific fields in a CIP ForwardOpen.  I ran into situations
where CIP-Motion's "vague" heuristics incorrectly dissected packets meant for
CIP-Safety.  Of course this requires the ForwardOpen to be in the trace, but it
is the most deterministic way to have CIP-Motion packets.

2. Minor bugfix to the CIP-Safety dissector.  A couple of fields were
"missing", causing errant malformed packets.

svn path=/trunk/; revision=41283
2012-03-02 03:39:16 +00:00
Anders Broman
6b2b82d213 From Michael Mann:
a dissector for the ODVA protocol: CIP Safety. More information
about the protocol can be found here: 

http://www.odva.org/Home/ODVATECHNOLOGIES/CIP/CIPTechnologyOverview/CIPSafety/CIPSafetyOverview/tabid/131/lng/en-US/Default.aspx

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6862

svn path=/trunk/; revision=41201
2012-02-27 09:30:26 +00:00