Guards the calledOnce boolean, against malformed traps, using register_frame_end_routine.
Fixes openSAFETY - Malformed packets disable the dissector for the WS session
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6950
svn path=/trunk/; revision=41674
I'm contributing a new dissector for the HART/IP protocol. This
protocol is specified by the HART Conformance Foundation (HCF). It is
a standard protocol used in the process control industry. It
essential wraps the multip-drop serial HART packets in TCP or UDP
packets. The standard has been approved by the HCF and has been
assigned UDP/TCP port 5094 by IANA.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6961
--This line, and those below,
will be ignored--
M AUTHORS
M epan/CMakeLists.txt
M epan/dissectors/Makefile.common
AM epan/dissectors/packet-hartip.c
M ui/gtk/main_menubar.c
svn path=/trunk/; revision=41644
Repeat r41359 in another location:
Don't try to display tone entries if there are none (but there is length for
them). Could/should be an expert_info.
Also fix a typo: Nomber->Number.
svn path=/trunk/; revision=41639
Don't use a proto_item as the tree in proto_tree_add_text(). (There's code
here to hang a subtree off the item but it's commented out.)
svn path=/trunk/; revision=41638
tidlist is registered as a FT_UINT16 so don't add an array of 16-bit entities
(tids) using it. Instead add each TID individually.
svn path=/trunk/; revision=41637
Conversation address generation during processing of endpoint descriptors
is not being done in a manner consistent with that of general USB
packet dissection. I am not aware of any observable manifestation of this
bug.
svn path=/trunk/; revision=41634
cover the entire MCS field, in the hopes of avoiding the need to ask
questions such as
http://ask.wireshark.org/questions/9461
svn path=/trunk/; revision=41633
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6949 :
Don't use a guint8 for() loop index when the end of the loop value is stored
in a guint: the loop index may never reach the end-of-loop value.
Also remove a shadow'd variable.
svn path=/trunk/; revision=41625
(Additional instances requiring feedback from the dissector author have
been marked with XXX).
For 'hf_om2k_aop' use a bitmask in the hf[] entry rather than shifting & etc
in the proto_tree_add_uint() call.
See https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6792 Comment #8.
svn path=/trunk/; revision=41612
Error: the name for field "Initial Resource Locator Length " ("eiss.aid.irl.length") has trailing space in packet-eiss.c
Error: the name for field "Initial Resource Locator String " ("eiss.aid.irl.string") has trailing space in packet-eiss.c
svn path=/trunk/; revision=41601
In some cases:
Use val_to_str_const() instead of val_to_str();
Reformat long lines;
Do some general whitespace changes.
svn path=/trunk/; revision=41587
FT_BOOLEAN hf[] entries with a 0 'bitmask' should have 'display' = BASE_NONE;
General whitespace & formatting changes.
svn path=/trunk/; revision=41579