The original code was causing a malformed packet exception if there was
one additional byte after the measurement pilot interval.
Bug: 15903
Change-Id: Ibe3e7fab5ea5c3d18ea4792ff342a0d8b8d2533b
Reviewed-on: https://code.wireshark.org/review/33858
Reviewed-by: Richard Sharpe <realrichardsharpe@gmail.com>
Petri-Dish: Richard Sharpe <realrichardsharpe@gmail.com>
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
error: variable ‘handle’ might be clobbered by ‘longjmp’ or ‘vfork’ [-Werror=clobbered]
Change-Id: Id53d02927cbb738acedc80b0f6556afb3322c787
Reviewed-on: https://code.wireshark.org/review/33846
Petri-Dish: Guy Harris <guy@alum.mit.edu>
Tested-by: Petri Dish Buildbot
Reviewed-by: Guy Harris <guy@alum.mit.edu>
RFC 6671 allocates a G-ACh channel type to MPLS-TP OAM, which basically
boils down to what is provided in the CFM dissector. Let the CFM
dissector therefore register for this channel type.
Bug: 15887
Change-Id: Ib23b046b3e8d79d4b3d51f10b83892333f593235
Reviewed-on: https://code.wireshark.org/review/33837
Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl>
Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
This change adds a basic dissector for the Network Controller Sideband
Interface (NCSI), as described by DMTF specification DSP0222.
Change-Id: I4e98361bfb7315c524f9c90db38507892adeeebe
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Reviewed-on: https://code.wireshark.org/review/33818
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
The commit 0c5b14395e fixed a leak
but introduced a regression since the username gets freed while it's
still needed. We need to make a copy here.
Change-Id: Id45c1b8f98c9649a0ead30ec6cacdd6c44b923bd
Reviewed-on: https://code.wireshark.org/review/33821
Petri-Dish: Dario Lombardo <lomato@gmail.com>
Reviewed-by: Pascal Quantin <pascal@wireshark.org>
Tested-by: Petri Dish Buildbot
index() was the old V7 UNIX's name for strchr(); some UN*Xes still
define it, causing compiler warnings. Our API checker also checks for
it; rename the variable to avoid compiler and API checker warnings.
Change-Id: I4994f8b466aada8720ed43455ec8f80ce570728e
Reviewed-on: https://code.wireshark.org/review/33826
Petri-Dish: Guy Harris <guy@alum.mit.edu>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
dissect new SMB3 negotiate contexts (only) for compression and
netname.
Change-Id: Idb9ec6aa008864d225107cdc6f319a2874b98ac3
Reviewed-on: https://code.wireshark.org/review/33822
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Add Maximum Fragment Length extention field with values from RFC 6066.
Change-Id: I927fc6b17b6319834f61800d25cd698b4657fd6b
Reviewed-on: https://code.wireshark.org/review/33823
Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org>
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
epan/dissectors/packet-smb2.c:
- factor out decryption code from transform header dissector
- rewrite CCM decryption to use the proper gcrypt cipher
- add GCM support
- change weird 1 element CCM bitmask to value_string
test/suite_decryption.py: add smb2 GCM decryption test
- add one test
- add a new capture to test smb3.1.1 AES-128-GCM decryption
Change-Id: Id5ab75e1830bc24ace9f9b2f2dbd5a3c20666d52
Reviewed-on: https://code.wireshark.org/review/33600
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
The imap.request/response is a more general field, containing tags.
It is moved first as we have more general fields followed by more
specific ones.
Change-Id: Ib8f7fbdd28f2d0ed2ed6d8d6b2de4d92ae24c6cc
Reviewed-on: https://code.wireshark.org/review/33755
Petri-Dish: Dario Lombardo <lomato@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
The NB-IoT DPR MAC CE is not included in the L field of the CCCH MAC CE.
Change-Id: I497176dfc722f0080e544bbc73845cfce2064e2d
Reviewed-on: https://code.wireshark.org/review/33805
Petri-Dish: Pascal Quantin <pascal@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal@wireshark.org>
Default QoS is not sent anymore.Topic Information feature expects
the Reliability, Durability and Ownership fields in the
discovery Data(w) packet, so it will never be shown in
Connext > 6.0.0. Since there is a link to the Data(w) packet,
there is no need to show Reliability, Durability and
Ownership.
Change-Id: Ie23395916e5dc6ea8e13e4de502f0eb811d63814
Reviewed-on: https://code.wireshark.org/review/33727
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Added a new function code for modifying an existing cyclic job.
Show the Job-ID in the info column.
Change-Id: I30a5ce0ba03171a947c59b039c9c879b82f3c026
Reviewed-on: https://code.wireshark.org/review/33781
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Two additional (previously reserved flags) in the mcast flags are now used
to inform other nodes that no IPv4/IPv6 multicast routers can be found in
its segment.
Change-Id: Idf066200cf6ccee581d5c3074b0500664460e806
Signed-off-by: Sven Eckelmann <sven@narfation.org>
Reviewed-on: https://code.wireshark.org/review/33768
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Type Object parameter can be sent compressed using zlib to
save bandwidth. This data can be decompressed and
dissected as an usual Type Object.
Change-Id: Id226b01daff225bb8e21aea765dcc5f7a0165bb7
Reviewed-on: https://code.wireshark.org/review/33738
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Bug: 15876
Add code to understand the version 3 "low noise" trailer.
Dissect fields added in the version 3 trailer.
Re-organize the "ingress" field from trailer version <= 2 to a flags field for
version >= 3. Mark the f5ethtrailer.ingress field as a gerenated field in
version 3 and higher so that users can still use it for filtering, but move the
"real" ingress to be part of the flags.
Change-Id: I946e91e6b482ee5bd4e6d5a9c2523613a607c609
Reviewed-on: https://code.wireshark.org/review/33743
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Do not cut off the last byte when passing the IMEI IE to the
bssap.imei dissector.
Change-Id: Id5cda256f5a641afcf72c677313b8d8681366ee8
Reviewed-on: https://code.wireshark.org/review/33742
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
This new tap collects credentials (username and paassword)
from the dissectors.
So far, few dissectors have been instrumented:
- http (basic auth)
- http (header auth)
- ftp
Others can be instrumented as well using the same technique.
Tshark has a new option (-z credentials) and Wireshark a new
"tools" menu: the documentation has been updated accordingly.
Change-Id: I2d0d96598c85bb3ea4fb5ec090dd8dc28b481fc9
Reviewed-on: https://code.wireshark.org/review/33453
Reviewed-by: Gerald Combs <gerald@wireshark.org>
Petri-Dish: Gerald Combs <gerald@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Dario Lombardo <lomato@gmail.com>
Previous buffer size was truncating 2048 and 4096 bits DH pre-master
secrets (PMS_CLIENT_RANDOM). New size allows to read DH pre-master
secrets up to 4096 bits.
Change-Id: Ib1bb8946f9c81b4b8e85f82ca7401b3cc9901a1f
Reviewed-on: https://code.wireshark.org/review/33722
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Anders Broman
Oliver Smith