Commit Graph

72 Commits

Author SHA1 Message Date
Martin Mathieson d8be0764d3 Set length of 'PDU Block Header' subtrees.
svn path=/trunk/; revision=33812
2010-08-16 15:14:01 +00:00
Martin Mathieson bbc98aa015 Fix a duplicate/copy-pasted filter field name.
svn path=/trunk/; revision=33782
2010-08-12 08:53:08 +00:00
Martin Mathieson b91b0515cc Update bit_offset whether calling MAC dissector or not.
svn path=/trunk/; revision=33711
2010-08-04 14:42:09 +00:00
Martin Mathieson 7b5d7d2e33 Add a preference to call MAC for TBs (on by default).
Improve info column display for HS-DSCH Capacity Request messages.
Removed calls to check_col().
Removed a few tabs.

svn path=/trunk/; revision=33698
2010-08-03 14:26:35 +00:00
Bill Meier 73eb16d678 Fix some gcc -Wshadow warnings
svn path=/trunk/; revision=31623
2010-01-22 17:41:47 +00:00
Anders Broman 4888a8de8a From Tobias Witek:
Add support for UMTS FP over UDP.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4218

svn path=/trunk/; revision=31113
2009-11-29 12:05:23 +00:00
Anders Broman 54aa776069 From Tobias Witek:
w protocols: UMTS RLC (ETSI TS 125 322), UMTS MAC (ETSI TS 125 321)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3495

svn path=/trunk/; revision=30838
2009-11-05 21:54:06 +00:00
Kovarththanan Rajaratnam 65c53fedb6 Don't guard col_append_str with check_col
svn path=/trunk/; revision=30125
2009-09-24 20:00:21 +00:00
Kovarththanan Rajaratnam e971354a54 Don't guard col_set_str (COL_PROTOCOL) with col_check
svn path=/trunk/; revision=29340
2009-08-09 06:26:46 +00:00
Stig Bjørlykke 0437f102c3 From Kovarththanan Rajaratnam:
More FT_XXX cleanup.

svn path=/trunk/; revision=28971
2009-07-07 09:02:59 +00:00
Stig Bjørlykke b228488bc0 From Kovarththanan Rajaratnam via bug 3548:
(1) Trailing/leading spaces are removed from 'name's/'blurb's
(2) Duplicate 'blurb's are replaced with NULL
(3) Empty ("") 'blurb's are replaced with NULL
(4) BASE_NONE, NULL, 0x0 are used for 'display', 'strings' and 'bitmask' fields
    for FT_NONE, FT_BYTES, FT_IPv4, FT_IPv6, FT_ABSOLUTE_TIME, FT_RELATIVE_TIME,
    FT_PROTOCOL, FT_STRING and FT_STRINGZ field types
(5) Only allow non-zero value for 'display' if 'bitmask' is non-zero

svn path=/trunk/; revision=28770
2009-06-18 21:30:42 +00:00
Bill Meier c0e92cbc04 Fix various typos and spelling errors (mostly in text strings)
svn path=/trunk/; revision=27065
2008-12-20 00:09:02 +00:00
Bill Meier 33c99f44fd Fix typos and spelling (mostly in text strings)
svn path=/trunk/; revision=27028
2008-12-17 00:08:38 +00:00
Martin Mathieson 627bc2411a Show enhanced high speed channels more clearly.
svn path=/trunk/; revision=25472
2008-06-18 16:06:12 +00:00
Martin Mathieson e5b6e5e8c2 Show correct seqno in info column.
svn path=/trunk/; revision=25446
2008-06-12 16:50:23 +00:00
Martin Mathieson d275348e20 Dissect BCH channels (expect control messages only).
svn path=/trunk/; revision=25445
2008-06-12 16:11:16 +00:00
Martin Mathieson a68f2a299a Fix RACH extended IE handling.
Flags have different meanings depending upon radio mode...

svn path=/trunk/; revision=25435
2008-06-06 09:09:00 +00:00
Martin Mathieson 5b61d692ae Fix operator precedence problem.
svn path=/trunk/; revision=25430
2008-06-05 09:15:42 +00:00
Martin Mathieson acd6d3fb35 - Make FP radio division mode/speed explicit in struct for R7
- Various R7 fixes












svn path=/trunk/; revision=25425
2008-06-04 17:33:48 +00:00
Martin Mathieson c0353af700 Missed "bytes" -> "bits" changes.
svn path=/trunk/; revision=25387
2008-05-27 19:00:47 +00:00
Martin Mathieson f4981baf47 Type 2 hsdsch data is different (size in bytes and byte-aligned).
svn path=/trunk/; revision=25386
2008-05-27 16:08:08 +00:00
Martin Mathieson 44c5c69d04 Fix max pdu size in hsdsch alloc type 2.
svn path=/trunk/; revision=25385
2008-05-27 11:13:57 +00:00
Martin Mathieson dbb97069a4 More R7 tweaks and comment updates.
svn path=/trunk/; revision=25376
2008-05-25 23:12:56 +00:00
Martin Mathieson 37217be839 When extending values, extra bits are always m.s.
svn path=/trunk/; revision=25328
2008-05-20 16:36:29 +00:00
Martin Mathieson ec60070b2c Enable FP R7 support.
This commit adds a header file needed by my PDCP dissector.
(not yet ready to be added).

svn path=/trunk/; revision=25326
2008-05-20 10:08:28 +00:00
Martin Mathieson aad8618736 HS-DSCH type 2 bug fix + prettification.
svn path=/trunk/; revision=25277
2008-05-12 16:25:49 +00:00
Martin Mathieson ee26858622 Added HS-DSCH data frame type 2 (currently only compile-tested).
svn path=/trunk/; revision=25271
2008-05-11 00:46:25 +00:00
Martin Mathieson 275c415f7e Add a couple of missing HS-DSCH data frame fields.
svn path=/trunk/; revision=25267
2008-05-09 17:46:45 +00:00
Martin Mathieson 6036ca259e Initialise variable.
(sorry about the build breakage, these new message formats will be tested soon
and it looks like I forgot to compile-test the last change I made...).

svn path=/trunk/; revision=25220
2008-05-02 21:38:49 +00:00
Bill Meier 36121319b0 Fix (what I presume to be) a typo to prevent compile error.
svn path=/trunk/; revision=25219
2008-05-02 19:18:08 +00:00
Martin Mathieson c7640c39a5 More R7 additions.
Main missing part is new HSDSCH data frame type 2.



svn path=/trunk/; revision=25217
2008-05-02 15:27:00 +00:00
Martin Mathieson 7c25297f76 Updated common control messages to R7.
svn path=/trunk/; revision=25216
2008-05-02 14:50:23 +00:00
Martin Mathieson 6d9fde71a6 Fix test for unlimited credits value in new alloc format.
svn path=/trunk/; revision=25185
2008-04-28 10:23:25 +00:00
Martin Mathieson 376058d201 Add comment explaining that case is safe.
svn path=/trunk/; revision=25178
2008-04-25 19:12:57 +00:00
Martin Mathieson c65e14ffa4 Add cast to avoid Windows warning.
svn path=/trunk/; revision=25177
2008-04-25 19:09:07 +00:00
Martin Mathieson fbb23743d8 Fixed some old problems found while starting to add R7 support.
svn path=/trunk/; revision=25171
2008-04-25 17:20:28 +00:00
Anders Broman 9d316093f6 Apply yet another set of the optimization patches:
-set_str2add_str_val_to_str

svn path=/trunk/; revision=23406
2007-11-08 22:49:03 +00:00
Martin Mathieson b40d397b16 Make groups of PDUs filterable as large FT_BYTES items
(where the initial length isn't readily available when item is first added)

Note that this still won't work where an initial length of 0 is given for
the item that will later be extended using proto_item_set_len(), as the
pointer value part of the zero-length array will reamin NULL...

svn path=/trunk/; revision=23253
2007-10-23 11:02:08 +00:00
Martin Mathieson 6ba32fd89f Show multi-byte variable length fields using FT_BYTES|BASE_HEX.
Note that there is still a problem with 'Apply as filter' filters.  They seem to remember the initial length of the item, and not the final length set using proto_item_set_len() (this is the case for groups of TBs/PDUs).  Will investigate when time allows...

svn path=/trunk/; revision=23239
2007-10-22 13:31:51 +00:00
Graham Bloice bb61f339ed Cast values to correct sizes for number of bits to squelch Win32 warnings
svn path=/trunk/; revision=21737
2007-05-09 09:33:44 +00:00
Guy Harris 636807c1ce Unless I've missed something, the number of subframes can be as many as
16 (4 bits, 0-origin, so that's 15 + 1 as the maximum).

svn path=/trunk/; revision=21733
2007-05-09 03:50:58 +00:00
Martin Mathieson aac8ca1355 From Kriang Lerdsuwanakij:
This patch adds the handling of Spare Extension bytes
to UMTS Frame Protocol.  It also handles the case when
the presence of CRC in dedicated channels is not known
(i.e. when FP from a K12/K15 log is dissected).

The new functionality is placed in the new function
"dissect_spare_extension_and_crc".  The "dch_crc_present"
field inside "struct fp_info" (file packet-umts_fp.h)
is also extended to handle the case of unknown CRC presence.

Much of other changes is to update "offset" variable and
return it so that the location of Spare Extension and CRC
is available.

The patch also include a small tweak to handle Frame
Protocol information saved from K15.  Some fields appear
8 bytes later compared to K12.  The changes are in the file
packet-k12.c.

svn path=/trunk/; revision=21726
2007-05-08 17:13:14 +00:00
Martin Mathieson 7025597eae Try to squash a warning seen on win32 buildbot.
svn path=/trunk/; revision=21092
2007-03-21 17:14:33 +00:00
Gerald Combs 2e89206961 Try to fix a naming conflict on Windows.
svn path=/trunk/; revision=20814
2007-02-14 22:03:39 +00:00
Martin Mathieson 958a67763d Change fp_info struct to be more general by removing DCT2000-specific field.
Also:
- Fix a division-by-zero error in FP dissector
- Correct the way DCT2000 IPPrim addresses and ports are dissected and displayed

svn path=/trunk/; revision=20812
2007-02-14 15:41:43 +00:00
Martin Mathieson b9f69234ad Check in trivial changes before generating a big diff...
svn path=/trunk/; revision=20304
2007-01-04 13:25:25 +00:00
Martin Mathieson 927e520b1a Show generated field when frame has 0 TBs for a channel
svn path=/trunk/; revision=20146
2006-12-18 17:58:52 +00:00
Martin Mathieson 6005837364 Fix version check needed for EDCH 'Number of subframes' field
svn path=/trunk/; revision=20137
2006-12-14 11:50:54 +00:00
Martin Mathieson f4e3b4c033 Fix range highlighted by EDCH sfn header tree
svn path=/trunk/; revision=20060
2006-12-07 18:06:22 +00:00
Martin Mathieson 2552039f08 EDCH - show total number of PDUs in info column
svn path=/trunk/; revision=20059
2006-12-07 11:31:25 +00:00