Commit Graph

80753 Commits

Author SHA1 Message Date
Alex Sirr 17ae0f6be2 DCERPC - Add dissector for ITaskSchedulerService 2021-04-27 20:11:59 +00:00
Preston Hunt ec14bbd892 IEEE 802.11: decode RSTA availability duration
RSTA Availability Duration has units of 100 microseconds. Display it as
ms for readability.
2021-04-27 19:47:12 +00:00
Guy Harris bdc878e2f7 wiretap: clean up freeing of if_filter options.
Use if_filter_free() in wtap_block_free_option(), don't duplicate it.

Move if_filter_dup() and if_filter_free() before the latter is first
used.
2021-04-27 10:22:00 -07:00
Jirka Novak 02107e6abe RTP Player: Fixed issue when keys were not processed till mouse clicked 2021-04-27 18:08:28 +02:00
Martin Mathieson 1b2fdeca13 PTP: Fix a couple of spelling errors 2021-04-27 10:01:37 +00:00
Guy Harris 80a6e34d81 rtps-virtual-transport: fix printing of 64-bit integers.
There is no guarantee that "%l[doux]" are correct for 64-bit integers.
Use G_GUINT64_FORMAT for unsigned 64-bit integers.
2021-04-27 02:07:31 -07:00
Luis Colmenero 3cdbbcdfb9 RTPS-VT: New dissector to enhance the RTPS protocol
Added dissectors for RTPS Virtual Transport and RTPS Processed Protocols

RTI Connext DDS can capture RTPS-related traffic by using the Network Capture
Utility. The generated .pcap capture files will follow these protocols,
establishing a format for how information must be saved, and then
parsed. This will improve debuggability by including additional information
obtained from within Connext DDS.

RTPS-VT parses the information related to the transport. It then, calls
the RTPS-PROC dissector, which handles the rest: calling the RTPS
dissector when needed, and parsing additional information such as the
one related to security.
2021-04-27 06:15:42 +00:00
Gerald Combs 2549e51ee4 Remove unneeded c-ares checks.
C-ares has been mandatory since 451a241e50. Remove some checks that are
no longer needed.

Rename OPTIONAL_DLLS to THIRD_PARTY_DLLS and OPTIONAL_PDBS to
THIRD_PARTY_PDBS in CMakeLists.txt, which is more accurate.
2021-04-27 05:36:49 +00:00
Wolfgang Steinwender ff9a89c8a2 http2: Rename GOAWAY Promised-Stream-ID to Last-Stream-ID
According to the RFC, the stream ID in a GOAWAY frame is called Last-Stream-ID.
2021-04-26 21:36:45 +00:00
Pascal Quantin c713fb3b7d Windows: move ENABLE_VLD to CMakeOptions.txt 2021-04-26 21:37:06 +02:00
Preston Hunt 21474fa308 IEEE 802.11: add dissection of FTM R2I/I2R reps
The max I2R and R2I repetition field values are one less than the actual
value. Display the actual count when displaying to the user.
2021-04-26 11:43:09 -07:00
Jirka Novak c1084fe97e RTP Player: Settings for enabling use of disk as temporarly store
New advanced settings are created:
- rtp_player_use_disk1 - controls if decoded samples are stored in
  memory or on disk.
- rtp_player_use_disk2 - controls if dictionary for decoded samples
is stored in memory or on disk.
- documentation updated
2021-04-26 10:57:22 +02:00
Uli Heilmeier fd14396972 PTP: Check for enough bytes
Make sure we have enough bytes for Length and Type fields before we read
from tvb.
Using existing msg_len for the checks.

Closes: wireshark/wireshark#17355
2021-04-26 07:45:18 +00:00
Tomasz Moń 340019b233 USBLL: Group packets into transactions
Move USB state machine tracking into one function. Do not store source
and destination addresses, simply generate them based on transaction
info and state when needed.

Related to #15908
2021-04-26 07:28:30 +00:00
Roland Knall 2448f6da57 BCG729: Fix url
Apparently the website was reworked and the link has to be changed
2021-04-26 08:41:17 +02:00
Jirka Novak 71bd81efd4 RTP Player: Fix of clang compilation error 2021-04-25 22:08:49 +02:00
Jirka Novak 54b7886a5e RTP Player: Memory consumption improvements
Audio for play is now decoded and stored without silence parts.

Changes:
- ui/qt/utils/rtp_audio_file.cpp created to handle silence skipping
- ui/qt/rtp_audio_stream.cpp refactored to support it
- Fixed issue with exporting streams: File synchronized export was missing
leading silence.
- No line is shown in waveform graph if there is silence
2021-04-25 19:34:52 +02:00
database64128 d5bd5a920b 🔍 Fix HiDPI scaling on Windows
- Set `Qt::HighDpiScaleFactorRoundingPolicy::PassThrough` to fix large UI on devices with non-integer scaling factors
- Fix #17007
- See discussions at https://github.com/keepassxreboot/keepassxc/issues/2815 and my fix at https://github.com/keepassxreboot/keepassxc/pull/4915
2021-04-25 17:18:18 +00:00
Jirka Novak e91806b8e9 RTP Player: Fix for compilation when no HAVE_LIBPCAP is defined
See comment on !2801.
2021-04-25 14:47:59 +02:00
Pascal Quantin 1408db615b Windows: upgrade Npcap to 1.31 2021-04-25 13:08:52 +02:00
Gerald Combs c4d6b0f6d7 [Automatic update for 2021-04-25]
Update manuf, services enterprise numbers, translations, and other items.
2021-04-25 09:28:50 +00:00
Martin Mathieson d9ad3b15c5 Fix more item lengths. 2021-04-24 19:22:37 +01:00
Dr. Lars Völker 8a96d2a903 CAN, AUTOSAR NM, Signal PDU: Fix the interpretation of CAN ID
This patches makes sure that the registered IDs are not influenced
by the three flags mapped into the same uint32.

This was a oversight in the AUTOSAR NM and Signal PDU dissectors.
2021-04-24 11:40:57 +00:00
Daniel Dulaney e35efdee8d TIFF: Add a basic TIFF dissector 2021-04-24 10:42:59 +00:00
John Thacker 9569288c3b BGP: Update Subsequent Address Family Identifiers (SAFI)
Update SAFI defines and value string from last update at
https://www.iana.org/assignments/safi-namespace/safi-namespace.xhtml
2021-04-24 08:28:10 +00:00
ferst da80daaf83 DNP3: Add TLS dissector
IEEE 1815-2012[1] section 7.8 describes the use of DNP3 over TLS using TCP
port 19999. This commit creates a global to store the return of
`register_dissector` and then calls `ssl_dissector_add` in
`proto_reg_handoff_dnp3`.

[1] https://ieeexplore.ieee.org/servlet/opac?punumber=6327576
2021-04-24 07:56:40 +00:00
Piotr Winiarczyk 91d21fc334 btmesh: Fix typo in PDU name
The Light Lightness Get is the proper name for the PDU 0x824B
2021-04-24 09:02:31 +02:00
Joakim Karlsson 1bd0cf5fbd NVMe: fix build error
packet-nvme.c:2396:8: error: ‘grp’ may be used uninitialized in this
function [-Werror=maybe-uninitialized]
     ti = proto_tree_add_item(grp, hf_nvme_get_logpage_lba_status_nel,
cmd_tvb, poff, len, ENC_NA);
        ^
packet-nvme.c:2378:17:
note: ‘grp’ was declared here
     proto_tree *grp;
                 ^
2021-04-23 08:04:58 +00:00
Christian Ambach 96e8ab4682 AJP13: properly display request attributes
do not show only the value of an attribute, but also its name

Change-Id: Ieb07e994dd984bdc98a52a947b2d3b06bc26fd30
Signed-off-by: Christian Ambach <ambi@samba.org>
2021-04-23 07:05:40 +00:00
Christian Ambach de5a830e95 AJP13: properly display common headers
do not show only the value of a header value, but also the header's name

Change-Id: I84ef3107cf3d4b0c8aa96fe137aa9be19c30c6ab
Signed-off-by: Christian Ambach <ambi@samba.org>
2021-04-23 07:05:40 +00:00
Preston Hunt 9ad9bb8969 IEEE 802.11: display STA Info STS with custom func
Updated dissection of number of STS field to use the same custom
function as used by STS dissection in other frames.
2021-04-23 05:44:43 +00:00
j.novak@netsystem.cz 0048142ea1 RTP Player: Added button 'Refresh streams' for live capture 2021-04-22 19:33:11 +00:00
Martin Mathieson c182fa4268 Make some vars static. 2021-04-22 09:47:51 +01:00
Josh Schmelzle f3bd0b5772 80211: Rename VHT_TX_PWR_ENVELOPE to TX_PWR_ENVELOPE 2021-04-22 04:30:19 +00:00
John Thacker 50dda353ec SGSAP: Use ECGI specific fields for the ECGI MCC/MNC 2021-04-22 04:14:30 +00:00
Thomas Dreibholz 4232d2f81d Fix for the ASAP and ENRP statistics.
Removed wrong stat_tap_set_field_data() call -> interval display is working
correctly now.
2021-04-22 03:55:15 +00:00
Richard Sharpe fe13ec8fd2 ieee80211: Fix handling of PASN Auth for seq==3.
The original code was too complex and missed some IEs.

Change-Id: I0734f31e9f4b37b8a876b675dbde8972745f124e
2021-04-21 22:52:25 +00:00
Peter Wu 785657d9b8 CMake: fix macOS build when Qt5 and Qt6 are both installed
When both qt (qt@6) and qt5 are installed via Homebrew, the build fails:

    FAILED: ui/qt/CMakeFiles/qtui.dir/qtui_autogen/mocs_compilation.cpp.o
    ...
    In file included from ui/qt/qtui_autogen/mocs_compilation.cpp:2:
    In file included from ui/qt/qtui_autogen/EWIEGA46WW/moc_about_dialog.cpp:10:
    In file included from ui/qt/qtui_autogen/EWIEGA46WW/../../../../../repos/wireshark/ui/qt/about_dialog.h:15:
    In file included from /Users/pwu/repos/wireshark/ui/qt/models/astringlist_list_model.h:15:
    In file included from /usr/local/opt/qt5/lib/QtCore.framework/Headers/QAbstractTableModel:1:
    In file included from /usr/local/opt/qt5/lib/QtCore.framework/Headers/qabstractitemmodel.h:43:
    In file included from /usr/local/include/QtCore/qvariant.h:43:
    In file included from /usr/local/include/QtCore/qatomic.h:41:
    /usr/local/include/QtCore/qglobal.h:667:26: error: no template named 'enable_if_t' in namespace 'std'; did you mean 'enable_if'?
             typename = std::enable_if_t<std::is_arithmetic_v<T> && std::is_arithmetic_v<U> &&
                        ~~~~~^

That qvariant.h header is from Qt 6 which is backwards incompatible:

    /usr/local/include/QtCore -> ../Cellar/qt/6.0.2/include/QtCore

It appears that `<qt5 prefix>/include` must be explicitly included as
the default Qt5 include directories does not cover this:

    $ find /usr/local -lname '*include/QtCore' -ls
    ... /usr/local/include/QtCore -> ../Cellar/qt/6.0.2/include/QtCore
    $ find /usr/local -name qvariant.h -ls
    ... /usr/local/Cellar/qt@5/5.15.2/lib/QtCore.framework/Versions/5/Headers/qvariant.h
    ... /usr/local/Cellar/qt/6.0.2/lib/QtCore.framework/Versions/A/Headers/qvariant.h
    $ find /usr/local -name QtCore -lname '*Headers' -ls
    ... /usr/local/Cellar/qt@5/5.15.2/include/QtCore -> ../lib/QtCore.framework/Headers
    ... /usr/local/Cellar/qt/6.0.2/include/QtCore -> ../lib/QtCore.framework/Headers
    $ ls -la /usr/local/opt/qt5
    ... /usr/local/opt/qt5 -> ../Cellar/qt@5/5.15.2
2021-04-21 20:30:53 +00:00
Thomas Dreibholz c295e8a149 Added missing documentation for the RSerPool statistics features. 2021-04-21 19:53:09 +00:00
Peter van der Perk 4959ae652e UAVCAN/CAN dissector see https://uavcan.org/ 2021-04-21 19:36:44 +00:00
Pascal Quantin f15d35b0c8 CSP: fix compilation with MSVC 2021-04-21 20:45:48 +02:00
Thomas Dreibholz f199c00d40 Improvements for the CSP dissector 2021-04-21 11:16:43 +00:00
Jim Young d42042fcbb Qt: Add checkbox for enabling/disabling packet-list hover_style
At times the presence of the packet-list hover_style colorization can make
it difficult to determine the state of the packet directly under the mouse
cursor. This forces the user to move the mouse cursor away from the
packet-list row to reveal the next colorization state. The packet-list row
colorization style precedence, from highest to lowest, is: hover_style,
Selected, Ignored, Marked and then coloring rules.

This patch adds a new 'Packet List settings:' checkbox option 'Enable
mouse-over colorization'. By default the supporting preference
`gui.packet_list_hover_style.enabled` will be enabled (TRUE). When this
checkbox is disabled, the packet-list hover_style (mouse-over)
colorization will not be used.
2021-04-21 08:36:27 +00:00
Thomas Dreibholz 6d809554a4 Fixed typo. 2021-04-21 04:16:27 +00:00
Thomas Dreibholz 1c7d9a57ab Further SCTP Analysis dialog layout improvements. 2021-04-21 04:16:27 +00:00
Thomas Dreibholz c0aa2a0841 More SCTP Analysis GUI layout fixes. 2021-04-21 04:16:27 +00:00
Thomas Dreibholz 317d264664 Second part of SCTP Analysis GUI layout fixes. 2021-04-21 04:16:27 +00:00
Thomas Dreibholz df394c057b First part of SCTP Analysis GUI layout fixes. 2021-04-21 04:16:27 +00:00
Vadim Yanitskiy eb3e124b46 GSMTAP: use Wireshak's API for displaying dB/dBm units 2021-04-21 02:24:29 +02:00
ismaelrti eb5f4eea99 RTPS: Added new coherent sets PIDs.
Add support for new PIDs (PID_GROUP_COHERENT_SET, PID_END_COHERENT_SET,
PID_END_GROUP_COHERENT_SET, PID_END_COHERENT_SET_SAMPLE_COUNT).
2021-04-20 20:53:31 +00:00