This has never worked AFAICT because functions have never accepted
fvalues, only fields, so converting from unparsed to an fvalue
string is moot, they are both invalid argument types to functions.
Reset tap_listener_queue and tap_dissector_list in tap_cleanup() so that
other cleanup routines (e.g. tap dialog destructors) don't try to access
invalid memory. Fixes#17719.
Have these functions accept a zero max length to mean "display
the whole byte array". Change the max length parameter to receive a
number of bytes to print, not the length of the output character
string.
Adjust the macros bytes_to_str() and bytes_to_string_punct() to
produce the same output. Add more tests. Rename the functions to
bytes_to_str_maxlen() and bytes_to_str_punct_maxlen() because this is
an API break.
Remove a duplicated argument to fix a warning:
Wrong number of arguments for string format.
Format ptvcursor_add(cursor, hf_skinny_%s, 6, ENC_NA);
takes 1, but 2 are provided.
Add tname as argument to Type eth_type_default_body() to fix a warning.
Call to method Type.eth_type_default_body with too many arguments;
should be no more than 1.
Do not keep epan_dissect_t instance hanging until FrameInformation
destructor is called. Simply copy the tvb data into local buffer and
cleanup epan_dissect_t instance as soon as possible.
Fixes#17590
Rcv.Wind.Shift and Snd.Wind.Shift were not displayed correctly by
the BBLog dissector and the TCP dissector was not using the
information about the shift values available in the BBLog file.
Add uat_set_default_values, which lets us provide default values for
fields that might be missing from the end of a UAT line. Set a default
value for the I/O Graph dialog's Y Axis Factor. Fixes the backward
compatibility issue described in #17623
If we encounter unexpected extra fields on a line, simply log a warning
and continue instead of returning an error. This allows forward
compatibility when we add a field to a UAT. We end up throwing away the
extra fields, but it's better than resetting the entire UAT. Fixes the
forward compatibility issue described in #17623.
If an ftype can participate in equala assume it can also participate in
not equals. Use fvalue_can_eq() instead of fvalue_can_ne().
If it can participate in one order comparison it can participate in all.
Replace any comparison with fvalue_can_cmp().
CMake does not use any shell to run execute_process(). When
running asciidoctor we must use the batch file. Put that before
"asciidoctor" (a ruby script) so CMake uses that instead.
Previously a chained expression like "a == b matches c" would be
considered syntactically valid. Fix that to be a syntax error.
Only math-like comparisons can be chained.
This also disallows chaining contains expressions.
While analyzing the network traffic between an OMRON NS8-TV01B-V2 HMI
and an OMRON CJ2M PLC, I discovered that all requests from the HMI have
their Gateway Count byte set to 0x07. Responses from the PLC still have
a Gateway Count byte set to 0x02.
This conflicts with the (20-year-old) protocol documentation by OMRON,
but happens nevertheless.
With this check removed, all bytes can be successfully parsed to an
OMRON FINS message.
- The RSSI fields in "(Un)Asssociated STA Link Metrics" and "Steering
Policy" TLVs are not defined as RSSI but RCPI in released versions of
the Multi-AP/EasyMesh specs. It's defined as an unsigned value in
range 0 - 220.
- Changed "RCPI reporting threshold" type to UINT8 in "Metric Reporing
Policy TLV".
This patch is a quick fix to the infinite loop during dissection of the
IOAM Trace data list, introduced by merge request !4962Fixes#17709Closes#17709
Signed-off-by: Justin Iurman <justin.iurman@uliege.be>
Registering a preference module for a protocol filter name with
upper case letters aborts the program. Relax this restriction to
conform with the rules for protocols. The recommendation is still
to use all lower-case letters.
Fixes 070aeddf76.
I have discovered that my name is listed twice in `AUTHORS`, and the second
occurrence is next to an unrelated contributor's email.
As far as I can see, the real name of that contributor has never been
established, so just use the local part of their email address instead.
Strengthen the heuristics according to Appendix A.1 of RFC 3550:
Reject if the packet isn't long enough to fit the fixed header, including
the CSRCs if present.
Reject if the packet isn't long enough to fit the extension header.
Reject if the packet isn't long enough to fit the padding, if we have
all the packet.
Reject the payload types reserved for RTCP conflict.
Most of these lead to malformed packet error if dissected anyway,
which can still be done via other methods (SDP, Decode As, etc.)
As searching the list of protocols takes a noticeable amount
of time and so would introduce significant lag while typing a string
into the Search box, we instead debounce the call to
updateSearchLineEdit(), so that it doesn't run until a set amount of
time has elapsed with no updates to the Search field.
If the user types something before the timer elapses, the timer restarts
the countdown.
Use a nested_type_depth preference to allow customization (default 25).
Fix incorrect display of 8 to 14 list & set lengths as negative values
when displaying internal Thrift fields of compact PDU in sub-dissector.
Dr. Lars Völker