and "gtk_file_chooser_set_filename()" requires an absolute path, so ""
isn't valid. Get rid of the "gtk_file_selection_set_filename()" call in
"file_selection_new()".
Put in a comment asking why we're using
"gtk_file_selection_set_filename()" at all.
svn path=/trunk/; revision=11095
declaration.
Give the address and port arguments to "add_hostlist_table_data()"
appropriate names and Doxygen comments (they're not a source address and
port, they're just an address and port), and do the same for the address
and port members of a "hostlist_talker_t".
Get rid of extra unnecessary variables in "add_hostlist_table_data()".
Clean up indentation.
svn path=/trunk/; revision=11066
changed window_xy (dialog) function calling in a lot of gtk files
cleanup of file selection code
cleanup in dlg_utils/file_dlg/ui_util
Please report any problems!!!
svn path=/trunk/; revision=11003
convenient to put into a command line (no capital letters, no spaces to
require quotes), and one that's a detailed description for use in the
UI. Allow either of them in the preferences file or "-o" option; use
the detailed description in the UI, and also use it when writing the
preferences out, so that the preference will be readable by older
versions of Ethereal (assuming the preference existed in that version).
Update "README.developer" to give more detail about an enum_val_t (and
to put the _t in), and to give a more detailed description of the
"radio_buttons" argument to "prefs_register_enum_preference()".
svn path=/trunk/; revision=10982
use window_new instead of dlg_window_new for the statistics windows
(as these are no dialog windows)
do some code cleanup
svn path=/trunk/; revision=10979
move the get/set window size functionality from main to ui_util,
add some functions to handle windows/dialogs.
changed help and about dialog to suit the current window API
svn path=/trunk/; revision=10974
(including remebering of the dialog size in recent file).
for a first step, I replaced all window_new() calls from dialogs
into dlg_window_new() ones, and removed all gtk_window_set_position
calls, this should be done in a more generalized way
svn path=/trunk/; revision=10964
- we don't put it at the end of the run-time version information.
Add newlines into formats used with that information where appropriate
(the "About" dialog box already had a newline in the format).
svn path=/trunk/; revision=10950
not all *printf routines don't handle them or because there's no
advantage to using one rather than just copying a null string to the
target (the length-checking done by "snprintf"-style routines is useful
for a null string only if the target is zero-length, which it isn't in
this case).
Clean up indentation.
svn path=/trunk/; revision=10940
added a notebook tab with some directory infos (still incomplete and ugly)
cleaned up #includes in main.c (hoping this didn't break the build on unix)
svn path=/trunk/; revision=10925
when changing the font size, even refilling of the corresponding
gtk_text_buffer doesn't seem to trigger an update.
The only workaround is to freshly select the frame, which will remove any
existing notebook tabs and "restart" the whole byte view again.
svn path=/trunk/; revision=10915
this would lead to an unresponsive program.
Simply discard the messages, as we don't have a way to queue and show this
message if the main window is becoming "visible" again.
svn path=/trunk/; revision=10910
add a config.nmake option to control whether to build
libethereal.dll or not;
remove "./wiretap" from PATH to prevent problems due to
wrongly-loaded files;
build dissector.lib with MSVC;
move "print.c" and "ps.c" to the dissector helpers, as "print.c"
imports variables from packet-frame.c and packet-data.c, which
are in libethereal;
move "g711.c" out of the dissector helpers, as they're used only
by Ethereal in a tap, not in Tethereal or in any dissector;
add a .def file for libethereal;
arrange to declare global variables exported from libethereal
with "__declspec(dllimport)" when building programs that import
those variables;
update the NSIS installer.
Make the "configure" script define ETH_VAR_IMPORT as "extern".
svn path=/trunk/; revision=10834
main window widgets, rather than requiring a relayout if the visibility
of the main toolbar, filter toolbar, or statusbar is changed.
Clean up indentation.
svn path=/trunk/; revision=10796
to re-lay-out the main window, we just need to change the visibility of
the appropriate widgets - that reduces the amount of drawing done,
speeding things up a little and reducing flicker.
svn path=/trunk/; revision=10795
displayed; otherwise, if you hide both of them (e.g., hiding the packet
details and packet data panes in the default layout), "main_second_pane"
remains but as a gray blob, rather than having the remaining pane take
over the entire window.
svn path=/trunk/; revision=10794
coloring rules Ethereal uses (yes, those views affect the way the
packets are displayed, but that also applies to at least some the
preferences, which are in Edit->Preferences).
Get rid of the "Show" menu under "View", moving the items up to the main
"View" menu, as per the GNOME HIG. Give some of them accelerators, and
change the accelerators for some other "View" items to avoid collisions.
svn path=/trunk/; revision=10780
when using GTK2 code for rendering the error. In order to correctly
render the error message, it must be XML escaped.
TODO: track down the remaining places where this XML escaping is
required, and fix it there too (not sure if they exist though).
svn path=/trunk/; revision=10764
construction of the hex dump pane (so we don't need a progress bar(!)
while it's being filled in), and might have some other UI advantages as
well.
svn path=/trunk/; revision=10723
would be an independent clause, so it should be separate from the other
clause with a semicolon).
Note that, in that tooltip, in some cases "link-layer types" would be
appropriate and in others "link-layer header types" might be more
appropriate.
svn path=/trunk/; revision=10722
and put it into new range_utils files. This will avoid:
a) duplicate code in save and print dialog and
b) yet another code duplication for future dialogs (export, ...)
svn path=/trunk/; revision=10665
add 2 hidden display filters for SIP - namely:
(1) sip.error (for all responses with code >= 300)
(2) sip.resend (for all packets that appear to have been retransmitted). A
field showing a count of these is shown in the SIP stats window.
svn path=/trunk/; revision=10662
-ps: added formatting hints for ghostscript, so pdf conversion will be much better
-ps: print a thin line at the top and bottom of each page
-ps/text: add an option to start a new page for every packet (formfeed)
svn path=/trunk/; revision=10660
ANSI and GSM MAP stats enhancements and cleanups;
enhanced parameter dissection related to SS for GSM A-interface
and MAP;
minor GSM SMS fix;
GSM SS enhancements for parameter dissection;
MTP3 statistics tap.
svn path=/trunk/; revision=10657
ANSI and GSM MAP stats enhancements and cleanups;
enhanced parameter dissection related to SS for GSM A-interface
and MAP;
minor GSM SMS fix;
GSM SS enhancements for parameter dissection;
MTP3 statistics tap.
svn path=/trunk/; revision=10655
failure occurs; now that "simple_dialog()" queues up messages if we
don't yet have the main window, those messages will be queued up until
then.
Move the point at which we pop up those queued messages after the
"process all pending GUI events" is done, so that those messages are
properly displayed on top of the main window.
svn path=/trunk/; revision=10617
errors to the user. Use that, rather than "g_warning()", in the
Diameter dissector to report errors reading the dictionary.
Make the format argument to "simple_dialog()" a "const" pointer.
Fix up the read-error message in Tethereal to end with a newline.
If a simple dialog is requested before the main window or the
capture-control window is popped up, queue it up and pop the queued
messages up once the main or capture-control window is displayed.
svn path=/trunk/; revision=10616
"get_color()" - otherwise, GDK will allocate a color from the colormap
to match whatever random values happen to be there.
svn path=/trunk/; revision=10612
Guy Harris