Commit Graph

11 Commits

Author SHA1 Message Date
Guy Harris 8a8b883450 Set the svn:eol-style property on all text files to "native", so that
they have LF at the end of the line on UN*X and CR/LF on Windows;
hopefully this means that if a CR/LF version is checked in on Windows,
the CRs will be stripped so that they show up only when checked out on
Windows, not on UN*X.

svn path=/trunk/; revision=11400
2004-07-18 00:24:25 +00:00
Guy Harris 00a057b79f Make "new_color_filter()" take the background and foreground colors, as
GdkColors, as arguments.

svn path=/trunk/; revision=10613
2004-04-16 19:36:36 +00:00
Guy Harris e20b794c0e You have to initialize a GtkColor structure before passing it to
"get_color()" - otherwise, GDK will allocate a color from the colormap
to match whatever random values happen to be there.

svn path=/trunk/; revision=10612
2004-04-16 19:05:05 +00:00
Laurent Deniel 1dc46c91aa * Color filters:
Read of color filters rewritten to remove possibility of buffer overflow
in read_filters_file() and to fix comment & blank line handling.
This removes any limitation (and stack overflow) on the lengths of color
filter name and filter expression which are now dynamically allocated.

Fix removal/deletion of color filters (avoid segmentation fault when
some color filter is deleted and then the list cleared for instance).
The use of g_slist_remove() within an iterator is simply unsafe if the
code is not prepared to handle this.

Fix a small memory leak in revert_filters().

Remove inappropriate comments in read_filters().

Miscellaneous code cleaning.

svn path=/trunk/; revision=10380
2004-03-14 23:55:53 +00:00
Guy Harris 1980fa5dbf Pass ESD_BTN_OK rather than NULL as a second argument to
"simple_dialog()"; NULL might be #defined to be a pointer expression on
some platforms, causing compiler warnings (and, on platforms where a
null pointer doesn't have all its bits 0, possibly causing misbehavior,
although I don't think there are any such platforms on which Ethereal
runs).

Don't allow 0 as button mask argument to "simple_dialog()".

Squelch a compiler warning.

Report fatal problems as errors, not warnings.

Report file I/O errors with "file_open_error_message()".

Report file write errors (including those reported by "close()", e.g.
some errors writing to an NFS server) when saving raw packet data to a
file.

svn path=/trunk/; revision=9915
2004-01-31 03:22:42 +00:00
Ulf Lamping 25edd1c53e renamed ESD_TYPE_CRIT to ESD_TYPE_ERROR to
better reflect the real error text

svn path=/trunk/; revision=9913
2004-01-31 02:25:46 +00:00
Olivier Biot d82c95c87a Part 2 of the "unmarking a packet matching a color filter does not apply
the color filter's colors" bug: keep a list of removed color filters, so
there's no problem if we delete a color filter for which there are one or
more packets that have its colors. Only get rid of the lists when they
ar no longer needed.

svn path=/trunk/; revision=9613
2004-01-09 20:20:42 +00:00
Guy Harris 115700bc62 From Richard Urwin:
use Export and Import for the buttons in GTK+ 2.x as well;

	get rid of a duplicate fclose;

	other fixes.

Update the description of color filters in the Ethereal man page to
reflect the change, clean up the formatting (use =item), and add the
global and personal color filters files to the FILES section; refer to
them as "color filters" files rather than "colorfilters" files, as the
FILES section gives the "colorfilters" file name so you don't have to
use that as the name.

Clean up white space.

svn path=/trunk/; revision=8285
2003-08-27 22:55:51 +00:00
Ronnie Sahlberg 710f08b09f From Richard Urwin a great enhancement to the color filter dialogue to
make it possible to import/export color filters

svn path=/trunk/; revision=8188
2003-08-18 21:27:11 +00:00
Guy Harris e1647e4504 From Richard Urwin:
add support for a system-wide color filter file;

	fix a bug where "read_filters()" didn't close the file handle.

Use the "get_datafile_path()" routine he added to construct the pathname
of the Diameter directory, the global preferences file, and the manuf
file.

svn path=/trunk/; revision=7677
2003-05-15 07:44:54 +00:00
Guy Harris 6ca5407668 Separate the routines to allocate colors from the routines to handle
color filters.

svn path=/trunk/; revision=6872
2003-01-08 01:59:42 +00:00