osmocom
/
wireshark
14
0
Fork 1
Code Issues Pull Requests Projects Releases Wiki Activity
35,040 Commits 26 Branches 0 Tags 795 MiB
Commit Graph

1515 Commits

Author SHA1 Message Date
Anders Broman 67900c23be Fix Unused varaiable warnings. 
CID 1163 - 1166

svn path=/trunk/; revision=36675
 2011-04-17 09:34:38 +00:00
Bill Meier e07cb22a47 Rework whitespace. 
svn path=/trunk/; revision=36583
 2011-04-12 14:33:30 +00:00
Bill Meier c424bd7c83 Don't assign to a proto_item * if the value won't be used: Coverity 1158 & 1159. 
svn path=/trunk/; revision=36581
 2011-04-12 13:27:08 +00:00
Bill Meier e3f4dc17a9 localtime() can return a NULL ptr. 
svn path=/trunk/; revision=36580
 2011-04-12 13:21:32 +00:00
Gerald Combs 3e44421764 Either remove or use unused values found by Coverity. Fixes CIDs 
1169-1172.

svn path=/trunk/; revision=36500
 2011-04-06 18:59:36 +00:00
Chris Maynard 735b61500c Don't dereference a NULL pointer. Fixes CID 426. 
svn path=/trunk/; revision=36424
 2011-03-31 18:00:26 +00:00
Anders Broman 645cfe9ef2 Add a missing break. 
CID 487

svn path=/trunk/; revision=36403
 2011-03-29 21:20:36 +00:00
Anders Broman ce248d9ea9 Add a missing break. 
CID 488

svn path=/trunk/; revision=36402
 2011-03-29 21:11:26 +00:00
Anders Broman 2b81b097e5 Add a missing break. 
CID 490

svn path=/trunk/; revision=36401
 2011-03-29 21:08:34 +00:00
Anders Broman bc0fbb792a Added FALLTHRU comment to avoid a "missing break" warning. 
CID 489

svn path=/trunk/; revision=36400
 2011-03-29 21:05:29 +00:00
Martin Mathieson 7356320a2a Don't assign proto_item pointers that are not used. 
Coverity 1174

svn path=/trunk/; revision=36395
 2011-03-29 14:23:13 +00:00
Chris Maynard 10928bc0cc Don't use prohibited strncpy(). Use g_strlcpy() instead. Ensures that "orig" 
will be NULL-terminated, even if len >= SCS_HUGE_SIZE.

svn path=/trunk/; revision=36383
 2011-03-28 17:04:58 +00:00
Bill Meier 7c41d527fd Removed uneeded 'continue'. 
Fixes Coverity 815 ("UNREACHABLE").

svn path=/trunk/; revision=36367
 2011-03-27 14:34:19 +00:00
Bill Meier 78c5c20d08 Don't assign to a proto_item* if the value won't be used: Coverity 1155-1156; 
Also:
  - Fix a few cases of SET_HIDDEN on the wrong item. (The SET_HIDDEN was being
    done on an already hidden item).
  - Minor indentation cleanup;

svn path=/trunk/; revision=36315
 2011-03-24 21:19:39 +00:00
Bill Meier b9331456e9 Don't assign to a proto_item* if the value won't be used: Coverity 1151-1154; 
svn path=/trunk/; revision=36312
 2011-03-24 17:37:07 +00:00
Bill Meier 24b8d23fb4 Don't assign to a proto_item* if the value isn't to be used: Coverity 1173; 
Also:
  - Fix 2 cases of an item attached to the wrong subtree;
  - "localize" & rename some variable definitions;
  - Minor indentation cleanup.


svn path=/trunk/; revision=36310
 2011-03-24 16:03:12 +00:00
Stig Bjørlykke cb56e84556 Removed unused parameter to parseServiceNodeId. 
Coverity 596.

svn path=/trunk/; revision=36283
 2011-03-23 08:03:02 +00:00
Stig Bjørlykke 888880eb25 Rewrote check for szStr in dissect_ICBAPhysicalDevice_get_LogicalDevice_rqst. 
Coverity 535.

svn path=/trunk/; revision=36282
 2011-03-23 07:34:00 +00:00
Ronnie Sahlberg 875abf1deb dont assign to a proto_item* unless we are going to use the value 
coverity 1157

svn path=/trunk/; revision=36276
 2011-03-23 05:18:26 +00:00
Stig Bjørlykke 1f108b02a0 Allocate correct size of range. 
Coverity 718.

svn path=/trunk/; revision=36262
 2011-03-22 18:58:32 +00:00
Jeff Morriss 3621346c20 Fix a typo 
svn path=/trunk/; revision=36249
 2011-03-22 13:49:07 +00:00
Ronnie Sahlberg 7191538bcc Coverity 1167 
Dont assign tlv_item unless we need to dereference it.
Also push the variable deeper into the scope where it is used isntead of function wide scope.


svn path=/trunk/; revision=36243
 2011-03-22 09:55:33 +00:00
Ronnie Sahlberg 3037db8904 Coverity 1168 
Create the items for 33_ARS under the subtree we create for this type and not under the parent node in the tree.


svn path=/trunk/; revision=36242
 2011-03-22 09:47:34 +00:00
Ronnie Sahlberg ea9e664fc9 Coverity 420 
Remove dead code and add a g_assert_not_reached() at a spot we can definitely never reach.

change a if(x)g_free(x) to a g_free(x)
since g_free(NULL) is just a nop.



svn path=/trunk/; revision=36238
 2011-03-22 09:05:26 +00:00
Stig Bjørlykke a774994572 Added some casts to fix coverity 325. 
svn path=/trunk/; revision=36228
 2011-03-21 18:33:18 +00:00
Guy Harris 7dfd6b1e09 From Roland Knall <rknall [AT] gmail.com>: allow heuristic subdissectors 
for SERCOS III packets.

svn path=/trunk/; revision=36214
 2011-03-20 00:47:18 +00:00
Stephen Fisher a62a37fbbe From Roland Knall via bug #5726: Adding a dissector registration, so the 
dissector may be called by other dissectors.


svn path=/trunk/; revision=36055
 2011-02-24 21:47:37 +00:00
Gerald Combs c514eaabf9 Try to fix some Clan scan-build warnings. 
svn path=/trunk/; revision=36003
 2011-02-18 19:57:18 +00:00
Stephen Fisher f749439b71 Remove some of the many dead assignments found by clang 
svn path=/trunk/; revision=35982
 2011-02-17 18:45:45 +00:00
Bill Meier e3ae028064 Rename some hf_... vars so name starts with hf_docsis_cmstatus 
svn path=/trunk/; revision=35873
 2011-02-08 01:15:44 +00:00
Bill Meier 7eb1530061 #if 0 code related to unused "docsis" dissector table; 
Use consistent indentation & other whitespace cleanup.

svn path=/trunk/; revision=35869
 2011-02-08 00:24:10 +00:00
Jaap Keuter 3312fc1bfe From Hendrik Robbel: 
Dissector for DOCSIS 3.0 CM-STATUS Report Messages.

svn path=/trunk/; revision=35866
 2011-02-07 22:19:38 +00:00
Guy Harris 3eecbb3248 Just use g_strdup_printf(), rather than doing it ourselves. 
svn path=/trunk/; revision=35780
 2011-02-03 08:31:04 +00:00
Bill Meier d3efa3ed9f A bit of Windows makefiles rework and cleanup: 
- Define macros for certain CFLAGS in config.nmake iso of having defs in each makefile;
  a. -DHAVE_CONFIG_H and -D_U_="" are now part of a macro named STANDARD_CFLAGS;
  b. -WX has been replaced by WARNINGS_ARE_ERRORS (defined as -WX in config.nmake)
      (This allows disabling "Warnings as Errors" by just changing config.nmake)
  c. CVARSDLL definitions (not usage) have been removed from the various makefiles.
     XXX: It appears the usage of CVARSDLL can also be removed (not yet done) since:
     -DWIN32 and -DNULL=0 do not appear to be needed (any more);
     -D_MT and _D_DLL  are not needed since /MP causes these definitions.
  d. Define a macro WARNINGS_CFLAGS with additional specific compiler (level4) warnings to be enabled.
     E.G., 4295: array is too small to include a terminating null character
- config.nmake: reformat some long lines for readability;
- plugins\Makefile.nmake: clean-deps does nothing: remove it (and usage in top-level makefile);
- dissectors/Makefile.nmake: test to enable packet-rrc.obj target needs to include MSVC2010 ...

svn path=/trunk/; revision=35747
 2011-02-02 01:19:53 +00:00
Bill Meier 6e079af172 Whitespace cleanup (remove trailing blanks from lines). 
svn path=/trunk/; revision=35711
 2011-01-30 22:57:00 +00:00
Bill Meier 17281958a2 Add a comment about some "unreachable code" indicating possible incorrect code someplace. 
Fix some spelling..

svn path=/trunk/; revision=35710
 2011-01-30 22:42:06 +00:00
Jeff Morriss f53744b59d There's no need to pass the result of tvb_get_ptr() as the 'value' in 
proto_tree_add_*(): just use proto_tree_add_item().
   
Replace some tvb_get_ptr()s with tvb_get_ephemeral_string().

svn path=/trunk/; revision=35603
 2011-01-21 03:00:31 +00:00
Jaap Keuter 969b5a240e Don't stop calling subdissectors when there's no tree. 
svn path=/trunk/; revision=35591
 2011-01-19 22:55:53 +00:00
Jaap Keuter c5c0a0d943 Use Wireshark standard marking for unused parameters. 
svn path=/trunk/; revision=35590
 2011-01-19 22:53:46 +00:00
Bill Meier 7089b9c780 Do Windows compile with /WX flag: treat warnings as errors. 
svn path=/trunk/; revision=35565
 2011-01-16 23:47:05 +00:00
Guy Harris 742915eca5 Fix some cut-and-pasteos and other typoes. 
svn path=/trunk/; revision=35328
 2011-01-02 19:39:24 +00:00
Guy Harris a8bc4a0d13 Rename the routines that handle dissector tables with unsigned integer 
keys to have _uint in their names, to match the routines that handle
dissector tables with string keys.  (Using _port can confuse people into
thinking they're intended solely for use with TCP/UDP/etc. ports when,
in fact, they work better for things such as Ethernet types, where the
binding of particular values to particular protocols are a lot
stronger.)

svn path=/trunk/; revision=35224
 2010-12-20 05:35:29 +00:00
Jeff Morriss 84aebe5af7 There is no exceptions.h file here, remove it from DISSECTOR_INCLUDES. 
svn path=/trunk/; revision=35201
 2010-12-16 14:39:33 +00:00
Jaap Keuter a6b55e6530 From Guido Reismueller: 
packet-mdd.c
- TLV 15 fixed

packet-tlv.c
- Added Support for DOCSIS 3.0 TLVs (38-66)

Added Support for the following DOCSIS 3.0 MAC Management Messages
- DBC-REQ (packet-dbcreq.c)
- DBC-RSP (packet-dbcrsp.c)
- DBC-ACK (packet-dbcack.c)
- CM-CTRL-REQ (packet-cmctrlreq.c)
- CM-CTRL-RSP (packet-cmctrlrsp.c)
- DPV-REQ (packet-dpvreq.c)
- DPV-RSP (packet-dpvrsp.c)

svn path=/trunk/; revision=35193
 2010-12-16 07:01:22 +00:00
Stig Bjørlykke d9af8b16ba Added opcua_extensionobjecttable.c from revision 34906. 
svn path=/trunk/; revision=35177
 2010-12-11 21:40:01 +00:00
Jeff Morriss 64a099a652 From Gerhard Gappmeier via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5429 : 
Until now the info column only shows the OPC UA transport protocol type (Hello,
Ack, Secure Conversion message).
After connections establishment has finished this column shows only Secure
Conversion message, because every service is sent over the secure channel.

This patch adds the useful support of displaying the service type in the info
column. This makes it easier to find specific service calls in huge capture
files.

svn path=/trunk/; revision=35119
 2010-12-04 02:54:59 +00:00
Jeff Morriss 4f6ea6ef47 From Gerhard Gappmeier via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5427 : 
This patch adds support for dissecting all Extension Objects types defined by
the OPC Foundation.

svn path=/trunk/; revision=35118
 2010-12-04 02:54:25 +00:00
Anders Broman a06eef00b8 From Gerhard Gappmeier: 
Fix mapping of datatype strings in opcua plugin
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5428

svn path=/trunk/; revision=35105
 2010-12-02 20:44:18 +00:00
Anders Broman dd43cbec82 From Robert Groenenberg: 
Assert when using ASN.1 dissector with loading a 'type table'
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5447

svn path=/trunk/; revision=35055
 2010-11-28 21:03:43 +00:00
Jaap Keuter b1914ff4df Fix for bug 5435: 
Add support for dissecting SLL type 0x17 frames.

svn path=/trunk/; revision=35029
 2010-11-25 19:59:19 +00:00