Commit Graph

27704 Commits

Author SHA1 Message Date
Anders Broman 3a11073d6b Get info about media type(Video or not) a first step towards usage in rtp statistics.
svn path=/trunk/; revision=28415
2009-05-19 18:42:33 +00:00
Stig Bjørlykke af7304aa79 Move pd variables outside HAVE_LIBGCRYPT.
svn path=/trunk/; revision=28414
2009-05-19 18:28:24 +00:00
Martin Mathieson 8315e941ac Add a few more missing ROHC RTP fields.
svn path=/trunk/; revision=28413
2009-05-19 17:26:14 +00:00
Stig Bjørlykke fc3f1b5283 From Artem Tamazov (bug 3472):
Save/Restore pinfo->private_data when used.

svn path=/trunk/; revision=28412
2009-05-19 17:16:14 +00:00
Bill Meier 79e537af33 expert_comp: Fix some memory leaks (several non-trivial);
Fix hack wherein a ptr was stored using the address of an int (could cause Win64 crash ?)
  Use consistent indentation;

svn path=/trunk/; revision=28410
2009-05-19 15:53:26 +00:00
Stig Bjørlykke 1d54e7ad56 Avoid crash when not reassembling multiple TCP segments.
(check for valid pointers, in this case: ndmp_conv_data->task)

This fixes the crash in bug #3470.

svn path=/trunk/; revision=28409
2009-05-19 14:40:23 +00:00
Jaap Keuter 95dfe6a326 Update IP protocol numbers according to current IANA registery.
svn path=/trunk/; revision=28408
2009-05-19 07:34:33 +00:00
Gerald Combs 61d2248b3f Use the xhtml stylesheet to generate the release notes instead of the
html stylesheet. This makes xsltproc use utf-8 instead of iso-8859-1.

svn path=/trunk/; revision=28407
2009-05-19 01:26:06 +00:00
Gerald Combs d797045341 From Abhik Sarkar via bug 3242:
Add a UAT for custom HTTP header fields.
  
From me:

  Use se_alloc0 to initialize a struct. Use g_strdup(...) instead of
  g_strdup_printf("%s"...). Add a missing UAT_END_FIELDS.

svn path=/trunk/; revision=28406
2009-05-19 00:17:23 +00:00
Bill Meier b65b001476 prefs_column: fix a small memory leak.
svn path=/trunk/; revision=28403
2009-05-18 22:21:16 +00:00
Stig Bjørlykke 4d3a7aa966 Use g_strdup_printf() instead of g_snprintf() with a fixed buffer.
svn path=/trunk/; revision=28402
2009-05-18 22:01:19 +00:00
Stig Bjørlykke cfde6d67df Fix a small memory leak.
svn path=/trunk/; revision=28401
2009-05-18 21:48:48 +00:00
Bill Meier 7b6265b63e pixmap_save: fix a small memory leak.
svn path=/trunk/; revision=28400
2009-05-18 21:42:09 +00:00
Bill Meier 5daf89e386 mtp3_summary: fix a small memory leak.
svn path=/trunk/; revision=28399
2009-05-18 21:23:24 +00:00
Bill Meier 0608bff3c2 prefs_capture: Interface Options Edit dialog: code cleanup;
- Fix typo which caused Properties|Descriptions value field to be incorrectly right-justified;
- Fix several (small) memory leaks;
- Rename variables & rework comments: What was a clist was replaced by a treeview/liststore;
- Remove a left-over line of code still calling a gtk_clist function;
- Rename some constants and variables to more closely reflect usage;
- Add some defensive coding; 
- Use gtk_combo_box_get_active_text if GTK+ is 2.6 or greater;
- Simplify code in several places;
- Use consistent indentation;

svn path=/trunk/; revision=28398
2009-05-18 20:57:06 +00:00
Gerald Combs def3068154 Use se_alloc0 and ep_alloc0.
svn path=/trunk/; revision=28397
2009-05-18 20:30:55 +00:00
Gerald Combs 79c4c2990b Remove unnecessary tree checks pointed out by Stig.
svn path=/trunk/; revision=28396
2009-05-18 19:14:21 +00:00
Guy Harris a9f463bee4 Clean up indentation.
svn path=/trunk/; revision=28395
2009-05-18 17:47:42 +00:00
Gerald Combs 23d52583ca From Yaniv Kaul via bug 3215:
Attached please find a patch that enables to heuristically find VNC
traffic on non-standard ports.

(it also adds some if(tree) ... around some proto_tree_add_item()
functions)

svn path=/trunk/; revision=28394
2009-05-18 17:23:16 +00:00
Anders Broman 25329d1427 Don't skipp the first entry.
svn path=/trunk/; revision=28393
2009-05-18 16:43:48 +00:00
Jaap Keuter b118290a6b From David Aggeler:
Not much, just a little bit of fine tuning:
- Spelling
- Added expert_add_info() for status responses with warning & error level
- Added command details in info column (optionally)

Also plugging memory leak.

svn path=/trunk/; revision=28392
2009-05-18 06:21:22 +00:00
Jaap Keuter 1161738146 Add Jens Steinhauser.
svn path=/trunk/; revision=28391
2009-05-18 05:29:24 +00:00
Guy Harris 19a74e6fcc Just use proto_tree_add_item() for some fields whose values we don't
use.

Rename some variables to reflect the names they have in the IGRP
document.

Don't treat being called with a non-IPv4 address as a dissector bug - we
can't prevent ourselves from being called from the IPv6 dissector.  This
fixes bug 3466.

Clean up indentation.

svn path=/trunk/; revision=28390
2009-05-18 00:27:44 +00:00
Guy Harris 9b3360c5ef Add a URL on the Cisco site describing IGRP packets.
svn path=/trunk/; revision=28389
2009-05-17 22:25:13 +00:00
Gerald Combs 82b0574415 From Márton Németh via bug 2137:
Currently the randpkt random packet generator does not have support to
generate WTAP_ENCAP_USB and WTAP_ENCAP_USB_LINUX type packets.

svn path=/trunk/; revision=28388
2009-05-17 21:41:23 +00:00
Martin Mathieson 09d545038d Add newline to end of file
svn path=/trunk/; revision=28387
2009-05-17 21:41:00 +00:00
Gerald Combs 2dacd2ff63 From Roland Illig via bug 1764:
The hexdump of the "Follow TCP Stream" feature creates a file that is about 160
characters wide. That's far beyond the size of my screen. The appended patch
suggests a narrower layout.

From me:

Add a note about prepending each line with "C" or "S" instead.

svn path=/trunk/; revision=28386
2009-05-17 19:34:30 +00:00
Gerald Combs 7ea5c3cba7 From Johannes Berg via bug 3415:
The attached patch updates wireshark to the radiotap RX flags leaving the
non-standard option to dissect bit 14 as "FCS in header".

Merge the patch by hand in a couple of places to avoid conflicts with
r26861.

svn path=/trunk/; revision=28385
2009-05-17 19:18:18 +00:00
Gerald Combs a5f53652c6 From Andreas Heise via bug 3357: Allow spaces in VERSION_EXTRA.
svn path=/trunk/; revision=28384
2009-05-17 18:46:50 +00:00
Gerald Combs 169d8cb394 From Didier Gautheron via bug 3210:
This patch improves the decoding of MapID and MapName Apple's AFP commands for
subtype 5 and 6.

svn path=/trunk/; revision=28383
2009-05-17 18:30:04 +00:00
Gerald Combs 9a76c35676 [Automatic manuf and enterprise-numbers update for 2009-05-17]
svn path=/trunk/; revision=28381
2009-05-17 15:03:39 +00:00
Jaap Keuter b429593171 Remove C++ style comments.
Cleanup indentation a bit.

svn path=/trunk/; revision=28380
2009-05-17 06:02:48 +00:00
Stig Bjørlykke c47e788c94 Regenerate all asn2wrs generated dissectors.
svn path=/trunk/; revision=28379
2009-05-16 22:07:03 +00:00
Stig Bjørlykke b4f4444202 Copy optimization changes to ASN.1 sources.
svn path=/trunk/; revision=28378
2009-05-16 22:03:05 +00:00
Stig Bjørlykke cbcd176043 Improved name and abbrev used for sequence of and set of elements.
svn path=/trunk/; revision=28377
2009-05-16 22:01:19 +00:00
Jörg Mayer 1922d3ceee Jochen Bartl <jochen.bartl@gmail.com>
via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2824

I have added the SCM header to the wlccp dissector. This header is present in
packets of base message type 0x01. You can find the specification in the
following document, when you search for "The table below shows the fields for
an SCM Advertisement Reply Message.":

http://www.freepatentsonline.com/y2005/0220054.html

It seems like the header structure in the document is wrong regarding the "SCM
Node ID" (MAC address) field. From looking at the hexdumps I found out that the
node id shows up in the header before the "Instance Age" field. There is also a
2 byte field between the node id and the instance age, which is always zero. I
have named this field  wlccp.scm_unknown_short, because I don't know what it is
for.

Me:

Fix two bugs that came up during testing but were present before the patch,
both involving wrong length handling triggering dissector assert and malformed
packet messages.



svn path=/trunk/; revision=28376
2009-05-16 16:31:54 +00:00
Anders Broman 0f9c96f8fd From Chidambaram Arunachalam:
SIP Patch to include support for Max-Breadth, Answer-Mode, Priv-Answer-Mode, Trigger-Consent and Permission Missing headers
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3463

svn path=/trunk/; revision=28375
2009-05-16 09:16:11 +00:00
Anders Broman ea4f4f08af Froim Vincent Helfre:
Fix issues with unaligned PER.

svn path=/trunk/; revision=28374
2009-05-15 18:39:33 +00:00
Anders Broman 1464f7ca84 Introduce decode_bits_in_field() and use it.
clean up some left owers from previous checkin.

svn path=/trunk/; revision=28373
2009-05-15 18:38:13 +00:00
Gerald Combs 54cfb39143 Prep for 1.2.0rc1.
svn path=/trunk/; revision=28372
2009-05-15 18:27:25 +00:00
Martin Mathieson 7ed080da5c Timing advance command is 6 bits.
svn path=/trunk/; revision=28371
2009-05-15 10:02:14 +00:00
Jörg Mayer ced7569727 Rename an CCX IE
svn path=/trunk/; revision=28370
2009-05-15 06:51:58 +00:00
Jörg Mayer 7bbfa31856 - All Frames that I currently know how to dissect include the FCS
- Decode Channel and (what probably is the) Timestamp

svn path=/trunk/; revision=28369
2009-05-15 06:48:25 +00:00
Jaap Keuter 88bf6d140f Update standards version.
svn path=/trunk/; revision=28368
2009-05-15 04:55:27 +00:00
Gerald Combs 93471e8eeb Remove an unused variable.
svn path=/trunk/; revision=28367
2009-05-15 00:07:10 +00:00
Gerald Combs 9a72434b1e Add support for process flow records to IPFIX, which required adding
support for vendor-specific IEs. Fix variable-length record handling. Add
conversation tracking to the UDP dissector and add process flow
information to TCP and UDP conversations.

This lets us run process flow collectors on one or more machines and
have the process username, PID, command name, etc. show up in the TCP
and UDP protocol trees.

svn path=/trunk/; revision=28366
2009-05-14 23:33:17 +00:00
Anders Broman bec2875b2b Apply some of the patches from:
http://wiki.wireshark.org/Development/Optimization

svn path=/trunk/; revision=28365
2009-05-14 20:12:43 +00:00
Anders Broman 64a33ad7af Apply some of the patches from:
http://wiki.wireshark.org/Development/Optimization

svn path=/trunk/; revision=28364
2009-05-14 20:04:28 +00:00
Anders Broman 4ec2c4ff47 Apply some of the patches from:
http://wiki.wireshark.org/Development/Optimization

svn path=/trunk/; revision=28363
2009-05-14 19:28:07 +00:00
Anders Broman 5f538e901d Apply some of the patches from:
http://wiki.wireshark.org/Development/Optimization

svn path=/trunk/; revision=28362
2009-05-14 19:11:43 +00:00