osmocom
/
wireshark
11
0
Fork 1
Code Issues Pull Requests Projects Releases Wiki Activity
78,793 Commits 26 Branches 0 Tags 795 MiB
Commit Graph

184 Commits

Author SHA1 Message Date
Martin Kaiser 47a8a496f1 fix 
packet-bssgp.c: In function 'de_bssgp_unconfim_send_state_var':
packet-bssgp.c:3318:13: error: variable 'state_var' set but not used [-Werror=unused-but-set-variable]


svn path=/trunk/; revision=48095
 2013-03-05 20:17:29 +00:00
Anders Broman f6ce72ee04 From Joseph Chai: 
Add aditional IE dissection.
From me patch cleanup and add set fence for multiple DTAP messages in one frame.

svn path=/trunk/; revision=48087
 2013-03-05 17:38:44 +00:00
Anders Broman a3ef2a7293 Fix bit_offset. 
svn path=/trunk/; revision=47637
 2013-02-11 17:39:52 +00:00
Pascal Quantin ae61fe0158 Try to fix dissection of GSM protocol family broken by r47209. 
Using val_to_str seemed to be a good idea, but most value_string arrays were not properly filled or were using hacks.
(I hope I got everything right...)


svn path=/trunk/; revision=47218
 2013-01-22 23:25:44 +00:00
Bill Meier c230713b57 Fix several [-Wshadow] warnings; 
Also: Do some minor whitespace and formatting changes.
-This line, and those below, will be ignored--

M    dissectors/packet-bootp.c
M    dissectors/packet-bssgp.c
M    dissectors/packet-babel.c

svn path=/trunk/; revision=46191
 2012-11-25 23:16:30 +00:00
Martin Kaiser 6b3bfa5507 fix 
/home/wireshark/builders/trunk/ubuntu1204x64/build/epan/dissectors/packet-bssgp.c: In function de_bssgp_son_transfer_app_id:
/home/wireshark/builders/trunk/ubuntu1204x64/build/epan/dissectors/packet-bssgp.c:3173:12: error: variable next_tvb set but not used
[-Werror=unused-but-set-variable]
cc1: all warnings being treated as errors


svn path=/trunk/; revision=46125
 2012-11-21 22:20:22 +00:00
Guy Harris 715065609b Clean up white space (no tabs). 
svn path=/trunk/; revision=46120
 2012-11-21 21:09:32 +00:00
Guy Harris 6c6b37cada The previous change means the "len" argument is now being used. 
svn path=/trunk/; revision=46113
 2012-11-21 18:13:51 +00:00
Anders Broman 66c80c0f60 From l.wachowski: 
Allign the tables for dissection.
From me try to fix the dissection of SONtransferApplicationIdentity_PDU.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8008

svn path=/trunk/; revision=46111
 2012-11-21 17:59:19 +00:00
Anders Broman 66c34f3c7b From l.wachowski: 
- In de_bssgp_pdu_in_error() use current_offset isof 0.
- in function de_bssgp_ran_inf_error_rim_cont. Error rim
container doesn't have field rim sequence number. This field exists in the rest
of containers but not in this one. So I have removed this field. 
In this function we have field pdu in error and this field is mandatory, not
optional

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8000

svn path=/trunk/; revision=46081
 2012-11-19 18:59:09 +00:00
Jeff Morriss 2552c750e5 We always HAVE_CONFIG_H so don't bother checking whether we have it or not. 
svn path=/trunk/; revision=45017
 2012-09-20 02:03:38 +00:00
Jakub Zawadzki 5a8783f5b1 Initial commit to support yet another method of passing data between dissectors. 
Add new parameter 'data' to heur_dissector_t and new_dissector_t, for now it's always NULL

svn path=/trunk/; revision=44860
 2012-09-10 21:40:21 +00:00
Jakub Zawadzki b18e880040 Update FSF address - part II. 
svn path=/trunk/; revision=43538
 2012-06-28 23:18:38 +00:00
pascal 0ba1ab2909 Display Element ID in hexadecimal (like in 3GPP specs) 
Display EPS bearer ID in decimal

svn path=/trunk/; revision=42755
 2012-05-21 19:27:38 +00:00
Alexis La Goutte 342c647ed4 Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang 
svn path=/trunk/; revision=41466
 2012-03-10 17:48:33 +00:00
Anders Broman 0a7df4d63c Use tce correct IE id 
svn path=/trunk/; revision=41043
 2012-02-16 20:23:16 +00:00
Chris Maynard c2208aa172 Fix some duplicate display filter names. 
svn path=/trunk/; revision=40586
 2012-01-19 19:15:13 +00:00
Anders Broman 27f95726b3 Try to get the container stuff right... 
svn path=/trunk/; revision=40119
 2011-12-08 21:17:03 +00:00
Anders Broman 28f7d63c58 Dissect RIM related IEs 
svn path=/trunk/; revision=39740
 2011-11-06 08:18:26 +00:00
Bill Meier c4b63360dc Fix proto_tree_add_item( encoding args; 
Do whitespace cleanup (for a few files).

svn path=/trunk/; revision=39640
 2011-10-27 20:30:38 +00:00
Bill Meier 94f36ca4ff Use ENC_NA as encoding for proto_tree_add_item() calls which directly reference an hf item (in hf[] with types: 
FT_NONE
   FT_BYTES
   FT_IPV6
   FT_IPXNET
   FT_OID

Note: Encoding field set to ENC_NA only if the field was previously TRUE|FALSE|ENC_LITTLE_ENDIAN|ENC_BIG_ENDIAN

svn path=/trunk/; revision=39260
 2011-10-04 22:44:31 +00:00
Anders Broman 6eae60aa2f From Yaniv Kaul: 
Fix 'set but not used' errors that GCC 4.6 emits.

svn path=/trunk/; revision=36874
 2011-04-26 20:24:53 +00:00
Bill Meier 91991145de Don't assign to a proto_item * if the value won't be used: Coverity 858; 
Fix two cases where items appear to be added to the wrong tree: Coverioty 856 & 857.
Also: remove some unneeded #includes& do some whitespace cleanup.

svn path=/trunk/; revision=36473
 2011-04-05 15:33:56 +00:00
Anders Broman aaf0d277b8 Get rid of gsm_a_dtap_pinfo. 
svn path=/trunk/; revision=36444
 2011-04-04 14:49:14 +00:00
Anders Broman 8d6ca293dc Change the signature of elem_fcn():ns to include pinfo. 
svn path=/trunk/; revision=36443
 2011-04-04 14:37:25 +00:00
Anders Broman 72b69aeaf5 Change the msg_fcn() signature to include pinfo. 
svn path=/trunk/; revision=36441
 2011-04-04 07:45:34 +00:00
Stig Bjørlykke c9468a80be Added some missing breaks. 
Coverity 443 & 444.

svn path=/trunk/; revision=36361
 2011-03-27 13:40:54 +00:00
Anders Broman 23400cd7a3 Add dissection of 
- MBMS-SESSION-STOP-REQUEST
- MBMS-SESSION-STOP-RESPONSE
- MBMS-SESSION-UPDATE-REQUEST
- MBMS-SESSION-UPDATE-RESPONSE
- PS-HANDOVER-COMPLETE
- PS-HANDOVER-CANCEL
- PS-HANDOVER-COMPLETE-ACK

svn path=/trunk/; revision=36195
 2011-03-15 06:03:58 +00:00
Anders Broman 338f238746 Add dissection of 
- MBMS-SESSION-START-REQUEST
- MBMS-SESSION-START-RESPONSE

svn path=/trunk/; revision=36186
 2011-03-14 07:15:25 +00:00
Anders Broman 840b816f05 Remove more obsolete code. 
svn path=/trunk/; revision=36154
 2011-03-07 11:56:21 +00:00
Anders Broman 6c47c809ef Fix packet-bssgp.c:125: warning: 'hf_bssgp_tmsi_ptmsi' defined but not used 
svn path=/trunk/; revision=36153
 2011-03-07 10:01:24 +00:00
Anders Broman a7e379499d Remove the old code. 
svn path=/trunk/; revision=36152
 2011-03-07 09:36:24 +00:00
Anders Broman b4941ca580 Prepare to remove old bssgp code by changing exports. 
svn path=/trunk/; revision=36142
 2011-03-06 09:42:41 +00:00
Anders Broman 7e17176c39 All messages converted to the "GSM style" dissection. 
svn path=/trunk/; revision=36137
 2011-03-04 12:57:55 +00:00
Anders Broman a469849210 From Pascal Quantin: 
[3GPP protocols] Prettify the display of Mandatory Value information elements

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5711

svn path=/trunk/; revision=36026
 2011-02-22 11:56:10 +00:00
Jeff Morriss 34dc101fcb #if out some (currently) unused functions. 
svn path=/trunk/; revision=36000
 2011-02-18 17:38:46 +00:00
Anders Broman 29ddaec6a6 Add more MSG dissection. 
svn path=/trunk/; revision=35998
 2011-02-18 07:00:03 +00:00
Gerald Combs dae5200002 Fix some Visual C++ analysis warnings. 
svn path=/trunk/; revision=35988
 2011-02-17 23:00:34 +00:00
Anders Broman daf631cce8 packet-bssgp.c:10020: warning: 'bssgp_perform_loc_response' defined but not used 
svn path=/trunk/; revision=35738
 2011-01-31 23:00:11 +00:00
Anders Broman 882874e91c More IE dissection. 
svn path=/trunk/; revision=35736
 2011-01-31 22:25:19 +00:00
Anders Broman 7a78a180c7 Dissect more IE's in PERFORM-LOCATION-REQUEST. 
svn path=/trunk/; revision=35721
 2011-01-31 15:16:45 +00:00
Guy Harris 0e2361fdb8 Clean up white space. 
Use the bssgp_perform_loc_request() routine for PERFORM-LOCATION-REQUEST
(fixes a "defined, but not used" warning).

svn path=/trunk/; revision=35714
 2011-01-31 00:12:21 +00:00
Anders Broman f4fad72618 Add more MSG dissection. 
svn path=/trunk/; revision=35707
 2011-01-30 22:08:22 +00:00
Anders Broman 7e77c162b0 Fix a typo and prettify some printouts. 
svn path=/trunk/; revision=35677
 2011-01-27 11:23:22 +00:00
Stephen Fisher 53fec4ae34 Fix compilation errors 
svn path=/trunk/; revision=35673
 2011-01-26 23:11:08 +00:00
Anders Broman 68f4f61017 Dissect PS-HANDOVER-REQUEST. 
svn path=/trunk/; revision=35666
 2011-01-26 19:44:23 +00:00
Gerald Combs 73a08a9b17 Fix gcc compilation. 
svn path=/trunk/; revision=35650
 2011-01-25 18:43:43 +00:00
Anders Broman 43ba2ecef7 Switch more messages over to the "gsm dissector style". 
svn path=/trunk/; revision=35649
 2011-01-25 16:41:59 +00:00
Anders Broman feea97e6aa packet-bssgp.c:6916: warning: 'bssgp_tree' may be used uninitialized in this function 
svn path=/trunk/; revision=35581
 2011-01-19 09:49:36 +00:00
Anders Broman 3c491eee6b Cleaned up splitt between old and new dissection style. 
A lot of conversion still needed.

svn path=/trunk/; revision=35580
 2011-01-19 09:35:34 +00:00
Bill Meier 8d272fb165 (Until Anders comletes work): use #if 0 instead of //; init a variable; 
svn path=/trunk/; revision=35571
 2011-01-17 16:51:31 +00:00
Jeff Morriss b2c0cfa9dd Move assignment of 'oct' outside of if(tree)--it is used outside of the if block. 
svn path=/trunk/; revision=35550
 2011-01-16 04:38:59 +00:00
Anders Broman 1f19cd8f1b Comitting work in progress to fix the linking problem. 
>Linking fails now:
>epan/.libs/libwireshark.so: undefined reference to `hf_bssgp_elem_id'
>epan/.libs/libwireshark.so: undefined reference to `bssgp_elem_fcn'
>epan/.libs/libwireshark.so: undefined reference to `ett_bssgp_elem'
>epan/.libs/libwireshark.so: undefined reference to >`bssgp_elem_strings'
>Did you miss packet-bssgp.c in that commit?

I'll try to clean this up in the next few days.

svn path=/trunk/; revision=35544
 2011-01-15 23:13:28 +00:00
Anders Broman f01cbcd296 Add cause values. 
svn path=/trunk/; revision=34685
 2010-10-29 15:19:47 +00:00
Bill Meier 05168e614f Access several large value-string arrays via extended value-string functions. 
svn path=/trunk/; revision=34501
 2010-10-13 18:51:23 +00:00
Bill Meier e7568712ef Define some fcns & vars as static; 
Minor whitespace and comments cleanup.

svn path=/trunk/; revision=34477
 2010-10-11 19:00:55 +00:00
Anders Broman d7e6928096 Add PDUs to value_string. 
svn path=/trunk/; revision=34266
 2010-09-27 20:09:08 +00:00
Anders Broman 21aa009150 From Holger Freyther: 
Cosmetic patch to fix Optional/Conditional mismatch.

svn path=/trunk/; revision=33226
 2010-06-15 13:36:11 +00:00
Guy Harris 1b444c55fd Refer to the endianness arguments as "encoding" rather than 
"representation" - we already use "representation" to refer to the text
representation of fields.

Change some routines with an endianness argument to make it a
representation argument instead; 

svn path=/trunk/; revision=32929
 2010-05-24 06:06:17 +00:00
Guy Harris 67c095e188 Use REP_BIG_ENDIAN for integral data types not already using REP_ 
(they're one-byte, so the byte order is irrelevant, but it's probably a
bit cleaner to use REP_*_ENDIAN for all integral data types), and REP_NA
for the top-level protocol item.

svn path=/trunk/; revision=32924
 2010-05-24 02:54:08 +00:00
Guy Harris 313b3edf0a Get rid of private byte-order definition. The definition didn't match 
the name - a non-zero last argument to proto_tree_add_item(), such as
TRUE or REP_LITTLE_ENDIAN, means "little-endian", and a zero argument,
such as FALSE or REP_BIG_ENDIAN, means "big-endian"; at least as I read
the spec, little-endian is correct, but the wrong definition's been used
for a while, so we'll use REP_BIG_ENDIAN.

svn path=/trunk/; revision=32923
 2010-05-24 02:28:16 +00:00
Anders Broman 447faa6082 From Mike Morrin: 
Dissection of BSSMAP IEs: Old BSS to New BSS Info and New BSS to Old BSS Info
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4712

svn path=/trunk/; revision=32606
 2010-04-29 20:45:53 +00:00
Bill Meier 055dd62063 #include <string.h> not needed. 
svn path=/trunk/; revision=32410
 2010-04-06 21:14:01 +00:00
Bill Meier 09764dd969 Remove unneeded #include <stdio.h> 
svn path=/trunk/; revision=32367
 2010-04-03 21:55:23 +00:00
Stig Bjørlykke 86a6a0c2a4 Use a more correct length for hf_bssgp_ie_type and hf_bssgp_bvci, 
to try fixing a buildbot run-randpkt failure.

svn path=/trunk/; revision=31509
 2010-01-12 21:25:35 +00:00
Gerasimos Dimitriadis 18d299b758 - Replaced get_start_octet() with a right shift 
- Deleted function bssgp_tvb_get_bits8(), uses tvbuff counterpart now
- guint32 vars should be enough for bit offsets

svn path=/trunk/; revision=30963
 2009-11-14 21:15:38 +00:00
Anders Broman f8a37ac1d6 Make it possible to use bssgp.tlli as custom column. 
Remove COL_BSSGP_TLLI and CHECK_COL.

svn path=/trunk/; revision=29543
 2009-08-24 20:54:25 +00:00
Kovarththanan Rajaratnam 8b515e9340 Switch a bunch of dissectors over to using tvb_new_subset_remaining() 
svn path=/trunk/; revision=29446
 2009-08-16 12:36:22 +00:00
Kovarththanan Rajaratnam 0a5b014cec Don't guard col_clear with col_check 
svn path=/trunk/; revision=29344
 2009-08-09 07:36:13 +00:00
Kovarththanan Rajaratnam e971354a54 Don't guard col_set_str (COL_PROTOCOL) with col_check 
svn path=/trunk/; revision=29340
 2009-08-09 06:26:46 +00:00
Stig Bjørlykke b228488bc0 From Kovarththanan Rajaratnam via bug 3548: 
(1) Trailing/leading spaces are removed from 'name's/'blurb's
(2) Duplicate 'blurb's are replaced with NULL
(3) Empty ("") 'blurb's are replaced with NULL
(4) BASE_NONE, NULL, 0x0 are used for 'display', 'strings' and 'bitmask' fields
    for FT_NONE, FT_BYTES, FT_IPv4, FT_IPv6, FT_ABSOLUTE_TIME, FT_RELATIVE_TIME,
    FT_PROTOCOL, FT_STRING and FT_STRINGZ field types
(5) Only allow non-zero value for 'display' if 'bitmask' is non-zero

svn path=/trunk/; revision=28770
 2009-06-18 21:30:42 +00:00
Jaap Keuter 88d9e0f55f From Reinhard Speyerer: 
This patch fixes several misspellings/typos in Wireshark SVN revision 28201.

svn path=/trunk/; revision=28209
 2009-05-01 07:06:17 +00:00
Bill Meier f68d3d46fe Fix some indentation .... 
svn path=/trunk/; revision=27310
 2009-01-27 18:09:50 +00:00
Bill Meier c544c20956 Fix various typos and spelling errors (mostly in text strings) 
svn path=/trunk/; revision=27050
 2008-12-18 19:08:49 +00:00
Bill Meier a8f30cbca1 Fix some typos and spelling (mostly in text strings) 
svn path=/trunk/; revision=27037
 2008-12-17 17:23:37 +00:00
Bill Meier 33c99f44fd Fix typos and spelling (mostly in text strings) 
svn path=/trunk/; revision=27028
 2008-12-17 00:08:38 +00:00
Jaap Keuter e7ca77a5cc Fix for bug 3085: 
Correct interpretation of QoS T-bit.

svn path=/trunk/; revision=26908
 2008-12-03 07:08:33 +00:00
Stig Bjørlykke d0e33bc3c5 Fix some "format not a string literal and no format arguments" warnings. 
svn path=/trunk/; revision=26646
 2008-10-31 14:07:23 +00:00
Anders Broman d1ea868c27 Bucket Leak Rate decoded incorrectly as bytes instead of bits 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2849

svn path=/trunk/; revision=26147
 2008-09-06 11:45:08 +00:00
Bill Meier b52d95d591 #include <emem.h> not req'd 
svn path=/trunk/; revision=26091
 2008-08-26 01:28:50 +00:00
Bill Meier acbbc43f2e Remove unnecessary registration of a prefs callback & do minor cleanup 
svn path=/trunk/; revision=26078
 2008-08-25 18:37:18 +00:00
Anders Broman 96aa45646d First step to split the gsm_a dissector into several smaller ones ( done by Neil Piercy) 
rename the "old" one to gsm_a_common.

svn path=/trunk/; revision=25915
 2008-08-04 16:11:17 +00:00
Stig Bjørlykke cb43c90778 Renamed a local variable to avoid name collisions. 
svn path=/trunk/; revision=25561
 2008-06-23 21:34:40 +00:00
Anders Broman 2e0c1810e7 Fix some of the Errors/warnings detected by checkapi. 
svn path=/trunk/; revision=25294
 2008-05-14 07:35:52 +00:00
Anders Broman 1950ffc214 Apply the small performance enhancment patches for: 
- if offset is 0, tvb_length is the same as tvb_length_remaining, just faster.
Replace 
- col_append_fstr() with faster  col_append_str() 
- col_add_str() with col_set_str()
when it's safe

svn path=/trunk/; revision=23252
 2007-10-23 05:50:00 +00:00
Anders Broman 8f3a0cb862 BSSGP.TLLI is not recognized properly in filter 
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1384

svn path=/trunk/; revision=22777
 2007-09-03 16:39:07 +00:00
Jeff Morriss 794a933a2c Change "lenght" to "length" and "decypt" to "decrypt" 
svn path=/trunk/; revision=22356
 2007-07-19 13:05:39 +00:00
Guy Harris e62e5e3b25 There's more than one IE table; instead of fixing up all the IE tables 
with default IE names, have bssgp_proto_tree_add_ie() use val_to_str()
if the IE table doesn't have an IE name.

Don't use the IE name as a format; use "%s" as the format, and the IE
name as the argument.  (That more clearly states what's being done.)

svn path=/trunk/; revision=21837
 2007-05-19 21:22:05 +00:00
Anders Broman b688f9154a Split tvb_get_bits64 into tvb_get_bits8 tvb_get_bits16 tvb_get_bits32 and tvb_get_bits64 
and use them in proto_tree_add_bits_ret_val().

svn path=/trunk/; revision=21828
 2007-05-18 16:46:35 +00:00
Guy Harris 1bc049906a Add some GCC warnings to the standard set, and add some others to the 
--enable-extra-gcc-checks set.

If we turn on -pedantic, try turning on -Wno-long-long as well, so that
it's not *so* pedantic that it rejects the 64-bit integral data types
that we explicitly require.

Constify a bunch of stuff, and make some other changes, to get rid of
warnings.

Clean up some indentation.

svn path=/trunk/; revision=21526
 2007-04-23 10:59:26 +00:00
Ronnie Sahlberg 0294198960 Remove a compiler warning by #if 0 out a function that is not called. 
The function is referenced from a comment which is why it was #ifed out instead of just deleted.


svn path=/trunk/; revision=21108
 2007-03-22 08:03:44 +00:00
Anders Broman 33c97b6a1f Get rid of yet another printout that does not go well with optional IE:s 
svn path=/trunk/; revision=20884
 2007-02-20 22:12:54 +00:00
Anders Broman fd3aa71e67 Test before comitting... 
svn path=/trunk/; revision=20883
 2007-02-20 21:58:30 +00:00
Anders Broman 0c0367bfa1 Fix a typo and some reported compiler warnings(hopefully). 
svn path=/trunk/; revision=20879
 2007-02-20 19:40:14 +00:00
Bill Meier 103bf29730 Continuing the tradition: squelch some compiler warnings .... 
svn path=/trunk/; revision=20866
 2007-02-19 22:29:23 +00:00
Anders Broman f30812691b Fix the bugs part of http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1371. 
- a typor in in hf_bssgp_ie_type
- id def out debug code.

svn path=/trunk/; revision=20821
 2007-02-16 06:54:32 +00:00
Anders Broman 6c9ce8acf8 Froim Rene Pilz: 
This patch consists also the last issues. Additionally it solves:
- For the SSCOP frames the AAL5 decoding was not performed due to an earlier patch. This caused that no SSCOP message was properly decoded.
- As the detection between a LANE frame and a SSCOP frame is rather hard a switch within the atm dissector is included which enforce SSCOP dissecting over a LANE frame. At the moment I do not see a better solution for that.

svn path=/trunk/; revision=20013
 2006-11-29 06:44:07 +00:00
Anders Broman 65267d932f Do some more of the relase 6 stuff. 
svn path=/trunk/; revision=19056
 2006-08-27 20:30:01 +00:00
Anders Broman 0bcced5d2e BSSGP: Wrong length on IE and preparation to export IE dissection. 
GSM_a: Add an if_def
GTP: Update comments

svn path=/trunk/; revision=19019
 2006-08-24 21:19:49 +00:00
Anders Broman e9a4ce8196 Decode PDU Type Extension. 
svn path=/trunk/; revision=18731
 2006-07-13 20:13:35 +00:00