In rare circumstances where port numbers are reused and sequence
numbers are lower in the later conversations, disabling TCP
sequence numbers analysis while enabling out-of-order reassembly
was leading to reassembly inconsistency. Closes#15096.
If there is DCP SET block with 0 block length, it is dissected
as erroneous block since DCP SET block can not have 0 block
length. Moreover, DCPBlockLength is not decoded if DCP option
and suboption is 0. However, each DCP block must have
Option/Suboption/DCPBlockLength. This is also fixed.
There's no reason to limit the tvb offset input parameter of this CRC8
function to a guint8, particularly now that the User Packet CRCs
later in the Base Band Frame are being checked.
Since the gssapi handler can cope fine with ntlm blobs, remove the
heuristic in ntlmssp and call the gssapi dissector directly. In turn
we get kerberos support, including decpryption with keytab etc.
When there are more packets on the stream after credssp, like tpkt-rpd
data, the credssp heuristics fails when invoked by tls and then even the
packets for which the credssp heuristics succeeded do not get dissected
as credssp but as tpkt-continuation data.
To work around that, call the credssp heuristic dissector directly from
the rdp dissector before trying fastpath.
Leave the credssp heursitics in TLS for other protocols such as HTTP
where it may work.
packet-rtps-processed.c:321:13: warning: Value stored to 'offset' is never read [deadcode.DeadStores]
packet-rtps-processed.c:349:13: warning: Value stored to 'offset' is never read [deadcode.DeadStores]
packet-rtps-processed.c:356:9: warning: Value stored to 'offset' is never read [deadcode.DeadStores]
packet-rtps-virtual-transport.c:946:17: warning: Value stored to 'offset' is never read [deadcode.DeadStores]
packet-rtps-virtual-transport.c:995:5: warning: Value stored to 'offset' is never read [deadcode.DeadStores]
Add section about common regex pitfalls and correct some examples.
Also add a more information about the string field type, including
an explanation of byte escape sequences.
Ping #15716.
Use wsApp->setLastOpenDirFromFilename() to convert a filename
to a directory name before calling wsApp->setLastOpenDir().
This will ensure to always store a directory instead of a filename
in the recent gui.fileopen_remembered_dir.
Add a generic function to write content to file. Use this on write
TLS session keys from UI and tshark, and for export objects.
Remove the now unused export_object_ui.[ch].
__VERSION__ is copied from GCC, clang has __clang_version__.
Apparently clang's __VERSION__ already includes the name:
Compiled (64-bit) using clang Clang 11.1.0
Gtker