Commit Graph

7418 Commits

Author SHA1 Message Date
Anders Broman a76efadf0c Get correct value for bitstrings.
svn path=/trunk/; revision=22784
2007-09-04 16:57:07 +00:00
Anders Broman f7bed80d57 ANSI MAP systemMyTypeCode should be OPTIONAL
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1820

svn path=/trunk/; revision=22783
2007-09-04 16:55:48 +00:00
Jaap Keuter 970f34a557 From Munenori Ohuchi:
This patch adds a new feature to dissect HSRPv2 packets.

One of the main features of HSRPv2 can enable using HSRP on IPv6. In order to
achieve this new feature, HSRPv2 packet format is totally different from
HSRPv1. HSRPv2 introduces new TLV formats.

This patch can decode these new formats of HSPRv2.

svn path=/trunk/; revision=22781
2007-09-04 06:55:52 +00:00
Anders Broman 8f1d357618 From Stas Maximov:
RTP analysis' jitter values are thrown off by RTP events
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1076
a) Ephemeral string (packet duration) was inserted into long-term hash of
dynamic payloads
b) There was no clock_rate mapping for MIME type "telephone-event".

svn path=/trunk/; revision=22780
2007-09-04 05:22:43 +00:00
Anders Broman 654554a507 Wireshark packet-gtp.c error in decoding IMEI.
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1536

svn path=/trunk/; revision=22779
2007-09-03 16:42:28 +00:00
Anders Broman 4e0cf23472 Incorrectly decoded IMSI in RANAP prot./id-CommonID procedure
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1713

svn path=/trunk/; revision=22778
2007-09-03 16:40:51 +00:00
Anders Broman 8f3a0cb862 BSSGP.TLLI is not recognized properly in filter
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1384

svn path=/trunk/; revision=22777
2007-09-03 16:39:07 +00:00
Guy Harris 8084fb9e82 guint8, not gchar, is the appropriate type for a byte.
svn path=/trunk/; revision=22776
2007-09-03 06:44:54 +00:00
Jaap Keuter bd56b304c6 Fix for bug 1816:
Add status value to LSSU info column.

svn path=/trunk/; revision=22775
2007-09-03 05:56:48 +00:00
Guy Harris 522053f04b tvb_reported_length() returns a gint, so assign its value to a gint.
svn path=/trunk/; revision=22773
2007-09-02 23:51:51 +00:00
Guy Harris 6b45c4179d The actual length of the PPPoE payload is returned by
tvb_reported_length_remaining(), not by tvb_length_remaining() -
tvb_length_remaining() shows only the amount of *captured* data
remaining, but the capture might have been done with a snapshot length
that cut the packet data short.

The payload length from the PPPoE header could legitimately be different
from the actual length of the PPPoE payload if there's not enough PPPoE
payload to avoid padding at the E(thernet) level.  Only complain if
there shouldn't have been any padding.

Report an "expert" warning if the payload length looks wrong.

Update a comment to reflect current reality (as of many many years ago,
when we went all-tvbuff).

svn path=/trunk/; revision=22770
2007-09-02 22:49:56 +00:00
Guy Harris 0e09d21936 Fix indentation.
svn path=/trunk/; revision=22768
2007-09-02 20:37:39 +00:00
Bill Meier 0534c6982c macro_name_chk: return valid error string for fail return when empty macro name field;
fixes bug #1813

svn path=/trunk/; revision=22767
2007-09-02 12:37:24 +00:00
Jaap Keuter 770034f1d0 From Steve Karg:
Fix for bug 1807. This patch corrects the decoding of the NotificationParameters. 
I fuzz tested with these and other captures (Pass > 100).

svn path=/trunk/; revision=22766
2007-09-01 11:47:59 +00:00
Guy Harris 81f968f748 Show unsigned quantities with %u, not %d.
svn path=/trunk/; revision=22764
2007-08-31 23:56:07 +00:00
Sake Blok 2ef69333db When doing TCP_SEQ analysis, if the packet is a SYN, then it's
not a lost packet but the tcp ports are being reused. This is often 
seen in load-balanced environments where client ports are preserved 
on the server-side.

We only want to report port reusage once, so the SYN/ACK is excluded 
from TCP_SEQ analysis.

svn path=/trunk/; revision=22762
2007-08-31 15:06:27 +00:00
Jaap Keuter 1a8fb7a459 Fix for bug 1244:
hf_isup_event_ind contains incorrect fieldbase.

svn path=/trunk/; revision=22760
2007-08-31 05:37:43 +00:00
Anders Broman 51460c5a5f fix dissect_per_bit_string() for unaligned PER, values ar still not correctly displayed.
svn path=/trunk/; revision=22758
2007-08-30 19:44:22 +00:00
Stig Bjørlykke 9703036496 Added capture_wlancap to libwireshark.def
svn path=/trunk/; revision=22756
2007-08-30 19:11:36 +00:00
Stig Bjørlykke 6d9c82338d Fixed a brace placement to enable the default case
svn path=/trunk/; revision=22751
2007-08-30 11:37:49 +00:00
Greg Morris 1506ed6fcc Test to see if packet is actually a request by verifying the one byte function code is a non-zero value.
svn path=/trunk/; revision=22749
2007-08-30 10:33:24 +00:00
Greg Morris a6aab98d1e Fix attribute *Print Checkpoint"
Fix Printer State Reasons in extended error codes.

svn path=/trunk/; revision=22747
2007-08-30 10:23:58 +00:00
Greg Morris c8be509d6a Add eDirectory iteration verb 0x6e.
Fix eDirectory timestamps to display correctly.

svn path=/trunk/; revision=22746
2007-08-30 10:18:29 +00:00
Anders Broman 039c84485d From Chris Maynard:
Incorrect display filter field naming convention.

svn path=/trunk/; revision=22743
2007-08-30 05:30:28 +00:00
Anders Broman e600941645 From Chris Maynard:
Incorrect display filter field naming convention.

svn path=/trunk/; revision=22742
2007-08-30 05:22:25 +00:00
Anders Broman 66465f99be From Chris Maynard:
Incorrect display filter field naming convention.

svn path=/trunk/; revision=22741
2007-08-30 05:05:45 +00:00
Anders Broman f0fdcf55c4 From Chris Maynard:
Incorrect display filter field naming convention.

svn path=/trunk/; revision=22740
2007-08-30 05:02:33 +00:00
Anders Broman 3d65e68a15 From Chris Maynard:
Incorrect display filter field naming convention.

svn path=/trunk/; revision=22739
2007-08-30 04:58:11 +00:00
Anders Broman 5849df64d6 From Chris Maynard:
Incorrect display filter field naming convention.

svn path=/trunk/; revision=22738
2007-08-30 04:49:04 +00:00
Gerald Combs 92802883a6 Change the "--enable-setuid-install" option to install dumpcap and TShark
setuid instead of Wireshark.  Remove the "DANGEROUS" notices, but leave it
disabled by default.  Whine if the user runs Wireshark or TShark as root.
Add a preference to disable the whining.  Add a "setuid-root" script that
can be used to switch dumpcap and TShark's setuid-ness on and off for
development and testing.  Update the release notes and README.packaging.

svn path=/trunk/; revision=22733
2007-08-30 00:24:40 +00:00
Stig Bjørlykke 21d5aaaa4f - Rewrote handling of extensions to get rid of "funky" oid strings.
- Added ASN.1 integer values for StandardExtension, ExtensionAttributeType
  and TokenDataType.
- Added expert info for unknown standard-extension, extension-attribute-type 
  and tokendata-type.
- Added expert info for unknown built-in content-type.

svn path=/trunk/; revision=22730
2007-08-29 18:39:30 +00:00
Anders Broman b71c2da3e4 OID name fixes.
svn path=/trunk/; revision=22729
2007-08-29 16:10:47 +00:00
Martin Mathieson 7f6d5c04a8 Don't show fragment offset as a bit field, but note number of bits used in long text.
svn path=/trunk/; revision=22727
2007-08-29 15:35:27 +00:00
Tomas Kukosa a8357929c4 RANAP rewritten to use original ASN.1 source and updated to TS 25.413 V7.6.0 (2007-06)
svn path=/trunk/; revision=22726
2007-08-29 11:57:27 +00:00
Tomas Kukosa c927edea31 ASN.1 parameterization handling (1st raw implementation)
it is not supported in asn2wrs now, code has to be written manually

svn path=/trunk/; revision=22724
2007-08-29 11:44:49 +00:00
Anders Broman f832aaf3b6 Fix up most of the OID names in GSM MAP.
svn path=/trunk/; revision=22723
2007-08-29 06:13:40 +00:00
Luis Ontanon d56f4f3a68 - turn some other TC from FT_BYTES to FT_STRING so that human-readable strings become readable by humans
- Add the EngineId decoding for the contextEngineId
- Add some expert info about malformed indexed oids


svn path=/trunk/; revision=22720
2007-08-28 23:55:49 +00:00
Luis Ontanon 79ea56143c Fix non implicit oid key indexes. This starts to look good!
svn path=/trunk/; revision=22718
2007-08-28 21:27:54 +00:00
Bill Meier ac04f94a3d From Todd Martin: "Flag IP TTL more intelligently".
Also: Change default "Low TTL" color filter to match.

svn path=/trunk/; revision=22715
2007-08-28 20:58:50 +00:00
Luis Ontanon 450767fb93 Report loading failures to the user
svn path=/trunk/; revision=22712
2007-08-28 19:07:39 +00:00
Anders Broman ba38b75a24 Add filters.
svn path=/trunk/; revision=22709
2007-08-28 17:50:02 +00:00
Luis Ontanon 0c154e528a Commit canges to uat_load.l, and initialize uat_t->loaded (not every system zeroes-out on malloc).
svn path=/trunk/; revision=22705
2007-08-28 15:38:05 +00:00
Luis Ontanon dfbac00752 SNMP:
- As noted by Thomas Anders values are not added to the tree anymore. Move the calling of subdissectors to the end of the function, so that the value is added to the tree.
 - add port 8161 to be decoded as SNMP (hey, it's on IANA's services file!)
UAT:
 - do not have the uat reloaded.
OIDS:
 - do not complain if renaming an OID to an identical name



svn path=/trunk/; revision=22704
2007-08-28 15:18:32 +00:00
Ronnie Sahlberg 8fde3b7561 rename dcerpc_smb_store_pol_name to dcerpc_store_polhnd_name
rename dcerpc_smb_fetch_pol  to dcerpc_fetch_polhnd_data and also make 
it take an additional parameter to return the "type" of the policy 
handle, if such a type was stored.

extend the pol_value structure used to track policy handles to also 
store a type to represent what created the policy handle
types could be USER/ALIAS/CONNECT/... etc handles returned from the 
SAMR interface

add a new helper function  dcerpc_store_polhnd_type()

track policy handles between request/responses for dcerpc

update the samr.cnf file to make the samr dissectors for
SetSecurity/QuerySecurity dissect the specific bits for the security 
descriptor correctly based on whether the policy handle refers to a 
CONNECT/DOMAIN/USER/ALIAS or GROUP



svn path=/trunk/; revision=22703
2007-08-28 11:45:08 +00:00
Tomas Kukosa 99a2ec1c9f fix bug in snmp.variable_oid subdissector calling and call them at the end of snmp dissector (so as snmp does not overwrite COL_INFO of subdissector)
svn path=/trunk/; revision=22701
2007-08-28 07:59:35 +00:00
Ronnie Sahlberg 90b34f5b69 improve the ctdb dissector to track request/responses for controls and
start decoding some control payload


svn path=/trunk/; revision=22700
2007-08-28 07:34:05 +00:00
Jaap Keuter 22cb9fb03f Fix warnings "dereferencing type-punned pointer will break strict-aliasing rules"
svn path=/trunk/; revision=22699
2007-08-28 05:59:09 +00:00
Luis Ontanon 5e7a8a9a87 Do not throw, some of this functions get called outside TRY blocks.
svn path=/trunk/; revision=22692
2007-08-27 21:29:20 +00:00
Stig Bjørlykke 49fc9636b9 From Tuomas Maattanen:
Committed changes in r21450 again.

svn path=/trunk/; revision=22691
2007-08-27 21:23:18 +00:00
Luis Ontanon 4e26d3ad2e cast a guint64 down to guint32 before assignment to get windows build running
svn path=/trunk/; revision=22689
2007-08-27 19:37:48 +00:00