Commit Graph

11 Commits

Author SHA1 Message Date
Jeff Morriss 0e8fef5827 Finish getting making the Diameter XML valid XML.
... Except for the fact that many AVP names start with "3GPP".

Make the AVP names XML IDs again.

Fix all the grouped AVPs that reference AVPs (by name) or vice-versa.  This
includes:
 * Fixing a bunch of typos (including type mismatches).
 * Commenting out a number of references to vendor AVPs for which we don't have
   the specs.
 * Adding a few missing AVPs.

Change-Id: Ic2ddb50cc947877de9086be51f7813e8f9be02b4
Reviewed-on: https://code.wireshark.org/review/15973
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-06-16 17:12:08 +00:00
Jeff Morriss d06cac6092 Diameter (NSN): the attribute name is 'mandatory' not 'mandatory-flag'.
Change-Id: Ifa19b59e23278abf332d8ab06dd5ad2059f3e679
Reviewed-on: https://code.wireshark.org/review/15872
Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
2016-06-13 17:56:43 +00:00
Anders Broman 5de7817315 Revert "[Diameter] Update Nokia Solutions and Networks vendor-specific AVPs"
As requested by the supplier of the data.

This reverts commit 19069dde80.

Change-Id: Ic5ed9df94a1a78d8fd861cb542828c60f104ac24
Reviewed-on: https://code.wireshark.org/review/13433
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-01-20 10:00:55 +00:00
AndersBroman 19069dde80 [Diameter] Update Nokia Solutions and Networks vendor-specific AVPs
Change-Id: I42e1243bd5563bd5296a8430544a317bb4caac06
Reviewed-on: https://code.wireshark.org/review/12840
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-12-23 09:05:06 +00:00
AndersBroman 830f30a705 Add AVP 100 amd 223
Change-Id: Ifccb111a8139b7c41cf6fec3fa6bc8e201e2e2ea
Reviewed-on: https://code.wireshark.org/review/12800
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-12-21 15:52:37 +00:00
Jeff Morriss 0b4e883803 Allow empty-element Diameter Applications and use that format.
This also fixes a couple of applications that weren't properly terminated
(as a result of some of my recent changes).

Change-Id: I9662017a81c63aceeb950d3b29cb17dde16d4f0c
Reviewed-on: https://code.wireshark.org/review/8335
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-05-08 04:23:10 +00:00
Jeff Morriss 7f6fe7a1fd Reorganize some of the Diameter XML files, taking advantage of the fact that
AVPs can be grouped by Vendor now (not just by Application).

Move a bunch of vendor-specific Application IDs to the vendor's XML file.

Delete the (basically empty) SKT.xml, ChinaTelecom.xml, and VerizonWireless.xml
files.

Fix a typo: 16777224 is 3GPP Gx, not 3GPP Cx.

Use (derived) type Enumerated (rather than Unsigned32 or Integer32) when the
AVP is of type Enumerated.

Change-Id: I7a9702c0c48dc3fe751ad74413d8ecc040984f1f
Reviewed-on: https://code.wireshark.org/review/8235
Petri-Dish: Jeff Morriss <jeff.morriss.ws@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-04-29 11:37:29 +00:00
Jeff Morriss ecc3369c05 Misc. Diameter XML cleanups.
Consistently used (derived) type Enumerated (rather than Unsigned32 or
Integer32) when the AVP is of type Enumerated.

Use a uri of "none" when we don't have access to the specification.
Update the URI of an Application or two.

Clean up white space and formatting.

Change-Id: Iad677db186469b7d8c4a23b7a7fca6c357dbc012
Reviewed-on: https://code.wireshark.org/review/8164
Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
2015-04-22 01:50:23 +00:00
Jeff Morriss 33f1256e00 Fix nameless application in NokiaSolutionsAndNetworks.xml (from
I4cd9bd7f7219e4d9ff1bb8a71fab32439a8a9a35).

(The nameless application was causing known applications to be reported as
unknown.)

Add code to the Diameter dissector to report such problems at startup (similar
code exists for other entities).

Tweak the parser debug slightly.

Change-Id: I6b28cda8660e6eb96648c7b3697d7fd85151ac96
Reviewed-on: https://code.wireshark.org/review/6927
Petri-Dish: Jeff Morriss <jeff.morriss.ws@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-02-03 05:58:57 +00:00
Josip Medved 17a1748ca9 Updated NSN dictionary with vendor-specific Sy application AVPs.
Change-Id: I4cd9bd7f7219e4d9ff1bb8a71fab32439a8a9a35
Reviewed-on: https://code.wireshark.org/review/6705
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-01-21 09:08:00 +00:00
Josip Medved c8bca4fa9a Updated company name from Nokia Siemens Networks to Nokia Solutions and Networks.
Change-Id: I93782facc2e3f9ff6358cf617968fac30bac1f7a
Reviewed-on: https://code.wireshark.org/review/6647
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-01-19 16:53:04 +00:00