Commit Graph

24 Commits

Author SHA1 Message Date
Guy Harris 88535b9a99 From Lars Ruoff (who also contributed the previous change; my apologies
to both Larses):

	- Comfort noise (CN) packets and packets following them
	  immediately are excluded from maximum delay calculation (as
	  well as marked packets are)
	- Payload changes between CN and regular packets are ignored.
	- Added a "Marker missing?" status warning for packets following
	  CN that don't have the marker bit set (cf. RFC1890 4.1)
	- Changed status "Ok" to "[ Ok ]", so that when sorting by status
	  column, all non-Oks are grouped together.
	- Minor GUI updates: reduced size of box, borders, spacing,
	  changed highlight colors.

svn path=/trunk/; revision=9819
2004-01-24 01:15:24 +00:00
Guy Harris 7f727e9119 From Lars Roland:
- "Refresh" button is back again.  Everything should work fine now
	  with multiple windows on the same streams.
	- made packet list sortable by column.
	- show a warning when user chooses "RTP Streams/Analyze"
	  without having a RTP packet selected instead of displaying the
	  streams box.
	- minor GUI updates, renamed button "Next" to "Next non-Ok" for
	  more clarity.

svn path=/trunk/; revision=9788
2004-01-23 00:29:52 +00:00
Ulf Lamping 503a830e48 The progressbar had a parameter to specify the text of the Cancel/Stop button.
As this will always be a Cancel of a running operation, this parameter was removed.
This makes us also able to use a stock button for this.

svn path=/trunk/; revision=9774
2004-01-21 22:00:28 +00:00
Ulf Lamping e3dd2f5472 use stock buttons whereever possible,
added some ethereal specific stock icons

svn path=/trunk/; revision=9763
2004-01-21 03:54:32 +00:00
Ulf Lamping 1108d88e29 commented out refresh_bt, as it's currently unused
svn path=/trunk/; revision=9755
2004-01-20 19:31:46 +00:00
Olivier Biot bc8d20be32 From Lars Ruoff: temporarily comment out the code for the "refresh" button;
register and unregister the tap listener in a thread-safe manner.

svn path=/trunk/; revision=9742
2004-01-19 23:35:32 +00:00
Guy Harris a093c75b59 Use "retap_packets()" rather than "redissect_packets()".
svn path=/trunk/; revision=9660
2004-01-13 22:49:15 +00:00
Richard Sharpe 5d7261eb78 Make Analyze/Statistics have an accelerator of Alt+A S and move
Analyze/Summary to Alt+A Y.

svn path=/trunk/; revision=9537
2004-01-03 18:05:57 +00:00
Ulf Lamping cb2658031d removed some MSVC warnings (warning level 2)
svn path=/trunk/; revision=9459
2003-12-28 12:43:40 +00:00
Guy Harris ac48df79f2 From Lars Roland: have common code to handle display filter dialogs in
taps, and use that in the H.225 taps.

svn path=/trunk/; revision=9327
2003-12-17 22:13:08 +00:00
Olivier Abad abb4aec1fe Use gtk compatibility macros (from compat_macros.h) instead of some gtk+
v1.2 functions which are deprecated in gtk+ v2.

Update OBJECT_SET_DATA macros to cast "data" to (gpointer).

svn path=/trunk/; revision=9296
2003-12-16 18:43:35 +00:00
Guy Harris f0b9d12b6a Don't use GNodes for the protocol tree, put the sibling pointer, and
pointers to the first *and* last child, in the "proto_node" structure
itself.  That saves us one level of indirection and memory allocation,
and lets us append to a tree by appending to the last child directly,
rather than having to scan through the list of siblings of the first
child to find the end of that list.

svn path=/trunk/; revision=9171
2003-12-04 10:59:34 +00:00
Guy Harris dcd98ae8d3 The "ptr_u" unions no longer have a "next" pointer - they now just have
one member - or have one that's not used, so get rid of those unions.

svn path=/trunk/; revision=9151
2003-12-03 09:28:26 +00:00
Guy Harris bd9f96738c From Didier Gautheron: put an "fvalue_t" structure into a "field_info"
structure, rather than separately allocating "fvalue_t"s and having the
"field_info" structure point to them - this appears to speed up protocol
tree construction a bit.

svn path=/trunk/; revision=9146
2003-12-02 21:15:49 +00:00
Guy Harris 122dd3959c Make the recent epan/proto.{c,h} change compile.
svn path=/trunk/; revision=9075
2003-11-24 22:11:55 +00:00
Guy Harris c682c10915 From Lars Ruoff: fix a problem with wrong maximum delay calculation -
first or marked packets are now ignored when calculating maximum delay.

svn path=/trunk/; revision=8868
2003-11-03 20:45:25 +00:00
Guy Harris 3a6a79c3c9 From Lars Ruoff:
- fix missing detection of first packet when writing payload.
	- fix bug of erroneous handling of confort noise when writing payload.
	- fix bug of possible endless silence insertion on first packet when
	  writing payload.

svn path=/trunk/; revision=8846
2003-10-31 19:45:16 +00:00
Guy Harris f7706315f4 Use PT_ values rather than raw numbers when checking for u-law and A-law
payload.

svn path=/trunk/; revision=8664
2003-10-10 10:16:03 +00:00
Guy Harris 1904d3498f Include "mkstemp.h" only if we're including our own "mkstemp()".
svn path=/trunk/; revision=8605
2003-10-03 22:38:56 +00:00
Jörg Mayer e2fe785941 Graham Bloice: Add missing #include mkstemp.h
svn path=/trunk/; revision=8604
2003-10-03 21:19:10 +00:00
Jörg Mayer 243d1ea197 use mkstemp instead of tmpnam
svn path=/trunk/; revision=8569
2003-09-29 19:20:51 +00:00
Guy Harris 59938a45fe Assorted GUI cleanups.
svn path=/trunk/; revision=8544
2003-09-26 02:09:44 +00:00
Guy Harris 87d87ace4e RTP analysis updates from Lars Ruoff:
- can now handle streams with different payload types
	- detects payload changes
	- detects comfort noise (PT=13 and 19)
	- status line now shows: sequence errors, payload changes,
	  comfort noise (if any)
	- uses colours for lines with status != "Ok"
	- new button "next": jumps to next line with status != "Ok"
	  (starting from selected line)
	- fixed: wrong jitter calculation (bug from tap_rtp)
	- fixed: marker was not shown on first packet or erroneous
	  packets (bug from tap_rtp)
	- code refactored to improve readability and reuse

svn path=/trunk/; revision=8543
2003-09-25 19:35:14 +00:00
Guy Harris 14d13e3401 From Lars Ruoff: rewritten RTP analysis module.
svn path=/trunk/; revision=8529
2003-09-24 07:48:12 +00:00