Jakub Zawadzki
bf81b42e1e
Update Free Software Foundation address.
...
(COPYING will be updated in next commit)
svn path=/trunk/; revision=43536
2012-06-28 22:56:06 +00:00
Pascal Quantin
2f035a3c0f
From Frank Lahm via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7334 :
...
FPSpotlightRPC dates structure can contain multiple dates
svn path=/trunk/; revision=43133
2012-06-06 16:55:48 +00:00
Anders Broman
b69547925f
Get rid of a couple of warnings.
...
svn path=/trunk/; revision=43066
2012-06-04 13:52:46 +00:00
Bill Meier
91e5923458
Fix some "warning: Value stored to '...' is never read" clang scan-build warnings.
...
Also; Do some whitespace cleanup in a few cases.
svn path=/trunk/; revision=42715
2012-05-19 14:20:55 +00:00
pascal
101e304d4e
Spaces -> tabs
...
svn path=/trunk/; revision=42637
2012-05-15 21:18:39 +00:00
pascal
96e21ee3f7
Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7261 :
...
Add some sanity checks when dissecting SQ_TYPE_NULL
svn path=/trunk/; revision=42636
2012-05-15 21:16:06 +00:00
pascal
d5aa739fd0
From Alexander Lüders & Frank Lahm via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7254 :
...
Enhancements for FPSpotlightRPC AFP function
svn path=/trunk/; revision=42633
2012-05-15 19:25:33 +00:00
pascal
05cfd1c391
From Frank Lahm via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7256 :
...
Fix subquery_count loop variable updating
svn path=/trunk/; revision=42624
2012-05-14 21:46:02 +00:00
pascal
723b213c89
From Frank Lahm via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7246 :
...
Patch adding dissection of time data
svn path=/trunk/; revision=42620
2012-05-13 21:02:42 +00:00
pascal
b42423a8dc
From Frank Lahm:
...
In FPSpotlightRPC packets, check for elements with 0 childs (denoted by L in TLV is sizeof(TLV tag))
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7245
svn path=/trunk/; revision=42571
2012-05-11 09:03:22 +00:00
pascal
19a766b152
Remove unused hf entries
...
svn path=/trunk/; revision=42516
2012-05-08 20:20:12 +00:00
pascal
0c4569d941
From Frank Lahm:
...
Display guids in FPSpotlightRPC AFP packets
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7237
svn path=/trunk/; revision=42515
2012-05-08 19:38:58 +00:00
Anders Broman
b438c7415f
From Frank Lahm:
...
Fixes for FPSpotlightRPC AFP dissector.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7235
svn path=/trunk/; revision=42508
2012-05-08 14:24:13 +00:00
Bill Meier
2fef9f460f
Don't use tabs in string constants;
...
svn path=/trunk/; revision=42357
2012-04-30 19:55:24 +00:00
Jeff Morriss
891c9db19b
As suggested in http://www.wireshark.org/lists/wireshark-dev/201204/msg00062.html :
...
Don't use ENC_BIG_ENDIAN or ENC_LITTLE_ENDIAN with ENC_ASCII: ASCII has no
endianism, so ENC_NA is more appropriate.
svn path=/trunk/; revision=42297
2012-04-27 18:58:37 +00:00
Jakub Zawadzki
8a1dc57c03
Remove doubled semicolons and semicolons outside function.
...
svn path=/trunk/; revision=42053
2012-04-13 20:22:31 +00:00
Bill Meier
cad303d777
(Trivial) Fix a typo in a comment; Do some whitespace changes.
...
svn path=/trunk/; revision=41092
2012-02-20 22:46:24 +00:00
Alexis La Goutte
78c4f454f9
Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
...
svn path=/trunk/; revision=40093
2011-12-04 18:43:05 +00:00
Stephen Fisher
082938900c
Fix Coverity ID #1288 : UNUSED_VALUE in spotlight_dissect_query_loop:
...
"returned_pointer: Pointer ... is never used" due to break and end
of function after the switch block.
svn path=/trunk/; revision=39470
2011-10-19 16:15:53 +00:00
Stephen Fisher
20ae7e93d5
Fix Coverity ID 1300: UNUSED_VALUE in dissect_spotlight: "returned_pointer
...
is never used" because of the return -1 at the end of this if block.
Removed item_toc = assignment and fixed indentation.
svn path=/trunk/; revision=39469
2011-10-19 16:08:13 +00:00
Chris Maynard
c553e708a2
Cleanup AFP Version display filter name.
...
svn path=/trunk/; revision=39448
2011-10-17 23:58:25 +00:00
Bill Meier
126aa85393
Convert proto_tree_add_item() 'encoding' arg for field types FT_STRING, FT_STRINGZ, FT_UINT_STRING as follows:
...
1. If there's no character encoding (ENC_ASCII, ...) specified
then use ENC_ASCII.
2. For all but FT_UINT_STRING, always use ENC_NA
(replacing any existing True/1/FALSE/0
/ENC_BIG_ENDIAN/ENC_LITTLE_ENDIAN).
svn path=/trunk/; revision=39426
2011-10-15 18:46:26 +00:00
Guy Harris
6c3f1f0df7
Squelch some more warnings.
...
svn path=/trunk/; revision=39212
2011-10-02 08:58:35 +00:00
Guy Harris
b061017eca
Squelch warnings (at that point, toc_offset has been determined to fit
...
into an int, as has offset + toc_offset + 8).
svn path=/trunk/; revision=39211
2011-10-02 08:40:03 +00:00
Guy Harris
3bad9fcc4d
SQ_TYPE_NULL appears to do run-length encoding of nulls; do run-length
...
encoding of the list of nulls in the protocol tree, so if we have a
ridiculously large number of nulls, we don't have a ridiculously large
number of protocol tree entries, one for each null. This should
(finally) fix bug 6378.
Add some additional sanity checks to avoid integer overflows and
underflows due to subtracting N from a value not guaranteed to be >= N.
In the big switch statements for AFP command codes, put the break
statement on a separate line, so it's a bit more obvious that the code
isn't falling through.
svn path=/trunk/; revision=39210
2011-10-02 08:12:08 +00:00
Guy Harris
e4532f21af
Quit if we have a zero-length query, so we don't loop indefinitely.
...
Should fix bug 6378.
svn path=/trunk/; revision=39176
2011-09-28 19:08:20 +00:00
Anders Broman
c0c4fb5f21
Make query_length a gint as the lenght argument to proto_tree_add_text() is a gint.
...
svn path=/trunk/; revision=39067
2011-09-21 07:36:26 +00:00
Guy Harris
3e7c0390d7
From Frank Lahm: Complete dissection of AFP FPSpotlightRPC function.
...
From me: don't use global variables in FPSpotlightRPC dissection.
svn path=/trunk/; revision=39065
2011-09-20 19:24:07 +00:00
Guy Harris
98bbf4578d
Use ENC_ values in proto_tree_add_item() calls. Use ENC_UTF_8 for
...
strings, and note that, for older AFP clients and servers, we might need
a way to say to use some Mac encoding instead.
Use tvb_strsize() rather than tvb_get_ephemeral_stringz() to just get
the length of a null-terminated string.
Use FT_GUID for UUIDs.
The low-order bit in the MessageBitmap in the FPGetSrvrMsg reply does
not, at least according to the current AFP spec, specify whether there's
a message at all, it specifies whether it's a server message or a login
message. The spec *does* now mention the "message is UTF-8" bit; use
it.
Fix a blurb.
svn path=/trunk/; revision=39063
2011-09-20 17:23:16 +00:00
Stig Bjørlykke
e28a15e6ec
Added some casts from spotlight_ntoh64 to guint.
...
svn path=/trunk/; revision=37694
2011-06-17 13:39:56 +00:00
Anders Broman
6a4ed4f4c3
From Michael Mann.
...
Part of "display filters with redundancies of PROTABBREV in them."
The ones left outs should be fixed differently I think.
Rename som ndps hf variables while at it.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2794
svn path=/trunk/; revision=37406
2011-05-26 06:32:51 +00:00
Jeff Morriss
d553df218e
Use tvb_memeql().
...
Use tvb_ip_to_str().
There's no need to pass the result of tvb_get_ptr() as the 'value' in
proto_tree_add_*(): just use proto_tree_add_item().
Replace some tvb_get_ptr()s with tvb_get_ephemeral_string()s to ensure the
return string is NULL terminated.
svn path=/trunk/; revision=35547
2011-01-16 03:46:16 +00:00
Bill Meier
c17c9fff87
Use value_string_ext fcns to access certain value_string arrays;
...
Sort a few value_string arrays to be in ascending order by value;
Do minor reformatting and whitespace cleanup.
svn path=/trunk/; revision=34813
2010-11-08 21:59:39 +00:00
Jeff Morriss
cca3ba3ce2
(Refining the regexp...) Replace blurbs that match the name (case insensitive) with NULL.
...
svn path=/trunk/; revision=34230
2010-09-24 02:51:40 +00:00
Jeff Morriss
72516cc39e
Replace another blurb that matches the name (case insensitive) with NULL.
...
svn path=/trunk/; revision=34228
2010-09-24 01:32:27 +00:00
Jeff Morriss
0ff5638f37
Replace blurbs that match the name (case insensitive) with NULL.
...
svn path=/trunk/; revision=34227
2010-09-23 21:46:31 +00:00
Stephen Fisher
4c6864b29b
From Frank Lahm via bug #5169 : Provide initial support for the undocumented
...
AFP FPSpotlightRPC call.
svn path=/trunk/; revision=34083
2010-09-08 19:01:41 +00:00
Guy Harris
43ae1a4b2b
Update some links.
...
svn path=/trunk/; revision=33969
2010-08-27 21:28:24 +00:00
Stig Bjørlykke
ec94791339
From Frank Lahm via bug 5136:
...
Correct volume flags for FPGetSrvrParms.
svn path=/trunk/; revision=33961
2010-08-27 20:54:21 +00:00
Jeff Morriss
729de1a635
As suggested in http://www.wireshark.org/lists/wireshark-dev/200809/msg00075.html
...
(as referenced in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2907 ) and
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3411 :
Write a new convenience routine for finding a conversation and, if it is not
found, create it. The frame number and addresses are taken from pinfo (as is
the common case).
Use this function in a bunch of dissectors.
svn path=/trunk/; revision=32790
2010-05-13 18:28:34 +00:00
Bill Meier
ce72d43d29
Use consistent indentation & whitespace.
...
svn path=/trunk/; revision=32693
2010-05-06 21:16:31 +00:00
Bill Meier
055dd62063
#include <string.h> not needed.
...
svn path=/trunk/; revision=32410
2010-04-06 21:14:01 +00:00
Bill Meier
09764dd969
Remove unneeded #include <stdio.h>
...
svn path=/trunk/; revision=32367
2010-04-03 21:55:23 +00:00
Anders Broman
aaa917be72
remove check_col
...
svn path=/trunk/; revision=32089
2010-03-03 13:52:17 +00:00
Guy Harris
8e236e55de
For fields of type FT_ABSOLUTE_TIME, have the "display" value be one of
...
ABSOLUTE_TIME_LOCAL or ABSOLUTE_TIME_UTC, indicating whether to display
the date/time in local time or UTC. (int)ABSOLUTE_TIME_LOCAL ==
(int)BASE_NONE, so there's no source or binary compatiblity issue,
although we might want to eliminate BASE_NONE at some point and have the
BASE_ values used with integral types start at 0, so that you can't
specify BASE_NONE for an integral field.
svn path=/trunk/; revision=31319
2009-12-19 03:17:44 +00:00
Bill Meier
0882e38510
Remove some unneeded (indirect) 'if(check_col()...)' guarding.
...
svn path=/trunk/; revision=30213
2009-09-30 13:30:35 +00:00
Jeff Morriss
e64df56967
From Didier Gautheron via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3995
...
There's a copy and paste error in hf_afp_vol_attribute_CaseSensitive
declaration and add kSupportsTMLockSteal
svn path=/trunk/; revision=29916
2009-09-15 01:49:01 +00:00
Anders Broman
213c607443
From Alex deVries:
...
DSI/AFP dissectors need support for AFP 3.3
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3995
svn path=/trunk/; revision=29836
2009-09-10 06:07:31 +00:00
Kovarththanan Rajaratnam
8b515e9340
Switch a bunch of dissectors over to using tvb_new_subset_remaining()
...
svn path=/trunk/; revision=29446
2009-08-16 12:36:22 +00:00
Kovarththanan Rajaratnam
e971354a54
Don't guard col_set_str (COL_PROTOCOL) with col_check
...
svn path=/trunk/; revision=29340
2009-08-09 06:26:46 +00:00