Commit graph

1570 commits

Author SHA1 Message Date
Guy Harris
f952217194 The capture options edit dialog is a dialog, not a menu, so don't use
GDK_WINDOW_TYPE_HINT_MENU, use GDK_WINDOW_TYPE_HINT_DIALOG.

GDK_WINDOW_TYPE_HINT_MENU, at least on OS X with quartz-wm, causes the
combo box for the interface type not to work, so
GDK_WINDOW_TYPE_HINT_MENU breaks things.

GDK_WINDOW_TYPE_HINT_DIALOG, at least on OS X with quartz-wm, causes the
minimize and whatevertheheckthegreenbuttondoesize buttons to be clear
and inactive, so maybe GDK_WINDOW_TYPE_HINT_DIALOG does something
approximating the right thing.

svn path=/trunk/; revision=48545
2013-03-25 11:41:59 +00:00
Pascal Quantin
1aa1f2ee67 Add a few missing explicit casts
svn path=/trunk/; revision=48544
2013-03-25 08:34:46 +00:00
Martin Kaiser
b8a67334a1 add casts for ws_gtk_grid_attach_extended()
svn path=/trunk/; revision=48541
2013-03-24 23:04:13 +00:00
Martin Kaiser
cfc0087d71 add missing cast
svn path=/trunk/; revision=48540
2013-03-24 23:03:21 +00:00
Jaap Keuter
0090d11212 Forget about the show and hide dance.
svn path=/trunk/; revision=48531
2013-03-24 17:23:37 +00:00
Jaap Keuter
07b2125538 Set the height to fit the interfaces actually shown.
svn path=/trunk/; revision=48529
2013-03-24 17:19:15 +00:00
Evan Huus
c4a36c513f Redissect extra packet windows in all cases (that I know of) where we
redissect normal packet list.

Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8482

svn path=/trunk/; revision=48528
2013-03-24 16:47:38 +00:00
Anders Broman
912814ac0f From beroset:
allow flexible resizing of graph_analysis.c items

Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7418

svn path=/trunk/; revision=48525
2013-03-24 14:10:43 +00:00
Alexis La Goutte
1b5350b10a Add Modelines Info (and remove some tabs)
svn path=/trunk/; revision=48487
2013-03-22 17:37:34 +00:00
Alexis La Goutte
05a24bedbc Fix "Decryption Key Warning " Dialog broken in revision 47005
svn path=/trunk/; revision=48486
2013-03-22 17:37:25 +00:00
Alexis La Goutte
8bf9de273f Fix "Advanced Wireless Settings" Dialog broken in revision 47003
svn path=/trunk/; revision=48485
2013-03-22 17:31:32 +00:00
Alexis La Goutte
f24ce3f381 Remove minimize / maximize buttons for "Edit Interfaces / Remote Capture Settings" Dialog
svn path=/trunk/; revision=48483
2013-03-22 17:31:23 +00:00
Alexis La Goutte
d5e14301ba After Revision 46500 ( Make "Edit Interfaces Dialog" modal )
The "Advanced Wireless / Remote Capture Settings" is not on the top of Dialog

Make "Advanced Wireless / Remote Capture Settings " Dialog modal too

svn path=/trunk/; revision=48482
2013-03-22 17:31:15 +00:00
Alexis La Goutte
02d80d23fd Make Dialog about "Decryption Key (List / Add / Edit)" Modal
svn path=/trunk/; revision=48481
2013-03-22 17:31:06 +00:00
Alexis La Goutte
11d6a3f393 On Windows (Tested with XP and 7), the Add(New)/Edit Decryption Key Dialog is not always in top (regarding Decryption Key Management Dialog)
svn path=/trunk/; revision=48480
2013-03-22 17:30:55 +00:00
Evan Huus
4906b50767 Idea from Michail Koreshkov via bug #8371. Open a referenced packet in a new
window when double-clicking with a modifier key held. The original suggestion
was CTRL, but GTK didn't like that, so ALT was suggested as an alternative,
but I think SHIFT makes more sense, since that's what browsers use (shift+click)
to open links in a new window.

svn path=/trunk/; revision=48470
2013-03-21 23:59:55 +00:00
Gerald Combs
8edee26054 Make the elided label width match our cutoff limit.
svn path=/trunk/; revision=48469
2013-03-21 23:31:16 +00:00
Gerald Combs
6ef9a20ae9 Only elide text that's longer than 50 characters.
svn path=/trunk/; revision=48468
2013-03-21 23:25:58 +00:00
Gerald Combs
86b9b16075 Windows lets you use long interface names, e.g. "Local Area Connection 3
was walking through the woods one day taking a basket full of emergency
zombie apocalypse supplies to her grandmother. It was raining." This can
make the interface list dialog really wide, so elide the interface text.
Elide the description as well.

Try to make the interface list resize sanely. This doesn't appear to
work for Gtk2.

svn path=/trunk/; revision=48467
2013-03-21 23:00:21 +00:00
Gerald Combs
fa7cc9c20f Bill pointed out that gtk_window_get_size() + gtk_window_resize()
doesn't work well in some cases.  Switch to window_get_geometry() +
gtk_window_set_default_size(). (We use gtk_widget_get_preferred_size()
elsewhere but fetches what appeares the minimum width of the top-level
window on my machine instead of the actual width.)

Use a macro to define the initial conversation and endpoint dialog
heigth and increase its value. Use best-guess dialog metrics and UTF8
entities in a few more spots.

Add a comment about alignment not working quite right in Gtk3.

svn path=/trunk/; revision=48459
2013-03-21 18:39:16 +00:00
Anders Broman
f8a93562e0 [-Wmissing-prototypes]
Use explicit casts.

svn path=/trunk/; revision=48457
2013-03-21 17:52:43 +00:00
Chris Maynard
37e7e36915 Fix compilation if WANT_PACKET_EDITOR is defined. Should we also add an edit_window_cb_ref?
svn path=/trunk/; revision=48454
2013-03-21 16:50:47 +00:00
Evan Huus
4836f13ac0 From Michail Koreshkov via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8371
Add item to context menu of frame references to open the referenced frame in a
new window. Very useful when the referenced frame is hidden by a filter.

From me:
- modelines
- simplify some of the logic

svn path=/trunk/; revision=48451
2013-03-21 15:27:38 +00:00
Bill Meier
35d1b406d7 From beroset:
remove C++ incompatibilities
 https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416 attachment #10408

Note: The following parts of the patch had been previously done:
 asn1/snmp/packet-snmp-template.c
 epan/dissectors/packet-snmp.c
 epan/dissectors/packet-x11.c

svn path=/trunk/; revision=48448
2013-03-21 02:58:59 +00:00
Bill Meier
8112ecc321 From beroset:
remove C++ incompatibilities
 https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416 attachment #10404

Note: The following parts of the patch had been previously done:
 asn1/snmp/packet-snmp-template.c
 epan/dissectors/packet-snmp.c
 epan/dissectors/packet-x11.c

Also; hostlist_table.c: code under '#ifdef HAVE_GEOIP'
 didn't compile and needed a few additional patches.


svn path=/trunk/; revision=48447
2013-03-21 02:29:09 +00:00
Gerald Combs
da1bdffa1b Reverse some logic.
svn path=/trunk/; revision=48446
2013-03-20 22:58:51 +00:00
Gerald Combs
a8e0c85548 Add frame_new, which creates a frame that best conforms to the GNOME,
Windows, and OS X HIGs. Use it in the capture options dialog. The
capture options dialog is a bit taller now and could probably use a bit
more tweaking.

In the capture options, conversation, and endpoint dialogs use our
best-guess dialog spacing and pad out some areas.

svn path=/trunk/; revision=48445
2013-03-20 22:41:51 +00:00
Bill Meier
0df5a9390d From beroset:
remove C++ incompatibilities
 https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416 attachment #10397

svn path=/trunk/; revision=48438
2013-03-20 01:18:10 +00:00
Bill Meier
a43e5a7eb9 Fix another case of "Widgets are not properly expanded in gtk3"
See https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7377#c21


svn path=/trunk/; revision=48437
2013-03-20 00:47:49 +00:00
Anders Broman
089dfcd108 From beroset:
remove C++ incompatibilities 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416

svn path=/trunk/; revision=48424
2013-03-19 19:02:25 +00:00
Anders Broman
a10b98284c From beroset:
remove C++ incompatibilities 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416

svn path=/trunk/; revision=48412
2013-03-19 04:54:30 +00:00
Anders Broman
434aae5245 From beroset:
remove C++ incompatibilities 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416

svn path=/trunk/; revision=48396
2013-03-18 19:47:33 +00:00
Bill Meier
eca156d710 From Jaap Keuter: Fix "GTK3: Interface List dialog does not expand properly"
From me: Add an XXX comment about an un-related issue

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8468


svn path=/trunk/; revision=48342
2013-03-16 18:57:35 +00:00
Anders Broman
f5a5b3d0fe From beroset:
remove C++ incompatibilities 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416

svn path=/trunk/; revision=48333
2013-03-15 22:39:37 +00:00
Michael Mann
3a48e7e1e2 Bugfix Decryption Key Management dialog, bug 8446 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8446)
Needed to convert use of old IEEE802.11 preference strings to UAT.  Since UAT is self-contained within its own file, the entire preference file doesn't need to be rewritten/saved when UAT values are changed.

svn path=/trunk/; revision=48308
2013-03-15 01:31:53 +00:00
Jaap Keuter
004d22cf0a Remove the tool string if all you do is free it in the end.
svn path=/trunk/; revision=48304
2013-03-14 22:01:48 +00:00
Bill Meier
c63dfc2ab4 gtk_widget_set_vexpand() is only for GTK3.
svn path=/trunk/; revision=48281
2013-03-13 20:25:28 +00:00
Bill Meier
ea64ac1937 Certain prefs window contents should not be centered vertically in GTK3.
(Fix: prevent vertical expand/fill of grid widget in certain cases).

(This stuff in GTK3 about "parents inheriting expand/fill properties from children"
is driving me crazy).

svn path=/trunk/; revision=48280
2013-03-13 20:04:48 +00:00
Alexis La Goutte
35daeed3f1 Fix compilation under Linux ../../../ui/gtk/prefs_capture.c: In function ‘ifopts_write_new_pmode’: ../../../ui/gtk/prefs_capture.c:2055:18: error: variable ‘all_pmode’ set but not used [-Werror=unused-but-set-variable]
svn path=/trunk/; revision=48279
2013-03-13 15:56:35 +00:00
Irene Rüngeler
44e6a88b13 Add interface options preferences.
svn path=/trunk/; revision=48275
2013-03-13 12:38:08 +00:00
Anders Broman
2cc00294c7 Use explicit casts.
svn path=/trunk/; revision=48260
2013-03-12 06:41:00 +00:00
Bill Meier
f97e7fa8ee Update GTK3 port status.
svn path=/trunk/; revision=48245
2013-03-11 17:26:03 +00:00
Bill Meier
978d314630 GTK3 "expand" handling changes.
As suggested by Peter Hatini in the patch attached to Bug #8315.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8315


svn path=/trunk/; revision=48244
2013-03-11 17:15:54 +00:00
Bill Meier
5662419a06 Remove leftover "//".
svn path=/trunk/; revision=48242
2013-03-11 16:28:11 +00:00
Bill Meier
ed9c682383 From the proposed patch by Peter Hatina in Bug #8315.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8315


svn path=/trunk/; revision=48241
2013-03-11 16:18:41 +00:00
Bill Meier
db5727f34c Set the "Capture Options" window as the parent ('transient_for') of the "Interface Management" window.
svn path=/trunk/; revision=48240
2013-03-11 15:46:04 +00:00
Anders Broman
ac2515ee6f Use explicit casts.
svn path=/trunk/; revision=48239
2013-03-11 06:47:34 +00:00
Bill Meier
60b9be7c7b "Capture ! Options ! Manage Interfaces": Cleanup handling of Window epansion.
Improves 'expand' handling for both Gtk2 & Gtk3;

Adapted (with additions by me) from a proposed patch by Peter Hatina (Bug #8315).

Also:

1. Don't use gtk_widget_set_size() in several cases when a single use of
   gtk_window_set_default_size() for the "Manage Interfaces" window is sufficient.

2. Add an XXX comment as to a specific call to 'gtk_window_destroy_with_parent'
   actually being a no-op on Windows.

svn path=/trunk/; revision=48237
2013-03-11 01:11:38 +00:00
Anders Broman
98387d0498 Use explicit casts.
svn path=/trunk/; revision=48232
2013-03-10 16:56:40 +00:00
Anders Broman
deefa09237 Use explicit casts.
svn path=/trunk/; revision=48217
2013-03-09 17:33:15 +00:00