Commit graph

50 commits

Author SHA1 Message Date
Widok
970197c19f Corrected mrp decoding of link up and down
Added DCP decoding of reset to factory
removed unused value_strings
corrected decoding of PDSubFrameBlock
most of the length display added a dec_hex display


Signed-off-by: Widok <kellingwido@aol.com>
Change-Id: I17b59b45eff37b65047a7a3e5e275f01a37ee616
Reviewed-on: https://code.wireshark.org/review/517
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2014-03-05 18:53:50 +00:00
Alexis La Goutte
296591399f Remove all $Id$ from top of file
(Using sed : sed -i '/^ \* \$Id\$/,+1 d')

Fix manually some typo (in export_object_dicom.c and crc16-plain.c)

Change-Id: I4c1ae68d1c4afeace8cb195b53c715cf9e1227a8
Reviewed-on: https://code.wireshark.org/review/497
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-03-04 14:27:33 +00:00
Anders Broman
451c30ef81 Fix [-Wmissing-prototypes]
svn path=/trunk/; revision=54528
2014-01-01 12:17:57 +00:00
Jakub Zawadzki
ae59b09443 Add missing includes in order to remove exceptions.h from proto.h (next commit).
svn path=/trunk/; revision=53230
2013-11-10 15:59:37 +00:00
Jakub Zawadzki
1899903f69 Include <epan/to_str.h> only when needed.
svn path=/trunk/; revision=53189
2013-11-09 13:41:10 +00:00
Pascal Quantin
953c6fed13 emem -> wmem
svn path=/trunk/; revision=52130
2013-09-17 21:34:05 +00:00
Michael Mann
7ec34a52c5 expert_add_info_format_text -> expert_add_info_format
svn path=/trunk/; revision=51850
2013-09-09 00:11:19 +00:00
Michael Mann
dffc4fefc6 Batch (some of) the plugins to filterable expert infos. The Profinet plugin started to get a bit complex in determining filter names (especially the DCOM stuff), so I'll leave that to someone more familiar with the protocol.
svn path=/trunk/; revision=49624
2013-05-29 23:41:33 +00:00
Pascal Quantin
4d63de1b41 From Ed Beroset via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416 :
Remove C++ incompatibilities from profinet plugin

svn path=/trunk/; revision=48039
2013-03-03 18:45:23 +00:00
Bill Meier
f784806968 Comment out numerous unused hf_.... instances found by checkhf.
svn path=/trunk/; revision=47617
2013-02-10 20:52:21 +00:00
Bill Meier
5a8c275b26 General cleanup:
- Localize some variables; remove unneeded initializers;
- Reformat some hf[] entries;
- Whitespace; style; long lines.

svn path=/trunk/; revision=46529
2012-12-13 18:17:47 +00:00
Bill Meier
708e463c47 From Wido Kelling: [Profinet] Updated disecction regarding the IEC 61158
(with a few minor fixes by me).

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8002

major change:
 reassembling of PNIO fragments (only works if OpenSafty dissector is disabled)

minor changes:
 improved handling of DFP Frames

added / updated
 MRP Block decoding
 ARServerBlock
 ARVendorBlock
 PDInterfaceDataReal
 PDInterfaceAdjust
 PDPortStatistic
 SubdirFrameData corrected display and subblocks added
 PDIRGlobalData complete dissection
 decoding of FrameDataProperties and ARTypes updated to conform the STD
 removed now usuported RTC2 ranges


svn path=/trunk/; revision=46522
2012-12-12 18:47:59 +00:00
Alexis La Goutte
26f28b0427 Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
svn path=/trunk/; revision=45219
2012-09-30 11:06:28 +00:00
Alexis La Goutte
84f7a07047 From Yu Zhang via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7769
Add Dissector for SuboptionDeviceInstance under DevicePropertiesOption in PROFINET DCP

In PROFINET DCP dissector, current build didn't have SuboptionDeviceInstance
(0x07) under DevicePropertiesOption (0x02). This patch add the support of
SuboptionDeviceInstance

svn path=/trunk/; revision=45218
2012-09-30 11:02:56 +00:00
Jeff Morriss
3551a86c36 We always HAVE_CONFIG_H so don't bother checking whether we have it or not.
svn path=/trunk/; revision=45015
2012-09-20 01:29:52 +00:00
Jakub Zawadzki
5a8783f5b1 Initial commit to support yet another method of passing data between dissectors.
Add new parameter 'data' to heur_dissector_t and new_dissector_t, for now it's always NULL

svn path=/trunk/; revision=44860
2012-09-10 21:40:21 +00:00
Jakub Zawadzki
bf81b42e1e Update Free Software Foundation address.
(COPYING will be updated in next commit)

svn path=/trunk/; revision=43536
2012-06-28 22:56:06 +00:00
Bill Meier
1783543e92 AFAICT '#include sys/types.h' is not needed for these files.
svn path=/trunk/; revision=42446
2012-05-05 21:29:13 +00:00
Bill Meier
ef8009abe3 Use ENC_NA as encoding for proto_tree_add_item() calls which directly reference an hf item (in hf[] with types:
FT_NONE
    FT_BYTES
    FT_IPV6
    FT_IPXNET
    FT_OID

Note: Encoding field set to ENC_NA only if the field was previously TRUE|FALSE|1|0|ENC_LITTLE_ENDIAN|ENC_BIG_ENDIAN

svn path=/trunk/; revision=39262
2011-10-05 01:00:06 +00:00
Stig Bjørlykke
333ef8b5b7 Removed unused hf_pn_dcp and hf_pn_ptcp.
svn path=/trunk/; revision=34544
2010-10-17 16:49:10 +00:00
Anders Broman
e611923124 Get rid of check_col().
svn path=/trunk/; revision=32428
2010-04-08 15:51:44 +00:00
Anders Broman
440c3f9261 From Didier Gautheron:
check_col.diff
Remove redundant calls to check_col() if it guards only one columns function with one parameter after the column type.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4394

svn path=/trunk/; revision=31519
2010-01-13 20:32:01 +00:00
Anders Broman
7bff8c664b From Benjamin Meyer:
PROFINET DCP ResetFactorySettings not decoded.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4090

svn path=/trunk/; revision=30320
2009-10-04 19:31:02 +00:00
Kovarththanan Rajaratnam
633bb05380 Use col_set_str instead of col_add_fstri/col_add_str when adding constant strings to COL_PROTOCOL
svn path=/trunk/; revision=30088
2009-09-23 14:43:23 +00:00
Stig Bjørlykke
2bba6be84f From Kovarththanan Rajaratnam via bug 3548:
Cleanup header_field_info in plugins.

svn path=/trunk/; revision=28771
2009-06-18 23:22:10 +00:00
Jaap Keuter
b7dc0a3e51 From Reinhard Speyerer:
This patch fixes several misspellings/typos in Wireshark SVN revision 28201.

svn path=/trunk/; revision=28204
2009-05-01 06:58:28 +00:00
Guy Harris
2ba37de400 Fix uninitialized variable.
More indentation cleanups.

svn path=/trunk/; revision=27306
2009-01-26 23:48:10 +00:00
Guy Harris
248db0a42a Non-constant strings should not be used as format items; the format
should be "%s", with the string used as an argument, just in case the
string contains a "%" character.

Clean up indentation.

svn path=/trunk/; revision=27304
2009-01-26 22:58:47 +00:00
Ulf Lamping
269cec3108 add some expert infos
svn path=/trunk/; revision=27298
2009-01-26 19:52:19 +00:00
Ulf Lamping
bd8528644e fix BlockError strings
svn path=/trunk/; revision=25490
2008-06-19 18:44:23 +00:00
Ulf Lamping
adccc10596 add some parentheses as suggested by the OS X buildbot
svn path=/trunk/; revision=24122
2008-01-17 19:30:35 +00:00
Ulf Lamping
6cfbb485bf better conformance to the released DCP protocol spec:
- redesign/refactoring the code to support BlockQualifier
- fix handling of BlockInfo 
- rename some display strings for better spec conformance
- remove LLDP suboption

svn path=/trunk/; revision=24120
2008-01-17 18:29:51 +00:00
Ulf Lamping
0104002d2e Add PN-IO FSHelloBlock and PN-DCP Device/AliasName
svn path=/trunk/; revision=21298
2007-04-02 05:18:31 +00:00
Ulf Lamping
d6e22b2d9a major code cleanup:
- move dcom-cba and pn-rt files into profinet plugin (where they really belong)
- move some common pn functionality into new packet-pn.c/h instead of having duplicate code

svn path=/trunk/; revision=20825
2007-02-16 21:53:36 +00:00
Ulf Lamping
2981e4022a remove some warnings (2nd try)
svn path=/trunk/; revision=18635
2006-07-01 15:14:19 +00:00
Ulf Lamping
66318ef7e1 remove some "signedness" warnings
svn path=/trunk/; revision=18633
2006-07-01 12:15:37 +00:00
Ulf Lamping
1896e7021d squelch some compiler warnings
svn path=/trunk/; revision=18560
2006-06-23 18:03:40 +00:00
Ulf Lamping
a016d9ee45 fix a (correct) compiler warning
svn path=/trunk/; revision=18548
2006-06-22 19:17:43 +00:00
Ulf Lamping
1d51934de2 add an expert info if a capture file contains some (yet) undecoded portions
svn path=/trunk/; revision=18534
2006-06-21 18:35:39 +00:00
Ronnie Sahlberg
89f022b12b name change
svn path=/trunk/; revision=18197
2006-05-21 05:12:17 +00:00
Ulf Lamping
2e2c970da9 replace g_malloc and alike by their corresponding ep_ functions
svn path=/trunk/; revision=17576
2006-03-11 09:08:18 +00:00
Ulf Lamping
60869fe1cc various code cleanup (e.g. remove unrequired length parameter), should also fix coverity id 126
svn path=/trunk/; revision=17569
2006-03-10 21:34:56 +00:00
Ronnie Sahlberg
3a92bf963c fix coverity bug 122
svn path=/trunk/; revision=17527
2006-03-08 10:59:05 +00:00
Ulf Lamping
eefbb60770 minor enhancements
svn path=/trunk/; revision=16485
2005-11-12 09:39:24 +00:00
Ulf Lamping
e90ebfad09 minor enhancement (raised plugin version to 0.1.2):
PN-DCP: dissection of "DHCP/DHCP client identifier" suboption was added

svn path=/trunk/; revision=16377
2005-11-02 19:33:46 +00:00
Guy Harris
25c4bc9379 Replace tvb_memcpy() calls that extract IPv4 addresses into a guint32,
and that extract IPv6 addresses into a "struct e_in6_addr", with
tvb_get_ipv4() and tvb_get_ipv6() calls - except for some that we
remove, by using proto_tree_add_item(), rather than replacing.

Have epan/tvbuff.h include epan/ipv6-utils.h, to define "struct
e_in6_addr" (not necessary to declare the tvbuff routines, but including
it there means "struct e_in6_addr" is guaranteed to be defined before
those declarations, so we don't get compiler complaints if we define it
*after* those declarations).

svn path=/trunk/; revision=15758
2005-09-11 21:25:37 +00:00
Jörg Mayer
4f693dfae2 Some warning fixes for "no previous declaration"
Remove svn:executable
Add svn:eol-style native
Add svn:keywords Id


svn path=/trunk/; revision=15179
2005-08-02 05:39:45 +00:00
Jörg Mayer
30a8557868 More 'char*' -> 'const char*' changes to fix warnings.
svn path=/trunk/; revision=15015
2005-07-23 11:41:25 +00:00
Gerald Combs
3a6c9ab134 Fix a format string vulneratility in the AFP dissector identified
by iDEFENSE.  Add constant format strings to proto_item_append_text()
in a bunch of other dissectors.  Copy a comment from proto.c to proto.h.

svn path=/trunk/; revision=14713
2005-06-20 19:35:58 +00:00
Ulf Lamping
4e3c0cde68 move the pn-dcp dissector into the profinet plugin
svn path=/trunk/; revision=14285
2005-05-03 01:39:00 +00:00
Renamed from epan/dissectors/packet-pn-dcp.c (Browse further)