Commit graph

7955 commits

Author SHA1 Message Date
Guy Harris
23aa226b33 The AODV draft cited in the dissector says that extensions are
supported, and the AODV6 drafts cited say that the AODV6 extensions are
the same as the AODV ones.  Dissect extensions in both AODV and AODV6.

Use "exttype_vals[]" to get the name of the extension.

svn path=/trunk/; revision=7997
2003-07-09 03:59:59 +00:00
Gilbert Ramirez
6a8701fb67 Script to unit-test ftype functions via dfilters passed to tethereal.
Uses text2pcap to create pcap trace files from hex-dumps embedded in the
test script.

svn path=/trunk/; revision=7996
2003-07-09 03:57:34 +00:00
Guy Harris
eabf70db65 Replace "hf_scsi_log_pc" with separate "hf_scsi_logsel_pc" and
"hf_scsi_logsns_pc" fields, with the latter using "scsi_logsns_pc_val[]"
as its value_string table (the names are different).

Rename "scsi_modesense_medtype_val[]" to
"scsi_modesense_medtype_sbc_val[]", as it's specific to block devices;
add in additional information from a SCSI-3 Block Commands draft, and
have "dissect_scsi_modeselect6()" and "dissect_scsi_modeselect10()" use
it if the device is a block device.

Get rid of "scsi_inq_evpd_val[]", as it's not used and is redundant (we
already have "scsi_evpd_pagecode_val[]".  Add the Implemented operating
definition page to the latter table.

Fix up a "val_to_str()" call to include a format string in the "if
unknown" format, so the value is shown.

svn path=/trunk/; revision=7995
2003-07-09 03:42:55 +00:00
Guy Harris
94c2ea7e5b From Lars Roland: export "dissect_h245_OpenLogicalChannel()" and
"dissect_h245_MultimediaSystemControlMessage()" for use in the future by
other dissectors.

svn path=/trunk/; revision=7994
2003-07-08 18:16:44 +00:00
Guy Harris
259609e677 Don't define "vals_wsp_reason_codes[]" in "packet-wsp.h", define it in
"packet-wsp.c", and just *declare* it in "packet-wsp.h" - no need to
have everybody who includes "packet-wsp.h" get their own copy
(especially as they might not use it).

svn path=/trunk/; revision=7993
2003-07-08 18:10:39 +00:00
Guy Harris
b1dd70cb3e Make the top-level protocol tree entry cover all the data being
dissected, rather than none of it.

Clean up white space.

svn path=/trunk/; revision=7992
2003-07-08 17:42:24 +00:00
Jörg Mayer
6846c011e7 -dlopen didn't work on some platforms/in some environments (for me, the
problem became evident with an update from autoconf 2.52 to 2.53).
Worked around a bug in libtool that caused -dlopen to be ignored (and
things being linked into the code instead).
Many many thanks to Dirk M�ller for providing me with the workaround!

svn path=/trunk/; revision=7991
2003-07-08 13:09:37 +00:00
Ronnie Sahlberg
6b720cd68f remove one more redundant decode of the extensions present bit.
change the decode of sequence and extensions  to assume the lower bound for the number of extensions is 1 and thus 1 have to be added to the encoded value.

dont know if this is right or not, the satndard x691 does not mention anything
about the lb being 1 and the value being semiconstrained but a note at 18.8
does mention that the number of extensions can not be 0.

i think there is a difference between saying a value can not be zero and
between saying the lower bound is 1.  but hey it is a telco standard.

the change might be right or it might be wrong.
i think it is wrong or else the standard is wrong.
it at least dissects the very few captures i have properly.
telco guys, either give feedback or live with the dissector being potentially
wrong.
its that easy.

svn path=/trunk/; revision=7990
2003-07-08 11:39:45 +00:00
Ronnie Sahlberg
790e4a1b78 fix a small bug in dissect_per_choice where it dissected and displayed a bit for "extensions present" even if that bit was not encoded in the pdu.
svn path=/trunk/; revision=7989
2003-07-08 11:03:12 +00:00
Ronnie Sahlberg
9352374151 when extensions are present to a sequence,
for the individualk bits in the bitmap field for whether each extension
is present or not, add "(<extension name> [is|is NOT] present)" to the
tree item.

this makes the dissection of the extension bitmap more meaningful

svn path=/trunk/; revision=7988
2003-07-08 10:35:17 +00:00
Ronnie Sahlberg
9fb50f7318 When decoding the optional field bitmap for a sequence,
for the individual bits,  if we know the name of the optional field
then put "<field name> [is|is NOT] present"  into the tree pane
so we can see what each bit in this field refers to.

svn path=/trunk/; revision=7987
2003-07-08 10:22:20 +00:00
Ronnie Sahlberg
94e862eeb6 change the interfae so that dissect_per_boolean() also can return the proto_item
that was created to display the value.

svn path=/trunk/; revision=7986
2003-07-08 10:08:22 +00:00
Guy Harris
3368b84541 Put in stuff to dissect the body of a cause IE, just as the Q.2931
dissector does.

svn path=/trunk/; revision=7985
2003-07-08 07:56:27 +00:00
Guy Harris
d52c79cc0c Get rid of "q2931_cause_coding_standard_vals[]" - it's a duplicate of
"coding_std_vals[]".

Add a bunch of cause codes from Q.850.

Use "q2931_rejection_reason_vals[]", not "q2931_cause_condition_vals[]",
for rejection reason values.

svn path=/trunk/; revision=7984
2003-07-08 07:55:10 +00:00
Guy Harris
d1819d7c34 As "dissect_ap_options()" isn't compiled in, don't mark its arguments as
unused; presumably it'll either

	1) get written, in which case if an argument isn't used it
	   shouldn't be supplied

or

	2) be removed, in which case there aren't any arguments.

svn path=/trunk/; revision=7983
2003-07-08 06:39:13 +00:00
Tim Potter
db76d47952 Added prototype for p_rem_proto_data()
Fixed bug in said function which prevented it from actually working.

svn path=/trunk/; revision=7982
2003-07-08 05:29:42 +00:00
Tim Potter
05330d4ac9 Fix some unused parameter and function warnings.
svn path=/trunk/; revision=7981
2003-07-08 04:06:26 +00:00
Guy Harris
e3f7c2bb89 %yynowrap forces "yywrap()" to be a macro that returns 1, so there's no
need to define "ascendwrap()" to return 1 - "ascendwrap()" is no longer
used.

svn path=/trunk/; revision=7980
2003-07-08 02:11:09 +00:00
Gilbert Ramirez
ffb5f848c7 ntp.precision is a signed 8-bit integer, according to the code and to
RFC 2030. Make it an FT_INT8 field instead of FT_UINT8.

svn path=/trunk/; revision=7979
2003-07-08 01:52:19 +00:00
Guy Harris
64f3f56c6b From Aamer Akhter: PWE updates.
svn path=/trunk/; revision=7978
2003-07-08 00:46:26 +00:00
Guy Harris
c664749b18 Typo fix, from Brad Hards.
svn path=/trunk/; revision=7977
2003-07-07 22:59:54 +00:00
Guy Harris
40a25a5519 From Darren Steele: fetch the delivery time from the correct offset.
svn path=/trunk/; revision=7976
2003-07-07 22:55:55 +00:00
Guy Harris
19e0e3dc85 From Brad Hards: Jabber client-to-server protocol support.
svn path=/trunk/; revision=7975
2003-07-07 22:48:55 +00:00
Guy Harris
ecb79f8973 From Olivier Biot: use "fragment_add_seq_check()" so that we don't have
a problem with message IDs getting reused.

svn path=/trunk/; revision=7974
2003-07-07 22:42:11 +00:00
Guy Harris
924136d7d7 A couple of captures have been seen with the first (low-order) byte of
the network type being 1 and the byte after it being 2; we assume, for
now, that the network type is 1 byte, and that if the byte after it is
0, the network type is an NDIS type - 1, and if it's 2, it's an NDIS type.

svn path=/trunk/; revision=7973
2003-07-07 21:08:49 +00:00
Guy Harris
2bb321d981 Mark the "plugin_dir" argument to "proto_init()" as unused if we don't
have plugin support.  (Don't do so if we *do* have it, because if
"proto_init()" ever changes so that it doesn't use the argument even if
we have plugin support, we want a warning so we know that we should get
rid of that argument.)

svn path=/trunk/; revision=7972
2003-07-07 20:29:45 +00:00
Michael Tüxen
d06dd8a3e9 Fixed a bug in the handling of DATA 1 and DATA 2 parameter handling
reported by Michael Lum.

svn path=/trunk/; revision=7971
2003-07-07 12:51:38 +00:00
Ronnie Sahlberg
634693b1f5 If we dont want the internal per stuff to be displayed,
dont put the object identifier length field in the tree.

svn path=/trunk/; revision=7970
2003-07-07 10:30:36 +00:00
Ronnie Sahlberg
d516f11660 Attempt to decode GeneralString.
RFC2833 is a bit "unclear" but I guess this type is encoded
as first a length-determinant followed by the actual ascii data.

I belive the length-determinant is byte aligned in aligned-per so the entire
field is so.

at best, this is pure guesswork  but it does decode the single capture i do have containing GeneralString types properly.

Anyone interested are welcome to purchase and provide
proper h323 standard docs from itu-t and snail-mail them to me.
A random asn file from www.packetyzer.com together with the X.691 pdf file is
"difficult".

svn path=/trunk/; revision=7969
2003-07-07 10:22:59 +00:00
Ronnie Sahlberg
70d5abe409 minor updates
add a gboolean which controls whether the internal PER fields are to be displayed or not in the tree pane.

svn path=/trunk/; revision=7968
2003-07-06 11:11:41 +00:00
Ronnie Sahlberg
a8b3756214 Small updates.
Replace dissect_h245_TransportAddress()  which was the generic decoder for the TransportAddress sequence  with several semi-identical routines that matches the name of the field (instead of the type).
This makes the presentation easier to read.

e.g.  Present this ip address as mediaChannel  which is the field name instead of as TransportAddress

svn path=/trunk/; revision=7967
2003-07-06 10:29:14 +00:00
Guy Harris
511b5486df From Gregory Stark: fix up the check for packets not in a given
connection to check for addresses and ports at the same time, rather
then checking the source addresses, destination addresses, and ports
separately, as the latter doesn't handle A:X->B:Y and B:X->A:Y both
being active connections.

svn path=/trunk/; revision=7966
2003-07-06 00:30:40 +00:00
Guy Harris
a99b2c3b2b From Nathan Jennings: "g_list_remove_link()" doesn't free the list item
itself, so we leaked memory when freeing the interface list; in
"free_interface_list()", use "g_list_foreach()", calling a list free
routine, to free the data items in the list, and then use
"g_list_free()" to free the list.

Use "free_interface_list()" in "get_interface_list()" to free the list
if we have an error, as it now does what the code that use to be there
did.

svn path=/trunk/; revision=7965
2003-07-06 00:07:59 +00:00
Guy Harris
33bdfd46d7 From Lars Roland: load WinPcap *before* constructing the information
about library versions.

svn path=/trunk/; revision=7964
2003-07-04 23:50:10 +00:00
Ronnie Sahlberg
34772e0b82 work copy of a h245 dissector and PER dissection helper routines.
read the comment at the top of the file for instructions on how to activate it and what needs to be done.

svn path=/trunk/; revision=7963
2003-07-04 09:24:00 +00:00
Gilbert Ramirez
803619a6dd Use FLT_DIG and DBL_DIG from float.h to create printf-style print format
for FT_FLOAT and FT_DOUBLE values.

svn path=/trunk/; revision=7962
2003-07-04 03:41:00 +00:00
Tim Potter
8a8ea353c8 The Windows 2000 global catalog is LDAP on TCP port 3268, as per IANA assigned
port numbers document.

svn path=/trunk/; revision=7961
2003-07-03 01:52:11 +00:00
Guy Harris
69a9858068 From Olivier Biot:
Short Message reassembly;

	Preference to allow automatic decoding of Short Message data as
	CL-WSP if a Port Number UDH is present.

Use "%u" rather than "%d" for unsigned quantities.

Use "tvb_get_ntohs()" to fetch big-endian 16-bit quantities rather than
calling "tvb_get_guint8()" twice and reassembling yourself.

svn path=/trunk/; revision=7960
2003-07-02 21:10:50 +00:00
Tim Potter
5a0b626674 Dissect LDAPv3 search result references (s4.5.3 in rfc 2251).
svn path=/trunk/; revision=7959
2003-07-02 04:03:27 +00:00
Guy Harris
e0666c0dd8 BSD AF_ values are generally given in decimal, not hex, so display them
as such.

svn path=/trunk/; revision=7958
2003-07-02 00:08:17 +00:00
Guy Harris
176d16241b From Christoph Wiest: redo MEGACO dissector to more fully parse
text-format messages.

svn path=/trunk/; revision=7957
2003-07-01 08:00:06 +00:00
Guy Harris
71fefcc0c4 From Adam Sulmicki: report the message type for accounting status
messages and accounting messages.

svn path=/trunk/; revision=7956
2003-07-01 03:59:11 +00:00
Guy Harris
57d229babe Make "cb_str_postprocess()" work like "cb_wstr_postprocess()" by using
"tvb_get_string()" rather than "tvb_format_text()".  (This fixes a
problem wherein we freed the return value of "tvb_format_text()", which
we should not do as "tvb_format_text()" doesn't dynamically allocate the
buffer it returns, but means that we don't handle non-printable
characters - but that's a problem with "cb_wstr_postprocess()" as well,
as "tvb_fake_unicode()" also doesn't handle non-printable characters
specially; we should fix the problem in *both* routines.)

svn path=/trunk/; revision=7955
2003-07-01 00:59:43 +00:00
Guy Harris
299f79c4f7 From Olivier Biot:
UDH dissection in SMPP message
	WTP and WSP dissection over SMPP (no reassembly)
	WSP status code rendering in Info column

svn path=/trunk/; revision=7954
2003-06-30 23:24:39 +00:00
Guy Harris
dd544457db Get rid of a value_string table that's not used.
svn path=/trunk/; revision=7953
2003-06-30 21:58:41 +00:00
Guy Harris
862a1f0e4c Move definitions of value_string tables out of header files and into
source files, so that they're not defined in every file that includes
the header file, regardless of whether the file uses the table (in which
case it should be defined in one file, and externally referenced in
other files) or not (in which case it should't be defined in that file
at all).

Get rid of a boilerplate comment paragraph that doesn't apply.

svn path=/trunk/; revision=7952
2003-06-30 21:50:18 +00:00
Guy Harris
3fd9b8f6f4 Some versions of GDB create a ".gdb_history" file; ignore it in CVS.
svn path=/trunk/; revision=7951
2003-06-30 21:31:41 +00:00
Guy Harris
bb71a25dd1 Fix a cut-and-pasteo.
svn path=/trunk/; revision=7950
2003-06-30 21:30:54 +00:00
Guy Harris
4cdfa9c59e From Lionel Ains:
don't assume that a dissector handle has a protocol associated
	with it (there's none for the "OSI network layer" dissector, for
	example, as that dissector hands off to one of several protocols
	based on the NLPID);

	rename a few functions to have names that better explain what
	they do;

	have separate functions to show all the layer types (dissector
	tables) and to show all the protocols supported for a layer
	type, and have both of them take, as an argument, the standard
	I/O stream to which they should write;

	improve the parser for the "-d" option to give more information
	on errors;

	fix up some comments.

svn path=/trunk/; revision=7949
2003-06-30 00:58:18 +00:00
Guy Harris
98e7c94dc1 Use the "rx_frm_len" field from the trace packet data record header,
rathe than the record length minus the record header length, as the
number of available (captured) bytes in the packet.  Check to make sure
that value isn't bigger than the record length minus the header length.

Only subtract the 4-byte FCS length from the purported length of the
packet on the wire if that would leave the on-the-wire length >= the
number of captured bytes, so that we can better handle capture files
from programs that produce LANalyzer-format captures where the
on-the-wire length *doesn't* include the FCS.

svn path=/trunk/; revision=7948
2003-06-30 00:41:33 +00:00