Commit Graph

5 Commits

Author SHA1 Message Date
Peter Wu 14085e043a Revert "Another message from Clang for unknown -f and -m flags."
This reverts commit 5e5e2019ee.

This change was proposed in https://cmake.org/Bug/view.php?id=13194 to
catch some Clang warnings concerning invalid -m flags, but it is causing
legitimate breakage when setting CMAKE_C_FLAGS=-gsplit-dwarf.
CMakeFiles/CMakeError.log shows:

    /usr/bin/clang  -gsplit-dwarf -DC__W_VALID    CMakeFiles/cmTC_04cc8.dir/src.c.o  -o cmTC_04cc8 -rdynamic
    clang-3.7: warning: argument unused during compilation: '-gsplit-dwarf'

With the additional regex, basic checks (like -Wall but also -fPIE) are
incorrectly reported as unsupported. Follow upstreams action here and
remove it, it is still not present as of CMake 3.3.2.

Change-Id: I8a1e97b16c2bb929436cca669fdb42f33612c490
Reviewed-on: https://code.wireshark.org/review/10880
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Jörg Mayer <jmayer@loplof.de>
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2015-10-14 16:53:36 +00:00
Joerg Mayer 8fdd49aaa1 Duplicate CheckCCompilerFlag for CXX.
Correctly detect that XCode7Beta1 does not support -fno-delete-null-pointer-checks
  by adding a new regex.

Change-Id: I76e0b6bb72094e6e75dae9be97bc7ee8e7051792
Reviewed-on: https://code.wireshark.org/review/9552
Reviewed-by: Jörg Mayer <jmayer@loplof.de>
2015-07-08 07:16:01 +00:00
Guy Harris 5e5e2019ee Another message from Clang for unknown -f and -m flags.
For -f and -m flags that don't apply to the target architecture(?),
Clang doesn't fail but does print a warning "argument unused during
compilation: '-{flag}'".  Catch that and treat it as a failure
indication, so we don't use that flag.

Change-Id: I65948ada41fa44fb62f9a2b8b320f137a5902b8f
Reviewed-on: https://code.wireshark.org/review/2399
Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-06-18 18:46:09 +00:00
Jörg Mayer 7a324cfcd6 Fix a bug that will prevent the extra flags from being honored.
svn path=/trunk/; revision=50876
2013-07-24 20:42:11 +00:00
Jörg Mayer ae6007ab11 Copy over from cmake git head as it fixes a bug:
The detection will not work if the locale is non-English

svn path=/trunk/; revision=50875
2013-07-24 20:40:40 +00:00