Commit Graph

21471 Commits

Author SHA1 Message Date
Guy Harris 7f97cc813e From Cal Tunney:
contify some arrays;

	don't complain about "print.command" on Windows, just ignore it,
	as it's valid on non-Windows platforms;

	fix some comparisons for preferences moved elsewhere;

	clean up some comments.

svn path=/trunk/; revision=49485
2013-05-21 21:28:41 +00:00
Guy Harris dc8af1b552 Clean up white space.
svn path=/trunk/; revision=49484
2013-05-21 20:38:51 +00:00
Michael Mann 1bdf3446c5 From Michal Labedzki via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8700 :
Highlight correct bytes in some SDP trees.

svn path=/trunk/; revision=49481
2013-05-21 13:27:48 +00:00
Michael Mann 77b1d9b323 add a few filterable fields/expert info
svn path=/trunk/; revision=49479
2013-05-21 12:55:55 +00:00
Michael Mann 2369729832 use ep_ allocated memory instead of g_ allocated.
svn path=/trunk/; revision=49478
2013-05-21 12:54:08 +00:00
Anders Broman 51723864c1 - Move the export_pdu tap outside of if(tree)
- Have the diameter tap request a tree.

svn path=/trunk/; revision=49475
2013-05-21 05:47:20 +00:00
Anders Broman b8618947bd Add missing element NSAP to IE Evolved Allocation/Retention Priority II.
svn path=/trunk/; revision=49474
2013-05-21 05:08:50 +00:00
Michael Mann 478ee0ae73 DHCPv6 option 56, RFC 5908
Bug 8421 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8421)

svn path=/trunk/; revision=49473
2013-05-21 03:24:55 +00:00
Michael Mann 24df2990e5 Use col_set_fence() functionality to remove an unnecessary global variable.
svn path=/trunk/; revision=49472
2013-05-21 02:08:40 +00:00
Michael Mann f04a801716 Minor cleanup. Removal of unnecessary packet_info* global variable
svn path=/trunk/; revision=49471
2013-05-21 02:04:41 +00:00
Evan Huus 575aba0a05 Fix format string typo.
svn path=/trunk/; revision=49470
2013-05-21 00:11:10 +00:00
Michael Mann e39b328f0d add a few more filterable items.
svn path=/trunk/; revision=49469
2013-05-20 23:56:47 +00:00
Jeff Morriss 8730b3e8c5 Fix:
Error: the blurb for hf_048_030_WE ("asterix.048_030_WE") matches the field name in epan/dissectors/packet-asterix.c

Also remove a few blurbs which aren't exact matches but are basically the same.

svn path=/trunk/; revision=49468
2013-05-20 23:23:34 +00:00
Evan Huus 5484210e11 More compiler warning fixes...
svn path=/trunk/; revision=49461
2013-05-20 20:45:52 +00:00
Evan Huus 0a0b6bf6c2 Third time lucky, hopefully fix the last of the compiler warnings...
svn path=/trunk/; revision=49460
2013-05-20 20:30:23 +00:00
Evan Huus 148d363586 Use doubles and FT_DOUBLE for better precision and to avoid a large
number of compiler warnings for systems where floats are 32 bits, but
floating-point literals default to 64-bit doubles.

svn path=/trunk/; revision=49459
2013-05-20 20:16:03 +00:00
Evan Huus 98d005506a Fix some compile warnings, and spread a struct definition over multiple
lines to make it obvious where the 32-bit cast is needed, since it's not
at all obvious to me...

svn path=/trunk/; revision=49458
2013-05-20 19:56:04 +00:00
Evan Huus 230205de79 From Marko Hrastovec via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8579
Dissector for ASTERIX (a radar data and air traffic controller protocol).

svn path=/trunk/; revision=49457
2013-05-20 19:23:41 +00:00
Anders Broman 9327da8ffa From Tom Bottom:
Addition of STREAM_VLAN_ID field to GET_STREAM_INFO and SET_STREAM_INFO pdu in packet-ieee17221.c

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8698

svn path=/trunk/; revision=49450
2013-05-20 18:41:46 +00:00
Anders Broman 631b77e47a Remove #if 0:ed code.
svn path=/trunk/; revision=49449
2013-05-20 18:38:34 +00:00
Anders Broman e3f8090f76 Add export_pdu_tap to packet-diameter.c
svn path=/trunk/; revision=49448
2013-05-20 18:30:32 +00:00
Anders Broman 6a3a3c228c Make preparation to select which level tap is to be used.
svn path=/trunk/; revision=49446
2013-05-20 17:48:09 +00:00
Alexis La Goutte 771675cfa5 From me via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8631
Fix to honour the Response Bit/Opcode implementation,
as e.g. a map response opcode is not 129 as per 1000 0001 but should be
Response bit =1 / Opcode =1.

* Rename opcode variable to ropcode (and pcp_ropcode_vals)
* Use pcp_opcode for hf_pcp_opcode
* Add hf for R item (and add tfs)
* Fix bitmask for opcode

Also fix warning found by encoding-args tool.

svn path=/trunk/; revision=49445
2013-05-20 17:33:44 +00:00
Gerald Combs c0702583d3 Make the minimum supported GLib version 2.16.
svn path=/trunk/; revision=49444
2013-05-20 17:27:05 +00:00
Evan Huus 4444bdca61 Fix typo s/ENCNA/ENC_NA/
svn path=/trunk/; revision=49442
2013-05-20 17:06:07 +00:00
Alexis La Goutte 694c6c2e3a Add Modelines Info and fix warning from fix-encoding-args tools
svn path=/trunk/; revision=49438
2013-05-20 16:31:54 +00:00
Alexis La Goutte d86a5a8013 From david19801118 via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8680 Add decryption for WPA eapol 4-way handshake
Wireshark can't decode eapol packet which using WPA properly.
(decode eapol packaet which using WPA2 is work well.)

svn path=/trunk/; revision=49437
2013-05-20 16:31:44 +00:00
Anders Broman 1569217448 From Cal Turney:
When another profile is selected, its column.hidden preference is ignored.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8696

svn path=/trunk/; revision=49434
2013-05-20 05:33:18 +00:00
Anders Broman a68080a1c6 Don't access nbap_dch_chnl_info if the index is > maxNrOfDCHs
svn path=/trunk/; revision=49418
2013-05-19 15:21:33 +00:00
Ronnie Sahlberg 44e9de065d SCSI: Add support for report-one-command structure for REPORT SUPPORTED OPCODES
svn path=/trunk/; revision=49415
2013-05-19 14:45:12 +00:00
Ronnie Sahlberg a9b5d79a41 SCSI: REPORT SUPPORTED OPCODES print the reporing options in human readable
text.

svn path=/trunk/; revision=49414
2013-05-19 14:24:31 +00:00
Evan Huus 50acddcc97 Fix a memory leak by using seasonal memory for building all parts of one of
the address resolution tables.

Showed up with https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8670
although I doubt it's the cause of the crash.

svn path=/trunk/; revision=49413
2013-05-19 13:00:06 +00:00
Pascal Quantin d560c14cae Regenerate t124 dissector
svn path=/trunk/; revision=49411
2013-05-18 17:50:10 +00:00
Martin Kaiser 2592079230 distinguish between length and reported length when dissecting a packet
with DLT_USERxy

with this fix, the user-encap dissector hands over truncated packets to
the defined sub-dissector

(the previous version would assume length==reported length and throw an
execption for truncated packets)

svn path=/trunk/; revision=49409
2013-05-18 17:08:46 +00:00
Ronnie Sahlberg 783cf2eff2 SCSI: Add dissection of REPORT SUPPORTED OPCODES
svn path=/trunk/; revision=49408
2013-05-18 16:26:26 +00:00
Pascal Quantin a9ced211ac Do not display payload twice when using uncompressed profile
svn path=/trunk/; revision=49407
2013-05-18 11:41:44 +00:00
Guy Harris ba8ead5e61 Add some casts for C++ compatibility.
Make conv_get_fid() return a "const char *", as it can return a string
constant, and they are usually *not* writable.

svn path=/trunk/; revision=49400
2013-05-18 01:42:20 +00:00
Guy Harris a274d9de4a A "pointer to something" is a "void *", not a "char *". Using "void *"
avoids some alignment warnings from clang.

svn path=/trunk/; revision=49399
2013-05-18 00:45:20 +00:00
Pascal Quantin 0091c984df From Chris Bontje via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8695 :
packet-synphasor.c: use 'new_' versions of dissector registration and initialization

svn path=/trunk/; revision=49386
2013-05-17 21:24:20 +00:00
Anders Broman 6cfe8894b3 set col fence, in case there are more Diameter PDU:s in a transport message.
svn path=/trunk/; revision=49381
2013-05-17 16:24:46 +00:00
Jeff Morriss 86744b65da As suggested by Jakub: don't ep_alloc buffers for TVBs, use g_malloc()'d
memory with tvb-free-callback.

Fixes one of the "read after free" warnings from Valgrind reported in
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8197 and the one reported
in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8653

svn path=/trunk/; revision=49379
2013-05-17 14:38:36 +00:00
Guy Harris d4ad2e087c Fix some more warnings that show up on platforms with 32-bit time_t.
Get rid of double semicolons.

svn path=/trunk/; revision=49371
2013-05-17 08:09:39 +00:00
Anders Broman 4b85b45281 Squelch more warnings about empty structures.
svn path=/trunk/; revision=49366
2013-05-17 05:33:53 +00:00
Guy Harris f296630024 Squelch warnings about empty structures and chopping off 64-bit values
at 32 bits.

svn path=/trunk/; revision=49364
2013-05-17 05:25:11 +00:00
Jeff Morriss 504d830981 From Dominique Martinet via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8589 :
Theses patches add alot of new message types for the 9P protocol and its
extensions (most specifically 9P2000.L), while staying compatible with the
legacy protocol (hence the hashtable with conversation information, since
version is only known at handshake)

It is still missing alot of 9P2000.u specifics, but I don't have any server
to test it with. I'm also missing some dump to test legacy, but I'm pretty
confident I didn't break much there as it is mostly compatible, most
differences are handled using different messages, the only one that was
changed would be RERROR.


second diff also adds deeper interpretation of the protocol, by following
the conversation stream and keeping a bigger hashtable associating fid (file
handles) and file names, for easier debugging.


From me: roll the contents of the (new) packet-9p.h back into the C file.

svn path=/trunk/; revision=49363
2013-05-17 02:00:05 +00:00
Evan Huus 5dc6e4598e Use proto_tree_add_int64 for 64-bit values.
svn path=/trunk/; revision=49362
2013-05-17 00:56:54 +00:00
Evan Huus 0c2e3fb3a7 From Florian Forster via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8472
Starting with collectd 5.0, the representation of time has changed. The new
fields "TIME_HR" and "INTERVAL_HR" contain the seconds since the epoch in steps
of 2^{-30} seconds (roughly nanosecond precision). This patch adds support for
both time formats.

From me:
Permit using 64-bit integers with value-strings, as this protocol actually 
seems to needs it. We'll misbehave for named values > 2^32 but there aren't any
of those despite the field being 64 bits.


svn path=/trunk/; revision=49357
2013-05-17 00:06:26 +00:00
Evan Huus f2bdbd2b32 Use a readable name for the wmem callback test. Warn that reallocing memory
for which a callback is registered is also a fairly stupid thing to do.

svn path=/trunk/; revision=49354
2013-05-16 23:38:31 +00:00
Evan Huus 4b6ff3d829 Use slice memory for data sources, since we never have to realloc it.
svn path=/trunk/; revision=49353
2013-05-16 23:34:19 +00:00
Anders Broman b17cefcd66 From Cal Turney:
Missed p_get_proto_data() signature update in #if 0:ed code.

svn path=/trunk/; revision=49342
2013-05-16 21:00:36 +00:00