Commit Graph

19 Commits

Author SHA1 Message Date
Alexis La Goutte 50cf6ca9c3 Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang
svn path=/trunk/; revision=36701
2011-04-18 17:44:17 +00:00
Anders Broman da9d25c9eb From Samu Varjonen:
Bug fix: Incorrect presentation of Domain Identifier type and length in HIP dissector

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5649

svn path=/trunk/; revision=35818
2011-02-04 12:30:42 +00:00
Jaap Keuter a54400c59f From Samu Varjonen:
This patch fixes four issues with the Host Identity Protocol (HIP dissector:

1. The incorrect parsing of the "type 1" locator of HIP. 
2. Updates the comments to reflect the approval of RFC 5770.
3. Cosmetic change (uppercase SPI)
4. Change in the checksum dissection 
   (when the HIP packet is UDP encapsulated 0 checksum is correct).

svn path=/trunk/; revision=35777
2011-02-03 06:32:35 +00:00
Guy Harris a8bc4a0d13 Rename the routines that handle dissector tables with unsigned integer
keys to have _uint in their names, to match the routines that handle
dissector tables with string keys.  (Using _port can confuse people into
thinking they're intended solely for use with TCP/UDP/etc. ports when,
in fact, they work better for things such as Ethernet types, where the
binding of particular values to particular protocols are a lot
stronger.)

svn path=/trunk/; revision=35224
2010-12-20 05:35:29 +00:00
Bill Meier 44f9eec459 From Samu Varjonen: Whitespace cleanup
Tabs converted to 8 spaces and trailing whitespaces removed, etc.

svn path=/trunk/; revision=33086
2010-06-04 17:59:53 +00:00
Bill Meier 9beaab0ce2 From Samu Varjonen: "New patch to the locators"
See: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3378#c25

From me:
 Fix typo: "REALY_UDP_HIP" --> "RELAY_UDP_HIP";
 Cleanup whitespace.

svn path=/trunk/; revision=32276
2010-03-25 15:18:39 +00:00
Bill Meier 97767a5a7b Revert SVN #32222: The handling of TLVs within the "LOCATOR" TLV needs to be reworked.
svn path=/trunk/; revision=32228
2010-03-17 20:38:43 +00:00
Bill Meier 0c1991d488 From Samu Varjonen: Locator presentation change for HIP dissector.
See: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3378

From me: use consistent (tab) indentation; replace use of C++ style comment.

svn path=/trunk/; revision=32222
2010-03-17 18:23:56 +00:00
Bill Meier c63cb48b5b Minor changes:
- stdio/stdlib/string includes not req'd;
- Use less generic names for a few enum identifiers;
- Use coonsistent indentation in a few palces.

svn path=/trunk/; revision=32221
2010-03-17 18:08:45 +00:00
Jaap Keuter 6be946c4bb From Samu Varjonen:
svn diff of the changes after draft-ietf-hip-nat-traversal-09 was approved to
become an RFC.

svn path=/trunk/; revision=31148
2009-12-02 07:34:55 +00:00
Kovarththanan Rajaratnam 6fe1060cd1 Don't pass ep_alloc()'ed strings to col_set_str().
Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3984

svn path=/trunk/; revision=29726
2009-09-06 04:26:50 +00:00
Kovarththanan Rajaratnam 17c9803cac Sanitize epan includes
svn path=/trunk/; revision=29499
2009-08-21 20:25:24 +00:00
Kovarththanan Rajaratnam 8b515e9340 Switch a bunch of dissectors over to using tvb_new_subset_remaining()
svn path=/trunk/; revision=29446
2009-08-16 12:36:22 +00:00
Jaap Keuter 98fa965a00 Make dissector handle unexpected data better.
svn path=/trunk/; revision=28875
2009-06-28 16:39:31 +00:00
Jörg Mayer c321f29518 Trivial warning fixes:
- Might be used uninitialized
- not a prototype
- comma at end of enum


svn path=/trunk/; revision=28730
2009-06-15 02:34:53 +00:00
Bill Meier 8ccf0f9ba4 packet_hip: (Minor): Remove unused data_handle; move proto_register... to just before proto_reg-handoff...
svn path=/trunk/; revision=28604
2009-06-02 18:47:20 +00:00
Stig Bjørlykke 7e6d072ce7 Rewrote to add IPv6 addresses correctly and rewrote some proto_item_add_bytes()
to avoid using tvb_get_ptr().

svn path=/trunk/; revision=28601
2009-06-02 15:46:55 +00:00
Stig Bjørlykke a48abd8b33 Removed a unused preference setting, some unused includes and
some unused code.

svn path=/trunk/; revision=28598
2009-06-02 15:22:33 +00:00
Stig Bjørlykke 7bdb23ed67 From Samu Varjonen via bug 3378:
Added support for Host Identity Protocol (HIP).

From me:
- Adjusted location of "Checksum" and "HIP Controls", as they seems to have
  switched place in the bytes window
- Rewrote some proto_tree_add_uint -> proto_tree_add_item (some still remain)
- Rewrote to not use tvb_memcpy()
- Corrected some proto_tree_add_item's as the format seems to be big-endian
- Terminate ALL value_string's with { 0, NULL }
- No need to zero-terminate value_string strings.
- Removed call to check_col()
- Removed some prototypes
- Removed unused hf_hip_tlv_id, hf_hip_res and hf_hip_tlv_enc_iv (please check)
- Rewrote some C++ comments

svn path=/trunk/; revision=28596
2009-06-02 15:10:04 +00:00