key list. In the Nettle code, clear the key list and re-read the key
file when the key file preference changes.
Remove a redundant define in config.h.win32.
svn path=/trunk/; revision=12471
use it ("sec_rgy_pname_t_size" had been used as an hf_ value, but it's
just a #define).
Fix the code for some strings to advance the offset by the string size
regardless of whether it's > 1 or not.
svn path=/trunk/; revision=12454
length of the UDP header itself, so subtract the length of the header
when using it to limit the length of the payload tvbuff.
Clean up the computing of the captured length of the payload tvbuff (we
really should get rid of the "length" argument to "tvb_new_subset()",
and have it compute the captured length based on the supplied reported
length and the amount of that data actually present in the parent
tvbuff).
Don't fetch the length and checksum fields until we use them (so that we
don't throw an exception until then, and fail to process the source and
destination ports), and check whether the length is bogus regardless of
whether we're building a protocol tree or not.
svn path=/trunk/; revision=12444
should be the length of the packet being dissected, so that if we throw
an exception dissecting it, the item covers the entire packet (because
it's incomplete, and thus *all* of it is the beginning of the header).
Instead, we should pass the length of the part of the header prior to
the protocol field as an argument to "dissect_ppp_common()", and it
should use that to set the length of that item.
svn path=/trunk/; revision=12441
by his madwifi Atheros driver on Linux; rename
WTAP_ENCAP_IEEE_802_11_WLAN_BSD to WTAP_ENCAP_IEEE_802_11_WLAN_RADIOTAP,
and change its text name from "ieee-802-11-bsd" to
"ieee-802-11-radiotap".
svn path=/trunk/; revision=12429
long.
The offset is relative to the first byte of the TIFF structure, which is
after the "Exif\0" *and* the extra byte after "Exif\0".
Loop over all IFDs.
Sanity check the offset to the first IFD and the offset in each IFD to
the next IFD.
svn path=/trunk/; revision=12424
"void".
Fix a typo in the MAP Dialogue dissector template .h file.
Re-generate the MAP Dialogue dissector files and set svn:keywords to Id
and svn:eol-style to native for them.
svn path=/trunk/; revision=12419
Clean up indentation.
If we dissect an octet string and then re-dissect it as a particular
type of data, don't use the end offset from the re-dissection as the
offset of the end of the octet string - just use the result of
"dissect_per_octet_string()".
svn path=/trunk/; revision=12406
*". For val_u_byte, if non-null, it points to a "value_string" table to
be used to interpret the value. Replace "toggle" and "yes_no" with
"boolean, and have the "data" pointer point to a "struct
true_false_string" to be used to interpret the value.
The NetBIOS-over-TCP/IP Node Type option can now be a regular val_u_byte
value, with the appropriate value_string table.
Construct the item for DHCP options by initializing it without the value
and appending the value to the item's string with
"proto_item_append_text()".
svn path=/trunk/; revision=12391
just like "struct opt_info", except for the name of the "enum
field_type" field; use "opt_info" instead of them. Rename the
equivalent field in "struct o63_opt_info", as well, with an eye towards
changing "struct opt_info" to be able to replace "struct o63_opt_info"
as well.
svn path=/trunk/; revision=12389
ever necessary.
Make some options, that have only one IPv4 address, use ipv4 rather than
ipv4_list.
Add val_u_short_list, and have val_u_short accept one and only one
16-bit integer. Give options the appropriate type.
Shuffle the types a bit in the enum, and shuffle the cases for types
around to match the order in the enum.
svn path=/trunk/; revision=12388
and add a separate "ipv4"; use that in the dissector for Netware IP
options.
Add a "presence" option type, for options with no value whose presence
is significant; use that in the dissector for Netware IP options.
svn path=/trunk/; revision=12387
end of the option, and have them do bounds checking. Also, in some
places, check the suboption length.
In "dissect_netware_ip_suboption()", process the suboption length
(which, according to RFC 2242, is present in all suboptions), and use
val_u_byte rather than val_u_short for 1-byte options.
svn path=/trunk/; revision=12386
distribution.
Don't use ":=" - not all versions of make necessarily support it, and,
even for those that do, it doesn't mean the same thing in all versions
(it means something different in Solaris make than in GNU make, for
example).
svn path=/trunk/; revision=12371
all other BSD NFS clients) retransmit on different ports from the port
on which the original request was set, so have the RPC "conversation"
for connectionless protocols use only the source address and destination
port.
Use NO_ADDR_B and NO_PORT_B when looking up the conversation in those
cases, and use NO_ADDR2 and NO_PORT2 when creating the conversation in
those cases, to make it clearer that we're only using one address and
port.
svn path=/trunk/; revision=12362
- change DHCP option 122 dissection to use official RFC 3495/3594 wording
(if bootp.pkt.ccc.protocol_version preference setting is 2 or 3)
- update CableLabs specification references
- some minor cleanup (option 43 also)
svn path=/trunk/; revision=12338
- add full support for upcoming PacketCable 1.5
- fix bug regarding MTA/CM Device Capabilities Length
- PacketCable MTA: fix bug regarding RSVP and UGS-AD options
- make presentation more compact (similar to other TLV data dissectors)
- change some descriptions and variables to (hopefully) make more sense
to DOCSIS/PacketCable users
svn path=/trunk/; revision=12325
allocate them to be large enough.
Add checks that the numbers in the range fit in a guint32.
Check the validity of a range before saving or printing, and report
errors in an alert box.
Clean up white space.
svn path=/trunk/; revision=12320
if HAVE_KERBEROS and HAVE_MIT_KERBEROS are both defined in config.h
Now we need someone to hack up the required automake magic to detect MIT Kerberos and massage the makefiles accordingly.
svn path=/trunk/; revision=12296
RFC 2132, which says
Options containing NVT ASCII data SHOULD NOT include a trailing
NULL; however, the receiver of such options MUST be prepared to
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
delete trailing nulls if they exist.
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
svn path=/trunk/; revision=12295
Add more COPS client type values from the IANA cops-parameters page.
Get rid of per-dissection static variables - pass them as parameters.
Make functions not used outside packet-cops.c static.
svn path=/trunk/; revision=12294
draft-ietf-aaa-diameter-cc-06.
Indicate where the Diameter application IDs for 3GPP stuff came from.
Update URLs for various Diameter drafts.
svn path=/trunk/; revision=12293
I am amazed it worked at all and noone complained.
It is little less broken now and handles some of the PrintableStrings properly.
svn path=/trunk/; revision=12262
Only display this value if we really have some data to ACK
which is not always the case.
This fixes a problem recently reported to the list
svn path=/trunk/; revision=12259
fixes.
Include "packet-ldp.h" in "packet-ldp.c" (if we'd been doing that, the
mismatch between "packet-ldp.h"'s declaration of "fec_vc_types_vals[]"
and "packet-ldp.c"'s definition of it would have been caught earlier).
svn path=/trunk/; revision=12241
- Added new RFC 3588 header format support (vendor-Id is replaced by
application-Id) and command code has its own separated name space. The
Draft v16 behaviour is maintained (through Preferences menu).
- Added 3GPP IMS Cx/Dx interface decoding (new imscxdx.xml)
- Fixed some issues in dictionary.xml
- Refreshed Diameter applications in embedded AVPs (that do not rely on
XML dictionary)
svn path=/trunk/; revision=12235
I02-040930). The code had to be integrated with the existing D-QoS code,
and has not been extensively tested. Add ports for PacketCable D-QoS
(2126) and Multimedia (3918). Code contributed by CableLabs.
svn path=/trunk/; revision=12232
Use "tvb_reported_length_remaining()", not "tvb_length_remaining()", to
find out how much encapsulated data there is, so we properly handle
short frames (reporting how much was really there, not how much was
captured).
svn path=/trunk/; revision=12219
The reason why you need to turn on "Try heuristic sub-dissector first"
is that the traffic might be port 10000 traffic, and the NDMP dissector
gets that but doesn't properly reject it if it doesn't look like NDMP -
that's been fixed.
svn path=/trunk/; revision=12217
don't get stuck into protocol tree item representations (and so that
they can be more easily found if, as, and when we get around to handling
different character encodings).
Clean up white space.
Get rid of another sprintf() on top of a string constant.
svn path=/trunk/; revision=12211
Client Configuration option number configurable. Add an option to switch
between the CCC versions defined in PKT-SP-PROV-I05-021127, IETF draft 5,
and RFC 3495. Code contributed by CableLabs.
Remove an unneeded macro.
svn path=/trunk/; revision=12208
adds support for dissecting EAP-FAST packets;
add version field displaying for EAP-TTLS since the latest TTLS
draft defines a new version mechanism (which matches with both
EAP-PEAP and EAP-FAST in design).
svn path=/trunk/; revision=12167
o Fix EXTENDED_COMMUNITIES output that was appending the Carried
Extended communities; fix BGP_EXT_COM_L2INFO was not appending to the
bgpext_com_type
o Update various text with the specific afi/safi
o Decode fields in MP Reach NLRI for labeled VPNv4 and labeled IPv4
(and small offset fix for the latter)
o Decode unknown address family in MP Reach NLRI
svn path=/trunk/; revision=12165
for organizations to an <epan/sminmpec.h> header, and add in the ones
that were used (without #defines) in the Diameter dissector.
Merge the value_string tables for them from the Diameter and Radius
dissectors into epan/sminmpec.c and merge them.
Use that value_string table in the Diameter and Radius dissectors.
Constify some stuff in the Diameter dissector.
svn path=/trunk/; revision=12159
o Add link type string for MPLS Link Type in MPLS Link sub-TLV
o Decode MPLS Link Color/Resource sub-TLV
o Add bps for bandwidths in Max BW and Max Reservable BW sub-TLVs
o Display Type, Length Value for Unknown Link sub-TLV
o Allow display filter on Link Type and Link Color
svn path=/trunk/; revision=12122
- Add a configuration option for Diameter version. Currently,
the choice is between everything before draft-v16 and RFC3588.
- Fix diameter-ip-address parsing depending on the Diameter
version (and showing decoding errors accordingly).
- Change registration of Diameter from TCP and SCTP port 1812 to
TCP and SCTP port 3868 (this is according to RFC3588, section
11.5).
svn path=/trunk/; revision=12121
make the source files all include the corresponding header files (so
that the declarations in the headers have to match the definitions in
the source files in order for compilation to succeed).
svn path=/trunk/; revision=12116
- pass only value (not tag and length) to subdissectors from the
snmp.variable_oid table
- register the SNMP dissector
svn path=/trunk/; revision=12093
packet-etheric.c:99: warning: `message_type_vals' defined but not used
packet-etheric.c:376: warning:
`isup_calling_party_nature_of_address_ind_value'
defined but not used
packet-etheric.c:892: warning:
`dissect_etheric_cause_indicators_parameter' defi
ned but not used
svn path=/trunk/; revision=12085
check in packet-cip.h).
Also, add packet-cip.h to epan/dissectors/Makefile.common, so it gets
included in the release tarballs.
svn path=/trunk/; revision=12081
- Dissect ICQ TLV values
- Dissect channel 1 and channel 2 messages correctly in Oscar (required
for dissecting direct connections)
svn path=/trunk/; revision=12072
move CIP protocol to own dissector
clean up code and fix variable names
add more info to info column
fixed decoding of embedded messages in Unconnected send and
Multiple Service packets
add more info to path decoding
add more filter options/clean up
complete CIP vendor codes
svn path=/trunk/; revision=12070
append MPLS fields and values to the MPLS Header subtree;
correct the string displayed for MPLS Label;
don't show non-reserved MPLS label values as "Unknown".
svn path=/trunk/; revision=12065
- Dissect the DC (Direct Connection) info structure
- Dissect the complete buddy icon family (you can now save buddy
icons as .JPG's/.PNG's directly from the capture using the "Export
selected bytes..." option!)
- Add a function that dissects a sequence of TLV's instead of having
while() loops all over the place.
svn path=/trunk/; revision=12063
Remove some code duplication from the Oscar dissector (reduces
the number of lines by 500) by providing a custom registration
function for oscar families (aim_init_family). This also fixes
a number of issues with column names.
Add minor updates such as adding support for the Capability Info
TLV on users.
svn path=/trunk/; revision=12060
1. Fix dissection of Check Point vendor ID version field. The length was
wrong.
2. Added dissection of payloads 130 and 131, which were used in early
NAT-T drafts (and are still used by MS and others). They are equal to
payloads 15 & 16, (NAT-D, NAT-OA), respectively.
3. Added ASN.1 decoding of Certificate requests of type X.509
Certificate - Signature (4)
4. Added ASN.1 decoding of ID of type ID_DER_ASN1_DN (9)
svn path=/trunk/; revision=12059
if that pointer is non-null, put the field in question into the protocol
tree under the top-level item for that attribute/value pair, rather than
hardcoding particular fields for particular attribute codes.
Use BASE_NONE, not BASE_DEC, for FT_STRING, FT_BYTES, and FT_IPv4
fields.
svn path=/trunk/; revision=12048
NETTL_SUBSYS_NS_LS_ICMPV6 - they don't even have IP headers, so we need
to directly call the ICMP and ICMPv6 dissectors.
svn path=/trunk/; revision=12047
within the file) and "burst offset" field (offset of this packet within
the burst).
The burst header is not present if the SYS flag is set in the packet or
if the data offset field is non-zero.
Compute the offset, within a burst packet, of the data, as we advance
through the burst header - and don't advance through the burst header if
it's not present.
Properly display the fields in the "missing fragment list".
svn path=/trunk/; revision=12041
