Commit Graph

106 Commits

Author SHA1 Message Date
Anders Broman 9c04eb9b2c Fix typos
svn path=/trunk/; revision=35597
2011-01-20 14:03:13 +00:00
Anders Broman fbde1c7130 Update a comment.
svn path=/trunk/; revision=35596
2011-01-20 13:19:26 +00:00
Anders Broman 3112035ad2 In MM context the container contains IE:s not a complete
DTAP message.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5598

svn path=/trunk/; revision=35595
2011-01-20 13:05:17 +00:00
Anders Broman 2c7b85a624 Add dissection of Radio Priority LCS.
svn path=/trunk/; revision=35276
2010-12-27 20:23:26 +00:00
Guy Harris a8bc4a0d13 Rename the routines that handle dissector tables with unsigned integer
keys to have _uint in their names, to match the routines that handle
dissector tables with string keys.  (Using _port can confuse people into
thinking they're intended solely for use with TCP/UDP/etc. ports when,
in fact, they work better for things such as Ethernet types, where the
binding of particular values to particular protocols are a lot
stronger.)

svn path=/trunk/; revision=35224
2010-12-20 05:35:29 +00:00
Bill Meier 62e44e3f66 Minor cleanup:
- Initialize a few static global variables;
- Remove two unnecessary calls to g_hash_table_foreach_remove;
- Do whitespace cleanup and use consistent indentation;
- Fix a few typos and fix up several comments.

svn path=/trunk/; revision=35183
2010-12-14 01:50:31 +00:00
Anders Broman 7870de6f95 Fill value_strings.
svn path=/trunk/; revision=34875
2010-11-15 16:46:07 +00:00
Bill Meier c256942255 Use value_string_ext fcns to access various value_string arrays.
Also: use value_string_const() instead of value_string() where apropriate;
      minor reformatting & whitespace cleanup.

svn path=/trunk/; revision=34745
2010-11-01 18:26:34 +00:00
Jeff Morriss cca3ba3ce2 (Refining the regexp...) Replace blurbs that match the name (case insensitive) with NULL.
svn path=/trunk/; revision=34230
2010-09-24 02:51:40 +00:00
Jeff Morriss 0ff5638f37 Replace blurbs that match the name (case insensitive) with NULL.
svn path=/trunk/; revision=34227
2010-09-23 21:46:31 +00:00
Bill Meier 7219ee2a49 Use val_to_str_ext() & friends to access sminmpec_values[];
Also: packet-nhrp.c: #include sminmpec.h not req'd;

svn path=/trunk/; revision=34143
2010-09-17 04:51:21 +00:00
Stig Bjørlykke 85b4d16277 Update the header length after dissecting the header.
This fixes bug 5162.

svn path=/trunk/; revision=34031
2010-08-31 10:24:08 +00:00
Anders Broman 9092ed1aa2 Try to fix the GTP' header dissection a bit.
svn path=/trunk/; revision=33689
2010-08-01 20:55:29 +00:00
Anders Broman d4182159b6 Split dissection of GTP and GTP' in ordet to try to fix bug
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5055

svn path=/trunk/; revision=33648
2010-07-28 16:13:56 +00:00
Gerald Combs 83c5be18c7 Add End Marker back in.
svn path=/trunk/; revision=33380
2010-06-29 23:50:51 +00:00
Gerald Combs bce5424063 Completely revert r33367 so that we don't duplicate content in
packet-gtp.h.

svn path=/trunk/; revision=33379
2010-06-29 23:48:24 +00:00
Anders Broman 3123ecf3e4 Add "End Marker" get rid of the .h file as no one imports anything.
(Leave the .h file for a while).

svn path=/trunk/; revision=33367
2010-06-29 08:06:13 +00:00
Jeff Morriss 729de1a635 As suggested in http://www.wireshark.org/lists/wireshark-dev/200809/msg00075.html
(as referenced in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2907 ) and
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3411 :

Write a new convenience routine for finding a conversation and, if it is not
found, create it.  The frame number and addresses are taken from pinfo (as is
the common case).

Use this function in a bunch of dissectors.

svn path=/trunk/; revision=32790
2010-05-13 18:28:34 +00:00
Bill Meier 10ffd14b8f Indentation & whitespace cleanup (including: "4 space tabs" ==> spaces)
svn path=/trunk/; revision=32735
2010-05-10 15:54:57 +00:00
Anders Broman a0f2f56ec8 Dissect 3GPP AVP 5 3GPP-GPRS Negotiated QoS profile.
svn path=/trunk/; revision=32622
2010-05-01 14:58:03 +00:00
Anders Broman 99054f9413 From Tamas Regos:
Another bug in packet-gtp.c (mask of Signalling Indication)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4694

svn path=/trunk/; revision=32510
2010-04-19 06:02:56 +00:00
Anders Broman 64a8ae8676 From Tamas Regos:
Harmless typo and whitespace bugs in packet-gtp.c
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4677
(didn't apply cleanly so partly applied by hand).

svn path=/trunk/; revision=32474
2010-04-15 17:58:54 +00:00
Bill Meier 69df32fb11 #include <string.h> not needed.
svn path=/trunk/; revision=32411
2010-04-06 22:09:47 +00:00
Bill Meier 09764dd969 Remove unneeded #include <stdio.h>
svn path=/trunk/; revision=32367
2010-04-03 21:55:23 +00:00
Guy Harris b395a98305 Squelch a bunch of compiler warnings.
svn path=/trunk/; revision=31961
2010-02-23 04:35:23 +00:00
Anders Broman 0c5dfd7698 Target Identification shall be coded as TLV IE where value is
coded as TargetRNC-ID.
Proposed fix to
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3974
(The enclosed trace dioes not decode properly but may be wrongly encoded).

svn path=/trunk/; revision=29816
2009-09-09 07:29:41 +00:00
Kovarththanan Rajaratnam 8b515e9340 Switch a bunch of dissectors over to using tvb_new_subset_remaining()
svn path=/trunk/; revision=29446
2009-08-16 12:36:22 +00:00
Gerald Combs 1f3776bf8b Add some length checks.
svn path=/trunk/; revision=29388
2009-08-11 23:29:21 +00:00
Kovarththanan Rajaratnam 0a5b014cec Don't guard col_clear with col_check
svn path=/trunk/; revision=29344
2009-08-09 07:36:13 +00:00
Kovarththanan Rajaratnam e971354a54 Don't guard col_set_str (COL_PROTOCOL) with col_check
svn path=/trunk/; revision=29340
2009-08-09 06:26:46 +00:00
Anders Broman 7b8cdbe44f Restore hf_gtp_ext_rat_type as it's used in decode_gtp_rat_type().
Fix IMEI(SV) While we're at it.

svn path=/trunk/; revision=29053
2009-07-10 12:26:39 +00:00
Bill Meier 59cc6f3e61 packet-gtp: 3GPP AVP custom VSA dissection no longer required for 3GPP-RAT-Type attribute.
3GPP-RAT-Type values are now defined in the Radius dictionary.3gpp file.

svn path=/trunk/; revision=29039
2009-07-09 16:02:34 +00:00
Stig Bjørlykke 0437f102c3 From Kovarththanan Rajaratnam:
More FT_XXX cleanup.

svn path=/trunk/; revision=28971
2009-07-07 09:02:59 +00:00
Anders Broman 2555dcfb74 Revert(Try to fix indentation a bit.)
svn path=/trunk/; revision=28821
2009-06-23 14:16:28 +00:00
Anders Broman 6738ccefeb Try to fix indentation a bit.
svn path=/trunk/; revision=28820
2009-06-23 13:49:46 +00:00
Stig Bjørlykke b228488bc0 From Kovarththanan Rajaratnam via bug 3548:
(1) Trailing/leading spaces are removed from 'name's/'blurb's
(2) Duplicate 'blurb's are replaced with NULL
(3) Empty ("") 'blurb's are replaced with NULL
(4) BASE_NONE, NULL, 0x0 are used for 'display', 'strings' and 'bitmask' fields
    for FT_NONE, FT_BYTES, FT_IPv4, FT_IPv6, FT_ABSOLUTE_TIME, FT_RELATIVE_TIME,
    FT_PROTOCOL, FT_STRING and FT_STRINGZ field types
(5) Only allow non-zero value for 'display' if 'bitmask' is non-zero

svn path=/trunk/; revision=28770
2009-06-18 21:30:42 +00:00
Stig Bjørlykke fc3f1b5283 From Artem Tamazov (bug 3472):
Save/Restore pinfo->private_data when used.

svn path=/trunk/; revision=28412
2009-05-19 17:16:14 +00:00
Anders Broman ca3cca594a Update a comment.
svn path=/trunk/; revision=28309
2009-05-08 18:11:39 +00:00
Anders Broman 0416dd2457 Inital GTPv2 dissector.
svn path=/trunk/; revision=27414
2009-02-10 21:57:56 +00:00
Bill Meier da3959145e Fix some indentation .....
svn path=/trunk/; revision=27307
2009-01-27 00:54:09 +00:00
Bill Meier c544c20956 Fix various typos and spelling errors (mostly in text strings)
svn path=/trunk/; revision=27050
2008-12-18 19:08:49 +00:00
Bill Meier a8f30cbca1 Fix some typos and spelling (mostly in text strings)
svn path=/trunk/; revision=27037
2008-12-17 17:23:37 +00:00
Anders Broman f050d5a949 Add a cople of IE's
svn path=/trunk/; revision=26975
2008-12-12 20:36:57 +00:00
Stig Bjørlykke bd08ae7ee6 Fix some "format not a string literal and no format arguments" warnings.
svn path=/trunk/; revision=26647
2008-10-31 15:11:57 +00:00
Jaap Keuter 73cd38c1bd Fix an assignment which is intended as a comparison.
svn path=/trunk/; revision=26529
2008-10-23 19:57:19 +00:00
Anders Broman b3256e6d44 Fix:
cc1: warnings being treated as errors
packet-gtp.c: In function ‘decode_qos_umts’:
packet-gtp.c:3725: error: ‘guar_dl_ext’ may be used uninitialized in this function
packet-gtp.c:3722: error: ‘max_dl_ext’ may be used uninitialized in this function
packet-gtp.c:3725: error: ‘guar_ul_ext’ may be used uninitialized in this function
packet-gtp.c:3722: error: ‘max_ul_ext’ may be used uninitialized in this function
packet-gtp.c:3726: error: ‘sig_ind’ may be used uninitialized in this function
packet-gtp.c:3726: error: ‘src_stat_desc’ may be used uninitialized in this function
make[4]: *** [libdissectors_la-packet-gtp.lo] Error 1

svn path=/trunk/; revision=26528
2008-10-23 19:44:07 +00:00
Anders Broman 2ff51cb037 Update the QoS IE
svn path=/trunk/; revision=26526
2008-10-23 19:22:54 +00:00
Anders Broman cee238507d From Kari Tiirikainen:
Req/resp tracking and service response time stats for GTP-C

svn path=/trunk/; revision=26361
2008-10-06 20:11:44 +00:00
Bill Meier 802f4452b4 Minor cleanup related to proto_reg_handoff ....
svn path=/trunk/; revision=26176
2008-09-11 14:07:02 +00:00
Bill Meier 8d9c5d9b2b Cleanup related to prefs & proto_reg_handoff
svn path=/trunk/; revision=26124
2008-09-02 21:40:46 +00:00