Bill Meier
bfde04b845
ui/gtk/*.c: Add editor modelines; As needed: Fix indentation
...
Change-Id: I8cd9d9fe5f12c284f46b8f725766f681faccd753
Reviewed-on: https://code.wireshark.org/review/7138
Reviewed-by: Bill Meier <wmeier@newsguy.com>
2015-02-15 19:02:30 +00:00
Martin Mathieson
43f09e67b4
Remove unneeded includes from ui folder
...
Change-Id: Ifd1eebff9080cd3867e44e4dcb2d2681370ed60a
Reviewed-on: https://code.wireshark.org/review/6128
Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
2015-01-01 23:11:10 +00:00
Alexis La Goutte
296591399f
Remove all $Id$ from top of file
...
(Using sed : sed -i '/^ \* \$Id\$/,+1 d')
Fix manually some typo (in export_object_dicom.c and crc16-plain.c)
Change-Id: I4c1ae68d1c4afeace8cb195b53c715cf9e1227a8
Reviewed-on: https://code.wireshark.org/review/497
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-03-04 14:27:33 +00:00
Bill Meier
11b5c15fdb
Remove trailing whitespace
...
Change-Id: I8116f63ff88687c8db3fd6e8e23b22ab2f759af0
Reviewed-on: https://code.wireshark.org/review/385
Reviewed-by: Bill Meier <wmeier@newsguy.com>
Tested-by: Bill Meier <wmeier@newsguy.com>
2014-02-25 20:46:49 +00:00
Guy Harris
db25270df8
Move the epan/filesystem.c routines to wsutil; they're not specific to
...
packet dissection, they're specific to the entire Wireshark suite of
programs.
svn path=/trunk/; revision=53377
2013-11-17 02:55:14 +00:00
Jakub Zawadzki
08eb36b5af
Remove fdata->opt_comment, add pkt_comment to pinfo
...
Original (read from file) comments can be accessed by pkthdr->opt_comment
Keep user comments in seperated BST, add new method for epan session to get it.
svn path=/trunk/; revision=51090
2013-08-01 20:59:38 +00:00
Martin Kaiser
88a4c49bf7
update the button in the status bar when a packet comment is added
...
(this is a quick fix, the case when the last comment is removed
is still not handled correctly)
svn path=/trunk/; revision=50069
2013-06-19 23:37:38 +00:00
Guy Harris
039a075699
Eliminate some includes of ui/simple_dialog.h by files that don't use
...
anything from it.
svn path=/trunk/; revision=49277
2013-05-13 22:50:29 +00:00
Bill Meier
8112ecc321
From beroset:
...
remove C++ incompatibilities
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416 attachment #10404
Note: The following parts of the patch had been previously done:
asn1/snmp/packet-snmp-template.c
epan/dissectors/packet-snmp.c
epan/dissectors/packet-x11.c
Also; hostlist_table.c: code under '#ifdef HAVE_GEOIP'
didn't compile and needed a few additional patches.
svn path=/trunk/; revision=48447
2013-03-21 02:29:09 +00:00
Anders Broman
97c4bc6292
Use explicit casts.
...
svn path=/trunk/; revision=48212
2013-03-09 10:09:58 +00:00
Martin Kaiser
4099ef9457
make function names consistent
...
edit_capture_dlg_launch() -> edit_capture_comment_dlg_launch()
svn path=/trunk/; revision=47780
2013-02-20 22:18:56 +00:00
Martin Kaiser
18ec6f01a3
kill an "edit capture comment" popup if the underlying file is closed
...
(at the moment, the edit window remains open even if the file is closed or
changed, this allows effectively to overwrite a file's capture commment with
the capture comment of a previously used file)
svn path=/trunk/; revision=47779
2013-02-20 22:08:00 +00:00
Anders Broman
fe7a2570db
Move summary related stuff to summary_dlg
...
svn path=/trunk/; revision=46782
2012-12-26 12:29:43 +00:00
Gerald Combs
a5d5162826
Qt: Implement packet comments. Fix packet detail updates.
...
GTK+: Shorten the packet comment menu item name. Remove a couple of
unneeded includes.
Both: Add an arbitrary 20 MB limit when fetching all packet comments.
Use a color from the Tango palette for comments.
svn path=/trunk/; revision=46709
2012-12-23 04:37:58 +00:00
Evan Huus
52aff57285
Remove unneeded initializations, and one redundant if condition.
...
svn path=/trunk/; revision=46702
2012-12-22 21:14:13 +00:00
Jeff Morriss
7d0bb3bc0d
Remove a now-unused variable.
...
svn path=/trunk/; revision=46246
2012-11-28 15:34:50 +00:00
Anders Broman
7d92266058
Add a copy button that copies to clipboard.
...
svn path=/trunk/; revision=46245
2012-11-28 14:34:20 +00:00
Anders Broman
18d5f2dbfc
Start including info from Statistics/Summary.
...
svn path=/trunk/; revision=46219
2012-11-27 13:35:33 +00:00
Anders Broman
beeabf86aa
Rudimentary code to show comments summary.
...
svn path=/trunk/; revision=46204
2012-11-26 16:11:04 +00:00
Martin Kaiser
47cf08409d
change the capture comment icon in the statusbar from "add" to "edit"
...
when a comment was added
(deletion of a comment is not recognized correctly)
svn path=/trunk/; revision=45109
2012-09-24 19:30:23 +00:00
Jeff Morriss
3729335973
We always HAVE_CONFIG_H so don't bother checking whether we have it or not.
...
svn path=/trunk/; revision=45016
2012-09-20 01:48:30 +00:00
Martin Kaiser
17a8522cb6
update the expert info entries after a packet comment was modified
...
the packet comment window can be opened from the expert infos
by clicking on a comment, when a comment is modified in this way, we
have to cf_retap_packets() to update the expert infos window
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7690
svn path=/trunk/; revision=44852
2012-09-10 19:48:16 +00:00
Jörg Mayer
12a0aa4849
- Replace packet_list_recreate_visible_rows -> packet_list_recreate_visible_rows_list
...
- Replace new_packet_list_ -> packet_list_
svn path=/trunk/; revision=44765
2012-09-04 02:35:25 +00:00
Jörg Mayer
380fe63a6d
Rename new_packet_list.[ch] to packet_list.[ch]
...
svn path=/trunk/; revision=44764
2012-09-04 01:57:36 +00:00
Martin Kaiser
bd1d3b4825
add a vertical scrollbar to the text input windows for capture comment
...
and packet comment
scrollbar is shown only when the text does not fit into the window
this fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7677
svn path=/trunk/; revision=44754
2012-09-03 17:56:24 +00:00
Anders Broman
aa1dd4546d
Shoul be gtk_box_pack_start(GTK_BOX (vbox), message_type_fr, TRUE, TRUE, 0);
...
svn path=/trunk/; revision=43828
2012-07-19 14:02:47 +00:00
Anders Broman
d3ecc1431f
gtk_container_add() -> gtk_box_pack_start().
...
svn path=/trunk/; revision=43825
2012-07-19 13:06:04 +00:00
Jakub Zawadzki
bf81b42e1e
Update Free Software Foundation address.
...
(COPYING will be updated in next commit)
svn path=/trunk/; revision=43536
2012-06-28 22:56:06 +00:00
Guy Harris
9c44d87610
Have a main_update_for_unsaved_changes() routine that, if changes are
...
made to the capture file (adding/removing/editing comments, for now) or
if a capture file with unsaved changes are unsaved, updates the menu
bar, the toolbar, *and* the titlebar, which now has a GNOME-style "*" to
indicate unsaved changes.
Make set_menus_for_capture_file() a private interface between main.c and
main_menubar.c, and have its callers, such as
main_update_for_unsaved_changes(), be responsible for updating the
toolbar as well.
svn path=/trunk/; revision=43051
2012-06-04 02:24:42 +00:00
Jeff Morriss
135ebc4148
Don't include a Clear button in the packet- and capture-file-comment dialogs:
...
the user can just Ctrl-A + backspace if they want to do that.
svn path=/trunk/; revision=42836
2012-05-24 21:38:22 +00:00
Jeff Morriss
373e0925f3
Enable word wrapping for capture-file comments.
...
svn path=/trunk/; revision=42835
2012-05-24 21:35:41 +00:00
Guy Harris
0d6e9145be
Word-wrap comments in the display.
...
svn path=/trunk/; revision=42833
2012-05-24 19:18:31 +00:00
Jeff Morriss
c1e2dd357d
Free the comment after calling gtk_text_buffer_set_text().
...
svn path=/trunk/; revision=42828
2012-05-24 18:11:55 +00:00
Bill Meier
a703450659
AFAICT '#include sys/types.h' is not needed for these files.
...
svn path=/trunk/; revision=42443
2012-05-05 20:51:14 +00:00
Anders Broman
b832d1d6ba
Replace gtk_vbox_new() and gtk_hbox_new() with ws_gtk_box_new().
...
svn path=/trunk/; revision=42161
2012-04-20 14:56:24 +00:00
Stephen Fisher
0dd6243320
Add newline at end of file to fix compilation error.
...
svn path=/trunk/; revision=41820
2012-03-28 23:54:50 +00:00
Jeff Morriss
9c1bf7223e
Don't mark the file as unsaved unless the capture or packet comments actually changed.
...
svn path=/trunk/; revision=41744
2012-03-23 01:41:59 +00:00
Gerald Combs
52deb5a309
Create some standard definitions for dialog control spacing. Use them in
...
the comment dialog.
svn path=/trunk/; revision=41412
2012-03-08 01:24:31 +00:00
Jeff Morriss
5b120f36d8
Rename the functions and variables to go along with r41410.
...
svn path=/trunk/; revision=41411
2012-03-07 23:04:15 +00:00
Jeff Morriss
94e539a193
Use OK, Clear, and Cancel in the comment dialogs (instead of Save, Clear, and Close). This makes the UI similar to our Preferences dialog. And it avoids confusion about whether Save will save the file or not.
...
svn path=/trunk/; revision=41410
2012-03-07 22:38:02 +00:00
Jeff Morriss
7f96e88fc0
Set File->Save sensitivity after file or packet comments are changed.
...
svn path=/trunk/; revision=41409
2012-03-07 22:19:06 +00:00
Jeff Morriss
8db7c4d369
#if out setting the help buttons' callbacks to NULL to avoid GLib-Object-CRITICAL warnings.
...
svn path=/trunk/; revision=41269
2012-03-01 16:03:42 +00:00
Jeff Morriss
e3cf120575
Keep track of whether we have a "Edit Capture Comment" dialog open. If we do,
...
don't open another one.
Make a couple globals static.
svn path=/trunk/; revision=41268
2012-03-01 15:57:39 +00:00
Anders Broman
d24fad6371
- Add a LED in the statusbar to indicate that capture comments exists,
...
clickable to open an edit window.
- Add checks for NULL pointers.
Help with a different color LED possibly with Jeff's (c) in it apreceated.
Should the LED be placed elsewhere or the whole thing done differently?
svn path=/trunk/; revision=41242
2012-02-29 16:51:32 +00:00
Anders Broman
b3ef8443ab
Packet comments are working
...
svn path=/trunk/; revision=41218
2012-02-28 06:05:32 +00:00
Anders Broman
196e1ab97b
Mark an unused parameter.
...
svn path=/trunk/; revision=41016
2012-02-13 18:50:31 +00:00
Anders Broman
c894108aca
Edit packet comments
...
svn path=/trunk/; revision=41013
2012-02-13 17:33:05 +00:00
Guy Harris
96b89de3e9
Capitalize the "P" in "Packet" in "Add or Edit Packet Comment". Add
...
"..." after it, as it pops up a dialog box to let you actually type in a
comment.
Add "Add or Edit Packet Comment" to the menubar's Edit menu.
svn path=/trunk/; revision=41005
2012-02-12 23:09:14 +00:00
Anders Broman
ad0df12982
Add a button row.
...
svn path=/trunk/; revision=41003
2012-02-12 21:15:11 +00:00
Michael Tüxen
8aa280b721
Get it compiling.
...
svn path=/trunk/; revision=40986
2012-02-12 16:38:47 +00:00