Commit Graph

46258 Commits

Author SHA1 Message Date
Alexis La Goutte 1093faf643 From Michael Mann via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8446 Wifi details are not stored in the Decryption Key Management dialog (post 1.8.x)
If there is not 80211_keys file, using Decryption Management Key don't create the file and keys is not saved.

From me:
Use a err2 variable to avoid to break API/ABI when backport to 1.8

svn path=/trunk/; revision=48900
2013-04-17 19:38:34 +00:00
Alexis La Goutte 0ef40a6145 Don't display the SVN Version in SSL Logs (only Wireshark VERSION) (and avoid to rebuild and relinkg libwireshark when the svn revision changes...)
svn path=/trunk/; revision=48899
2013-04-17 19:38:07 +00:00
Alexis La Goutte c1b61506d9 Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
svn path=/trunk/; revision=48898
2013-04-17 19:37:44 +00:00
Alexis La Goutte a376f3b5d1 Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
svn path=/trunk/; revision=48897
2013-04-17 19:36:49 +00:00
Evan Huus d385db2133 Remove chromium-specific license exceptions which it makes no sense for
us to carry.

Add an exception of our own for tools/pidl since that is GPL but the headers
are not in a format that licensecheck will pick up, and fixing them all would
just introduce a delta with upstream for no reason.

svn path=/trunk/; revision=48896
2013-04-17 19:35:43 +00:00
Gerald Combs b25fa89125 Reverse the arguments we feed to valgrind-wireshark.sh. Add debugging
output.

svn path=/trunk/; revision=48895
2013-04-17 17:23:41 +00:00
Evan Huus b2f0991616 Catch overflow condition in mysql dissector.
Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8458

Also add modelines.

svn path=/trunk/; revision=48894
2013-04-17 15:38:35 +00:00
Evan Huus b13e702709 Cast scrolling values to gdoubles, not gfloats - GtkAdjustment have
always taken doubles that I've been able to find, and casting to floats
causes loss of precision and weird bugs when the values get enormous.

Should fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8460

svn path=/trunk/; revision=48893
2013-04-17 15:07:48 +00:00
Guy Harris 51b56bfebc Update FSF address.
svn path=/trunk/; revision=48892
2013-04-17 01:44:00 +00:00
Guy Harris fb0701f40e Fix more typos that broke the license checker (these might have been
created by taking packet-dvb-eit.c, doing a global search and replace of
"ei" with the new name, and then doing further editing).

svn path=/trunk/; revision=48891
2013-04-17 01:40:25 +00:00
Guy Harris f1cd6b131d Fix typo that caused this to fail the license check.
svn path=/trunk/; revision=48890
2013-04-17 01:36:07 +00:00
Evan Huus 82ad8cdf19 Change offset to be 8, based on an educated guess from looking at the
code around line 777.

Fixes the last open issue in
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7260

svn path=/trunk/; revision=48889
2013-04-16 21:57:36 +00:00
Evan Huus 0c8abacbec Fix a minor memory leak caught by cppcheck. Also replace a whole bunch of
"This shouldn't happen" fallback strings with a single assertion.

svn path=/trunk/; revision=48888
2013-04-16 21:20:57 +00:00
Michael Mann 8e2c1312d8 dissect CIP-Safety application reply data
svn path=/trunk/; revision=48887
2013-04-16 21:16:41 +00:00
Martin Kaiser d7bb57a5ef remove unused structs and defines
(the unnamed union caused a compiler warning on fedora 14)

svn path=/trunk/; revision=48886
2013-04-16 20:53:24 +00:00
Anders Broman af2cda1cc3 Introduce a dissector table for vendor extensions.
svn path=/trunk/; revision=48885
2013-04-16 18:13:40 +00:00
Anders Broman e1f2565570 Change name on a define.
svn path=/trunk/; revision=48884
2013-04-16 18:12:56 +00:00
Anders Broman 91f44b2940 Update USR Robotics and 3GPP2 dictionarys.
svn path=/trunk/; revision=48883
2013-04-16 18:12:23 +00:00
Evan Huus f8f078744b Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8583
IO graph was misbehaving if the packets covered too much real time.
It's still ungodly slow, but at least it seems to work.

svn path=/trunk/; revision=48882
2013-04-16 16:16:15 +00:00
Evan Huus 10b150f49c Re-add format argument that appears to have been accidentally
dropped in r48880.

svn path=/trunk/; revision=48881
2013-04-16 15:30:59 +00:00
Irene Rüngeler 65043453b9 Update interface list when interface get lost and come back.
svn path=/trunk/; revision=48880
2013-04-16 15:12:38 +00:00
Evan Huus 80350136f0 Dead assignment caught by cppcheck.
svn path=/trunk/; revision=48879
2013-04-16 14:15:33 +00:00
Jeff Morriss 5c85df8a93 Add packet-PROTOABBREV.c to source distribution. Reorder some entries.
svn path=/trunk/; revision=48878
2013-04-16 13:57:06 +00:00
Evan Huus 4008d3e544 From Roland Knall via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8587
Fix openSafety reassembly and dissection when the first package has
a payload length of 0.

svn path=/trunk/; revision=48877
2013-04-16 13:44:15 +00:00
Michael Mann c3780c2e8d Fix compiler errors on Linux.
svn path=/trunk/; revision=48876
2013-04-16 13:17:45 +00:00
Evan Huus 494fe3e943 From Roland Knall via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8588
Add casts to that idl2wrs compiles with -Wc++-compat

svn path=/trunk/; revision=48875
2013-04-16 12:48:27 +00:00
Michael Mann 93cd5ebc4a SOCKS dissector, general cleanup.
Cleanup included:
1. converting proto_tree_add_text to proto_tree_add_item.
2. Converting state machines to use frame data instead of a large hash structure.
3. Apply consistent whitespace, add modelines
4. Remove global variable used for recursion, replaced with frame data.
5. Update protocol spec links
6. Add some "manual" fragmentation support. The goal was to fix bug 2157, but it appears some TCP SEQ/ACK inconsistencies may be getting in the way.

svn path=/trunk/; revision=48874
2013-04-16 12:05:38 +00:00
Anders Broman 68f0af8b03 Set pinfo->link_dir per message not in the IE dissection.
svn path=/trunk/; revision=48873
2013-04-16 05:42:17 +00:00
Anders Broman b522b91cf6 Revert revision 48854, the problem is in packet-gtp.c not setting P2P_DIR correctly.
svn path=/trunk/; revision=48872
2013-04-16 05:40:54 +00:00
Evan Huus 2290bf6575 From J. Bruce Fields via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8584
Support for NFSv4.1 open access modes including delegation wants.

svn path=/trunk/; revision=48871
2013-04-16 02:03:01 +00:00
Evan Huus cb4d9f982e Don't use seasonal memory for NFS file tracking tables (at least I think that's
what these are). It gets freed slightly before we need to access it in order to
correctly free other glib memory.

Discovered accidentally while valgrinding the capture from
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8584

svn path=/trunk/; revision=48870
2013-04-16 01:58:28 +00:00
Evan Huus d0bd2097f0 Fix another dozen or so files with bad FSF addresses as caught by licensecheck.
svn path=/trunk/; revision=48869
2013-04-16 00:00:09 +00:00
Evan Huus f7fbe1ccda From J. Bruce Fields via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8582
Fix a few misc. issues with NFS CB_SEQUENCE decoding.

svn path=/trunk/; revision=48868
2013-04-15 23:26:57 +00:00
Gerald Combs d75dbf9aff Fix a typo.
svn path=/trunk/; revision=48865
2013-04-15 23:16:20 +00:00
Gerald Combs 3954ab4c69 More indentation fixes.
svn path=/trunk/; revision=48864
2013-04-15 23:04:16 +00:00
Gerald Combs e96673d549 Add links to Google Breakpad and other possible solutions.
svn path=/trunk/; revision=48863
2013-04-15 23:02:34 +00:00
Pascal Quantin 238659f271 Add dissection of USAT TLV IARI, PLMN list, EPS PDN connection activation parameters and Tracking Area Identification
svn path=/trunk/; revision=48862
2013-04-15 21:52:59 +00:00
Evan Huus 4e3c836273 Major cleanup of skeleton dissector and related bits of README.developer.
Changes of note:
- Removed the 'Copied from' notice, it's only relevant if they're *not* using
  the skeleton code. Added a paragraph to README.developer instead.
- Exorcised all references to if (tree) and placed them in their own section
  at the bottom as an optimization. Hopefully this will be less confusing.

svn path=/trunk/; revision=48861
2013-04-15 21:43:40 +00:00
Evan Huus bb2820deb0 Put the skeleton sample code from README.developer into its own file - it's
much easier to edit/maintain that way as well as much easier to copy for a
new dissector. Explicitly don't set the SVN id tag since this is a template.

svn path=/trunk/; revision=48860
2013-04-15 20:56:55 +00:00
Martin Mathieson 08c91ded8a Add a context field for the carrierId.
svn path=/trunk/; revision=48859
2013-04-15 20:56:49 +00:00
Gerald Combs cd7796a6ef Handle the IEEE's new! improved! two-space indentation.
svn path=/trunk/; revision=48856
2013-04-15 19:10:15 +00:00
Martin Mathieson d7c35d571d Allow MAC and RLC stats dialogs to be launched other than by menu/filter
dialogs.

svn path=/trunk/; revision=48855
2013-04-15 18:25:04 +00:00
Anders Broman 1b7b729852 Don't check direction on "prot" where the meaning is the same UL/DL
svn path=/trunk/; revision=48854
2013-04-15 16:29:59 +00:00
Anders Broman 0807f8f1e7 Add Requested-Action AVP.
svn path=/trunk/; revision=48853
2013-04-15 16:29:23 +00:00
Pascal Quantin f4e31cadc3 Spell Tomasz' surname correctly
svn path=/trunk/; revision=48852
2013-04-15 09:23:17 +00:00
Alexis La Goutte 55c415b477 Fix Modelines (No CR in the end of file)
svn path=/trunk/; revision=48851
2013-04-15 08:43:04 +00:00
Alexis La Goutte 05e954f48c From report of chen li via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8572 Endian error and IP:Port error when decoding BT-DHT response message
When the remote client sended a node set, it contains nodes info
The node info it shows like (1	3cad1f360cc51870d3e68d61ed604078bc608ee2 60.173.31.54:43365), but this node's true ip and port is 99.192.73.131:26025. When we expand these items, the ips and ports in detailed information are right.

From me :
It is a problem of encoding (LITTLE ENDIAN => BIG ENDIAN) and wrong offset
Some issue with Peers info

svn path=/trunk/; revision=48850
2013-04-15 08:42:12 +00:00
Evan Huus ddb1685c93 From J. Bruce Fields via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8580
Add support for the NFSv4.1 test_stateid operation.

svn path=/trunk/; revision=48849
2013-04-14 23:04:50 +00:00
Evan Huus 5afbf48723 Update some of the old FSF addresses caught by the new licensecheck buildbot
step.

svn path=/trunk/; revision=48848
2013-04-14 18:55:28 +00:00
Pascal Quantin 6910f9428f From Tomasz Mon via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8503 :
Add USBPcap support

svn path=/trunk/; revision=48847
2013-04-14 16:00:34 +00:00