8b0a085250
Don't assign to a proto_item * if the value won't be used: Coverity 827;
...
Comment out some currently unused code: Coverity 828.
svn path=/trunk/; revision=36453
2011-04-04 17:24:17 +00:00
82a145ceb5
On Windows, try to use an existing console for our messages. Create one if
...
it doesn't exist.
svn path=/trunk/; revision=36452
2011-04-04 17:11:56 +00:00
e2ee0e52d8
Don't assign to a variable if the value won't be used: Coverity 826;
...
Also: Remove some uneeded #includes & use consistent indentation.
svn path=/trunk/; revision=36451
2011-04-04 16:54:02 +00:00
6799acc99b
Fix some typos.
...
svn path=/trunk/; revision=36450
2011-04-04 16:15:27 +00:00
cf20622668
Don't assign to a proto_item * if the value won't be used: Coverity 823 & 824;
...
Fix a minor bug wherein a proto_tree_add_text used the wrong tree: Coverity 825;
Remove some unneeded #includes;
Use consistent indentation.
svn path=/trunk/; revision=36449
2011-04-04 16:13:42 +00:00
89de0e74a0
Don't build a manifest if we don't need one.
...
svn path=/trunk/; revision=36448
2011-04-04 15:41:07 +00:00
aec98c121a
Don't assign to a proto_item * if the value won't be used: Coverity 820/821;
...
Also: #include <stdio.h> & <string.h> not required;
svn path=/trunk/; revision=36447
2011-04-04 15:38:19 +00:00
ede51600c7
Don't assign to a variable if the value won't be used: Coverity 817-821.
...
svn path=/trunk/; revision=36446
2011-04-04 15:31:33 +00:00
a7d7365f4a
Mark pinfo as unused.
...
svn path=/trunk/; revision=36445
2011-04-04 15:09:22 +00:00
aaf0d277b8
Get rid of gsm_a_dtap_pinfo.
...
svn path=/trunk/; revision=36444
2011-04-04 14:49:14 +00:00
8d6ca293dc
Change the signature of elem_fcn():ns to include pinfo.
...
svn path=/trunk/; revision=36443
2011-04-04 14:37:25 +00:00
5e494f36ae
From Vincent Helfre:
...
updated the script that extracts the asn1 from the specification (we modified it after noticing that it currently fails to take the IMPORT section). It should also work now to extract the WCDMA RRC (TS 25.331).
svn path=/trunk/; revision=36442
2011-04-04 14:35:21 +00:00
72b69aeaf5
Change the msg_fcn() signature to include pinfo.
...
svn path=/trunk/; revision=36441
2011-04-04 07:45:34 +00:00
6cef8aa872
From jakub Zawadzki:
...
I've fixed composite tests #0 and #2
svn path=/trunk/; revision=36440
2011-04-04 05:48:06 +00:00
f3af25f270
Don't assign to a proto_item* if the value won't be used: Coverity 885-889
...
Also: Significant code rework including:
- Fix bug wherein a timestamp was incorrectly reported as being an Error;
- Replace many proto_tree_add_text()/proto_item_set_text() sequences each by a
single proto_tree_add_text().
- remove unneeded #include <string.h>
- Whitespace clanup including replacing mixed space/tab indentation by spaces.
svn path=/trunk/; revision=36437
2011-04-03 15:39:01 +00:00
c756da785b
[Automatic manuf, services and enterprise-numbers update for 2011-04-03]
...
svn path=/trunk/; revision=36436
2011-04-03 15:03:50 +00:00
e645e3c4d0
-Whitespace fix in gsm_map-template(no need to regenerate).
...
- Fix dissection of extensions in INAP it should now be possible to add
an "OID dissector" for extensions.
Should fix BUG
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5799
svn path=/trunk/; revision=36435
2011-04-02 09:18:18 +00:00
f8ce3da390
Add some info as to the determination of the length of a FT_STRINGZ item.
...
Add a note not leaving trailing whitespace on a line.
svn path=/trunk/; revision=36434
2011-04-01 20:48:56 +00:00
43f966a0ea
From Alexis La Goutte via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5768 :
...
Patch 6 :
Enhance the MySQL collation
Patch 7 :
Enhance MySQL : add dissection of command Binlog Dump (replicate command).
svn path=/trunk/; revision=36433
2011-04-01 19:50:50 +00:00
4233a227ef
Avoid potential buffer overruns when sscanf'ing strings.
...
Should resolve CID's 656 and 657.
svn path=/trunk/; revision=36432
2011-04-01 18:16:47 +00:00
c236db55fe
Don't use pParser->yyidx as an index into pParser->yystack[] until after it is
...
verified that it is non-negative. Should resolve CID 619.
svn path=/trunk/; revision=36431
2011-04-01 16:55:59 +00:00
2db46ad8d4
Remove const type qualifier from cast. Resolves CID's 582-585.
...
svn path=/trunk/; revision=36430
2011-04-01 16:30:59 +00:00
5344e9f3d9
Take care not to append RLC mode to proto_item twice.
...
svn path=/trunk/; revision=36429
2011-04-01 13:41:08 +00:00
18fc4872bc
Rename local 'pipe_input' so it doesn't shadow global 'pipe_input';
...
Use consistent indentation and remove trailing whitespace.
svn path=/trunk/; revision=36428
2011-03-31 20:57:40 +00:00
f4d68c6a08
Memory leak in lemon.c
...
coverity 1177
svn path=/trunk/; revision=36427
2011-03-31 20:50:13 +00:00
6760848315
Fix 11 occurrences of returned pointer never used. Fixes CID's 1064-1067.
...
svn path=/trunk/; revision=36426
2011-03-31 19:17:06 +00:00
9e49109b28
Check return value of file_seek(). Fixes CID 338.
...
svn path=/trunk/; revision=36425
2011-03-31 18:28:52 +00:00
735b61500c
Don't dereference a NULL pointer. Fixes CID 426.
...
svn path=/trunk/; revision=36424
2011-03-31 18:00:26 +00:00
8f429fd919
separator will never be NULL, but sep_len could be 0, so test for that instead.
...
Fixes CID 620.
svn path=/trunk/; revision=36423
2011-03-31 17:27:48 +00:00
b92bf3b06c
Use BSWAP16 instead of BSWAP32 for 16-bit values. Fixes CID's 1179 and 1180.
...
svn path=/trunk/; revision=36422
2011-03-31 16:46:16 +00:00
adadb7dd0f
Use a common function, higher_priority_status_level() to determine whether or
...
not messages should be pushed onto the statusbar. Should fix CID 270.
svn path=/trunk/; revision=36421
2011-03-31 16:23:07 +00:00
4d4f0b839b
Clear the entire contents of ctx at the end of md5_finish(). Fixes CID 712.
...
svn path=/trunk/; revision=36420
2011-03-31 15:41:23 +00:00
f8737dfbcc
From Alexis La Goutte via bug 5790: Fix 8 clang warnings, all of which were:
...
"warning: Value stored to 'offset' is never read". The 'offset' is now used.
svn path=/trunk/; revision=36419
2011-03-31 15:17:49 +00:00
0db9556757
Delete unused header fields found by running tools/checkhf.pl.
...
svn path=/trunk/; revision=36418
2011-03-31 14:35:40 +00:00
94f2771f41
(Trivial) Fix some typos; do some whitespace cleanup & rewording of comments.
...
svn path=/trunk/; revision=36417
2011-03-31 14:30:38 +00:00
f88037ac41
From Yair via bug 5779: Add option to leave AAL5 in unspecified format.
...
(... with whitepsace changes by me.)
svn path=/trunk/; revision=36416
2011-03-31 14:23:07 +00:00
1e71ccef15
From Andrew Feren via bug 5775: Correct types on several info elements.
...
svn path=/trunk/; revision=36415
2011-03-31 14:03:23 +00:00
8d62b393a4
Register tcp by name.
...
To be used in User DLT's and Lua scripts.
svn path=/trunk/; revision=36414
2011-03-31 12:18:14 +00:00
a54e28e2ec
Use correct functions to fetch protocol name for a dissector registered
...
by register_dissector().
svn path=/trunk/; revision=36413
2011-03-31 12:16:41 +00:00
a6476ba91b
Added dissector_handle_get_long_name().
...
svn path=/trunk/; revision=36412
2011-03-31 12:14:59 +00:00
0b8be02229
Use correct length for clientaddr4 callback address entry.
...
svn path=/trunk/; revision=36411
2011-03-31 11:01:06 +00:00
a3fe8fbd1a
Fix a couple of typos.
...
svn path=/trunk/; revision=36410
2011-03-30 15:54:28 +00:00
dde455a94e
From: http://www.wireshark.org/lists/wireshark-dev/201103/msg00157.html
...
Change RTT references to SRT. (This should have been checked in with r36297.)
svn path=/trunk/; revision=36409
2011-03-30 14:53:09 +00:00
9e55be72fc
Wrap all text lines of help at column 80.
...
svn path=/trunk/; revision=36408
2011-03-30 14:44:18 +00:00
13f6b77d92
remove two pointless const in casts
...
coverity 580 and 581
svn path=/trunk/; revision=36407
2011-03-30 04:36:09 +00:00
f3512de0a9
remove some assignments we dont use
...
svn path=/trunk/; revision=36406
2011-03-30 03:39:58 +00:00
a4452f43fa
Change TCP_PORT_MANGO to TCP_PORT_MONGO.
...
svn path=/trunk/; revision=36405
2011-03-29 21:40:54 +00:00
5a2a122942
Don't put a 65536 byte variable on the stack: instead, malloc/free it.
...
Coverity 760-761.
svn path=/trunk/; revision=36404
2011-03-29 21:39:15 +00:00
645cfe9ef2
Add a missing break.
...
CID 487
svn path=/trunk/; revision=36403
2011-03-29 21:20:36 +00:00
ce248d9ea9
Add a missing break.
...
CID 488
svn path=/trunk/; revision=36402
2011-03-29 21:11:26 +00:00
Bill Meier