Anders Broman
6cef8aa872
From jakub Zawadzki:
...
I've fixed composite tests #0 and #2
svn path=/trunk/; revision=36440
2011-04-04 05:48:06 +00:00
Bill Meier
7f0107220d
Fix various instances of "unreachable code".
...
svn path=/trunk/; revision=35713
2011-01-30 23:27:57 +00:00
Stephen Fisher
d37c33b7e7
Mention that the fake tvb unicode functions have been superceded
...
svn path=/trunk/; revision=35689
2011-01-28 20:01:01 +00:00
Stephen Fisher
fc7b0c019b
Fix the dead initialization warnings found by clang's static analysis
...
("Value stored to 'xxx' during its initialization is never read")
svn path=/trunk/; revision=35598
2011-01-20 18:56:11 +00:00
Chris Maynard
116d67e164
Add tvb_get_[n|le]toh[40|48|56]() accessors. Addresses bug 5082.
...
svn path=/trunk/; revision=35538
2011-01-14 19:02:38 +00:00
Jeff Morriss
05400b7709
There's no need to call tvb_get_ptr() in here: just call ensure_contiguous() directly.
...
svn path=/trunk/; revision=35509
2011-01-12 20:25:36 +00:00
Jeff Morriss
0c4e881911
Introduce, and start using, tvb_get_const_stringz(). This function returns a
...
pointer to a NULL-terminated string in the TVB. It is no safer than dissectors
which call tvb_get_strsize() and then tvb_get_ptr() but it makes it clear that
this usage of tvb_get_ptr() is safe.
This function is slightly more efficient than tvb_get_ephemeral_stringz()--but
only as long as we're not using composite TVBs.
svn path=/trunk/; revision=35493
2011-01-12 02:25:08 +00:00
Stephen Fisher
55e08f007e
Introduce two new functions for Unicode (UTF-16) string handling:
...
tvb_get_unicode_string()
tvb_get_ephemeral_unicode_string()
These function like their counterparts, tvb_get_string and
tvb_get_epemeral_string, for standard strings.
Also update comment on what the first such function,
tvb_get_ephemeral_unicode_stringz does regarding updating lengthp.
svn path=/trunk/; revision=35344
2011-01-03 18:29:29 +00:00
Anders Broman
735709bee6
Add tvb_bcd_dig_to_ep_str()
...
/*
* Given a tvbuff, an offset into the tvbuff, and a length that starts
* at that offset (which may be -1 for "all the way to the end of the
* tvbuff"), fetch BCD encoded digits from a tvbuff starting from either
* the low or high half byte, formating the digits according to an input digit set,
* if NUll a default digit set of 0-9 returning "?" for overdecadic digits will be used.
* A pointer to the EP allocated string will be returned.
* Note a tvbuff content of 0xf is considered a 'filler' and will end the conversion.
*/
svn path=/trunk/; revision=35286
2010-12-28 12:36:26 +00:00
Stephen Fisher
e9f3d27b4a
Add a couple more comments to new unicode function to remind us when a
...
variable is counting UTF-16 characters vs. normal bytes.
svn path=/trunk/; revision=35256
2010-12-23 18:26:25 +00:00
Stephen Fisher
f0029fd060
Remove comment to myself that I forgot to remove before commiting r35253
...
and change comments to fit within 80 column display.
svn path=/trunk/; revision=35255
2010-12-23 18:24:39 +00:00
Stephen Fisher
4f5ccc00f8
Introduce new function called tvb_get_ephemeral_unicode_stringz(), which
...
is a unicode (UTF-16) version of tvb_get_ephemeral_stringz(). It scans
a tvbuff for a UTF-16 string and converts it to UTF-8 upon return.
svn path=/trunk/; revision=35253
2010-12-23 17:59:34 +00:00
Anders Broman
ab16d07fd3
From Vincent Helfre:
...
Bug in tvb_get_bits32(), The last bitshift is too large, which causes the least significant bits to be 0 all the time.
svn path=/trunk/; revision=35015
2010-11-23 17:33:57 +00:00
Jeff Morriss
0b7e2cd37e
Make tvb_strncaseeql()'s size parameter be a size_t. Cast the size to int before calling ensure_contiguous_no_exception() (also in tvb_strneql()).
...
svn path=/trunk/; revision=34727
2010-10-30 18:53:31 +00:00
Jeff Morriss
f5d3a16225
Make tvb_strneql()'s size parameter be a size_t. Remove some now-unnecessary casts.
...
svn path=/trunk/; revision=34725
2010-10-30 18:18:12 +00:00
Guy Harris
cd67ad0047
Clean up indentation.
...
svn path=/trunk/; revision=33814
2010-08-16 17:19:15 +00:00
Anders Broman
63bffd3ac5
From rodebiet:
...
tvb_get_bits32 produces malformed_packet if no_of_bits < 25 and tvb remaining = 3
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5080
svn path=/trunk/; revision=33811
2010-08-16 15:13:54 +00:00
Guy Harris
1b444c55fd
Refer to the endianness arguments as "encoding" rather than
...
"representation" - we already use "representation" to refer to the text
representation of fields.
Change some routines with an endianness argument to make it a
representation argument instead;
svn path=/trunk/; revision=32929
2010-05-24 06:06:17 +00:00
Anders Broman
1c1142fce6
From Jakub Zawadzki:
...
- use Glibc:s highly optimized memchr()
svn path=/trunk/; revision=32584
2010-04-28 08:15:20 +00:00
Anders Broman
4a711cc74a
From Jakub Zawadzki:
...
- optimize guint8_pbrk().
svn path=/trunk/; revision=32583
2010-04-28 07:58:59 +00:00
Bill Meier
6812b68eb1
From Yaniv Kaul: constify parameters
...
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4422
From me: Fix a number of instances where the function prototype or
the function definition wasn't changed so there was a mismatch
thus causing Windows (but not gcc) compilation errors.
svn path=/trunk/; revision=32365
2010-04-03 18:18:50 +00:00
Bill Meier
d32b4c0758
Revert SVN #32360 until Windows compilation errors corrected.
...
svn path=/trunk/; revision=32361
2010-04-02 15:18:03 +00:00
Bill Meier
049f9eac85
From Yaniv Kaul: constify parameters
...
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4422
svn path=/trunk/; revision=32360
2010-04-02 14:37:49 +00:00
Anders Broman
25af78517e
Make tvb_pbrk_guint8() return the found needle.
...
svn path=/trunk/; revision=32144
2010-03-08 20:45:13 +00:00
Bill Meier
9d663d7081
Fix various gcc -Wshadow warnings.
...
svn path=/trunk/; revision=31720
2010-01-28 18:45:46 +00:00
Stig Bjørlykke
bb5ef1c521
parent is not unused in tvb_child_uncompress().
...
svn path=/trunk/; revision=31658
2010-01-25 13:54:05 +00:00
Jaap Keuter
5dcaa2bec0
Make more output parameters optional.
...
svn path=/trunk/; revision=31059
2009-11-23 22:02:12 +00:00
Gerasimos Dimitriadis
9b36fc784e
From yy:
...
About GSM system information type 2quater
Modified to use newly defined tvb_get_bits() in tvbuff.c
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4219
svn path=/trunk/; revision=30962
2009-11-14 20:13:43 +00:00
Kovarththanan Rajaratnam
dc265696a1
tvb_format_text() always returns a non NULL pointer so don't check return value for NULL pointer
...
svn path=/trunk/; revision=30821
2009-11-04 16:08:47 +00:00
Kovarththanan Rajaratnam
30cb2b9448
Add DISSECTOR_ASSERT() before dereferencing a possible NULL pointer
...
svn path=/trunk/; revision=30404
2009-10-08 15:01:25 +00:00
Kovarththanan Rajaratnam
7775703b1a
Use g_new0() when allocating z_stream
...
svn path=/trunk/; revision=30277
2009-10-04 06:32:43 +00:00
Kovarththanan Rajaratnam
911b058d02
Use GLibs CLAMP(). The current inlined implementation seems to be wrong:
...
} else if (bufsiz > TVB_Z_MAX_BUFSIZ) {
bufsiz = TVB_Z_MIN_BUFSIZ;
}
This should probably have been 'bufsiz = TVB_Z_MAX_BUFSIZ;'
svn path=/trunk/; revision=30276
2009-10-04 06:28:50 +00:00
Kovarththanan Rajaratnam
19bf38ac52
Delay allocation of z_stream
...
svn path=/trunk/; revision=30275
2009-10-04 06:20:32 +00:00
Kovarththanan Rajaratnam
1703bfa464
g_malloc0() doesn't return NULL so remove NULL error paths
...
svn path=/trunk/; revision=30274
2009-10-04 06:12:31 +00:00
Kovarththanan Rajaratnam
c285a1cd3a
Remove 'type' formal parameter from tvb_new_with_subset()
...
svn path=/trunk/; revision=29988
2009-09-20 07:35:39 +00:00
Kovarththanan Rajaratnam
b97cfa22fd
offset_from_real_beginning() is only called with 0 as second argument, so remove the argument completely. It seems that the second argument only acts as an accumulator allowing offset_from_real_beginning() to call itself recursively. To be consistent offset_from_real_beginning() is renamed to tvb_offset_from_real_beginning().
...
svn path=/trunk/; revision=29844
2009-09-10 16:54:02 +00:00
Kovarththanan Rajaratnam
fe6f8b92c7
Add a new function, tvb_new_subset_remaining(), which is a sligtly optimized version of tvb_new_subset(). The latter can be mapped to the former by tvb_new_subset(tvb, offset, -1 /* backing_length */, -1 /* reported_length */). We can disable some bounds checking because 'backing_length' and 'reported_length' are hardcoded to -1.
...
The current implementation of tvb_new_subset_remaining() only has the THROW_ON(reported_length < 1) check removed when compared to tvb_new_subset(). So there's room for improvement in this function. We should be able to disable some more (redundant) bounds checking.
svn path=/trunk/; revision=29445
2009-08-16 10:53:47 +00:00
Kovarththanan Rajaratnam
c795851beb
Remove unused parameters
...
svn path=/trunk/; revision=29444
2009-08-16 09:48:25 +00:00
Kovarththanan Rajaratnam
6cd59f3799
Remove the non-thread safe usage of 'last_tvb' variable in tvb_new_subset()
...
svn path=/trunk/; revision=29443
2009-08-16 09:18:17 +00:00
Kovarththanan Rajaratnam
998ee3a2e0
Make some of the check_XXX functions accept the length/reported length of the tvbuff as arguments instead the tvbuff. We'll need this feature in order to remove the non-thread usage of the 'last_tvb' variable in tvb_new_subset()
...
svn path=/trunk/; revision=29442
2009-08-16 08:18:17 +00:00
Kovarththanan Rajaratnam
01abc372e6
Remove a non thread-safe usage (useful when/if we ever support threading) of a static tvbuff in tvb_new_real_data(). The current version uses a static 'last_tvb' to keep track of the last allocated tvbuff. This is needed because some of the function we call can throw an exception. This patch improves this strategy by throwing an exception (if needed) before we try to allocate the tvbuff. This way we avoid a memleak _and_ we don't have to track the 'last_tvb' tvbuff.
...
svn path=/trunk/; revision=29441
2009-08-16 07:29:11 +00:00
Kovarththanan Rajaratnam
aed905a6c9
Use the slice allocator if GLIB >= 2,10,0 as suggested by Anders Broman
...
svn path=/trunk/; revision=29434
2009-08-15 13:24:59 +00:00
Kovarththanan Rajaratnam
623db2e71e
Add a missing DISSECTOR_ASSERT in tvb_init()
...
svn path=/trunk/; revision=29433
2009-08-15 12:41:24 +00:00
Kovarththanan Rajaratnam
ef68d63745
Make mem chunk static
...
svn path=/trunk/; revision=29432
2009-08-15 12:29:25 +00:00
Kovarththanan Rajaratnam
e1c5ffd553
(Trivial change) move ensure_contiguous() to reflect call hierarchy
...
svn path=/trunk/; revision=29382
2009-08-11 18:28:10 +00:00
Kovarththanan Rajaratnam
158827a5e7
Turn a comment in fast_ensure_contiguous() into a DISSECTOR_ASSERT() to make the implied requirement explicit.
...
svn path=/trunk/; revision=29381
2009-08-11 18:16:55 +00:00
Stig Bjørlykke
81c551ec59
Remove some "statement not reached" warnings.
...
svn path=/trunk/; revision=28691
2009-06-11 10:03:08 +00:00
Stig Bjørlykke
a44cc2442d
Fixed check for no_of_bits in tvb_get_bits16(), tvb_get_bits32() and
...
tvb_get_bits64().
svn path=/trunk/; revision=28658
2009-06-08 08:28:42 +00:00
Stig Bjørlykke
d628c0a4cc
Added tvb_format_stringzpad_wsp().
...
svn path=/trunk/; revision=28140
2009-04-24 08:08:37 +00:00
Guy Harris
8b7812db76
Reapply the change from revision 27946.
...
svn path=/trunk/; revision=27963
2009-04-05 17:24:06 +00:00