Commit Graph

13177 Commits

Author SHA1 Message Date
Alexis La Goutte 99f11112f9 Update IKEv2 to last IANA Parameters (2011-11-09)
Add RFC-kivinen-ipsecme-secure-password-framework-03

svn path=/trunk/; revision=40233
2011-12-17 09:57:35 +00:00
Bill Meier 799be66d9f Add (what I think are) missing add_new_data_source() calls;
svn path=/trunk/; revision=40231
2011-12-16 19:15:17 +00:00
Bill Meier 4756f41771 Fix tvb memory leak; Also: For a "packet-lifetime" tvb use ep_alloc'd (not se_alloc'd) memory.
svn path=/trunk/; revision=40230
2011-12-16 17:33:09 +00:00
Ronnie Sahlberg 4f052c3cd6 PAC: S4U update, decode the full S4U Delegation Info blob with correct names
svn path=/trunk/; revision=40227
2011-12-16 03:54:46 +00:00
Ronnie Sahlberg bd83ae6dbb DCE/RPC: When printing counted strings to the tree, we divided the number of bytes by 2 and thus truncating the string in half for the presentation.
svn path=/trunk/; revision=40226
2011-12-16 03:44:43 +00:00
Ronnie Sahlberg d745d83b3c PAC: rename CONSTRAINED_DELEGATION to S4U_DELEGATION_INFO
svn path=/trunk/; revision=40225
2011-12-16 03:41:14 +00:00
Ronnie Sahlberg 90b7941dcd Kerberos: rename the pa type 129 to the correct name PA_FOR_USER and describe where this type is specified
svn path=/trunk/; revision=40224
2011-12-16 03:18:04 +00:00
Guy Harris dad8d4ca55 Note why we need <stdio.h>.
svn path=/trunk/; revision=40223
2011-12-16 00:54:45 +00:00
Bill Meier 49e38170c5 Oops: #include <stdio.h> is really needed.
svn path=/trunk/; revision=40222
2011-12-16 00:50:47 +00:00
Bill Meier 8ea30b478a Fix tvb memory leak; Add missing call to add_new_data_source();
Also: remove unneeded #includes.

svn path=/trunk/; revision=40221
2011-12-16 00:33:03 +00:00
Bill Meier ad769d824d Fix a typo
svn path=/trunk/; revision=40220
2011-12-15 21:30:51 +00:00
Guy Harris 33f6b348d1 #if 0 out a bunch of (currently?) unused routines.
svn path=/trunk/; revision=40219
2011-12-15 21:03:21 +00:00
Guy Harris 3d3c612706 Clean up indentation.
svn path=/trunk/; revision=40218
2011-12-15 21:00:15 +00:00
Guy Harris 3422b119f6 Null out opensafety_item if we're nulling out opensafety_tree.
Clean up indentation.

svn path=/trunk/; revision=40217
2011-12-15 20:59:44 +00:00
Anders Broman 8bbb6d5b2a #if 0 now unused variables.
svn path=/trunk/; revision=40216
2011-12-15 20:45:06 +00:00
Anders Broman 939ae71194 From Roland Knall:
- New Config option to configure the sequence of frames using UDP
- an Info will be added, if the SCM UDID is not configured or if it is wrongly
configured, so that the user can act on it.
- SCM UDID will only be printed if configured correctly, if not a warning will
be added to inform, that the first byte for the UDID will be assumed to be 00
- UDP dissection can enforce the number of sub-package the dissection should
assume
- SSDO: isRequest is determined by it's field not by the message id
- SSDO: Unused code for SNMT Reset Guarding SCM has been removed
- SNMT: error_group and error_code for SN_FAIL have not been dissected
correctly
- Sercos III: bug != instead of ==, is fixed
- dissect_opensafety_udp renamed to dissect_opensafety_udpdata, because of
future dissector called opensafety_udp which will handle transport of
openSAFETY data over UDP
- dissect_opensafety_udpdata enhanced to determine the index of the given frame
in the package. Needed for correct assembly of COL_INFO
- Added heuristic dissector hook for opensafety_udp dissector. The dissector
will be submitted to this list at a future point

- Enhanced description of the dissector to reflect it's capabilities
- Reworked the description for the config options to be more understandable

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6672

svn path=/trunk/; revision=40214
2011-12-15 20:34:45 +00:00
Anders Broman a106a9047a Call the rohc dissector directly, the code will be cleaned up
in the next weeks or so.

svn path=/trunk/; revision=40213
2011-12-15 20:22:54 +00:00
Bill Meier 98ed218772 Conform indentation to that specified by the modeline; Reformat long lines.
svn path=/trunk/; revision=40212
2011-12-15 18:47:57 +00:00
Bill Meier 8fe471e0c3 Fix some tvb memory leaks; Fix a typo.
svn path=/trunk/; revision=40211
2011-12-15 18:13:21 +00:00
Anders Broman b2678b43d1 From Per Liedberg:
RoHC dissection improvment.

svn path=/trunk/; revision=40210
2011-12-15 17:28:43 +00:00
Anders Broman d3e76bdeb0 Use correct string length.
svn path=/trunk/; revision=40209
2011-12-15 17:14:56 +00:00
Bill Meier 6c809fc444 In certain cases, don't reference a tvb when displaying a hidden,generated field.
svn path=/trunk/; revision=40208
2011-12-15 16:01:25 +00:00
Stephen Fisher e97991cdcc Fix moving nfs_fhandle_data from packet-nfs.h to packet-nfs.c as begun
in r40205.


svn path=/trunk/; revision=40206
2011-12-14 23:27:14 +00:00
Bill Meier 13f09ee27f Fix a tvb memory leak;
Essentially: generate tvbuffs as needed; don't save them for later reuse
               with the result they are never freed.

Also:
- move a struct from packet-nfs.h to packet-nfs.c since it's only used locally;
- reformat some long lines.

svn path=/trunk/; revision=40205
2011-12-14 22:01:38 +00:00
Bill Meier 586ea8d092 Add call to add_new_data_source() for a newly created REAL_DATA tvb.
svn path=/trunk/; revision=40203
2011-12-14 18:58:08 +00:00
Sake Blok 418863f88d Fix for bug 6032:
After changing the ssl_keys UAT, reparse the list and reload the keys.


svn path=/trunk/; revision=40200
2011-12-14 18:24:41 +00:00
Bill Meier 1460765248 Fix tvb memory leak.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3917

svn path=/trunk/; revision=40199
2011-12-14 17:35:22 +00:00
Bill Meier 13ad9f1071 Fix a tvbuff memory leak;
Also: Wireshark code change attributions are usually only in the svn log.

svn path=/trunk/; revision=40198
2011-12-14 15:19:14 +00:00
Bill Meier d281828b06 Fix a (sort-of) memory leak: Use ep_alloc'd rather than se_alloc'd memory for a tvbuff;
svn path=/trunk/; revision=40197
2011-12-14 14:39:16 +00:00
Guy Harris 44b29ee2ef Put back the source MAC address, but do it right, in one column_add_fstr()
call, and using ep_address_to_str(), so it can handle any address type,
including AT_NONE if the source address isn't available.

svn path=/trunk/; revision=40196
2011-12-14 05:23:57 +00:00
Guy Harris 343e983384 Refer to a PID of 0x0002 as the PID for the HP Teaming heartbeat
protocol.

Point to an HP document o the protocol, and discuss the two ways to hook
up the dissector.

Don't bother checking the destination address - either the OUI/PID
suffices, or the MAC address is both necessary and, presumably,
sufficient and we need to introduce a heuristic dissector table for SNAP
frames.  What's more, there's no guarantee that the destination address
is a MAC address - it might be absent, e.g. because you're capturing on
the Linux "any" device and are getting the "Linux cooked" header, with
only a destination address.

Don't put the source address into the Info column - it's already in the
source column *if* it exists (which it might not, for packets captured
from the "any" device and sent by the machine doing the capturing).

svn path=/trunk/; revision=40195
2011-12-14 02:55:26 +00:00
Bill Meier 29c17df6a5 Fix [-Wunused-but-set-variable] gcc warning;
Use consistent indentation.

svn path=/trunk/; revision=40192
2011-12-14 00:06:16 +00:00
Bill Meier 63c71a7090 Use consistent indentation.
svn path=/trunk/; revision=40191
2011-12-13 23:47:47 +00:00
Bill Meier 44c3525d14 Fix memory leak.
svn path=/trunk/; revision=40190
2011-12-13 23:16:13 +00:00
Bill Meier ececcf6811 Fix a memory leak.
svn path=/trunk/; revision=40189
2011-12-13 23:03:16 +00:00
Bill Meier 312f95f56c Convert "4 space tabs" to spaces; Minor reformatting.
svn path=/trunk/; revision=40188
2011-12-13 23:02:29 +00:00
Bill Meier 1311b2ab83 Fix tvb memory leak; Fix hex byte display for Unicode XML.
svn path=/trunk/; revision=40187
2011-12-13 22:49:59 +00:00
Bill Meier 1c3504bd6e Fix tvbuff memory leak.
svn path=/trunk/; revision=40186
2011-12-13 21:51:33 +00:00
Bill Meier 9c8a91f259 Use consistent indentation.
svn path=/trunk/; revision=40185
2011-12-13 21:03:57 +00:00
Bill Meier ec42a2bd1d Move proto_reg_handoff...(0 to the end of the file as per Wireshark convention.
Minor whitespace cleanup.

svn path=/trunk/; revision=40183
2011-12-13 19:58:47 +00:00
Bill Meier 6d3f5ff143 Fix: Execution Tracing High-Detail field selection highlighting seemingly wrong bytes in hex view pane.
Actual problem:
  A REAL_DATA tvbuff wasn't being added to the "data_sources"
  for a frame. When displaying the frame, when a field referencing the tvb was selected
  for display there was no 'hex bytes' tab for the field and so bytes ended up being
  highlighted in the currently displayed hex bytes tab (thus highlighting bytes in a pane
  not related to the field).

  Consider: Add some code in field creation (proto_tree_add...) to at least warn if
            a field is being created using a tvb whose data_source is not in the
            data_sources list for the frame ?

svn path=/trunk/; revision=40182
2011-12-13 19:54:19 +00:00
Martin Mathieson 70e2a50ad1 Initialise 'sub_tree' to NULL, to avoid warnings about possibly using
uninitialised.  The warnings are bogus, but could have been avoided, as the test
to see if we're using a compression profile is redundant/will always be TRUE
in those functions...

Also removed some unnecessary braces from switch cases (no local variables were defined).

svn path=/trunk/; revision=40181
2011-12-13 19:46:24 +00:00
Guy Harris 9924dd3acf The last element of an h248_pkg_param_t should be a pointer.
svn path=/trunk/; revision=40180
2011-12-13 18:56:01 +00:00
Anders Broman 031da40d79 h248_e_implicit = FALSE;
svn path=/trunk/; revision=40179
2011-12-13 17:59:27 +00:00
Anders Broman d47335b133 From Per Liedberg:
RoHC dissection improvment.

svn path=/trunk/; revision=40177
2011-12-13 17:13:50 +00:00
Bill Meier 4a976f1be7 Use tvb_new_child_real_data() instead of tvb_new_real_data() + tvb_set_child_real_data_tvbuff().
svn path=/trunk/; revision=40173
2011-12-13 04:01:33 +00:00
Bill Meier 199da73e21 Prevent memory leakage of uncompress tvb and associated data buffer (step 1).
(tvb memory leak will actually remain until a bug in tvbuff.c is also fixed).

svn path=/trunk/; revision=40171
2011-12-13 02:56:44 +00:00
Bill Meier 95977fcc8b Fix a memory leak of a tvb.
svn path=/trunk/; revision=40163
2011-12-13 00:02:30 +00:00
Chris Maynard 1153ff7b56 Fix incorrect "pos=0" pdml values. Resolves the issue reported in comment 4 of https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2432 and closes the bug.
svn path=/trunk/; revision=40161
2011-12-12 18:35:49 +00:00
Jaap Keuter b6872d0a3b From Roy Marples:
ICMPv6 DNSSL option can contain padding, which does not represent a malformed option.

svn path=/trunk/; revision=40159
2011-12-12 08:18:18 +00:00