- New Config option to configure the sequence of frames using UDP
- an Info will be added, if the SCM UDID is not configured or if it is wrongly
configured, so that the user can act on it.
- SCM UDID will only be printed if configured correctly, if not a warning will
be added to inform, that the first byte for the UDID will be assumed to be 00
- UDP dissection can enforce the number of sub-package the dissection should
assume
- SSDO: isRequest is determined by it's field not by the message id
- SSDO: Unused code for SNMT Reset Guarding SCM has been removed
- SNMT: error_group and error_code for SN_FAIL have not been dissected
correctly
- Sercos III: bug != instead of ==, is fixed
- dissect_opensafety_udp renamed to dissect_opensafety_udpdata, because of
future dissector called opensafety_udp which will handle transport of
openSAFETY data over UDP
- dissect_opensafety_udpdata enhanced to determine the index of the given frame
in the package. Needed for correct assembly of COL_INFO
- Added heuristic dissector hook for opensafety_udp dissector. The dissector
will be submitted to this list at a future point
- Enhanced description of the dissector to reflect it's capabilities
- Reworked the description for the config options to be more understandable
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6672
svn path=/trunk/; revision=40214
Essentially: generate tvbuffs as needed; don't save them for later reuse
with the result they are never freed.
Also:
- move a struct from packet-nfs.h to packet-nfs.c since it's only used locally;
- reformat some long lines.
svn path=/trunk/; revision=40205
call, and using ep_address_to_str(), so it can handle any address type,
including AT_NONE if the source address isn't available.
svn path=/trunk/; revision=40196
protocol.
Point to an HP document o the protocol, and discuss the two ways to hook
up the dissector.
Don't bother checking the destination address - either the OUI/PID
suffices, or the MAC address is both necessary and, presumably,
sufficient and we need to introduce a heuristic dissector table for SNAP
frames. What's more, there's no guarantee that the destination address
is a MAC address - it might be absent, e.g. because you're capturing on
the Linux "any" device and are getting the "Linux cooked" header, with
only a destination address.
Don't put the source address into the Info column - it's already in the
source column *if* it exists (which it might not, for packets captured
from the "any" device and sent by the machine doing the capturing).
svn path=/trunk/; revision=40195
Actual problem:
A REAL_DATA tvbuff wasn't being added to the "data_sources"
for a frame. When displaying the frame, when a field referencing the tvb was selected
for display there was no 'hex bytes' tab for the field and so bytes ended up being
highlighted in the currently displayed hex bytes tab (thus highlighting bytes in a pane
not related to the field).
Consider: Add some code in field creation (proto_tree_add...) to at least warn if
a field is being created using a tvb whose data_source is not in the
data_sources list for the frame ?
svn path=/trunk/; revision=40182
uninitialised. The warnings are bogus, but could have been avoided, as the test
to see if we're using a compression profile is redundant/will always be TRUE
in those functions...
Also removed some unnecessary braces from switch cases (no local variables were defined).
svn path=/trunk/; revision=40181