Commit Graph

46 Commits

Author SHA1 Message Date
Pascal Quantin 3ba1c7ff77 LTE RRC: upgrade dissector to v15.5.0
Change-Id: I227db32a59a16c31d7712cb9c48b55fa4aaf28ca
Reviewed-on: https://code.wireshark.org/review/32759
Petri-Dish: Pascal Quantin <pascal@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2019-04-06 18:59:11 +00:00
Pascal Quantin 24ef409900 ETSI CAT: add dissection of Network Measurement Results
Bug: 15665
Change-Id: Iaff2432bf87d1c9d237709b651005518c89bff18
Reviewed-on: https://code.wireshark.org/review/32707
Reviewed-by: Pascal Quantin <pascal@wireshark.org>
Petri-Dish: Pascal Quantin <pascal@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-04-04 10:59:12 +00:00
Gerald Combs 8d3ac3af86 epan: Convert our PROTO_ITEM_ macros to inline functions.
Convert our various PROTO_ITEM_ macros to inline functions and document
them.

Change-Id: I070b15d4f70d2189217a177ee8ba2740be36327c
Reviewed-on: https://code.wireshark.org/review/32706
Reviewed-by: Gerald Combs <gerald@wireshark.org>
Petri-Dish: Gerald Combs <gerald@wireshark.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-04-04 04:03:38 +00:00
Martin Mathieson d3c583aa67 Add protocol filter for exported parts of 3G and LTE RRC.
Change-Id: Ib5ed8eaecafe9f07eec2ee10f0f2684d81dec1b7
Reviewed-on: https://code.wireshark.org/review/32085
Petri-Dish: Martin Mathieson <martin.r.mathieson@googlemail.com>
Reviewed-by: Pascal Quantin <pascal@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
2019-02-18 12:39:07 +00:00
Pascal Quantin bf4fe342e3 LTE RRC: add dissection of NR RSRP/RSRQ/SINR fields
Change-Id: I56f44fd4dc6aa6358be54e200ddc7b27d51778aa
Reviewed-on: https://code.wireshark.org/review/32008
Petri-Dish: Pascal Quantin <pascal@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2019-02-13 16:46:22 +00:00
Pascal Quantin 592248c2fc LTE RRC: dissect 2 InterNode IEs
Change-Id: I17424675a7b60f468e94134f17533cd891d135f7
Reviewed-on: https://code.wireshark.org/review/31606
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2019-01-19 12:51:36 +00:00
Pascal Quantin 94daef786a LTE RRC: upgrade dissector to v15.4.0
Change-Id: I90b3a5afe782992eac98b37336cc9267ba73dbc0
Reviewed-on: https://code.wireshark.org/review/31595
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2019-01-18 19:30:05 +00:00
Pascal Quantin 67783962cf LTE RRC: fix dissection of measResultSCG-r15 IE
Change-Id: I68bdc75fc1fb270f815004f2cb6eafbb7bfc2329
Reviewed-on: https://code.wireshark.org/review/31572
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2019-01-17 10:24:17 +00:00
Pascal Quantin d6b187e42f XnAP: upgrade dissector to v15.2.0
Change-Id: Ie26f8918aff20ade21eda611950795a320a417f2
Reviewed-on: https://code.wireshark.org/review/31483
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2019-01-11 12:02:40 +00:00
Guy Harris 7eb3e47fa4 Try to squeeze some bytes out of the frame_data structure.
Make the time stamp precision a 4-bit bitfield, so, when combined with
the other bitfields, we have 32 bits.  That means we put the flags at
the same structure level as the time stamp precision, so they can be
combined; that gets rid of an extra "flags." for references to the flags.

Put the two pointers next to each other, and after a multiple of 8 bytes
worth of other fields, so that there's no padding before or between them.

It's still not down to 64 bytes, which is the next lower power of 2, so
there's more work to do.

Change-Id: I6f3e9d9f6f48137bbee8f100c152d2c42adb8fbe
Reviewed-on: https://code.wireshark.org/review/31213
Petri-Dish: Guy Harris <guy@alum.mit.edu>
Tested-by: Petri Dish Buildbot
Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-12-27 04:34:29 +00:00
Pascal Quantin f0b822f731 LTE RRC: add direction to UL-CCCH and DL-CCCH PDUs
This will be useful for the RRC Early Data procedure.

Change-Id: Idcf4251315ee171aa15e650682d7e686a05a9e0a
Reviewed-on: https://code.wireshark.org/review/30185
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-10-13 05:17:13 +00:00
Pascal Quantin 0443cd2c95 XnAP: upgrade dissector to v15.1.0
Change-Id: I2e15944580043774176956e896f360eb5a5711c8
Reviewed-on: https://code.wireshark.org/review/30045
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2018-10-07 15:47:23 +00:00
Pascal Quantin 5c878100b1 NGAP: prettify dissection
Change-Id: I7da88236143e573fe5ff3e1d39df4643de43129c
Reviewed-on: https://code.wireshark.org/review/30035
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2018-10-05 18:56:25 +00:00
Pascal Quantin 3d77c3fc2c X2AP: fix dissection of SeNB to MeNB Container
Change-Id: I4f5af9d52646d74dfa264583b6f0a79e097527e7
Reviewed-on: https://code.wireshark.org/review/30032
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2018-10-05 16:38:22 +00:00
Pascal Quantin 3887162e95 LTE RRC: fix RLC configuration for NB-IoT UE
R15 introduced UM mode for DRBs.

Change-Id: Ifd9030a46bcb237d6e6c1909f2dbad3be3a4eb86
Reviewed-on: https://code.wireshark.org/review/30014
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2018-10-04 12:49:46 +00:00
Pascal Quantin 0bb172194b LTE RRC: upgrade dissector to v15.3.0
Change-Id: I8ca861fb8cffe457780165c64dc3e6fcbc47ba8b
Reviewed-on: https://code.wireshark.org/review/29900
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2018-09-28 12:18:02 +00:00
Peter Wu 08d440cdd4 lte-rrc: avoid BASE_EXT_STRING field without strings
Change-Id: Ifb2b721972de8d80af20f24a6bfd3b17d593e0bd
Fixes: v2.5.0rc0-2357-gc634a73c95 ("LTE RRC: upgrade dissector to v15.0.1")
Reviewed-on: https://code.wireshark.org/review/29746
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2018-09-20 10:10:57 +00:00
Pascal Quantin 590d8c091e LTE RRC: upgrade dissector to v15.2.0
Change-Id: I89f3a3e3f2020d68ea1b165c0ed9d731256fbe94
Reviewed-on: https://code.wireshark.org/review/28346
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2018-06-20 13:07:57 +00:00
Pascal Quantin 64d6a7b846 NR RRC: upgrade dissector to v15.1.0
Change-Id: If34d8627e8dee0e9dd7c1dc72701aec57df68853
Reviewed-on: https://code.wireshark.org/review/26774
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-04-06 11:29:02 +00:00
Pascal Quantin 5f5255ec54 LTE RRC: upgrade dissector to v15.1.0
Change-Id: If8447a010d967dbc58d520bfcc23fecb65f25ed9
Reviewed-on: https://code.wireshark.org/review/26739
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2018-04-04 14:30:05 +00:00
Pascal Quantin c2daa6bc73 LTE RRC: register dissectors for UERadioAccessCapabilityInformation(-NB) and UERadioPagingInformation(-NB)
Change-Id: Idb3c3fe2cab4ce7aff2bfe108a6bd4fb07fe44b3
Reviewed-on: https://code.wireshark.org/review/25426
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-01-23 12:15:35 +00:00
Pascal Quantin c634a73c95 LTE RRC: upgrade dissector to v15.0.1
Change-Id: If0b6fe029b5f852250fde36ead5dc5bb03d44e28
Reviewed-on: https://code.wireshark.org/review/25304
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2018-01-13 19:36:06 +00:00
Pascal Quantin 88abff68df NR RRC: add initial dissector based on v15.0.0
ASN.1 prose imported from the specification and heavily modified
manually to workaround its poor quality.
Some of them are marked with -- WS modification comment, some are not.
Probably useless as-is, but it is an initial start until an updated
version is available.

Change-Id: I19ab6cedb6aa23c8ed57bae525ee4a3391494e32
Reviewed-on: https://code.wireshark.org/review/25235
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-01-10 05:31:33 +00:00
Pascal Quantin 6ab87ad77d LTE RRC: upgrade dissector to v14.4.0
Change-Id: If835450380263a012c3716cf2f2b6ee36a3201a0
Reviewed-on: https://code.wireshark.org/review/23765
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2017-09-27 15:01:52 +00:00
Pascal Quantin 2a9cab649e LTE RRC: add MBMS SIB messages to info column
Change-Id: Id238182ab19c9490d0e1cab852338fafdc2e1b66
Reviewed-on: https://code.wireshark.org/review/23385
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2017-09-04 14:45:20 +00:00
Pascal Quantin 63628636af LTE RRC: add SCPTMConfiguration-BR-r14 message to info column
Change-Id: I82a5625aecadc670c2b15a0ea21e3e796bcb5e63
Reviewed-on: https://code.wireshark.org/review/23313
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2017-08-30 16:50:39 +00:00
Pascal Quantin 8ee06279ff LTE RRC: upgrade dissector to v14.3.0
Change-Id: Ia64095a8a9bdd3b31589842809d8a5313b829f8e
Reviewed-on: https://code.wireshark.org/review/22770
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-07-23 20:34:54 +00:00
Pascal Quantin c27ffaff6d LTE RRC: upgrade dissector to v13.6.0
Change-Id: I0a4288b5044849fa0abe4b58c3c5795e16cee25a
Reviewed-on: https://code.wireshark.org/review/22454
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-06-29 00:41:55 +00:00
Pavel Strnad 3453a0b888 LTE RRC: fix filtering of q-RxLevMin parameter
Ensure that filter as a different abbreviation depending on the
technology used.

Bug: 13481
Change-Id: I14782dffcf70bdb015fd705d2184ae8c42f232c5
Reviewed-on: https://code.wireshark.org/review/22039
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-06-08 14:27:54 +00:00
Michael Mann dd73765549 packet-lte-rrc.c: Create temporary variables for some proto_tree_add_uint calculations.
Pacify checkAPIs.pl

Change-Id: I1801bd92aeb34e3e3240b15cef024718062852d7
Reviewed-on: https://code.wireshark.org/review/21744
Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-05-25 11:39:21 +00:00
Pascal Quantin 103c8b728a LTE RRC: insert an optional separator before adding message name to info column
Bug: 13634
Change-Id: I9585d915b9bc9c895eabeed3d3d5453e94c31789
Reviewed-on: https://code.wireshark.org/review/21274
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2017-04-21 17:13:54 +00:00
Pascal Quantin 4e56c063b4 LTE RRC: do not display twice RRCConnectionReestablishmentReject in info column
Bug: 13595
Change-Id: I5d1537afea7f5a2dddd5e11a06c451ec00913d12
Reviewed-on: https://code.wireshark.org/review/21073
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2017-04-13 11:23:36 +00:00
Pascal Quantin 559836a74c LTE RRC: upgrade dissector to v13.5.0
Change-Id: Ic1c1b2cbf2a9213dbb6d6eadb41c15fcddb0d64a
Reviewed-on: https://code.wireshark.org/review/20672
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-03-23 04:43:51 +00:00
Michael Mann 9365fd3d3a Convert GHashTable -> wmem_map_t for ASN.1 disseectors
Change-Id: Id749c41947c6300f2c82ed947352c336f9e45b72
Reviewed-on: https://code.wireshark.org/review/19838
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-01-30 02:25:24 +00:00
Pascal Quantin b357353f35 LTE RRC: upgrade dissector to v13.4.0
Change-Id: I5f7de78f0be320781091e17ec8c471a3fd482b14
Reviewed-on: https://code.wireshark.org/review/19625
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-01-13 12:40:37 +00:00
Pascal Quantin 934f255c07 LTE RRC: use unit strings
Change-Id: Ib18301246f051f1362ba93621c533044a118189f
Reviewed-on: https://code.wireshark.org/review/19320
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-12-18 01:22:46 +00:00
Pascal Quantin c5a477e72a S1AP: add dissection of NB-IoT transparent containers
To do so, memorize whether a given eNB UE S1AP ID belongs to a NB-IoT
TAI or not.
Also add a preference allowing to force dissection as legacy LTE or
NB-IoT if automatic mode fails.
While we are at it, let's remove the global variables and introduce
a S1AP private data info stored in pinfo.

Change-Id: I7e30b3d59d909684e5cfe13510293ed38ad52574
Reviewed-on: https://code.wireshark.org/review/17709
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2016-09-15 12:31:02 +00:00
Pascal Quantin 9be89dd8e8 X2AP: upgrade dissector to v13.4.0
Change-Id: I97250d022a40ac888522f885968e7cd3c86e3485
Reviewed-on: https://code.wireshark.org/review/17540
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2016-09-06 20:30:46 +00:00
Pascal Quantin 4a3b320c98 S1AP: add more LTE-RRC transparent containers dissection
Change-Id: I08246d3fa97ceafefd3a1ab5c36de50a5728fd19
Reviewed-on: https://code.wireshark.org/review/17474
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2016-09-03 19:06:37 +00:00
AndersBroman 10bcfa58f8 [S1AP] Add dissection of the content of UERadioCapabilityForPaging.
Change-Id: I7f6686a9324fdd364653404ed4b3315d6ca36716
Reviewed-on: https://code.wireshark.org/review/16650
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-07-25 11:35:18 +00:00
Pascal Quantin efc6e509ef LTE RRC: add dissection of schedulingInfoSIB1-r13 field
Change-Id: I226ae82a2d75a9b658a0e9122b4ef1925b003279
Reviewed-on: https://code.wireshark.org/review/16417
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-07-14 07:12:02 +00:00
Pascal Quantin e46be62c3b LTE RRC: upgrade dissector to v13.2.0
Change-Id: If2e15f429e3e35b3deef8afc23e57c8ef3974a22
Reviewed-on: https://code.wireshark.org/review/16410
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2016-07-13 10:24:36 +00:00
Pascal Quantin dd5f3c96c3 LTE RRC: fix display of info column when receiving a BR SIB
Change-Id: Ic288cb10fad3bd34fe088479e7a79f77985808e0
Reviewed-on: https://code.wireshark.org/review/16098
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2016-06-23 15:29:09 +00:00
Pascal Quantin d77b8318e8 LTE-RRC: fix dissection of GPRS container
Payload embedded in LTE message does not include the first byte identifying the message type.
Let's prepend a fake one before calling the gsm_rlcmac dissector

Change-Id: Ibcf9b52902474a556b55e9b0a076d09d341f868c
Reviewed-on: https://code.wireshark.org/review/15642
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2016-05-31 19:44:56 +00:00
Pascal Quantin e42a43bc58 LTE RRC: upgrade dissector to v13.1.0
Change-Id: I830c97f6f228a61b942f3b4df46ccdd22a043b5e
Reviewed-on: https://code.wireshark.org/review/14796
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2016-04-03 17:38:47 +00:00
João Valverde 54a520d4a1 Move /asn1 to /epan/dissectors
Change-Id: I1208fe3c2ba428995526f561e8f792b8d871e9a9
Reviewed-on: https://code.wireshark.org/review/14388
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Reviewed-by: João Valverde <j@v6e.pt>
2016-03-13 21:30:24 +00:00