Commit Graph

14609 Commits

Author SHA1 Message Date
Gerald Combs 06a47f5880 Fix Win32 compilation, broken by yesterday's checkin.
svn path=/trunk/; revision=14664
2005-06-16 19:51:14 +00:00
Jörg Mayer 488483855f Get rid of several megabytes worth of warnings about
"discards qualifier from assignment".

svn path=/trunk/; revision=14663
2005-06-16 17:23:34 +00:00
Guy Harris ff8f331006 Remove unused variable.
Clean up indentation.

svn path=/trunk/; revision=14662
2005-06-16 10:06:22 +00:00
Guy Harris de1ed1e840 Get rid of unnecessary assignment and unnecessary "volatile" qualifier.
Mark unused parameter as such.

svn path=/trunk/; revision=14661
2005-06-16 10:05:23 +00:00
Guy Harris 7db2a1221f From Peter Kovar: fix an incorrect assignment that caused a compilation
error with GCC 4.

svn path=/trunk/; revision=14660
2005-06-16 09:58:01 +00:00
Guy Harris f28456dd84 Note that the WAN_CAPTYPE value of 4 can correspond to Cisco HDLC
traffic as well as Frame Relay traffic, and give some information about
the cruft found in the xxc field of the header for one CHDLC and one FR
capture.

svn path=/trunk/; revision=14659
2005-06-16 08:10:13 +00:00
Guy Harris ddbee0ffd0 Clean up white space.
Register "standard" and "lock_info_col" as obsolete preferences, so
they're silently ignored rather than triggering warnings.

Propagate changes to check for "dissect_ber_octet_string()" supplying a
null tvbuff pointer from the checkins to the generated dissector ("Do
not modify this file" means "Do not modify this file"!) to the tcap.cnf
file, so that they're not lost if the dissector is regenerated.  (Don't
propagate the checks for "tvb_new_subset()" returning null - it never
returns null.)

Pass -1 to "tvb_new_subset()" when appropriate.

When looping over packet data, check against the reported length, not
the captured length, so we indicate a short frame if we get stopped by
the snapshot length.

Get rid of unused variables.

svn path=/trunk/; revision=14658
2005-06-16 07:46:03 +00:00
Guy Harris 7c3ce4f5fa Register "version" as an obsolete preference, so it's silently ignored,
rather than provoking a warning.

svn path=/trunk/; revision=14657
2005-06-16 06:50:20 +00:00
Guy Harris ff38fe8476 Don't hand a null pointer to a "%s" format.
svn path=/trunk/; revision=14656
2005-06-16 06:41:28 +00:00
Guy Harris 72acd3728a Fix a typo, and squelch a compiler warning.
svn path=/trunk/; revision=14655
2005-06-16 06:34:27 +00:00
Guy Harris 7259a05303 Include <ctype.h> to define/declare "isspace()".
svn path=/trunk/; revision=14654
2005-06-16 06:33:49 +00:00
Guy Harris ad99cb236c "dissect_isup_thin()" is a new-style dissector; register it as such.
svn path=/trunk/; revision=14653
2005-06-16 06:32:20 +00:00
Guy Harris ef37a1f7d2 Squelch some unitialized variable warnings.
svn path=/trunk/; revision=14652
2005-06-16 06:31:25 +00:00
Guy Harris 0583a7ef79 "proto_tree_add_text()" doesn't add a named field, so it takes no "hf_"
argument.

Report a non-integral type used with "dissect_per_integer()" with an
explicit "REPORT_DISSECTOR_BUG()" call, as that's a dissector bug.

svn path=/trunk/; revision=14651
2005-06-16 06:30:33 +00:00
Guy Harris 003a0a5bac Include <ctype.h> to get "isdigit()" defined/declared.
"dissect_msrp()" is a "new-style" dissector; register it as such.

Squelch an uninitialized variable warning.

svn path=/trunk/; revision=14650
2005-06-16 06:28:50 +00:00
Guy Harris 85f9363860 Squelch some compiler warnings.
svn path=/trunk/; revision=14649
2005-06-16 06:27:18 +00:00
Guy Harris 3b3670d2d3 Static variables considered harmful. Make the ISAKMP version a
parameter to many functions inside the ISAKMP dissector, as well as to
the "isakmp_dissect_payloads()" routine it exports.  Get rid of
"isakmp_set_version()", as the version can be passed to
"isakmp_dissect_payloads()" from the KINK dissector.

Put the declaration of "isakmp_dissect_payloads()" into a
"packet-isakmp.h" header, and have "packet-isakmp.c" and "packet-kink.h"
include it rather than declariing "isakmp_dissect_payloads()" itself -
or not doing so at all.

svn path=/trunk/; revision=14648
2005-06-16 06:19:03 +00:00
Guy Harris 562efe2ce9 Regenerate - this squelches some compiler warnings.
svn path=/trunk/; revision=14647
2005-06-16 06:06:18 +00:00
Luis Ontanon 6aead4f02c third and last(?) iteration on the import routines for tektronix 32bit rf5 files.
Now the import is correct even for large files.
I found out when and where the "junk" was inserted.


svn path=/trunk/; revision=14646
2005-06-16 02:27:30 +00:00
Ulf Lamping 77a53ee225 update toolbar items and icons
svn path=/trunk/; revision=14645
2005-06-15 23:55:46 +00:00
Ulf Lamping 6d1405fd29 don't call "Capture/Start" Capture but Start in the toolbar
svn path=/trunk/; revision=14644
2005-06-15 23:05:37 +00:00
Gerald Combs 578f7a4e84 Handle FT_UINTs in dissect_per_integer(). Fixes bug 234.
svn path=/trunk/; revision=14643
2005-06-15 22:56:23 +00:00
Ulf Lamping 69141660fc update various menu items (screenshots must be updated as well)
svn path=/trunk/; revision=14642
2005-06-15 22:47:20 +00:00
Ulf Lamping 7bcea8b425 minor editing
svn path=/trunk/; revision=14641
2005-06-15 22:45:51 +00:00
Gerald Combs 979d807cf5 Make sure dissect_browser_TYPE_12_data() returns the right value. Catch
integer overflows in that and other functions.  Fixes bug 236.

svn path=/trunk/; revision=14640
2005-06-15 22:08:43 +00:00
Gerald Combs c2b9534398 Catch an infinite loop in smpp_handle_dlist(). Fixes bug 246.
svn path=/trunk/; revision=14639
2005-06-15 21:42:30 +00:00
Gerald Combs a2af0184b9 Add missing hf entries. Fixes bug 240.
svn path=/trunk/; revision=14638
2005-06-15 21:33:48 +00:00
Gerald Combs a9f65e1cf3 In sam_dissect_SAM_SECURITY_DESCRIPTOR_data(), throw an exception if we
fetch a too-long length.  Fixes bug 236.


svn path=/trunk/; revision=14637
2005-06-15 20:55:11 +00:00
Gerald Combs 86fc5a99b2 Fix a couple of infinite loops found by Buildbot. Were the recent
changes to this dissector fuzz tested at all?

svn path=/trunk/; revision=14636
2005-06-15 18:35:13 +00:00
Gerald Combs 65fdf41f63 Fix an infinite loop found by randpkt testing. Change the line endings from
DOS to UNIX.

svn path=/trunk/; revision=14635
2005-06-15 17:56:47 +00:00
Gerald Combs dce31be366 When we add an FT_STRINGZ item, throw an exception if the length is
less than -1.  If the length is 0, set the item string to "[Empty]".
This fixes bug 219.


svn path=/trunk/; revision=14634
2005-06-15 15:10:02 +00:00
Anders Broman f576d10955 Add Samuel Thibault
svn path=/trunk/; revision=14633
2005-06-14 22:01:55 +00:00
Anders Broman f5ba6d59ca From Samuel Thibault,
Some updates to the yahoo msg dissector.

svn path=/trunk/; revision=14632
2005-06-14 21:58:54 +00:00
Anders Broman bdde78acb2 Correct a typo
svn path=/trunk/; revision=14631
2005-06-14 21:57:17 +00:00
Anders Broman 5e3a716014 From Javier Acuna
patch to include Cic info in Voip Calls

svn path=/trunk/; revision=14630
2005-06-14 21:48:42 +00:00
Anders Broman e430a0b6f0 Add vendor AVP:s for T-Mobile and T-Systems Nova International GmbH.
svn path=/trunk/; revision=14629
2005-06-14 21:46:51 +00:00
Anders Broman 3e85231160 Add Vendor ID of T-Mobile and T-Systems Nova International GmbH.
svn path=/trunk/; revision=14628
2005-06-14 21:45:29 +00:00
Gerald Combs b94621701c From Steve Grubb:
Fix bounds checking in lemon.c.  Fix up an if/else block in
packet-dcerpc-samr.c.  Fix hex printing in packet-gtp.c.


Fix other problems discovered by Steve:

Fix a bounds check in packet-isis-lsp.c.  Also, fix netmask printing
on non-little-endian machines.  Add a comment about adding a netmask
routine to to_str.c.  Add bounds checks to packet-ncp2222.inc.


All of these apply to bug 217.

svn path=/trunk/; revision=14627
2005-06-14 18:18:05 +00:00
Jörg Mayer 8063b6d0df Always skip the whole header: The current code would only decode
sizeof strcut wlan_header_v1 bytes, but if our struct was missing
some newer elements, things would go wrong.

svn path=/trunk/; revision=14626
2005-06-14 14:33:55 +00:00
Jörg Mayer 2073fb5b5b No // comments
svn path=/trunk/; revision=14625
2005-06-14 13:35:24 +00:00
Gerald Combs 5489ce999c Change read_prefs() to use GStrings instead of (re)allocating memory
ourselves.  This fixes a potential off-by-one error found by Steve Grubb.

Add two new -G options: defaultprefs and currentprefs.  The first dumps
the default preferences to stdout and the second dumps the user's prefs
to stdout.


svn path=/trunk/; revision=14624
2005-06-13 22:40:11 +00:00
Ulf Lamping 5a899bd97c the note about not sending sensitive information to the lists should really be a warning, not only a note
svn path=/trunk/; revision=14623
2005-06-13 20:04:09 +00:00
Ulf Lamping e856529240 minor editing
svn path=/trunk/; revision=14622
2005-06-13 20:01:05 +00:00
Luis Ontanon 851d6b9a5e use a helper dissector to show k12 files.
svn path=/trunk/; revision=14621
2005-06-13 19:45:21 +00:00
Gerald Combs dacd1736fa Read .svn/entries directly instead of calling "svn info", as suggested by
Thomas Anders.  This should make things more locale-independent and remove
a dependency on "svn" being present.

svn path=/trunk/; revision=14620
2005-06-13 16:31:01 +00:00
Luis Ontanon 589035eac0 Add the missing parlay.la to the makefile
svn path=/trunk/; revision=14619
2005-06-13 08:47:24 +00:00
Ulf Lamping 6e78d98561 from Jaap Keuter: add some comments, how paths should look like for a debian distro
svn path=/trunk/; revision=14618
2005-06-13 06:55:06 +00:00
Anders Broman 22a74984da Add some yhoo_service_vals
svn path=/trunk/; revision=14617
2005-06-11 21:31:13 +00:00
Guy Harris 8fb6579d68 Update references to the WinPcap Web site.
svn path=/trunk/; revision=14616
2005-06-11 19:03:49 +00:00
Guy Harris e81bdb0cb3 Update references to the WinPcap Web site.
svn path=/trunk/; revision=14615
2005-06-11 19:02:31 +00:00