osmocom
/
wireshark
14
0
Fork 1
Code Issues Pull Requests Projects Releases Wiki Activity
52,458 Commits 26 Branches 0 Tags 795 MiB
Commit Graph

203 Commits

Author SHA1 Message Date
Alexis La Goutte 296591399f Remove all $Id$ from top of file 
(Using sed : sed -i '/^ \* \$Id\$/,+1 d')

Fix manually some typo (in export_object_dicom.c and crc16-plain.c)

Change-Id: I4c1ae68d1c4afeace8cb195b53c715cf9e1227a8
Reviewed-on: https://code.wireshark.org/review/497
Reviewed-by: Anders Broman <a.broman58@gmail.com>
 2014-03-04 14:27:33 +00:00
Alexis La Goutte fa02368c95 EDNS0 DO bit in Z field is decode incorrect 
Z field of edns0 in Additinal records is decoded to text description incorrectly (wrong bitmask)

Found by  Jittinan Suwanrueangsri
Closed-Bug: 9767

Change-Id: I8171b211cce79cb096a0f354764992f5cb18617c
Reviewed-on: https://code.wireshark.org/review/226
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Reviewed-by: Evan Huus <eapache@gmail.com>
 2014-02-16 14:08:43 +00:00
Bill Meier 64fd4c9c28 (Trivial) update a comment 
svn path=/trunk/; revision=54962
 2014-01-25 18:44:29 +00:00
Evan Huus 2ae8edccea Rename more to_str functions to have ep_ in the name if they return ephemeral 
buffers. Remove two unused functions.

svn path=/trunk/; revision=54250
 2013-12-19 16:28:39 +00:00
Jakub Zawadzki 4d92f6079b Remove not needed ';' 
svn path=/trunk/; revision=54088
 2013-12-14 11:12:20 +00:00
Jakub Zawadzki ae59b09443 Add missing includes in order to remove exceptions.h from proto.h (next commit). 
svn path=/trunk/; revision=53230
 2013-11-10 15:59:37 +00:00
Michael Mann 8081cf1d90 Add data parameter to tcp_dissect_pdus() as well as convert it to using "new" style dissectors. 
Now that "bytes consumed" can be determined, should tcp_dissect_pdus() take advantage of that?

Should tcp_dissect_pdus return length (bytes consumed)?  There are many dissectors that just call tcp_dissect_pdus() then return tvb_length(tvb).  Seems like that could all be rolled into one.

svn path=/trunk/; revision=53198
 2013-11-09 17:46:28 +00:00
Jakub Zawadzki 5aa4b848ee g_snprintf() don't return -1 from glib-1.2.3 [1] 
[1] https://developer.gnome.org/glib/2.28/glib-String-Utility-Functions.html#g-snprintf

svn path=/trunk/; revision=53186
 2013-11-09 11:23:02 +00:00
Michael Mann 02a8391535 Require dissector_try_string to pass a data parameter to its subdissectors. There weren't that many calls, so might as well modify the function than create a need for dissector_try_string_new. 
svn path=/trunk/; revision=53049
 2013-11-02 15:52:25 +00:00
Michael Mann 4578df790d Use Z_tree for the subtree 
svn path=/trunk/; revision=52670
 2013-10-18 14:41:01 +00:00
Michael Mann 42c52d8612 Add more filterable fields around EDNS(0) 
svn path=/trunk/; revision=52664
 2013-10-18 01:53:32 +00:00
Michael Mann e746a62459 Bugfix an apparent typo in edns0 "Higher bits in extended RCODE". Bug 9199 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9199). 
#BACKPORT(1.10)

svn path=/trunk/; revision=52662
 2013-10-17 20:54:42 +00:00
Pascal Quantin a0c53ffaa1 emem -> wmem conversion: 
- ep_tvb_get_bits() -> wmem_packet_tvb_get_bits()
- tvb_g_memdup()/ep_tvb_memdup() -> tvb_memdup()
- tvb_fake_unicode()/tvb_get_ephemeral_faked_unicode() -> tvb_get_faked_unicode()
- tvb_get_g_string()/tvb_get_ephemeral_string()/tvb_get_seasonal_string() -> tvb_get_string()
- tvb_get_g_unicode_string()/tvb_get_ephemeral_unicode_string() -> tvb_get_unicode_string()
- tvb_get_ephemeral_string_enc() -> tvb_get_string_enc()
- update docs accordingly

svn path=/trunk/; revision=52172
 2013-09-22 15:50:55 +00:00
Michael Mann b38ee917b1 Convert proto_tree_add_uint_format to proto_tree_add_uint_format_value if hf_ field name is the first part of the formatted string. This was done with a perl script on the dissectors directory (packet-*.c), followed by manual inspection of the output. The manual inspection yielded a few cases that really should have been proto_tree_add_uint or proto_tree_add_item, so I updated them accordingly. 
The script didn't catch as many as I would have liked, but it's a start.

The most common (ab)use of proto_tree_add_uint_format was for appending strings to CRC/checksum values to note good or bad CRC/checksum.

svn path=/trunk/; revision=52045
 2013-09-15 01:48:30 +00:00
Michael Mann 9e3f9b449f expert_add_info_format_text -> expert_add_info_format 
svn path=/trunk/; revision=51852
 2013-09-09 00:44:09 +00:00
Alexis La Goutte 6934553230 Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang 
svn path=/trunk/; revision=51732
 2013-09-03 18:42:49 +00:00
Jörg Mayer ee8719e2e1 Fix typo: =+ ---> += 
svn path=/trunk/; revision=51721
 2013-09-03 13:49:48 +00:00
Alexis La Goutte 3c08741cae Enhance DNS Dissector Remove bad_rr goto ! 
Code is fuzzed (9 Pass with more of 400 DNS files)

svn path=/trunk/; revision=51717
 2013-09-03 06:36:43 +00:00
Alexis La Goutte 6f4225a6f4 Enhance NSEC3,NSEC3PARAM TLSA type visibility 
svn path=/trunk/; revision=51716
 2013-09-03 06:36:33 +00:00
Alexis La Goutte 29d07267df Add dissection of EUI Family (draft-jabley-dnsext-eui48-eui64-rrtypes) DNS Rcode (EUI48, EUI64) 
svn path=/trunk/; revision=51715
 2013-09-03 06:36:23 +00:00
Alexis La Goutte 3f3a394932 Add Dissection of ILNP (RFC6742) DNS Rcode (NID, L32, L64, LP) 
svn path=/trunk/; revision=51714
 2013-09-03 06:36:12 +00:00
Alexis La Goutte 3658cbf175 Update DNS Rcode to last IANA Parameters (2013-07-24) * Add ILNP (RFC6742) Rcode (NID, L32, L64, LP) * Add EUI Family (draft-jabley-dnsext-eui48-eui64-rrtypes) Rcode (EUI48, EUI64) * Add URI Rcode (256) * Add TA (DNSSEC Trust Authorities) Rcode (32768) 
svn path=/trunk/; revision=51713
 2013-09-03 06:36:01 +00:00
Alexis La Goutte cbb1820533 Enhance DNS reorder case of big switch dns_type 
svn path=/trunk/; revision=51712
 2013-09-03 06:35:51 +00:00
Alexis La Goutte 02f17d0564 Enhance DNS dissector Remove ugly dns_type_description function and use value_string(_ext) 
svn path=/trunk/; revision=51711
 2013-09-03 06:35:41 +00:00
Alexis La Goutte bfeb1475c0 Enhance DNS dissector visibility (Rename some hf and display field) 
svn path=/trunk/; revision=51710
 2013-09-03 06:35:30 +00:00
Alexis La Goutte 53e87bd2b0 Enhance DNS dissector visibility (Add comments) 
svn path=/trunk/; revision=51709
 2013-09-03 06:35:13 +00:00
Alexis La Goutte 800359d771 Enhance default DNS type... (and expert info) 
Convert proto_tree_add_text calls to proto_tree_add_item

svn path=/trunk/; revision=51708
 2013-09-03 06:35:01 +00:00
Alexis La Goutte 7f64348cc5 Enhance NULL type 
Convert proto_tree_add_text calls to proto_tree_add_item

svn path=/trunk/; revision=51707
 2013-09-03 06:34:52 +00:00
Alexis La Goutte de8247f4ae Enhance M.. familly type (MD, MF, MB, MG, MR, MINFO) 
Convert proto_tree_add_text calls to proto_tree_add_item

svn path=/trunk/; revision=51706
 2013-09-03 06:34:41 +00:00
Alexis La Goutte 4a51170e8d Enhance NSAP and NSAP PTR type 
Convert proto_tree_add_text calls to proto_tree_add_item

svn path=/trunk/; revision=51705
 2013-09-03 06:34:31 +00:00
Alexis La Goutte 340ff87d38 Enhance PX type 
Convert proto_tree_add_text calls to proto_tree_add_item

svn path=/trunk/; revision=51704
 2013-09-03 06:34:21 +00:00
Alexis La Goutte a6f7037765 Enhance X25 and ISDN type 
Convert proto_tree_add_text calls to proto_tree_add_item

svn path=/trunk/; revision=51703
 2013-09-03 06:34:10 +00:00
Alexis La Goutte b7e78c778a Enhance AFSDB and RT type 
Convert proto_tree_add_text calls to proto_tree_add_item

svn path=/trunk/; revision=51702
 2013-09-03 06:34:00 +00:00
Alexis La Goutte 8e237acf74 Enhance RP type 
Convert proto_tree_add_text calls to proto_tree_add_item

svn path=/trunk/; revision=51701
 2013-09-03 06:33:48 +00:00
Alexis La Goutte 7668baf5da Enhance GPOS type 
Convert proto_tree_add_text calls to proto_tree_add_item

svn path=/trunk/; revision=51700
 2013-09-03 06:33:38 +00:00
Alexis La Goutte 7b012cf03e Enhance APL (and DHCID) type 
Convert proto_tree_add_text calls to proto_tree_add_item

svn path=/trunk/; revision=51699
 2013-09-03 06:33:28 +00:00
Alexis La Goutte d37a4ea6a1 Enhance HIP type 
Convert proto_tree_add_text calls to proto_tree_add_item

svn path=/trunk/; revision=51698
 2013-09-03 06:33:18 +00:00
Alexis La Goutte 7de1545fda Enhance SSHFP type 
Convert proto_tree_add_text calls to proto_tree_add_item

svn path=/trunk/; revision=51697
 2013-09-03 06:33:07 +00:00
Alexis La Goutte f38fb1a906 Enhance NAPTR type 
Convert proto_tree_add_text calls to proto_tree_add_item

svn path=/trunk/; revision=51696
 2013-09-03 06:32:57 +00:00
Alexis La Goutte 2b63d4fa5e Enhance TSIG and TKIP DNS type 
Update rrcode list
Convert proto_tree_add_text calls to proto_tree_add_item
Use expert info when no found dissector for TSIG algo

Enhance TKEY (BETA)

svn path=/trunk/; revision=51695
 2013-09-03 06:32:47 +00:00
Alexis La Goutte b36e366aab Enhance SRV DNS type 
svn path=/trunk/; revision=51694
 2013-09-03 06:32:36 +00:00
Alexis La Goutte e748993bac Enhance WINS and WINS-R DNS type 
Convert proto_tree_add_text calls to proto_tree_add_item

svn path=/trunk/; revision=51693
 2013-09-03 06:32:26 +00:00
Evan Huus d9eb37b849 Add a preference for whether to use names found in DNS packets for address 
resolution.

svn path=/trunk/; revision=51584
 2013-08-30 01:29:46 +00:00
Anders Broman f6b9c18eed Use dissector_delete_uint_range/dissector_add_uint_range 
svn path=/trunk/; revision=51567
 2013-08-28 19:10:33 +00:00
Alexis La Goutte a6409fd3e9 From Dario Lombardo via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9061 Added expert info to DNS dissector for negative TTL values 
According to RFC, TTL valid values are the positive values of a 32 bit signed field. This means that, despite the negative values can be put in a packet, they should be ignored. Wireshark prints them correctly, but a warning expert info could be useful.

svn path=/trunk/; revision=51452
 2013-08-21 17:04:51 +00:00
Alexis La Goutte 3808dfc909 Add RFC6975 (Signaling Cryptographic Algorithm Understanding in DNS Security Extensions (DNSSEC)) support ( DAU, DHU and N3U OPT(ion)) 
svn path=/trunk/; revision=50840
 2013-07-23 14:54:18 +00:00
Alexis La Goutte 4806972c5e Fix warning found by fix-encoding-args 
svn path=/trunk/; revision=50839
 2013-07-23 14:54:09 +00:00
Alexis La Goutte 4aa7dab163 Enhance DNS Dissector Make DS ( Delegation Signature 43 ) filterable (Update RFC reference...) 
svn path=/trunk/; revision=50838
 2013-07-23 14:53:59 +00:00
Michael Mann c38a750821 Client subnet optcode value now IANA assigned. Warn if experimental placeholder value is still used. Bug 7552 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7552) 
svn path=/trunk/; revision=50503
 2013-07-11 11:59:30 +00:00
Alexis La Goutte 5cdc82ab69 From Oliver Gasser via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8863 Add CAA support to DNS dissector 
Add informationa about Certificate Authority Authorization (CAA) data to the DNS dissector. See the RFC [1] for more information. Suggestions and improvements are welcome.

[1] http://tools.ietf.org/html/rfc6844

svn path=/trunk/; revision=50370
 2013-07-03 16:46:29 +00:00