Commit Graph

832 Commits

Author SHA1 Message Date
Pascal Quantin 6deafe8afa F1AP: upgrade dissector to v16.3.1 2020-12-16 21:58:11 +01:00
Đorđije Manojlović 7e8392c784 R-GOOSE dissector: Fix subtree item lengths 2020-12-16 15:28:45 +00:00
Anders Broman adb1b59495 Fix duplicated filter names. 2020-12-16 15:13:31 +01:00
Anders Broman 4735eddfef Fix duplicated filter names 2020-12-16 12:58:38 +00:00
Pascal Quantin 7b4abddef2 LPPa: upgrade dissector to v16.1.0 2020-12-16 12:02:37 +01:00
Pascal Quantin 4427c11571 NRPPa: upgrade dissector to v16.1.0 2020-12-16 09:54:06 +00:00
Anders Broman 5dff85e84b Fix duplicated filter names. 2020-12-15 14:43:43 +00:00
Anders Broman 0fdbe0839d asn2wrs: Rename duplicated filter names 2020-12-15 10:54:58 +00:00
j.novak@netsystem.cz 7f376c7ced SNMP: Fix checking of SNMP v3 auth if MD5 method is used
When the user enters row to SNMP Users table in wireshark and Authentication model is set to MD5, row is ignored in processing. The reason is that constant for MD5 is 0, but the code checks if the value is defined by simple 'usm_p.user_assoc' condition. Therefore 0 never succeeds.
As item can have only listed values, I think the check can be removed.
Function verified on sample.

I propose to cherry pick the change to all stable branches.
2020-12-13 15:28:36 +00:00
Guy Harris bb494c11de Fix various spelling errors.
Found by lintian and by looking for the misspelled words that lintian
found.

(Does not fix spelling errors in .asn1 files.)
2020-12-09 05:52:50 +00:00
Anders Broman 16ea22eaa4 F-Container: Try to improve error handling. 2020-12-09 00:44:44 +00:00
Martin Mathieson 9f056c395a NGAP: don't include packet-ngap.h twice 2020-12-04 22:31:10 +00:00
Pascal Quantin 59efc252dc LPP: upgrade dissector to v16.2.0 2020-11-29 22:48:08 +01:00
Đorđije Manojlović 8c4d420fb3 Extend IEC 61850 GOOSE dissector to support IEC 61850 R-GOOSE protocol
R-GOOSE (Routable GOOSE) protocol is GOOSE protocol embedded into
RFC 1240: OSI Connectionless Transport over UDP.
2020-11-24 13:43:53 +00:00
Pascal Quantin 74c0b2134b S1AP: fix decoding of inter eNB transparent container from NGAP 2020-11-24 14:05:21 +01:00
Martin Mathieson df651aca91 Spelling improvements
Improve script by ignoring common contractions, dealing with
e.g. \n within strings, and finding multiple concatenated words even
when no camelCase is used.

Also includes some actual spelling fixes.
2020-11-22 11:30:24 +00:00
Jonas Falkevik 156f9e81fc lcsap: fix decode of plmnIdentity
Corretly decode MNC if it consists of 3 digits
Change to what is called big endinan MNC

   8   7   6   5   4   3   2   1
 +---+---+---+---+---+---+---+---+
 |  MCC digit 2  |  MCC digit 1  |  octet x
 +---------------+---------------+
 |    Filler     |  MCC digit 3  |  octet x+1
 +---------------+---------------+
 |  MNC digit 2  |  MNC digit 1  |  octet x+2
 +---------------+---------------+

 MNC of length 3:

   8   7   6   5   4   3   2   1
 +---+---+---+---+---+---+---+---+
 |  MCC digit 2  |  MCC digit 1  |  octet x
 +---------------+---------------+
 |  MNC digit 1  |  MCC digit 3  |  octet x+1
 +---------------+---------------+
 |  MNC digit 3  |  MNC digit 2  |  octet x+2
 +---------------+---------------+

From 3GPP TS 29.171
7.4.27 PLMN Identity

- digits 0 to 9, encoded 0000 to 1001,
- 1111 used as filler digit, two digits per octet,

- bits 4 to 1 of octet n encoding digit 2n-1
- bits 8 to 5 of octet n encoding digit 2n

The Selected PLMN identity consists of 3 digits from MCC followed by either
- a filler digit plus 2 digits from MNC (in case of 2 digit MNC) or
- 3 digits from MNC (in case of a 3 digit MNC).
2020-10-29 00:53:13 +01:00
Stig Bjørlykke edd71daa90 lte-rrc: Pluralize PagingRecord(s) 2020-10-27 15:51:11 +01:00
Ismael Pérez b694ad77e4 sv dissector: dissect optional field "gmIdentity"
The information regarding the VendorID in gmIdentity is also decoded.
2020-10-25 14:07:32 +00:00
Joakim Karlsson d1f0f08052 gprscdr: Update to 3GPP TS 32.298 V16.6.1
Change-Id: Id6e4504405b2d909d0ff9f044b4c1b1f99d3d407
2020-10-22 03:40:38 +00:00
Pascal Quantin 83af7b89fd 3GPP: add 5G-TMSI to 3gpp.tmsi common filter 2020-10-14 11:08:19 +02:00
Anders Broman e209253636 Create a cross protocol filter 3gpp.tmsi
It can be useful to track a "call" trough multiple protocols to make
that easier create a cross protocol filter, more may come.
2020-10-14 07:56:26 +00:00
Pascal Quantin f1eb3953f0 RRC: upgrade dissector to v16.1.0 2020-10-10 19:06:41 +02:00
Anders Broman 6dada3acf2 SNMP: Use BASE_SHOW_ASCII_PRINTABLE for octet strings
Closes #16900
2020-10-10 13:28:06 +00:00
Pascal Quantin 21c3bdff06 NR RRC: upgrade dissector to v16.2.0 2020-10-08 10:24:28 +02:00
Pascal Quantin 7924aaae00 LTE RRC: update message identifier value_string array 2020-10-07 21:30:08 +00:00
Pascal Quantin 1fd8174965 NGAP: dissect some PWS related fields 2020-10-07 23:00:26 +02:00
Martin Mathieson 3160f11af2 NGAP: Change "encyption" -> "encryption". 2020-10-07 20:20:38 +00:00
Pascal Quantin 1fd6a542fe LTE RRC: upgrade dissector to v16.2.0 2020-10-07 17:17:02 +00:00
Pascal Quantin fd85f6e9fc XnAP: fix the dissection of some NR and E-UTRA cell identity fields 2020-10-05 14:39:50 +02:00
Pascal Quantin aeb68eb68c X2AP: upgrade dissector to v16.3.0 2020-10-05 13:25:02 +02:00
Pascal Quantin 1dbc6f1da7 XnAP: upgrade dissector to v16.3.0 2020-10-05 10:50:45 +00:00
Pascal Quantin 4b4cd94093 E1AP: upgrade dissector to v16.3.0 2020-10-05 10:16:13 +00:00
Pascal Quantin 069ec8df85 NGAP: upgrade dissector to v16.3.0 2020-10-05 11:47:19 +02:00
Pascal Quantin 44739c33ce S1AP: upgrade dissector to v16.3.0 2020-10-05 09:54:35 +02:00
Guy Harris a883081b70 Update URLs pointing to the bug database.
Switch from bugs.wireshark.org to the GitLab issues list.
2020-10-03 07:54:12 -07:00
Guy Harris e013c5ec7f Clean up URLs.
Add ui/urls.h to define some URLs on various of our websites.  Use the
GitLab URL for the wiki.  Add a macro to generate wiki URLs.

Update wiki URLs in comments etc.

Use the #defined URL for the docs page in
WelcomePage::on_helpLabel_clicked; that removes the last user of
topic_online_url(), so get rid of it and swallow it up into
topic_action_url().
2020-10-02 20:13:42 -07:00
Martin Mathieson fc64ba242a More dissector spelling fixes. 2020-09-24 16:40:51 +00:00
Tom Yan 6387fd7729 X2AP : fix id-Target-SgNB-ID registered to wrong type 2020-09-23 05:55:21 +00:00
Tom Yan b746222896 X2AP : fix a typo 2020-09-22 10:26:00 +00:00
Martin Mathieson 82827278f7 More dissector string spelling fixes.
Finally, it is becoming difficult to find more.
2020-09-13 09:03:08 +01:00
Pascal Quantin d541071dae E1AP: upgrade dissector to v16.2.0 2020-09-05 18:00:48 +02:00
Pascal Quantin 291c836392 F1AP: upgrade dissector to v16.2.0 2020-09-05 13:32:33 +02:00
Pascal Quantin 87521e8bf5 NGAP: fix a comment in the header file and add it to CMakeLists.txt 2020-09-05 11:52:37 +02:00
Martin Mathieson 51cbb47e1f Fix some detected spelling errors in ASN1 dissectors.
Done by scanning the asan1 template files. If there are spelling
mistakes in the specifications, we should ignore.  Note that for z3950, I had
already found and accidentally fixed the same errors in the generated
file (before I taught my script to ignore gnerated dissector files).
2020-09-05 00:51:48 +00:00
Pascal Quantin fa9f718692 S1AP: fix a field mask 2020-09-04 21:47:32 +00:00
Pascal Quantin 6f68f86f28 X2AP: fix a field mask 2020-09-04 21:29:14 +00:00
Pascal Quantin 5024bbed65 XnAP: dissect a few more fields 2020-09-04 23:07:43 +02:00
Pascal Quantin 09c9b87c8c XnAP: upgrade dissector to v16.2.0 2020-09-03 12:22:26 +02:00
Pascal Quantin d24674c4ae NGAP: fix ngap.MDT_Location_Information.reserved definition 2020-08-31 20:59:37 +00:00