osmocom
/
wireshark
14
0
Fork 1
Code Issues Pull Requests Projects Releases Wiki Activity
54,415 Commits 26 Branches 0 Tags 795 MiB
Commit Graph

82 Commits

Author SHA1 Message Date
Evan Huus 9112a099d7 Fix an infinite loop when the line has no length 
Bug:10333
Change-Id: Ia2dae94095dddf57e4c75792b5477b0eb37c29c9
Reviewed-on: https://code.wireshark.org/review/3343
Reviewed-by: Anders Broman <a.broman58@gmail.com>
 2014-08-03 08:40:40 +00:00
AndersBroman 96f0585268 Quick fix to handle IEPS token. 
Fix deorecated APIs

Change-Id: Iad1f970b553f1655109b36364a1d37676582f608
Reviewed-on: https://code.wireshark.org/review/2984
Reviewed-by: Anders Broman <a.broman58@gmail.com>
 2014-07-10 14:48:08 +00:00
Michael Mann c7a6e6fa13 convert to proto_tree_add_subtree[_format] 
Change-Id: I621f2e2cad9403449cb78f45302388f0c874d3bc
Reviewed-on: https://code.wireshark.org/review/2852
Reviewed-by: Michael Mann <mmann78@netscape.net>
 2014-07-04 16:59:14 +00:00
Michael Mann 14824e6adf Revert "Fixup: tvb_* -> tvb_captured" 
https://www.wireshark.org/lists/wireshark-dev/201406/msg00131.html

This reverts commit 246fe2ca4c.

Change-Id: Ib24bae0198c13a84bd7f731bf4af921212109a8f
Reviewed-on: https://code.wireshark.org/review/2430
Reviewed-by: Michael Mann <mmann78@netscape.net>
 2014-06-19 18:25:59 +00:00
Dario Lombardo 246fe2ca4c Fixup: tvb_* -> tvb_captured 
Change-Id: I9209c1271967405c34c1b6fa43e1726a4d3a5a3f
Reviewed-on: https://code.wireshark.org/review/2377
Reviewed-by: Anders Broman <a.broman58@gmail.com>
 2014-06-18 14:14:58 +00:00
Michael Mann 73217d9f3f tvb_new_subset -> tvb_new_subset_length when length parameters are equal. 
tvb_new_subset -> tvb_new_subset_remaining it appears that's what the intention is.

Change-Id: I2334bbf3f10475b3c22391392fc8b6864454de2d
Reviewed-on: https://code.wireshark.org/review/1999
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
 2014-06-07 15:41:07 +00:00
Jakub Zawadzki d7bd2ecf9f Add new proto_tree_add_format_text() function 
There are lot of text dissectors which want just to add escaped (not filtrable) text,
add new function proto_tree_add_format_text() which just do this in optimized way.

Change-Id: Ia0e189b620cc0a5b74cfdaef1ad4571d766bb2ab
Reviewed-on: https://code.wireshark.org/review/1678
Reviewed-by: Michael Mann <mmann78@netscape.net>
Reviewed-by: Evan Huus <eapache@gmail.com>
 2014-05-19 02:27:12 +00:00
AndersBroman 5e4769dc87 Use ENC_UTF_8 for strings, it's faster and *should* be OK. 
Change-Id: I7615f407a017454d3fb11ec0b45b584bfa5d79b5
Reviewed-on: https://code.wireshark.org/review/940
Reviewed-by: Anders Broman <a.broman58@gmail.com>
 2014-04-03 11:57:40 +00:00
Alexis La Goutte 09cd306d1c Continue to remove $Id$ from top of file 
(Using sed : sed -i '/^\* \$Id\$/,+1 d') (no space before star)

Change-Id: I318968db2b8512ba1303b5fc5c624c66441658f0
Reviewed-on: https://code.wireshark.org/review/879
Reviewed-by: Anders Broman <a.broman58@gmail.com>
 2014-03-31 18:30:52 +00:00
Jakub Zawadzki 715e2d6699 Fix [-Wmissing-prototypes] 
svn path=/trunk/; revision=54095
 2013-12-14 16:09:57 +00:00
Jakub Zawadzki ae59b09443 Add missing includes in order to remove exceptions.h from proto.h (next commit). 
svn path=/trunk/; revision=53230
 2013-11-10 15:59:37 +00:00
Michael Mann 9e3f9b449f expert_add_info_format_text -> expert_add_info_format 
svn path=/trunk/; revision=51852
 2013-09-09 00:44:09 +00:00
Michael Mann 5405b34469 Batch of filterable expert info. 
svn path=/trunk/; revision=51688
 2013-09-02 23:32:31 +00:00
Alexis La Goutte 890d656bca Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang 
svn path=/trunk/; revision=51666
 2013-09-02 23:12:52 +00:00
Pascal Quantin b46f9bebe2 Change some dissectors to use pinfo memory pool instead of malloc if it can trigger an exception between between buffer allocation and tvb_set_free_cb call 
svn path=/trunk/; revision=51427
 2013-08-19 14:55:41 +00:00
Michael Mann 3eafc74e2b Convert proto_item_set_expert_flags to "filterable" items in alcap dissector. Unfortunately it had a few tentacles, so they needed to be brought along for the ride. 
svn path=/trunk/; revision=51136
 2013-08-04 13:46:25 +00:00
Michael Mann de68fd6eea Removed check_col() and the occasional tree. 
svn path=/trunk/; revision=49938
 2013-06-14 17:49:53 +00:00
Martin Kaiser 54a34fdb30 Coverity 1011110: Unused pointer value 
remove the whole unused subtree


svn path=/trunk/; revision=49213
 2013-05-09 11:40:14 +00:00
Michael Mann a18e128b44 convert some proto_tree_add_texts into expert_add_info_format. Didn't quite make checkAPIs.pl happy, but given the nature of the dissector (mostly raw text), I'm not sure it can hit the 50% ratio. 
svn path=/trunk/; revision=49022
 2013-04-24 23:17:44 +00:00
Anders Broman 2cc00294c7 Use explicit casts. 
svn path=/trunk/; revision=48260
 2013-03-12 06:41:00 +00:00
Bill Meier 959ae3d687 Use '#if 0 ... #endif' rather than /** ... **/ to comment out 
unused hf[] entries (which I should have done in the first place).


svn path=/trunk/; revision=47391
 2013-01-31 18:35:06 +00:00
Bill Meier c929e42eb4 Fix various instances of unused hf[] entries found 
by checkhf.

svn path=/trunk/; revision=47312
 2013-01-26 22:43:34 +00:00
Guy Harris 8ed7a73e22 Fix a bunch of warnings. 
Cast away some implicit 64-bit-to-32-bit conversion errors due to use of
sizeof.

Cast away some implicit 64-bit-to-32-bit conversion errors due to use of
strtol() and strtoul().

Change some data types to avoid those implicit conversion warnings.

When assigning a constant to a float, make sure the constant isn't a
double, by appending "f" to the constant.

Constify a bunch of variables, parameters, and return values to
eliminate warnings due to strings being given const qualifiers.  Cast
away those warnings in some cases where an API we don't control forces
us to do so.

Enable a bunch of additional warnings by default.  Note why at least
some of the other warnings aren't enabled.

randpkt.c and text2pcap.c are used to build programs, so they don't need
to be in EXTRA_DIST.

If the user specifies --enable-warnings-as-errors, add -Werror *even if
the user specified --enable-extra-gcc-flags; assume they know what
they're doing and are willing to have the compile fail due to the extra
GCC warnings being treated as errors.

svn path=/trunk/; revision=46748
 2012-12-26 05:57:06 +00:00
Jeff Morriss 2552c750e5 We always HAVE_CONFIG_H so don't bother checking whether we have it or not. 
svn path=/trunk/; revision=45017
 2012-09-20 02:03:38 +00:00
Michael Mann 1741731384 remove unnecessary underscores from display filters 
svn path=/trunk/; revision=44181
 2012-08-01 02:59:17 +00:00
Jakub Zawadzki bf81b42e1e Update Free Software Foundation address. 
(COPYING will be updated in next commit)

svn path=/trunk/; revision=43536
 2012-06-28 22:56:06 +00:00
Bill Meier 5e3066f006 Use dscp_vals_ext everyplace (instead of dscp_vals); 
(dscp_vals is now a static array in packet-ip.c)

svn path=/trunk/; revision=43211
 2012-06-11 19:07:53 +00:00
Michael Tüxen 24fa3fb59a No leading whitespaces in the INFO column. 
svn path=/trunk/; revision=42679
 2012-05-17 15:31:15 +00:00
Michael Tüxen 6526ea3751 Add support for specifying an SCTP port number. 
svn path=/trunk/; revision=42677
 2012-05-17 14:34:09 +00:00
Anders Broman 6819789c54 From Bodo Petermann: 
Megaco parser problem with LF in header.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7198

svn path=/trunk/; revision=42258
 2012-04-26 13:22:40 +00:00
Jakub Zawadzki 68ec58d385 Fix some: 'cast discards qualifiers from pointer target type' warnings 
- Add const qualifier
- Remove some strange casts

svn path=/trunk/; revision=42131
 2012-04-18 12:35:36 +00:00
Alexis La Goutte 1dee4d224e Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang 
svn path=/trunk/; revision=41469
 2012-03-10 17:49:33 +00:00
Chris Maynard 2a808af4da Fix some typos. 
svn path=/trunk/; revision=40454
 2012-01-13 16:05:23 +00:00
Anders Broman 4730454aad Accpet lover case Topology descriptor (tp) as we accept other tokens in lowercase. 
svn path=/trunk/; revision=40104
 2011-12-06 19:10:13 +00:00
Anders Broman e1b386b5fc Fix length of Error parameter. 
svn path=/trunk/; revision=40103
 2011-12-06 19:08:01 +00:00
Bill Meier 794757ae8f For proto_tree_add_item(..., proto_xxx, ...)use ENC_NA as the encoding arg. 
Also: remove trailing whitespace for a number of files.

svn path=/trunk/; revision=39503
 2011-10-21 02:10:19 +00:00
Bill Meier 126aa85393 Convert proto_tree_add_item() 'encoding' arg for field types FT_STRING, FT_STRINGZ, FT_UINT_STRING as follows: 
1. If there's no character encoding (ENC_ASCII, ...) specified
    then use ENC_ASCII.
 2. For all but FT_UINT_STRING, always use ENC_NA
    (replacing any existing True/1/FALSE/0
    /ENC_BIG_ENDIAN/ENC_LITTLE_ENDIAN).



svn path=/trunk/; revision=39426
 2011-10-15 18:46:26 +00:00
Bill Meier 3af6394891 Fix gcc 4.6 "set but not used [-Wunused-but-set-variable]" warnings 
svn path=/trunk/; revision=38001
 2011-07-13 19:48:58 +00:00
Jeff Morriss f3f9f2697f Make TVBs opaque for most users. 
Convert TVB_RAW_OFFSET() and TVB_GET_DS_TVB() into functions.

svn path=/trunk/; revision=37422
 2011-05-27 03:06:50 +00:00
Bill Meier a2b58f051d Add #include <stdlib.h> to files which reference fcns declared in stdlib.h; 
(In many cases I previously incorrectly removed the #include <stdlib.h>).

svn path=/trunk/; revision=37334
 2011-05-20 19:00:09 +00:00
Jeff Morriss 24c9bb76b0 Don't create a subtree that is not used. 
svn path=/trunk/; revision=36805
 2011-04-22 14:17:34 +00:00
Bill Meier 5f57b0d828 Don't assign to a variable if the value won't be used: Coverity 964 & 965; 
Also:
- Move proto_register...() & proto_reg_handoff...() to the end of the file;
- Remove some unneeded #includes;
- Do some indentation and whitespace cleanup (e.g., "4-space tabs").

svn path=/trunk/; revision=36556
 2011-04-11 14:41:14 +00:00
Anders Broman 771445d49a from Václav Horčák: 
Bug 5663 - [PATCH] Fix for MEGACO dissector context tracking.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5663

svn path=/trunk/; revision=35880
 2011-02-08 12:33:34 +00:00
Anders Broman 6d269f2713 From Václav Horčák: 
Fix keeps  parser function in scope of current transactions, allowing multiple
transaction in one packet. 

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3420

svn path=/trunk/; revision=35814
 2011-02-04 11:45:37 +00:00
Guy Harris a8bc4a0d13 Rename the routines that handle dissector tables with unsigned integer 
keys to have _uint in their names, to match the routines that handle
dissector tables with string keys.  (Using _port can confuse people into
thinking they're intended solely for use with TCP/UDP/etc. ports when,
in fact, they work better for things such as Ethernet types, where the
binding of particular values to particular protocols are a lot
stronger.)

svn path=/trunk/; revision=35224
 2010-12-20 05:35:29 +00:00
Bill Meier 09764dd969 Remove unneeded #include <stdio.h> 
svn path=/trunk/; revision=32367
 2010-04-03 21:55:23 +00:00
Anders Broman bc9a809b65 From Didier Gautheron: 
ep memory can't be used for tvbs defined as data_source.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4054

svn path=/trunk/; revision=30376
 2009-10-06 19:15:58 +00:00
Kovarththanan Rajaratnam 00810ff199 * Prefer col_append_str instead of col_append_fstr for constant strings 
* Remove check_col guards

svn path=/trunk/; revision=30127
 2009-09-24 20:21:23 +00:00
Kovarththanan Rajaratnam 4b6090e576 Don't guard col_set_str (COL_INFO) with col_check 
svn path=/trunk/; revision=29342
 2009-08-09 07:01:26 +00:00
Kovarththanan Rajaratnam e971354a54 Don't guard col_set_str (COL_PROTOCOL) with col_check 
svn path=/trunk/; revision=29340
 2009-08-09 06:26:46 +00:00