Commit Graph

43931 Commits

Author SHA1 Message Date
Bill Meier 4ab1b84a89 Fix 2 [-Wshadow] warnings.
svn path=/trunk/; revision=46369
2012-12-04 16:31:10 +00:00
Anders Broman c9622178cf Add more dissection for Japan ISUP.
svn path=/trunk/; revision=46368
2012-12-04 16:22:00 +00:00
Bill Meier ddb2a90dd0 Fix [-Wshadow] warning.
svn path=/trunk/; revision=46367
2012-12-04 14:38:38 +00:00
Bill Meier 357ea3fc88 Define variants of CLEANUP_PUSH & etc to allow nested use w/o "shadowing" variables.
svn path=/trunk/; revision=46366
2012-12-04 14:37:21 +00:00
Bill Meier 1c25482ebc Ethereal -> Wireshark; Update FSF address.
svn path=/trunk/; revision=46365
2012-12-04 14:23:53 +00:00
Anders Broman 362dd1dcb5 Add more Japan ISUP parameters to value sting, dissection remains to be done.
svn path=/trunk/; revision=46364
2012-12-04 09:15:21 +00:00
Gerald Combs fceea48622 Use more restrictive selectors, otherwise we end up styling things we
shouldn't (such as scroll bars).

svn path=/trunk/; revision=46363
2012-12-04 00:24:25 +00:00
Evan Huus f72aa597c7 Make the new -T option not overwrite the other options, so it can
be used in conjuction with -2 et al.

svn path=/trunk/; revision=46362
2012-12-04 00:05:58 +00:00
Evan Huus ced8abb125 Reduce the scope of one variable definition slightly.
svn path=/trunk/; revision=46361
2012-12-03 23:15:59 +00:00
Bill Meier 5f9077232e Declare a value_string as static.
svn path=/trunk/; revision=46360
2012-12-03 23:06:30 +00:00
Bill Meier 7316a50499 Declare a value_string as static.
svn path=/trunk/; revision=46359
2012-12-03 23:05:08 +00:00
Bill Meier be99fcad4d Minor cleanup:
- prefs callback not needed;
- move proto_reg_handoff...() to the end of the file as per convention;
- reformat some log lines.

svn path=/trunk/; revision=46358
2012-12-03 22:42:56 +00:00
Bill Meier 52e47754f1 Fix [-Wshadow] warnings.
svn path=/trunk/; revision=46357
2012-12-03 22:27:46 +00:00
Bill Meier 727ed68381 Fix [-Wshadow] warning for purported variable shadowing another.
svn path=/trunk/; revision=46356
2012-12-03 22:26:34 +00:00
Gerald Combs 469c33aff4 Make sure packets_bar_update does something.
svn path=/trunk/; revision=46355
2012-12-03 21:53:53 +00:00
Guy Harris da6f295794 Add some more uic lines.
svn path=/trunk/; revision=46352
2012-12-03 21:33:08 +00:00
Gerald Combs 46a454a94c Automatically size the interface column.
svn path=/trunk/; revision=46351
2012-12-03 20:38:32 +00:00
Gerald Combs 9e67335ea8 Update the interface list to reflect the recent interface name changes.
Allow multiple interface selections. Make sure we update the packet list
properly in a couple of places.

Use the right callback+signal to update capture statistics in the status
bar. Remove the global cfile from the main_statusbar.cpp

Add the version to the main window.

svn path=/trunk/; revision=46350
2012-12-03 19:58:55 +00:00
Bill Meier cef4af718c Fix SVN #46348 (iow, do it properly).
(Fixes compile warning)

svn path=/trunk/; revision=46349
2012-12-03 18:38:16 +00:00
Bill Meier f5ecb42c8e Remove duplicated code added as part of SVN #44777;
Move the SVN #44777 new (unduplicated) code to the correct place.
Also: fixes [-Wshadow] warning.

svn path=/trunk/; revision=46348
2012-12-03 18:11:30 +00:00
Bill Meier 3c0d6b8260 General minor cleanup:
- create/use several extended value strings;
- remove unneeded #includes;
- remove unneeded code & variable initializers;
- convert "4 space tabs" to spaces;
- do some reformatting to use a consistent whitespace style.

svn path=/trunk/; revision=46347
2012-12-03 17:28:43 +00:00
Anders Broman 52a4bd4644 Try to fix packet-sdp.c:1542: warning: 'parameter_item' may be used uninitialized in this function.
svn path=/trunk/; revision=46346
2012-12-03 15:04:24 +00:00
Pascal Quantin d2c32e27ed Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8038 :
Prevent a counter overflow in while loops

svn path=/trunk/; revision=46345
2012-12-03 14:44:12 +00:00
Anders Broman a07cfc3b50 Protect against malformed crypto-suite parameters.
Fixes SDP infinite loop.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8041

svn path=/trunk/; revision=46344
2012-12-03 13:55:03 +00:00
Anders Broman e23327c0bb From Michal Labedzki:
Bluetooth: AVDTP: Dissect RFA bits in header compression

Part of:
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7893

svn path=/trunk/; revision=46343
2012-12-03 11:39:22 +00:00
Anders Broman 4fdcd47001 From Michal Labedzki:
Bluetooth: AVDTP: Fix initialization of codec and some
 compiler warnings

If cannot obtain codec information by SetConfiguration/Reconfigure
use value "-1" to ensure that there will be no any stream dissected.


Part of:
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7893

svn path=/trunk/; revision=46342
2012-12-03 11:36:06 +00:00
Anders Broman ccb3fb14e2 From Michal Labedzki:
Bluetooth: Fix uninitialized fields on the USB side

Also make indentation/spaces cleanup in hci_usb dissector.

Part of:
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5032

svn path=/trunk/; revision=46341
2012-12-03 11:26:36 +00:00
Anders Broman 191aaba217 Wrong check for quote_offset.
Fixes  Bug 8042 - SIP infinite loop.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8042

svn path=/trunk/; revision=46340
2012-12-03 09:49:52 +00:00
Martin Mathieson 09a694823f Use tvb_get_const_stringz() when I know the tvb will be contiguous.
svn path=/trunk/; revision=46339
2012-12-03 01:45:00 +00:00
Bill Meier 020df2e24c Fix 2 bugs in heuristic tests which resulted in various false positives;
I believe this fix addresses the remaining issues for Bug #6047.
  https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6047

Also:
- Fix {-Wshadow] warning;
- Use tvb_get_ntoh24() in 2 places;
- Add ToDo comment about a TCP reassembly issue.

svn path=/trunk/; revision=46338
2012-12-03 01:41:32 +00:00
Martin Mathieson f5b9238ed6 Make list of file extensions to register display properly, using 3 text
lines rather than 2.  Add 2 new extensions to common.nsh.
Not sure if changes to wireshark.ini are necessary, copied what was done
for "Field 7", which is also just a label.

svn path=/trunk/; revision=46337
2012-12-02 23:55:44 +00:00
Pascal Quantin e52313959b Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8036 :
Check length of Slow Protocol OAM Vendor Specific Event Notification and add an expert info if it is not at least 2 bytes long

svn path=/trunk/; revision=46336
2012-12-02 22:19:37 +00:00
Pascal Quantin 8b5aa91371 Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8037 :
Fix an infinite loop in CSN.1 dissector when having more than 255 padding bits

svn path=/trunk/; revision=46335
2012-12-02 21:37:34 +00:00
Pascal Quantin 51323635aa From Ojab via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8035 :
Wrong packet bytes are selected for ISUP CUG binary code

svn path=/trunk/; revision=46334
2012-12-02 20:49:19 +00:00
Evan Huus 93a15fa28a Actually destroy the pool in epan_dissect_cleanup. There are many cases
where the edt is on the stack, in which case epan_dissect_free never gets
called and we were leaking the pool (although not any of the memory in it).

svn path=/trunk/; revision=46333
2012-12-02 18:16:21 +00:00
Evan Huus d4261b289f Document the new pinfo pool, add a TODO list.
svn path=/trunk/; revision=46332
2012-12-02 17:16:09 +00:00
Evan Huus b9c6f71fe4 Create a wmem pool in pinfo and use it for some address allocations.
A (better?) fix for https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8030

See also thread starting at:
http://www.wireshark.org/lists/wireshark-dev/201212/msg00001.html

svn path=/trunk/; revision=46331
2012-12-02 17:01:04 +00:00
Evan Huus 2461373edd Remove unneeded variable initializers.
svn path=/trunk/; revision=46328
2012-12-02 15:21:53 +00:00
Gerald Combs 0ff0068c48 [Automatic manuf, services and enterprise-numbers update for 2012-12-02]
svn path=/trunk/; revision=46327
2012-12-02 15:03:27 +00:00
Jeff Morriss a41c5abab1 Add SET_ADDRESS and SET_ADDRESS_HF to the list of APIs we (may--if we uncomment the code) check for being called with tvb_get_ptr().
svn path=/trunk/; revision=46326
2012-12-02 05:05:04 +00:00
Jeff Morriss e429065d4e Replace ip_to_str(tvb_get_ptr(...)) with tvb_ip_to_str(...).
svn path=/trunk/; revision=46325
2012-12-02 05:02:11 +00:00
Jeff Morriss 49466f95bc Introduce, and start using, TVB_SET_ADDRESS() and TVB_SET_ADDRESS_HF(). They
are like the non-TVB versions except that they take a TVB and an offset
instead of (frequently) a pointer into the TVB.

Calling tvb_get_ptr() before modifying the rest of the fields should help fix
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7960 (though I can't
reproduce that problem).


Replace a bunch of calls like:

SET_ADDRESS(..., AT_XXX, length, tvb_get_ptr(tvb, offset, length));

with:

TVB_SET_ADDRESS(..., AT_XXX, tvb, offset, length);

svn path=/trunk/; revision=46324
2012-12-02 04:49:13 +00:00
Jeff Morriss da4442d638 Use g_error() to generate an explanatory message (and a core) when
ABORT_ON_DISSECTOR_BUG is set and we pass MAX_TREE_ITEMS.

If ABORT_ON_DISSECTOR_BUG is set and we get an unregistered hf, generate
an explanatory message (and a core).

svn path=/trunk/; revision=46323
2012-12-02 03:34:06 +00:00
Jeff Morriss 2403ef591d Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8033 :
Register hf_btavdtp_number_of_signal_packets.

Remove (unused) hf_btavdtp_header_compression_rfa.

svn path=/trunk/; revision=46322
2012-12-02 03:25:38 +00:00
Jeff Morriss b5d14d6dcd Add an option to control whether tshark builds the tree (\"-T\").
Note the change in behavior: building the tree is now off by default.

Complain (and exit) if we get an argument we don't understand.

svn path=/trunk/; revision=46321
2012-12-02 02:58:29 +00:00
Jeff Morriss a92bbbcd5c Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8030 :
Don't store an AT_STRINGZ address in ep_ allocated memory: that memory is
freed before the addresses may be used.  Use se_ memory instead (no, that's
not really ideal either).

It would appear that several other dissectors have the same problem.

svn path=/trunk/; revision=46320
2012-12-02 02:46:12 +00:00
Evan Huus e2c9d02ba8 Fix typo
svn path=/trunk/; revision=46317
2012-12-01 20:51:20 +00:00
Evan Huus d730f8d348 Add -r option to valgrind script for --show-reachable=yes.
svn path=/trunk/; revision=46316
2012-12-01 20:49:27 +00:00
Evan Huus 7d1a8f8355 Fix potential copy-and-pasto in free_frame_data_sequence that may or may not
be the cause of https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8022

svn path=/trunk/; revision=46315
2012-12-01 18:19:08 +00:00
Evan Huus 400cb55a10 Remove unneeded include.
svn path=/trunk/; revision=46314
2012-12-01 17:48:01 +00:00