Commit Graph

13913 Commits

Author SHA1 Message Date
Martin Mathieson 92cd70bd61 Improve support for primitives that carry NAS-EPS.
Also parse beginning of "Monitor" lines.

svn path=/trunk/; revision=41821
2012-03-29 01:24:49 +00:00
Ronnie Sahlberg 3d81f3612b ONC-RPC: When a GSS context is destroyed, that NULL procedure call does not carry neither a verifier nor a payload.
Stop decoding the packed immediately after the credentials so that we dont incorrectly flag these packets as malformed.


svn path=/trunk/; revision=41817
2012-03-28 09:42:05 +00:00
Michael Tüxen 7e112bec91 From Robin Seggelmann:
Support DTLS 1.2
Fix a bug in option handling.


svn path=/trunk/; revision=41816
2012-03-28 09:31:04 +00:00
Ronnie Sahlberg 5a2b1ea380 remove a header include that was used when debugging and forgotten to be removed from previous commit
svn path=/trunk/; revision=41814
2012-03-28 09:16:09 +00:00
Ronnie Sahlberg fcd7ed4e62 ONC-RPC: add tracking of GSSAPI authentication contexts
Add traking of when GSS authentication contexts are created and when they are destroyed
so that it is easy to "click on created in link" in a SecNFS packet to get to where the kerberos blob for authentication is


Add context created in/destroyed in to the decode so you can quickly jump to where the authantiation happened to check the decrypted krb5 credentials



svn path=/trunk/; revision=41813
2012-03-28 09:10:41 +00:00
Alexis La Goutte 064024c58a From Ryan Doyle via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6874
Attached is the patch to allow PM_TYPE_AGGREGATE to fall through to PM_TYPE_AGGREGATE_STATIC.

svn path=/trunk/; revision=41812
2012-03-28 08:48:46 +00:00
Alexis La Goutte d4c9e52320 From Jason Damori via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7002
Add MAC Address Acquisition Protocol Dissector

Add the dissector for MAAP - the MAC address acquisition protocol for 802.3
Ethernet defined in IEEE1722.

svn path=/trunk/; revision=41811
2012-03-28 08:46:07 +00:00
Alexis La Goutte c77146cc0d Fix indent (use space) and add Modelines info.
svn path=/trunk/; revision=41798
2012-03-27 13:53:29 +00:00
Alexis La Goutte 2ddb826f55 Add IPv6 Option : RPL Option RFC-ietf-6man-rpl-option-06
svn path=/trunk/; revision=41797
2012-03-27 13:50:50 +00:00
Alexis La Goutte 22e69ad398 Add IPv6 Option :
* Tunnel Encapsulation Limit (RFC 2473)
* CALIPSO (RFC 5570)
* Experimental Option (RFC 4727)

svn path=/trunk/; revision=41796
2012-03-27 13:42:54 +00:00
Ronnie Sahlberg 22e4281355 SCSI SBC : Add decode for UNMAP command
svn path=/trunk/; revision=41795
2012-03-27 09:22:29 +00:00
Stig Bjørlykke f45d2dcd17 Check the user-provided custom header string for invalid characters before
trying to register it in an hf; registering invalid characters in an hf will
lead to an assertion.

This was fixed for the http dissector in revision 41787.

svn path=/trunk/; revision=41791
2012-03-27 06:50:09 +00:00
Martin Mathieson 2570bef0c2 When storing sequence analysis results, add (raw) sequence number and
ack number to the lookup key (which was previously just the frame number).

This helps with situations where multiple segments of the same TCP
conversation can be found in the same frame in a capture (e.g. with LTE
user-plane traffic carried in logged MAC or RLC frames).

svn path=/trunk/; revision=41788
2012-03-27 02:08:48 +00:00
Jeff Morriss c13c14429b Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6982 :
Check the user-provided custom header string for invalid characters before
trying to register it in an hf; registering invalid characters in an hf will
lead to an assertion.

svn path=/trunk/; revision=41787
2012-03-27 01:43:20 +00:00
Jeff Morriss ad5af7cf85 From Nick Lowe via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7001 :
Show EAPOL versions textually.

svn path=/trunk/; revision=41786
2012-03-27 01:17:38 +00:00
Guy Harris 74f042558d There is no "dBm transmit attenuation" field in radiotap; there is,
however, a dBm transmit *power* field.

Fix up the capitalization of "dB" and "dBm", and improve the blurb for
attenuation fields, while we're at it.

Should fix bug 7000:

	https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7000

svn path=/trunk/; revision=41781
2012-03-26 22:12:03 +00:00
Jeff Morriss fdb0862c6f Fix CID 1336 (new with r40139): infinite loop if length is equal to 1.
svn path=/trunk/; revision=41780
2012-03-26 22:11:15 +00:00
Jeff Morriss b800903ca2 Fix CID 1458 (new with r41751): infinite loop if length is equal to 1.
svn path=/trunk/; revision=41778
2012-03-26 21:30:16 +00:00
Chris Maynard 49c7005ab5 In dissect_invokeData(), fixup the default case of the switch statement. Fixes 2 instances of Coverity CID 813: UNREACHABLE.
svn path=/trunk/; revision=41775
2012-03-26 19:41:23 +00:00
Chris Maynard 9231cb51a9 Fix Coverity CID 1456: UNUSED_VALUE.
svn path=/trunk/; revision=41771
2012-03-26 17:35:13 +00:00
Jeff Morriss 730ae93ce8 Line wrap a few very long lines.
svn path=/trunk/; revision=41767
2012-03-26 14:16:58 +00:00
Jeff Morriss c4acc5cecc From Guy Martin via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6999 :
This patch adds support for the DVB Time Offset Table and the related
descriptor.
It also contains the Stuffing Descriptor as an added bonus.

svn path=/trunk/; revision=41766
2012-03-26 14:08:39 +00:00
Jeff Morriss 4204d39e76 From Guy Martin via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6998 :
This add support for the very simple DVB Time and Date Table (TDT) as
defined in ESTI EN 300 468.

svn path=/trunk/; revision=41765
2012-03-26 13:56:23 +00:00
Martin Mathieson 65ddfa9e3a Add a field for the number of SRs indicated in one frame.
svn path=/trunk/; revision=41764
2012-03-25 23:46:01 +00:00
Bill Meier eb24f600d7 Extensive rework to clean up code and to fix a number of issues with tn3270 dissection;
Also: do reformatting and symbol renaming for readability.

See Bug #6854 for several examples typical of the issues fixed:
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6854

svn path=/trunk/; revision=41763
2012-03-25 23:14:23 +00:00
Jeff Morriss 921b0f140d From Guy Martin via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6992 :
Use a couple of hf_ entries that were supposed to be used (reported in
comment 3).

I've also fixed two other small bugs I've found :
 - Invalid checking of mpeg1_only_flag in the video stream descriptor
 - Avoid processing descriptor data if reported length is 0

svn path=/trunk/; revision=41758
2012-03-25 14:03:39 +00:00
Jeff Morriss 254bf21caf From Guy Martin via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6993 :
This patch adds support for DVB Service Description Table as documented in
ETSI EN 300 468.

svn path=/trunk/; revision=41756
2012-03-25 01:49:23 +00:00
Jeff Morriss 5eab81456d Fix some hf encodings (courtesy of fix-encoding-args.pl).
svn path=/trunk/; revision=41755
2012-03-25 01:41:18 +00:00
Jeff Morriss 55e03ca50a From Guy Martin via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6992 :
This patch adds support for DVB Network Information Table as documented in
ETSI EN 300 468.

The patch also contains additional mpeg descriptors usually found in NIT plus
a few minor bugfix for other descriptors.

svn path=/trunk/; revision=41754
2012-03-25 01:33:35 +00:00
Jeff Morriss 19f951917e From Nikitha Malgi via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6958 :
The Group Address (GADDR) TLV, IS-IS TLV type 142, is carried only in an LSP
PDU and carries sub-TLVs that in turn advertise multicast group listeners.  It
also contains the Group MAC address Sub TLV. The Group MAC Address (GMAC-ADDR)
sub-TLV is sub-TLV type number 1 within the GADDR TLV.  In TRILL, it is used to
advertise multicast listeners.

Reference --- http://tools.ietf.org/html/rfc6326#section-2.1

svn path=/trunk/; revision=41751
2012-03-24 00:07:49 +00:00
Jeff Morriss 751930fccb From Guy Martin via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6989 :
Add support for DVB EIT packets from ETSI EN 300 468.

svn path=/trunk/; revision=41750
2012-03-23 23:49:14 +00:00
Jeff Morriss 323dd08b61 Add a couple casts to fix the Windows builds.
svn path=/trunk/; revision=41745
2012-03-23 01:58:46 +00:00
Jeff Morriss 4efb92a274 Replace some duplicate blurbs with NULL.
svn path=/trunk/; revision=41743
2012-03-23 01:41:24 +00:00
Jeff Morriss a7f0f54612 From Tom Bottom via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6887 :
Address comments in the bug: fix up some hf issues and use
proto_item_set_len() when necessary.

Added status field dissection to AEM packets.

From me: hf_aem_frequency is an FT_FLOAT and appears to have a length of 4 so
use that length (instead of 5).

svn path=/trunk/; revision=41742
2012-03-23 01:18:06 +00:00
Jeff Morriss 659d9535aa From Elliot Parsons via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6983 :
In the packet-slowprotocols dissector, there is a bug in the event notification
dissector. The code uses the incorrect value to skip past the data of a vendor
specific notification.

The attached patch file sets the offset to increment by raw_octet, which
corrects the issue.

svn path=/trunk/; revision=41741
2012-03-23 00:53:58 +00:00
Anders Broman efa9387886 From Krishna:
Enhancement to add more trace record fields in Citrix NetScaler capture file format.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?

svn path=/trunk/; revision=41740
2012-03-22 15:36:37 +00:00
Anders Broman f7b39033d4 Unescape NAL units
Bug https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6975

svn path=/trunk/; revision=41739
2012-03-22 15:10:14 +00:00
Stig Bjørlykke 7d6fcb871b Renamed dmp_class to sec_class, as this is a more correct variable name.
svn path=/trunk/; revision=41738
2012-03-22 12:38:18 +00:00
Stig Bjørlykke 2a9559e200 Removed unused 'msg_type_val' argument to some functions.
svn path=/trunk/; revision=41737
2012-03-22 12:37:03 +00:00
Anders Broman afa29e0070 From Yaniv Kaul:
Enhance the SSL dissector to dissect some Hello extensions.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6979

svn path=/trunk/; revision=41736
2012-03-22 08:58:19 +00:00
Anders Broman dba2c07cba From Weston Schmidt:
Add support for ETV Data processing & simple MPEG DSM-CC handling.
Witha a change of the name of dissect() in packet-etv.c to dissect-etv_common().

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6978

svn path=/trunk/; revision=41735
2012-03-22 08:49:00 +00:00
Chris Maynard 6d09f686dd If the checksum is 0, then only report "no checksum" for UDP/IPv4. This patch is from Jaap Keuter via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6232
svn path=/trunk/; revision=41734
2012-03-22 03:41:58 +00:00
Jeff Morriss 1731fc958e From Martin Kaiser via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6977 :
The attached (trivial) patch adds some missing breaks in switch-case blocks.

This fixes coverity defects #445, #446, #1316 and #1380.

svn path=/trunk/; revision=41727
2012-03-21 22:18:15 +00:00
Jeff Morriss 5629a3fa00 Fix fuzz failure reported in
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6976 :

Don't assume that all responses have conversations to find.

svn path=/trunk/; revision=41726
2012-03-21 21:21:58 +00:00
Bill Meier 34e788eb11 'tab-width/tabstop/tabSize' in editor modelines should really always be 8.
svn path=/trunk/; revision=41725
2012-03-21 18:27:10 +00:00
Bill Meier ca3e8b5d8b 'tab-width/tabstop/tabSize' in editor modelines should really always be 8;
Also: In some cases do some whitespace cleanup and some minor reformatting.

svn path=/trunk/; revision=41724
2012-03-21 18:20:44 +00:00
Martin Mathieson 2fc3322e82 Trivial formatting: Show segment offsets/length closer to associated sequence number
in partial NACK.

svn path=/trunk/; revision=41723
2012-03-21 13:53:18 +00:00
Anders Broman f85baa9dfa From Guy Martin:
Fix
Coverity has 3 complaints about this dissector, reported in CID's 1450-1451
CONSTANT_EXPRESSION_RESULT:

Event result_independent_of_operands: (crid & 3) >> 2 is 0 regardless of the
values of its operands [non-specific operand of assignment].
1385             crid_type = (crid &
MPEG_DESCR_CONTENT_IDENTIFIER_CRID_LOCATION_MASK) >> 2;


Event result_independent_of_operands: flags & 0x1000 is always 0 regardless of
the values of its operands (logical operand of if).
1512             if (flags & MPEG_DESCR_LOGON_INITIALIZE_CONNECTIVITY_MASK) {


Event result_independent_of_operands: flags & 0x1000 is always 0 regardless of
the values of its operands (logical second operand of '&&').
1544         if (offset < end && (flags &
MPEG_DESCR_LOGON_INITIALIZE_CONNECTIVITY_MASK)) {

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6960

svn path=/trunk/; revision=41722
2012-03-21 13:07:23 +00:00
Martin Mathieson 611dcb0d68 When a TCP graph is summoned, work out how many unique TCP conversations
are present. However, still only create the graph for the first/only
one.

LTE MAC or RLC frames often contain multiple SDUs that are segments of
the same TCP conversation - this avoids the need to find a frame with
only one SDU.

svn path=/trunk/; revision=41721
2012-03-21 12:58:50 +00:00
Alexis La Goutte 914a9df522 Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
svn path=/trunk/; revision=41720
2012-03-21 11:27:10 +00:00