Commit graph

5252 commits

Author SHA1 Message Date
Martin Mathieson
bd6931e2d3 Use FT_UINT_STRING for TBCP DENY reason-phrase
svn path=/trunk/; revision=18968
2006-08-21 11:41:32 +00:00
Anders Broman
43d1b4c099 Dissect some more H.245 messages in MEGACO
svn path=/trunk/; revision=18966
2006-08-20 21:18:43 +00:00
Ronnie Sahlberg
cf6d4692aa in LDAP over TCP
use tcp_dissect_pdus() which works    insterad of trying to do the pdu tracking and signalling for reassembly manually.
This makes ldap pdu tracking and reassembly work properly for cases when hosts are streaming lpad over tcp and there is little or none alignlemt of pdus to the start of a segment



svn path=/trunk/; revision=18965
2006-08-20 06:00:16 +00:00
Ronnie Sahlberg
0adb40dbc0 we have to search for multisegments starting PRIOR to the start of the current semgent or elsae it will break for the case when one multisegment ends in this segment there are a few smaller ones completely within this segment and then another segment starts that spans across future segments.
svn path=/trunk/; revision=18964
2006-08-20 05:18:10 +00:00
Ronnie Sahlberg
c0e5ca30ad add some well known rids from s4 security.idl and code to show the name of this rid
when dissecting a security descriptor


svn path=/trunk/; revision=18959
2006-08-19 09:22:20 +00:00
Guy Harris
f4457669d3 Fix some g_warning() calls.
svn path=/trunk/; revision=18958
2006-08-19 03:01:53 +00:00
Guy Harris
7cb6f60b18 Fix some format strings and format string arguments.
svn path=/trunk/; revision=18957
2006-08-19 03:01:15 +00:00
Guy Harris
5000c85513 Squelch a compiler warning.
svn path=/trunk/; revision=18956
2006-08-19 03:00:16 +00:00
Guy Harris
8a3af12c87 Define "char_def_alphabet_ext_decode()" with a return type - and define
it as static as it's not used outside this file.

svn path=/trunk/; revision=18955
2006-08-19 02:58:48 +00:00
Guy Harris
338f7ede99 Squelch a compiler warning.
svn path=/trunk/; revision=18954
2006-08-19 02:56:16 +00:00
Gerald Combs
7bded1f0ee Fix CID 209 (possible NULL dereference).
svn path=/trunk/; revision=18950
2006-08-18 20:18:38 +00:00
Guy Harris
51142bc70a From Gisle Vanem: export the new GUID functions.
svn path=/trunk/; revision=18949
2006-08-18 18:18:36 +00:00
Gerald Combs
f95cb7af5c Add an attribution.
svn path=/trunk/; revision=18948
2006-08-18 15:46:43 +00:00
Ronnie Sahlberg
b588469ccf guids are not olnly used in dcerpc interfaces and they often occur in many other protocols such as ldap and smb/smb2
move the initialization of the guid mapping table from the dcerpc dissector to a more neutral place


svn path=/trunk/; revision=18947
2006-08-18 09:32:19 +00:00
Ronnie Sahlberg
47969704c6 change the guid mapping code to use a tree isntead of a hashtable
svn path=/trunk/; revision=18946
2006-08-18 09:27:40 +00:00
Ronnie Sahlberg
d6ba4c112c from stephen f
new protocol: veritas low latency transport

---
Attached is a patch file that adds a new dissector for the LLT protocol
(Veritas Low Level Transport, used for server clustering).  They use
ethertype 0xCAFE even though it isn't assigned to them :(.  There are
other fields and possibly other message types directly between servers
it does not yet dissect as no one outside of Veritas knows what they
are.  This dissector understands the one people will run across most -
multiple servers broadcasting these heartbeats all over the place.  I
figured out these fields through many Internet searches.

I will add the protocol to the Wiki after it is committed.


Thanks,
  Steve




svn path=/trunk/; revision=18944
2006-08-18 08:46:31 +00:00
Gerald Combs
0e5e0c4453 Fix two remaining off-by-one errors. Remove a static buffer.
svn path=/trunk/; revision=18943
2006-08-18 00:22:48 +00:00
Anders Broman
a870534df9 From Stephen Fisher:
the attached patch removes the 
redundant "Cisco Discovery Protocol" from the info column:

Before:

  Cisco Discovery Protocol  Device ID: myswitch.domain.com  Port ID: GigabitEthernet3/17

After:

  Device ID: myswitch.domain.com  Port ID: GigabitEthernet3/17

svn path=/trunk/; revision=18941
2006-08-17 20:32:06 +00:00
Anders Broman
d221d6f2fc From Hannes Gredler:
A patch that adds support for dissection of
libpcap DLT_JUNIPER_VP frames. In addition i have fixed
also the indent for DLT_JUNIPER_GGSN.

svn path=/trunk/; revision=18940
2006-08-17 20:24:05 +00:00
Ulf Lamping
7d04019388 some further work on the GUID/UUID resolvings
most of the relevant code moved to guid_utils
lot of corresponding code cleanup in packet-dcerpc.c
still using GHashTable
still not using a manuf like file

svn path=/trunk/; revision=18939
2006-08-17 19:09:41 +00:00
Jörg Mayer
162d87a516 Muthu Krishnan V <muthukrishnanv@gmail.com>
As per RFC 4090, In the FAST_REROUTE Object, Include-any starts
at the 12th byte and Exclude-any starts at the 16th byte.

Ethereal has inter-changed these two fields in its display.

*Ethereal* bug 1043.

svn path=/trunk/; revision=18938
2006-08-17 11:56:35 +00:00
Ronnie Sahlberg
2fdf0e4b4b add trees with PErmanent allocation scope which will be useful for constructing
associative arrays for globally unique and persistent mappings such as
oid to name
sid to name
guid to name


svn path=/trunk/; revision=18937
2006-08-17 08:17:48 +00:00
Ronnie Sahlberg
c7250199a7 add missing _WIN32 encapsulation so braces match and compilation under non-win32 works
svn path=/trunk/; revision=18936
2006-08-17 07:35:58 +00:00
Ulf Lamping
de0594b9a5 various UUID/GUID based changes.
I think I've changed all corresponding appearances from FT_STRING to FT_GUID, so assert the FT_ type as it should only be a FT_GUID now.

Add a generic implementation in guid_utils.h to have a way to store data about GUID to name resolving (something like value_string for e.g. int). It might be better to have a single registry for all GUID's of all dissectors and implement the GUID name resolving into the proto_tree_add... functions.

svn path=/trunk/; revision=18935
2006-08-16 23:13:26 +00:00
Ulf Lamping
eb7c653073 FT_STRING -> FT_GUID
svn path=/trunk/; revision=18934
2006-08-16 22:59:55 +00:00
Ulf Lamping
2ed79a23f1 lower the expert info levels WARN -> NOTE for missing references
fix an iteration bug in cba_connection_disconnectme()

svn path=/trunk/; revision=18933
2006-08-16 22:56:55 +00:00
Ulf Lamping
f17222a893 FT_STRING -> FT_GUID
svn path=/trunk/; revision=18931
2006-08-16 20:55:21 +00:00
Ulf Lamping
3ec210b0d1 Don't mark a TCP packet as a "Duplicate ACK" if the flags don't have the ACK flag set (IMHO it's not an ACK in that case). This happens sometimes between FIN and RST packets.
Ronnie, could you check if this change is ok?

svn path=/trunk/; revision=18930
2006-08-16 20:52:51 +00:00
Ronnie Sahlberg
58396f47da add tracking of fid type to objects opened by NT CREATE so that we can dissect aces properly also for these fids
svn path=/trunk/; revision=18929
2006-08-16 19:38:39 +00:00
Gerald Combs
f9661850d1 Add support for AirPcap, an upcoming wireless product from CACE. Support
is disabled by default, and can be enabled by setting AIRPCAP_CONFIG
in config.nmake.  The code is currently limited to Windows, but should
be adaptable to other platforms.

The official announcement won't come until next week, so you'll have to
read the source for details.  :)

svn path=/trunk/; revision=18928
2006-08-16 18:01:25 +00:00
Ronnie Sahlberg
b02d08fa76 use the same structure to pass the fid type information from nt transaction parameter to nt transaction data dissector for both ssd and qsd instead of two different ones
svn path=/trunk/; revision=18927
2006-08-16 10:35:04 +00:00
Ronnie Sahlberg
d08c190fe0 track fid types between NT TRans QUERY_SECURITY_DESCRIPTOR and dissect the ACEs properly
svn path=/trunk/; revision=18926
2006-08-16 09:22:36 +00:00
Ronnie Sahlberg
80e1ff0ee8 add dissection of DIRECTORY specific bits of the accessmask for SET_SECURITY_DESCRIPTOR
svn path=/trunk/; revision=18925
2006-08-16 09:02:15 +00:00
Ronnie Sahlberg
3c6d1fcef8 add code to dissect FILE specific bits for the accessmask inside a security descriptor and have SET_SECURITY_DESCRIPTOR use it so that security descriptors for files held inside SET_SECURITY_DESCRIPTOR are decoded properly
svn path=/trunk/; revision=18924
2006-08-16 08:48:00 +00:00
Tomas Kukosa
5ff34d332b - add value_ptr into struct _asn1_ctx_t
- small changes in h225.cnf
- H.225 regenerated

svn path=/trunk/; revision=18923
2006-08-16 08:07:30 +00:00
Ronnie Sahlberg
0902016b42 add a type field for the fid tracking structure and initialize it to UNKNOWN
when files are opened using NTCreateAndX  and if we recognize the type   set the type field to either FILE, DIR or PIPE

This is useful to know when dissecting things like security descriptors since it tells us how to dissect the specific bits of the access mask.


Only do this for NTCreateAndX for now.   It is trivial to add similar tracking to some of the older   obsolete   calls used to open fids    but no clients ever use those old calls any more.





svn path=/trunk/; revision=18922
2006-08-16 08:00:46 +00:00
Tomas Kukosa
5cd8c719e6 ASN.1 dissectors regenerated with new asn2wrs to get updated field blurb
svn path=/trunk/; revision=18921
2006-08-16 05:58:39 +00:00
Jörg Mayer
c5bf44c6ad Always print length as well as type in Option line.
Count amount of padding.


svn path=/trunk/; revision=18920
2006-08-16 00:12:02 +00:00
Jörg Mayer
d9f56b9080 Steve Karg <skarg@users.sourceforge.net>
I made a small change in packet-bacapp.c to fix the following:
1. Corrected Signed value decoding for a one octet value.
2. Corrected Priority values to decode as Unsigned values.


svn path=/trunk/; revision=18918
2006-08-15 20:46:13 +00:00
Ronnie Sahlberg
e7816f82a1 export ep_free_all
svn path=/trunk/; revision=18917
2006-08-15 20:35:52 +00:00
Jörg Mayer
591167281e Complete: Make dhcp options filterable
svn path=/trunk/; revision=18916
2006-08-15 20:32:08 +00:00
Gerald Combs
a0f21609b8 Fix CIDs 204 - 208.
svn path=/trunk/; revision=18915
2006-08-15 19:28:07 +00:00
Jörg Mayer
b58714b375 Eric Fung <efung@certicom.com>
A very tiny patch that corrects decoding of the Next Payload field in
the IKEv2 header. RFC 4306, Sec 3.2 says that a payload type of 0
means "No Next Payload" and not RESERVED. The patch just uses the
same string the dissector uses for IKEv1, namely, "NONE".


svn path=/trunk/; revision=18914
2006-08-15 18:16:56 +00:00
Jörg Mayer
24f77cfbf5 Mike Duigou <wireshark@duigou.org>
The enclosed patch updates the set of mime types for line oriented text
data per RFC 2046.

Me:

Remove application/postscript, as it may be binary.

svn path=/trunk/; revision=18913
2006-08-15 18:13:35 +00:00
Jörg Mayer
9c53d1894b Start making dhcp options filterable (special cases still missing)
svn path=/trunk/; revision=18912
2006-08-15 13:24:02 +00:00
Jörg Mayer
c285c838f7 Mark Lewis <mlewis@altera.com>
I have developed a plugin for Pro-MPEG FEC packets over RTP (see
previous posts on ethereal-dev). I have added a page and example capture
file to the Wiki (http://wiki.wireshark.org/2dParityFEC). The source and
Windows makefile for the plugin are attached. Unfortunately I do not
have access to other systems so this plugin has been tested on Windows
only.


The attached version of my plug-in has only had the copyright header
added.
I will translate this into a proper dissector rather than a plug-in as
requested, but this may take a little time as I have a lot of other
things
to do at the moment.

Me:

Convert into a normal dissector
Reorder / reformat code a bit
Added Marks name to the top of the file.



svn path=/trunk/; revision=18908
2006-08-15 11:31:55 +00:00
Jörg Mayer
f229c45733 Remove no longer needed dummy files
svn path=/trunk/; revision=18907
2006-08-15 09:49:06 +00:00
Jörg Mayer
b21579abef Stephen Fisher <stephentfisher@yahoo.com>
Could you apply the attached patch also to finish it off - I
failed to include it in the original e-mail.

svn path=/trunk/; revision=18906
2006-08-15 06:40:26 +00:00
Ronnie Sahlberg
68bdadcb50 add decode of trust attribute flags as documented in samba4 netlogon idl
svn path=/trunk/; revision=18905
2006-08-15 02:21:08 +00:00
Ulf Lamping
b2751079ac various minor DCOM dissection enhancements:
- add a generic guid register to dissect UUID's (move this to a seperate file?)
- this enables us to set some known names for special UUID's
- use standard DCOM fields for IID and alike in remunk.c
- cleanup dcom_protseq_vals handling
- some FT_STRING to FT_GUID changes

svn path=/trunk/; revision=18904
2006-08-14 23:39:48 +00:00
Gerald Combs
f6802d35c8 Put protocol preferences in a scrolled window, in case a particular
protocol has a lot of preference items.  Change the number of
configurable ESP SAs to 16 (in case someone needs do decrypt many
sessions in a single trace file).  Fix up whitespace.

svn path=/trunk/; revision=18903
2006-08-14 22:34:46 +00:00
Jörg Mayer
d291a92109 Stephen Fisher <stephentfisher@yahoo.com>
Attached is a patch to packet-http.c that calls a subdissector for
traffic flowing through a proxy via the HTTP CONNECT method.  Most
protocols, especially SSL, can be tunneled through an HTTP proxy.
Wireshark currently says this traffic is "Continuation or non-HTTP
traffic" but this patch turns the payload over to the dissector for the
protocol being tunneled.  This is similar to how the Socks dissector
works.


svn path=/trunk/; revision=18901
2006-08-14 21:46:05 +00:00
Jörg Mayer
5bebfcc987 Carlos Pignataro <cpignata@cisco.com>
Please find attached a patch with updates to l2tpv3's l2_sublayer_vals
and pw_types_vals numbers (and pw type decoding).

The previous values belong to a different number space, "MPLS Pseudowire
Types Registry" in http://www.iana.org/assignments/pwe3-parameters, used
by LDP. The new values belong to the correct number space, "L2TPv3
Pseudowire Types" in http://www.iana.org/assignments/l2tp-parameters,
used by L2TPv3. Note that one is a 15-bit number while the other is a
16-bit number. So it's not really removing half of the values; even
though there are some numerical "matches" in the two registries, there
are differences (see for example 12 and 13, and some name changes). From
my knowledge the values not registered are also not used (and part of
the intention of the patch is that they are not misused); a fair
assumption is that it was a clerical error mis-assuming the two
protocols, LDP and L2TPv3, used the same space for "PW Types".


svn path=/trunk/; revision=18900
2006-08-14 21:37:12 +00:00
Ulf Lamping
49c07de8fb add a value_string for the LCID field
svn path=/trunk/; revision=18897
2006-08-14 20:47:54 +00:00
Ulf Lamping
5061097ee4 fix some dissection bugs
svn path=/trunk/; revision=18896
2006-08-14 20:41:46 +00:00
Ronnie Sahlberg
2657b9b701 make creation of subtrees used for the _array tree type use the same allocation scope as its parent and thus become allocation scope agnostic
change all accessor functions to be defines to the emem_tree_ functions.



now   to create a tree with a different scope we only need to create a new
..._tree_create() function   and set up the appropriate defines


(it was a mistake to call the functions   se_tree_create   and se_tree_create_non_persistent,     they should be the other way around    i.e.  se_tree_create_persistent   and se_tree_create )



svn path=/trunk/; revision=18895
2006-08-14 09:36:15 +00:00
Ronnie Sahlberg
8ce8e719e0 rename some structures and defines from the se_tree to the emem_tree prefix
svn path=/trunk/; revision=18894
2006-08-14 08:29:29 +00:00
Ronnie Sahlberg
8529abb69b put a memory allocator function pointer inside the tree structure so that all accessor functions become storage scope agnostic
svn path=/trunk/; revision=18888
2006-08-12 23:27:22 +00:00
Ronnie Sahlberg
db2e890949 rename some inline functions from se_ to emem_ prefix as a first step to generalize
teh tree management and to use trees with different storage scope without too much code duplication.


it would be useful with a tree that had indefinite storage instead of the emem functions which commonly have ep or se storage scope.

indefinite storage scope would be useful for example for managing a global and static set of well known guid to name mappings(not yet implemented)    and also for
oid to name mappings.

 

svn path=/trunk/; revision=18886
2006-08-12 22:43:12 +00:00
Ulf Lamping
d0aed5f920 add an experimental DCOM object "database" based on the exchanged interface pointers
add a lot more PROFINET CBA dissection output based on these DCOM context information
still need some improvements, e.g. dissection uses a simple (slow) linear list search
changes are fuzz-tested

svn path=/trunk/; revision=18882
2006-08-11 19:15:12 +00:00
Ronnie Sahlberg
5f8e067936 for sec descriptors found inside ldap
decode the specific bits of the accessmask as the ldap specific accessmask bits

bit definitions from samba4


svn path=/trunk/; revision=18881
2006-08-11 07:59:58 +00:00
Jörg Mayer
3fee10cc41 Change a label a bit to be able to differentiate it from the default
case.

svn path=/trunk/; revision=18879
2006-08-10 20:49:58 +00:00
Jörg Mayer
1d334bdc83 Solomon Peachy:
I've attached a patch to the "wlan capture header" dissector to bring it
in line with the current frame format, and a proper URL to obtain said
format.   Nothing major, just the addition of a couple of fields and
definitions.  The dissector remains backwards-compatible with the older
format.


svn path=/trunk/; revision=18878
2006-08-10 20:41:50 +00:00
Ulf Lamping
f177995f29 PN-CBA may also use class 2 frames
svn path=/trunk/; revision=18877
2006-08-10 19:51:14 +00:00
Ulf Lamping
d4bf67fb59 fix a misleading text
svn path=/trunk/; revision=18876
2006-08-10 19:45:14 +00:00
Ronnie Sahlberg
23426c8901 add missing ace revision 4 and several new types some of which contain optional GUIDs
from samba4   security.idl


svn path=/trunk/; revision=18875
2006-08-10 13:21:57 +00:00
Jörg Mayer
e1959d4f05 Erwin Rol:
Attached a dissector for JPEG images in RTP streams, AKA
        RFC2435.

Me: Fixed a warning (guint8 <= 255 is always true)


svn path=/trunk/; revision=18872
2006-08-10 11:18:02 +00:00
Ronnie Sahlberg
05fcb684ed create subtrees also for unknown address types instead of creating the items inside the previous expansion created
svn path=/trunk/; revision=18871
2006-08-10 10:52:16 +00:00
Jörg Mayer
41d8f13aec Neil Piercy:
I've just had a bug in one of our private dissectors which meant
that the handle passed to call_dissector was null. This seemed to give
varying behavior - on some Windows installations it hit wireshark's
in-built exception handling, and displayed that the dissector had an
error (correct), but on some installations it just crashed wireshark
(not helpful). I _think_ the difference was whether MSVC was installed
or not, but on a sample of only 3 machines.

Should call_dissector include explicit null handle checks, and if so,
should it:-

a) g_assert - the simple patch attached
b) fallback to doing a data decode (as disabled protocols do)
c) try to invoke the wireshark exception handling for the packet

Or is the correct answer none of the above - the exception handler
should already cope ?

        

svn path=/trunk/; revision=18869
2006-08-10 10:09:31 +00:00
Jörg Mayer
76b9953baa Fix for http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1014
provided by markdrago@mail.com.

Me: Patch template files instead and regenerate the dissector files.
    Fix Makefiles to use the correct asn filenames.

svn path=/trunk/; revision=18866
2006-08-10 09:02:24 +00:00
Ronnie Sahlberg
c771b251eb this is a blob not a policyhandle
svn path=/trunk/; revision=18865
2006-08-10 07:35:26 +00:00
Jaap Keuter
4c358e477c From: Michael Lum
Small ANSI-637 patch for identifying more Teleservice

svn path=/trunk/; revision=18864
2006-08-10 06:24:50 +00:00
Tomas Kukosa
73ddcc157a GnuTLS/libgcrypt initialization moved to epan.c
svn path=/trunk/; revision=18863
2006-08-10 06:06:21 +00:00
Jörg Mayer
f2a2bed08f efung@certicom.com:
Patch adding MOBIKE support to packet-isakmp.c

svn path=/trunk/; revision=18862
2006-08-10 03:11:33 +00:00
Martin Mathieson
e2767088d8 Minor TBCP fixes
svn path=/trunk/; revision=18860
2006-08-09 17:23:10 +00:00
Ronnie Sahlberg
4ac1c1fae5 metze pointed out that the last four bytes of the 20 byte blob prepenfing the ndr encoded data in the pac must be a unique pointer
make sense,   decode it as a unique pointer then



svn path=/trunk/; revision=18859
2006-08-09 11:25:20 +00:00
Ronnie Sahlberg
9149665c5c decode the field of type 11
(it could theoretically also be a union with arm:1 selected instead of a conformant array)


svn path=/trunk/; revision=18858
2006-08-09 08:25:01 +00:00
Ronnie Sahlberg
2e9f554669 testing the win32 decryp[tion out i noticed a lot of new previously not decoded info in the captures for constrained delegation on the Kerberos wiki page.
a new bit 0x00020000 is usde in the TGS-REQ packets and this results in a return of a PAC containing an unknown type 11 field.


the blob in the pac is 200 bytes and NDR encoded.   its structure is obvious since it contains 2 conformant and varying arrays  and three unique pointers.



enable decoding of this new KDCOptions bit and call it "constrained delegation"




svn path=/trunk/; revision=18857
2006-08-09 07:37:57 +00:00
Gerald Combs
4f16b6b178 Point to the newest (1.5.0-1) GnuTLS package. Since it contains
libgcrypt, enable it in the Windows build.

In packet-ipsec.c:

  - Remove non-constants from variable declaration initializations.
  - Use ep_alloc() in a couple of places.
  - Fix an off-by-one error.
  - Reduce the number of SAs in the preferences from 4 to 2.  4 made the
    preferences window absolutely enormous.  This is probably the wrong
    way to fix this.
  - Fix up whitespace.

svn path=/trunk/; revision=18856
2006-08-09 02:00:05 +00:00
Anders Broman
94c402d671 Routines for Universal Mobile Telecommunications System (UMTS) Radio Resource Control (RRC) (umts_rrc) dissection.
svn path=/trunk/; revision=18855
2006-08-08 21:32:44 +00:00
Jaap Keuter
c9a6054b75 From: Bálint Réczey:
The attached patch fixes decoding of message flags in BFD control packets.

svn path=/trunk/; revision=18853
2006-08-08 19:54:37 +00:00
Gerald Combs
0213f60e4b Add GNUTLS to the Windows build.
In packet-ssl.c, move ssl_set_debug() up a bit so that we can debug key
file parsing.

svn path=/trunk/; revision=18850
2006-08-07 19:52:18 +00:00
Martin Mathieson
463d895a53 Tidy up comments, var names, remove pedantic warnings
svn path=/trunk/; revision=18849
2006-08-07 17:10:59 +00:00
Ronnie Sahlberg
8969e45027 marik the request_in/response_to/time as generated fields
svn path=/trunk/; revision=18846
2006-08-07 10:35:26 +00:00
Ronnie Sahlberg
5a5dcdc8ad dissect nTSecurityDescriptor attribute as a security descriptor
svn path=/trunk/; revision=18845
2006-08-07 10:29:39 +00:00
Ronnie Sahlberg
5823354433 objectSid attribute contains a sid so decode it nively as a sid
svn path=/trunk/; revision=18844
2006-08-07 10:19:37 +00:00
Ronnie Sahlberg
2d5ec44674 add some more oid's
svn path=/trunk/; revision=18843
2006-08-06 14:31:58 +00:00
Ronnie Sahlberg
b446810939 the ldap values for supportedControl and supportedCapabilities is an oid in ascii format.
resolve it into a anme if possible and present it.




svn path=/trunk/; revision=18842
2006-08-06 14:04:07 +00:00
Ronnie Sahlberg
3ef9bcfa26 "objectGUID" should be dissected as a GUID
also change the name of one of the strings we keep around since it is more generic than just used for attributeassertions



svn path=/trunk/; revision=18841
2006-08-06 13:13:42 +00:00
Ronnie Sahlberg
db179bb768 config and makefile magic we need when we integrate kerberos for windows with the w32 build
disabled for now


svn path=/trunk/; revision=18838
2006-08-05 04:32:57 +00:00
Gerald Combs
4cd1774c69 ethereal -> wireshark.
svn path=/trunk/; revision=18836
2006-08-04 14:43:48 +00:00
Martin Mathieson
616a6a1509 Checked also needed here - remove wrong comment
svn path=/trunk/; revision=18835
2006-08-04 10:16:10 +00:00
Martin Mathieson
7d29d978ce There may be no icon data
svn path=/trunk/; revision=18834
2006-08-04 10:02:21 +00:00
Jaap Keuter
0431e78ccb From: Stephen Fisher
I was looking at the dissector I wrote recently, packet-exec.c, to remember 
how to handle conversations and I noticed a comment that isn't clear. 
It would throw someone off because it isn't how the dissector was finally written :).  

svn path=/trunk/; revision=18833
2006-08-04 05:54:38 +00:00
Ronnie Sahlberg
fe3114d00b check that itl is non-NULL to prevent a NULL pointer dereference that would crash the windows build but funnily enough not linux (since you can read from the null page on linux?)
svn path=/trunk/; revision=18832
2006-08-04 00:36:25 +00:00
Jaap Keuter
eaa71d78b3 Fix bug 1027: pinfo.iplen should contain option length as well
svn path=/trunk/; revision=18830
2006-08-03 20:24:24 +00:00
Martin Mathieson
6a6a108f5d Add an expert item to indicate unrecognised SIP headers. Useful for finding:
- encoding problems or use of exotic extensions in equipment
- headers missing from the SIP dissector

svn path=/trunk/; revision=18829
2006-08-03 14:51:45 +00:00
Anders Broman
6bdffa496e From Peter Johansson:
the supplied patch fixes a problem where the options value should really be used from the conversation found (using
conversation_lookup_hashtable(...) to create a new conversation based on the already stored conversation template (the CONVERSATION_TEMPLATE bit is set in the stored conversation) rather from the options argument passed to the function(s).

This solves a problem that otherwise shows itself where "DISSECTOR_ASSERT(!(conv->options & CONVERSATION_TEMPLATE) && "Use the conversation_create_from_template function when the CONVERSATION_TEMPLATE bit is set in the options mask");" fails sometimes.

svn path=/trunk/; revision=18825
2006-08-02 19:50:04 +00:00
Anders Broman
2554ddccb8 From Stephen Fisher:
This patch adds a new dissector for the daytime protocol (like the time
protocol, but the date and time is send as a text string).  This protocol and
dissector work s over TCP or UDP.

svn path=/trunk/; revision=18823
2006-08-02 17:13:22 +00:00
Anders Broman
4b12683547 From Stephen Fisher:
The time protocol (port 37) dissector (packet-time.c) currently only supports
UDP.  The protocol has an identical implementation over TCP as well.  This
patch adds support to the dissector for TCP time in addition to the UDP time
packets

svn path=/trunk/; revision=18822
2006-08-02 17:01:38 +00:00