Commit graph

3256 commits

Author SHA1 Message Date
Martin Mathieson
5de1a339c4 Fix some spelling errors 2023-12-21 16:37:45 +00:00
Balint Reczey
689ff45cfd tools: Switch to target UNRELEASED in make-version.py, too 2023-12-20 19:29:10 +00:00
John Thacker
29e56d0167 asn2wrs: Fix compilation without -L flag
Traceback (most recent call last):
  File "/home/johnthacker/wireshark/tools/asn2wrs.py", line 8196, in <module>
    eth_main()
  File "/home/johnthacker/wireshark/tools/asn2wrs.py", line 8167, in eth_main
    ectx.output.make_single_file(ectx.suppress_line)
                                 ^^^^^^^^^^^^^^^^^^
AttributeError: 'EthCtx' object has no attribute 'suppress_line'
2023-12-19 16:53:51 -05:00
Martin Mathieson
f2095c8027 Recurse into folders while checking URLs 2023-12-19 13:21:22 +00:00
Martin Mathieson
ed3b6e6b50 Check for some document URLs 2023-12-18 22:10:11 +00:00
Zoran Bošnjak
b8bad2c745 asterix: 'number' upstream change adjustment
Minor structure change in upstream asterix-specs repository.
2023-12-18 18:46:44 +00:00
Gerald Combs
ba2f53ef11 Windows: Upgrade libpcap to 1.10.4 2023-12-14 17:48:06 +00:00
João Valverde
7f32c90ab9 plugins: Add a codecs API level
Add a minimum and maximum API level. Backward-compatible changes to
the API only bump the maximum API level. Backward incompatible
changes bump the maximum API level and the mininum, to the
new (maximum) level.

This may allow codec plugins to continue working without recompilation,
possibly with reduced functionality.

The API level is only defined for codecs because it is a small
and easy to define API, and very stable.

Maybe we could do the same for wiretap (file type) plugins. For the
various epan plugin types it seems pointless and futile. I cannot
see a scenario where a new Wireshark minor release does not increase
the minimum API level.
2023-12-14 16:18:35 +00:00
Gerald Combs
ac524cff38 Windows: Upgrade GnuTLS to 3.8.2 2023-12-12 14:58:18 -08:00
Martin Mathieson
bfda80d230 check_typed_item_calls.py: Improve checks around items in bitmask calls 2023-12-08 09:20:02 +00:00
Martin Kaiser
70497ac5f8 check_tfs.py: ignore utf-8 encoding errors 2023-12-07 11:55:21 +00:00
Martin Mathieson
e17a22df89 Fix some spelling errors 2023-12-07 09:38:27 +00:00
Martin Mathieson
74f3dad37c Don't warn about rdp.flags.pkt being non-contigous 2023-12-06 19:13:16 +00:00
João Valverde
869728143d Remove plugin license check
This removes the license check introduce with commit 90b16b4092.

After discussion and criticism received on the mailing list
I now think this license requirement is too permissive on
one hand about GPL compatibility and on the other it can be
a significant inconvenience for users who do not wish to distribute
the modified work, and so in its current form the change did
not advance the project's goals or GPL compliance.
2023-12-05 20:27:48 +00:00
Martin Kaiser
1a33c02055 check_tfs.py: iterate through subdirs of epan/dissectors 2023-12-04 20:06:17 +00:00
João Valverde
60f1972fa3 plugins: Fill in short description field
Fill-in the short description field for plugins that was left as
a FIXME in commit 3b59ce90c31df5d77ddd4d08ad13cb0f0e818117.

We should add a similar field for extcap extensions and Lua scripts
eventually.
2023-12-03 23:20:39 +00:00
João Valverde
90b16b4092 Refactor plugin registration and add ABI/license check
Remove the boilerplate and multiple symbols required
to write and load a plugin and use a simpler
interface that is also much more featureful and
extensible.

This removes the major.minor ABI check in favor of an
ABI version number that is simpler and more flexible.

In practice our 3 separate ABI versions still increase
with each major.minor version number but this may change
in the future, particularly for codecs that have a much
narrower and stable codec API.

There is a new license compatibility check. Plugins
must declare if the use GPLv2 or later, or alternatively
an FSF compliant GPLv2 compatible license. Otherwise
Wireshark refuses to load the plugin. The SPDX ID is
just an ancillary field and not enforced currently.

Adds more metadata fields during plugin registration.
These are only used for display and debugging.

There is an extra API level number in the registration API
that is reserved for future use.
2023-12-03 23:20:39 +00:00
Martin Mathieson
64723c6fdc check_tfs.py: show more clearly how to use tfs i.s.o. value_string 2023-12-01 23:16:15 +00:00
Martin Mathieson
6f38651c3f Fix some spelling errors 2023-12-01 23:10:29 +00:00
John Thacker
2f3f879f90 manuf: Remove curly quotes, double angle brackets
Remove curly quotes and double angle bracket punctuation too.
For some reason this has to be done in a different regex substitution
or Python handles it incorrectly.

Also add Chengdu to the list of Chinese locations
2023-11-29 09:27:33 -05:00
John Thacker
7234ce727b manuf: Update make-manuf for a few more Chinese names
Remove the contents of fullwidth parenthesis for the same reason as
parenthesis.

Special case 杭州德澜科技有限公司(HangZhou Delan Technology Co.,Ltd)
where the item in the parenthesis is the English name.

Add Guangdong to the list of city names to remove at the start.
2023-11-29 13:34:49 +00:00
Martin Kaiser
c3048b3e3e check_tfs.py: use a set for the files to be checked 2023-11-28 11:23:31 +00:00
Jaap Keuter
55a1f8b602 BACapp: Update BACnet vendor ID's 2023-11-27 23:09:36 +00:00
Martin Kaiser
cbc2cd039d check_tfs.py: remove unnecessary wrapper 2023-11-26 20:56:10 +00:00
John Thacker
c3548e3005 manuf: Add back the special case for all zeroes
These words from Jörg Mayer are as true today as they were
21 years ago in 49a2f32336,
"I still have yet to see a case when a MAC address starting
with 0:0:0 actually means Xerox", but there are lots of cases
where all zero OUIs, MAC-48s, EUI-64s, etc are used to mean
null.

[skip ci]
2023-11-21 12:31:18 +00:00
Stig Bjørlykke
2a9bc63325 Remove init of proto variables
Remove init of proto, header field, expert info and subtree variables.
This will reduces the binary size by approximate 1266320 bytes due to
using .bss to zero-initialize the fields.

The conversion is done using the tools/convert-proto-init.py script.
2023-11-20 08:20:54 +01:00
Stig Bjørlykke
e8e16400d8 tools: Improve match for proto variables
Improve match for proto, hf, ett and ei variables. Add match for
non-static definitions, variables in comments and various spaces.

Remove the proto and field check conversions.
Assert in proto_item_add_subtree() when idx is 0.
2023-11-20 07:02:09 +00:00
Martin Mathieson
fe23a8bdef More item fussing 2023-11-18 22:26:10 +00:00
John Thacker
958131ca10 docs: Alter FollowStreamSection anchor
According to the Asciidoctor docs, we can assign multiple anchors
to a section using this method, which still uses the modern shorthand
syntax for the main anchor (the one that's been used for the last five
years). We have to use the double square brackets for the additional
anchor, though.

    https://docs.asciidoctor.org/asciidoc/latest/attributes/id/#add-additional-anchors-to-a-section

Related to #17982
2023-11-18 09:29:44 -05:00
Martin Mathieson
c4b97d1f52 Start to check range_strings 2023-11-08 03:25:47 +00:00
Martin Mathieson
5233a55fdf A few more item warning fixes 2023-11-07 22:40:48 +00:00
Martin Mathieson
d48e0a75cc Fix (or disable) more dissector item warnings 2023-11-14 20:51:12 +00:00
Gerald Combs
6ce97e418b Docs: Move attributes.adoc to the doc directory 2023-11-14 06:07:53 +00:00
Martin Mathieson
8ca602f6e7 Fix (or ignore) more consecutive item filters 2023-11-07 18:34:11 +00:00
Gerald Combs
58b3d0163f Windows: Update libsmi
Switch to a libsmi build with native Windows path and directory
separators.

Fixes #19476
2023-11-12 12:51:19 -08:00
Gerald Combs
a5e0be51df Windows: Upgrade Minizip to 1.3 2023-11-10 21:00:30 +00:00
Gerald Combs
cefcf0ac02 Windows: Upgrade c-ares to 1.19.1 2023-11-10 19:03:09 +00:00
Martin Mathieson
d139a97067 Fix some spelling errors 2023-11-10 09:28:10 +00:00
Stig Bjørlykke
309a47997e tools: Initialize static proto values
Update tools to not initialize static proto values to -1.
This will update dissectors for asterix, ncp2222 and x11.
2023-11-07 14:29:11 +00:00
Guy Harris
f821b03d5e macos-setup: work around problem with the Xcode 15 linker.
An error is produced when building GMP with Xcode 15, which has a new
version of the linker.  Falling back on the old version, with the -ld64
flag, fixes this.

[skip ci]
2023-11-05 10:35:21 -08:00
Martin Mathieson
fa3836a57c Detect more copy/pasted filters - looking further back 2023-11-03 15:28:57 +00:00
Martin Mathieson
82015a0a88 LDAP: val_to_str() format string has double % 2023-11-03 20:24:44 +00:00
Stig Bjørlykke
2cac1ca9e0 asn2wrs: Update to not initialize static proto values 2023-11-02 22:56:41 +00:00
Stig Bjørlykke
7d0b92aa0e Initialize static proto values to 0
Add a script to initialize static proto values to 0 instead of -1.
This will save ~1MB static init code.
2023-11-02 15:39:49 +00:00
John Thacker
520f0d8e26 Qt: Enforce Minimum Qt version 5.11
We already strongly recommend Qt version 5.12 and enforce 5.10.
Commit 06cd84a6e9 said "[a]lthough
build support for 5.10 and 5.11 is not being removed at this point,
it might be for 4.x at a later time."

Move to enforcing 5.11, and update macos-setup for that as well.
Remove the QT_VERSION_CHECKs for 5.10 and 5.11 (except in
qcustomplot.)

Hold off on enforcing 5.12 for now, because there isn't any code
that needs 5.12 or greater (there are two places for a workaround
for Qt 5.12.0 through 5.12.5), and because Debian Buster is on
Qt 5.11.3. There are not any known supported OS distributions on
Qt 5.10.
2023-11-02 15:28:01 +00:00
Guy Harris
af91d78a54 macos-setup: don't build GLib tests, to work around a bug.
Somebody closed the bug, and may have been the person who claim it was
"some issue in a broken build system that did not auto-create the
missing header file", but if Meson+Ninja doesn't handle it, either it's
a problem with their Meson configuration, a problem with Meson, or a
problem with Ninja, so either they should fix it or they should report
the problem with the Meson or Ninja maintainers.

Maybe I'll look into why it's failing, and report the bug and perhaps
fix to some Directly Responsible Developers, at some point, but I have
other things on my plate, and another comment in that bug said disabling
the test build was sufficient, so....

[skip ci]
2023-11-01 15:35:31 -07:00
Guy Harris
e9c7326d9c macos-setup: update to zstd 1.5.5. [skip ci]
It has a number of performance improvements and, even more important...

...it appears to let our settings for the minimum version to which code
can be deployed on macOS (and for the SDK to use) pass through to the
entire build process, unlike 1.4.5, which somehow seems to have
prevented that, which is why #19405 kept popping up.

Thanks to @tuexen for finding out that 1.5.5 seemed to finally get a
build of the libzstd lbirary that doesn't use Exciting New Run-Time
Linker Features that aren't supported by the run-time linker on older
versions of macOS for which we support Wireshark.
2023-11-01 20:38:54 +00:00
Dr. Lars Völker
276fb25e61 ISOBUS: Remove incomplete warning and cleanup
- Adding reserved for incomplete dissections
- more consistent formatting
- adding sorting to make-isobus.py in case csv are not sorted in future
- adding macros to packet-isobus-parameters.h
2023-11-01 09:54:40 +00:00
Dr. Lars Völker
1dd58a0559 ISOBUS: change to value_string_ext for faster lookup 2023-10-31 14:42:31 +00:00
João Valverde
96f0f487d7 IANA IP Registry: More API refactoring
Make the API return a single struct type. Use a union
to store the IP address. Make the IPv4 functions take
an IPv4 address as a host byte-order integer.
2023-10-31 08:49:55 +00:00