Commit Graph

126 Commits

Author SHA1 Message Date
Guy Harris 9f925a618f The trial period is arguably over - no need for packet-ansi_map.c to
have its own #if 0'ed out definition of dgt_set_t.

svn path=/trunk/; revision=42020
2012-04-11 00:35:53 +00:00
Guy Harris dd4cb8424b Get rid of redundant Dgt1_9_bcd digit set - passing NULL as the digit
set uses tvb_bcd_dig_to_ep_str()'s default digit set, which is the same.

Clean up white space (no 4-space tab characters).

svn path=/trunk/; revision=42019
2012-04-11 00:34:13 +00:00
Stig Bjørlykke b71ce5d268 Do not assign a value to itself.
svn path=/trunk/; revision=41482
2012-03-11 14:03:13 +00:00
Alexis La Goutte 95cc98f92c Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
svn path=/trunk/; revision=41211
2012-02-27 16:50:27 +00:00
Chris Maynard e799efeed9 Fix some duplicate display filter names.
svn path=/trunk/; revision=40568
2012-01-18 21:07:53 +00:00
Anders Broman faea2d624c Get rid of Warnings.
svn path=/trunk/; revision=39951
2011-11-19 22:42:51 +00:00
Anders Broman 1b7b2dd067 Use tvb_bcd_dig_to_ep_str().
svn path=/trunk/; revision=39929
2011-11-18 07:01:10 +00:00
Bill Meier 794757ae8f For proto_tree_add_item(..., proto_xxx, ...)use ENC_NA as the encoding arg.
Also: remove trailing whitespace for a number of files.

svn path=/trunk/; revision=39503
2011-10-21 02:10:19 +00:00
Bill Meier a6e35df202 Do some more conversions of proto_tree_add_item() 'encoding' arg
(previously missed).

svn path=/trunk/; revision=39451
2011-10-18 00:39:20 +00:00
Bill Meier 31abdcb584 Convert asn1 template files proto_tree_add_item() 'encoding' arg for field types FT_STRING as follows:
1. If there's no character encoding (ENC_ASCII, ...) specified
    then use ENC_ASCII.
 2. Always use ENC_NA
    (replacing any existing True/1/FALSE/0
    /ENC_BIG_ENDIAN/ENC_LITTLE_ENDIAN).

svn path=/trunk/; revision=39428
2011-10-15 19:48:19 +00:00
Bill Meier 24cf0aad06 Update generated ASN1 *.[hc] files after recent work done by Jeff Morriss;
The only change in each file is in a comment showing the asn2wrs cmd used to build that file.

svn path=/trunk/; revision=39427
2011-10-15 19:27:27 +00:00
Bill Meier 6142dd287b Convert 'encoding' parameter of certain proto_tree_add_item() calls in asn1/*:
Specifically:  Replace FALSE|0 and TRUE|1 by ENC_BIG_ENDIAN|ENC_LITTLE_ENDIAN as
  the encoding parameter for proto_tree_add_item() calls which directly reference
  an item in hf[] which has a type of:
     FT_BOOLEAN
     FT_IPv4
     FT_EUI64
     FT_GUID
     FT_UINT_STRING

 Also: For type FT_IPv6 use ENC_NA. (This was missed in SVN #39260)

svn path=/trunk/; revision=39332
2011-10-10 01:38:20 +00:00
Bill Meier e2996ceabe Convert 'encoding' parameter of certain proto_tree_add_item() calls in asn1 dissectors:
Specifically:  Replace FALSE|0 and TRUE|1 by ENC_BIG_ENDIAN|ENC_LITTLE_ENDIAN as
 the encoding parameter for proto_tree_add_item() calls which directly reference
 an item in hf[] which has a type of:
    FT_UINT8
    FT_UINT16
    FT_UINT24
    FT_UINT32
    FT_UINT64
    FT_INT8
    FT_INT16
    FT_INT24
    FT_INT32
    FT_INT64
    FT_FLOAT
    FT_DOUBLE


svn path=/trunk/; revision=39294
2011-10-06 16:50:13 +00:00
Anders Broman 7439bba9dc Try to do a more syntactically correct import.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6150

svn path=/trunk/; revision=38159
2011-07-21 22:46:07 +00:00
Jeff Morriss 80c1ef3811 Fix a couple (value) mistakes in value_strings. Found by Martin's patch on the -dev list.
svn path=/trunk/; revision=37259
2011-05-18 20:06:17 +00:00
Gerald Combs 793d683575 Regenerate the ANSI MAP, LDAP, and TETRA dissectors so that Coverity can
locate their template files.

svn path=/trunk/; revision=36569
2011-04-11 23:07:53 +00:00
Anders Broman 55f45d5266 Add a missing IE found in trace from https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5637
svn path=/trunk/; revision=35842
2011-02-07 17:43:26 +00:00
Anders Broman 01ef9f73ef Remove debug printouts.
svn path=/trunk/; revision=35834
2011-02-05 14:37:52 +00:00
Anders Broman b723ccb30c Introduce preferences to set the strictness of Invoke/response
tracking.

svn path=/trunk/; revision=35822
2011-02-04 16:12:59 +00:00
Anders Broman b80813a45c From Porus Mehta:
Corrections to ANSI MAP ASN.1 specifications.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5584

svn path=/trunk/; revision=35556
2011-01-16 18:36:17 +00:00
Anders Broman 735709bee6 Add tvb_bcd_dig_to_ep_str()
/*
 * Given a tvbuff, an offset into the tvbuff, and a length that starts
 * at that offset (which may be -1 for "all the way to the end of the
 * tvbuff"), fetch BCD encoded digits from a tvbuff starting from either 
 * the low or high half byte, formating the digits according to an input digit set, 
 * if NUll a default digit set of 0-9 returning "?" for overdecadic digits will be used.
 * A pointer to the EP allocated string will be returned.
 * Note a tvbuff content of 0xf is considered a 'filler' and will end the conversion.
 */

svn path=/trunk/; revision=35286
2010-12-28 12:36:26 +00:00
Guy Harris a8bc4a0d13 Rename the routines that handle dissector tables with unsigned integer
keys to have _uint in their names, to match the routines that handle
dissector tables with string keys.  (Using _port can confuse people into
thinking they're intended solely for use with TCP/UDP/etc. ports when,
in fact, they work better for things such as Ethernet types, where the
binding of particular values to particular protocols are a lot
stronger.)

svn path=/trunk/; revision=35224
2010-12-20 05:35:29 +00:00
Bill Meier 491f05b16e Use value_string_ext fcns to access several value_string arrays;
Minor whitespace cleanup.

svn path=/trunk/; revision=34900
2010-11-16 15:20:33 +00:00
Jeff Morriss a0c858efcd Add a little more code to avoid not-very-useful blurbs:
- Change spaces in the name to underscores before comparing it to the blurb.
  - Check if the type simply as T_ prepended to the name.
  - Don't put in a blurb of "NULL".

and regenerate the dissectors.

svn path=/trunk/; revision=32748
2010-05-11 03:53:31 +00:00
Jeff Morriss 8f210cf4e0 Regenerate a few of the ASN.1 dissectors
svn path=/trunk/; revision=32742
2010-05-11 02:13:26 +00:00
Bill Meier 9ade30a7b1 #include <string.h> and/or #include <stdio.h> not needed.
svn path=/trunk/; revision=32417
2010-04-07 16:54:29 +00:00
Bill Meier f8b92f8d0b #include <stdio.h> not needed.
svn path=/trunk/; revision=32405
2010-04-06 17:01:14 +00:00
Anders Broman 5c2af3980f Fix Tag value wrong in ansi_map.asn file for ServiceId in ServiceRequest message.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4637

svn path=/trunk/; revision=32354
2010-04-01 20:07:17 +00:00
Guy Harris b395a98305 Squelch a bunch of compiler warnings.
svn path=/trunk/; revision=31961
2010-02-23 04:35:23 +00:00
Anders Broman c4dd31cd87 From Didier Gautheron:
col_clear.diff 
Remove calls to col_clear :
- called twice.
- before functions which also clear the column
- by replacing col_clear + col_append_xxx with col_add_xxx
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4394

svn path=/trunk/; revision=31517
2010-01-13 20:25:10 +00:00
Anders Broman 4d0c391d5d From Michael Lum:
Fixes for E911 mobile positioning capability and Handoff Back2.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4373

svn path=/trunk/; revision=31462
2010-01-07 20:27:38 +00:00
Anders Broman 1661212158 Dissect NumberPortabilityRequest return result.
svn path=/trunk/; revision=31306
2009-12-18 06:26:20 +00:00
Anders Broman b1f6df534a From Michael Lum:
The attached patch calls the tap to allow the number
of each type of message to be counted.

The patch does not fix the "size"/number of octets
column that is all zeroes.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4253

svn path=/trunk/; revision=31027
2009-11-19 21:44:28 +00:00
Anders Broman 4a2c426b34 From Michael Lum:
MEID missing from some messages.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4252

svn path=/trunk/; revision=31025
2009-11-19 21:12:58 +00:00
Anders Broman 0d6239a976 Mobile On Channel carries no data.
svn path=/trunk/; revision=30998
2009-11-17 20:48:04 +00:00
Jeff Morriss 7a91a5b053 Don't call check_col(). Add a space at the end of each COL_INFO entry to make the column more readable when SCTP bundles multiple messages together.
svn path=/trunk/; revision=29922
2009-09-15 15:16:15 +00:00
Kovarththanan Rajaratnam 8c48c6835f Rename address_to_str() to ep_address_to_str() because:
1) This indicates that the string has ephemeral lifetime
2) More consistent with its existing seasonal counterpart, se_address_to_str().

svn path=/trunk/; revision=29747
2009-09-06 14:25:47 +00:00
Kovarththanan Rajaratnam 6110a96f68 Don't guard col_set_str (COL_INFO/COL_PROTOCOL) with col_check
svn path=/trunk/; revision=29345
2009-08-09 07:59:51 +00:00
Stig Bjørlykke 9733aadcfe Re-generate asn1 dissectors after hf_register_info cleanup.
svn path=/trunk/; revision=28848
2009-06-26 03:59:01 +00:00
Stig Bjørlykke b228488bc0 From Kovarththanan Rajaratnam via bug 3548:
(1) Trailing/leading spaces are removed from 'name's/'blurb's
(2) Duplicate 'blurb's are replaced with NULL
(3) Empty ("") 'blurb's are replaced with NULL
(4) BASE_NONE, NULL, 0x0 are used for 'display', 'strings' and 'bitmask' fields
    for FT_NONE, FT_BYTES, FT_IPv4, FT_IPv6, FT_ABSOLUTE_TIME, FT_RELATIVE_TIME,
    FT_PROTOCOL, FT_STRING and FT_STRINGZ field types
(5) Only allow non-zero value for 'display' if 'bitmask' is non-zero

svn path=/trunk/; revision=28770
2009-06-18 21:30:42 +00:00
Stig Bjørlykke c47e788c94 Regenerate all asn2wrs generated dissectors.
svn path=/trunk/; revision=28379
2009-05-16 22:07:03 +00:00
Anders Broman 27026d0eb1 Add dissection of:
- SMSDeliveryPointToPointAck
- InterSystemSMSDeliveryPointToPoint
- QualificationRequest2

svn path=/trunk/; revision=27991
2009-04-08 06:28:34 +00:00
Anders Broman 87c4184e91 According to the section 2.4 of the spec.
http://www.3gpp2.org/Public_html/specs/X.S0004-540-E_v2.0_070723.pdf

mandatory parameters for the message Authentication Failure Report.

1. Electronic serial number
2. MSID(i.e MIN/IMSI)
3.Report Type
4.System Access Type
5.System Capabilities(Serving)

svn path=/trunk/; revision=27923
2009-04-01 16:21:00 +00:00
Anders Broman 44c3d1b3ad In informationDirective use MSID instead of mobileIdentificationNumber.
svn path=/trunk/; revision=27858
2009-03-27 06:59:15 +00:00
Anders Broman 84bea61368 From Michael Lum:
ANSI MAP FeatureRequest update
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3349

svn path=/trunk/; revision=27836
2009-03-23 21:24:04 +00:00
Anders Broman aa4ddb790d Fix: The AuthDir invoke is missing optional tags for a couple of parameters.
and FeatReq invoke fixes.

svn path=/trunk/; revision=27831
2009-03-23 17:30:38 +00:00
Bill Meier 0f9f5caf9d As suggested by Jakub Zawadzki: g_free() is NULL safe, so we don't need check against it.
Also (from me): Clean up spacing

svn path=/trunk/; revision=27727
2009-03-15 15:40:55 +00:00
Anders Broman dd90adfe90 From Michael Lum:
More dissection of IOS parameters in ANSI MAP IOS Invoke/Response Data
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3323

svn path=/trunk/; revision=27695
2009-03-11 06:27:40 +00:00
Anders Broman 735764e6da From Michael Lum:
ANSI MAP fix for missing MEID/MSC ID number in RegNot
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3255

svn path=/trunk/; revision=27469
2009-02-17 05:54:04 +00:00
Bill Meier 35e5fa9bc1 #include <epan/conversation.h> and/or #include <epan/emem.h> not req'd ...
svn path=/trunk/; revision=27390
2009-02-07 14:33:47 +00:00