97146be883
The variable is assigned values twice successively found by PVS Studio (V519)
...
Change-Id: I063b0ee2dd4ed948f889c33ab458df20079a64ff
Reviewed-on: https://code.wireshark.org/review/12370
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-12-13 10:35:36 +00:00
c3025544b6
Misc minor issues caught by cppcheck
...
All trivial (unused variables, duplicate `break`s, etc).
Change-Id: Idbfffae4f6c0b0119a90ae5849de2ed7a1180c9b
Reviewed-on: https://code.wireshark.org/review/11886
Petri-Dish: Evan Huus <eapache@gmail.com>
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Evan Huus <eapache@gmail.com>
2015-11-17 04:18:37 +00:00
43f09e67b4
Remove unneeded includes from ui folder
...
Change-Id: Ifd1eebff9080cd3867e44e4dcb2d2681370ed60a
Reviewed-on: https://code.wireshark.org/review/6128
Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
2015-01-01 23:11:10 +00:00
4ac0438e46
In Visual Studio builds, enable the L4 warning
...
4189: Local variable is initialized but not referenced
Fix some variables found by this
Change-Id: Icc13def5413f1fe885ec25e659462c8906a6cfa0
Reviewed-on: https://code.wireshark.org/review/3748
Reviewed-by: Graham Bloice <graham.bloice@trihedral.com>
Petri-Dish: Graham Bloice <graham.bloice@trihedral.com>
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Evan Huus <eapache@gmail.com>
2014-08-20 19:25:28 +00:00
c0b0a11e4e
(Pedantic): set editor modelines tab-width & etc to 8; Also: fix some indentation in packet-sip.c
...
Change-Id: I623fc5e4c1247dbe5e15f0f33270f4f0994268ab
Reviewed-on: https://code.wireshark.org/review/943
Reviewed-by: Bill Meier <wmeier@newsguy.com>
Tested-by: Bill Meier <wmeier@newsguy.com>
2014-04-03 15:31:56 +00:00
296591399f
Remove all $Id$ from top of file
...
(Using sed : sed -i '/^ \* \$Id\$/,+1 d')
Fix manually some typo (in export_object_dicom.c and crc16-plain.c)
Change-Id: I4c1ae68d1c4afeace8cb195b53c715cf9e1227a8
Reviewed-on: https://code.wireshark.org/review/497
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-03-04 14:27:33 +00:00
093ace5c24
Fix Visual Studio Code Analysis warning C6011: Dereferencing NULL pointer 'returnedDevmode'
...
svn path=/trunk/; revision=54051
2013-12-13 18:25:06 +00:00
f216d4e440
When a line of text wraps to the next line, the character that caused the line to wrap was not being printed.
...
#BACKPORT(1.10,1.8)
svn path=/trunk/; revision=52221
2013-09-26 17:27:53 +00:00
2c71f23d1e
Make use of text metrics and devmode data to properly format a page for printing. Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7543
...
#BACKPORT(1.10,1.8)
svn path=/trunk/; revision=49946
2013-06-15 12:57:32 +00:00
ea888f9113
Squelch some more discarding-qualifiers warnings.
...
svn path=/trunk/; revision=46771
2012-12-26 11:27:21 +00:00
bf81b42e1e
Update Free Software Foundation address.
...
(COPYING will be updated in next commit)
svn path=/trunk/; revision=43536
2012-06-28 22:56:06 +00:00
0db1b9ae17
Make the win32 directory a subdirectory of the ui directory.
...
svn path=/trunk/; revision=40531
2012-01-16 01:26:46 +00:00
Alexis La Goutte