Commit Graph

42567 Commits

Author SHA1 Message Date
Anders Broman 4b6ad1d9d7 From Michael Mann:
length check "heuristics" for FF dissector (UDP + TCP)

"Fix" WTP+WSP packets incorrectly dissected as Foundation FieldBus packets https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4822

svn path=/trunk/; revision=44722
2012-09-01 11:37:42 +00:00
Anders Broman c44a7fba0d From Litao Gao:
Implementation of IRemoteSCMActivator::RemoteCreateInstance and some minor bug fix

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7673

svn path=/trunk/; revision=44721
2012-09-01 11:22:29 +00:00
Anders Broman 607d32b00d From David Ward: OSPF dissector: add filters for v3 LS Type field. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7684
svn path=/trunk/; revision=44720
2012-09-01 07:42:07 +00:00
Evan Huus 2f5b01c68a Fix part of build on latest GCC.
svn path=/trunk/; revision=44719
2012-09-01 02:56:32 +00:00
Gerald Combs 64346553f9 Don't try to read from our input pipe on Windows after we're done capturing.
svn path=/trunk/; revision=44718
2012-08-31 23:37:10 +00:00
Gerald Combs 3751353a70 Connect and disconnect our signals correctly.
Capture still doesn't work correctly under Windows.

svn path=/trunk/; revision=44717
2012-08-31 23:18:45 +00:00
Gerald Combs cf4ac2931e Fix compilation on Windows.
The moc man page says "The moc does not expand #include or #define,
it simply skips any preprocessor directives it encounters." This means
our signals and slots have to exist everywhere, even if they're empty
on some platforms.

Remove some duplicate definitions.

svn path=/trunk/; revision=44716
2012-08-31 23:13:43 +00:00
Gerald Combs d6ce6168bb Initialize a variable so that we can quit. Remove some debugging
statements.

svn path=/trunk/; revision=44715
2012-08-31 22:50:44 +00:00
Gerald Combs 5c715fcc19 It ain't Wireshark unless we can capture.
Implement basic capture start and stop. Add a lot of menu items and
enable and disable them when appropriate. Rename a few variables.

Next step: Let the user select an interface (we just use the default for
now).

svn path=/trunk/; revision=44714
2012-08-31 22:25:51 +00:00
Alexis La Goutte 94cbe0ce2c Add Q&A icon for qtshark
svn path=/trunk/; revision=44713
2012-08-31 12:11:44 +00:00
Alexis La Goutte f332f4b78d Add icon for Q&A (Ask)
The same (fav)icon of Ask Website

svn path=/trunk/; revision=44712
2012-08-31 12:04:35 +00:00
Anders Broman de809cc9e3 From Chris Elston:
Added L2TPv3 control message authentication checking

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7680

svn path=/trunk/; revision=44711
2012-08-31 09:39:52 +00:00
Anders Broman 1a8065acdc From Chris Elston:
Split md5_hmac for incremental use 

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7680

svn path=/trunk/; revision=44710
2012-08-31 09:29:34 +00:00
Anders Broman f32baca6e1 From Chris Elston:
Split sha1_hmac for incremental use.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7680

svn path=/trunk/; revision=44709
2012-08-31 09:25:36 +00:00
Alexis La Goutte 070ccb3d5a File => Open (Ctrl+O) on Qtshark (broke with last change...)
Use Qt:Autoconnect SLOT/Signal

svn path=/trunk/; revision=44708
2012-08-31 07:56:24 +00:00
Anders Broman 9d6e58a52b From Cal Turney: Fix Performance regression in tshark -z io,stat https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7674
svn path=/trunk/; revision=44707
2012-08-31 07:30:01 +00:00
Chris Maynard 3e976d69d1 tools/checkhf.pl reported 3 unused hf entries. Commented them out for now.
BTW:
tools/checkAPIs.pl reports 109 useless add_text()'s vs. 346 add_<something else>() calls (31.50%), under 50% threshhold, but not really that great.

tools/checkfiltername.pl reports 42 errors.

svn path=/trunk/; revision=44706
2012-08-30 20:36:53 +00:00
Jeff Morriss 3268b5b215 Remove trailing space in some hf names.
Add some hf names (some entries had only a space for a name).
Remove non-ASCII chars and C++/C99-style comments.

svn path=/trunk/; revision=44705
2012-08-30 20:22:09 +00:00
Pascal Quantin fc83e532db Display hf_dns_rr_opt_client_addr as FT_BYTES
svn path=/trunk/; revision=44704
2012-08-30 19:13:38 +00:00
Anders Broman e94d8a0b7e Add Japanese ISUP variant(not all IE's)
IE dissection code from Brian Mceniery.

svn path=/trunk/; revision=44703
2012-08-30 18:40:49 +00:00
Alexis La Goutte a09f80e8be From David Drysdale via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7552
Add support for EDNS0 option from draft-vandergaast-edns-client-subnet-01

From me
* use/prefer proto_tree_add_item
* use switch() for optcode (may be there is other optcode later...)

svn path=/trunk/; revision=44702
2012-08-30 17:03:50 +00:00
Chris Maynard 733baac21e Fix Session ID parsing. Patch from Fransesco Fondelli via bug 6881.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6881

svn path=/trunk/; revision=44701
2012-08-30 15:23:54 +00:00
Pascal Quantin 0e79405e0d Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7679:
Do not try to set IR header length when the profile is unknown

svn path=/trunk/; revision=44700
2012-08-30 12:08:53 +00:00
Evan Huus 1ccee24ec5 Fix uninitialized variable as caught by cppcheck.
svn path=/trunk/; revision=44699
2012-08-29 22:53:21 +00:00
Evan Huus baf111a23c Add casts to fix compilation with GCC.
Remove * from gconstpointers, they are already pointer types.
Add modelines to packet.c and clean up indentation a bit.

svn path=/trunk/; revision=44698
2012-08-29 22:19:29 +00:00
Jakub Zawadzki 2ec7c89c33 Fix memleak.
svn path=/trunk/; revision=44697
2012-08-29 22:14:55 +00:00
Michael Mann e5e09f7016 Fix Bug 7348 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7348)
svn path=/trunk/; revision=44696
2012-08-29 21:23:07 +00:00
Chris Maynard b840ba44b4 Trivial typo fix and duplicate word removal.
svn path=/trunk/; revision=44695
2012-08-29 17:05:38 +00:00
Chris Maynard cc3c9ba3e5 Allow wpa-psk decryption keys to be successfully entered.
Problems reported on ask.wireshark.org here:
1) http://ask.wireshark.org/questions/13951/invalid-key-format-wireshark-182
2) http://ask.wireshark.org/questions/13688/error-updating-record-invalid-key-format

#BACKPORT (to 1.8)

svn path=/trunk/; revision=44694
2012-08-29 16:15:01 +00:00
Guy Harris d0f32eea23 At least with the version of Xcode that comes with Leopard,
/usr/include/ffi/fficonfig.h doesn't define MACOSX, which causes the
build of GLib to fail.  If we don't find "#define.*MACOSX" in
/usr/include/ffi/fficonfig.h, explictly define it.

svn path=/trunk/; revision=44693
2012-08-29 10:31:29 +00:00
Pascal Quantin a5c0d49ac2 Remove useless include (GeoIP initialization was removed from epan_init() in r43604)
svn path=/trunk/; revision=44692
2012-08-28 15:14:30 +00:00
Jakub Zawadzki 0e382b6668 Yet another case of bug #7316 (r42989) and bug #7668 (r44688)
Use correct field type for ccp.opt.oui

svn path=/trunk/; revision=44689
2012-08-28 09:10:34 +00:00
Jakub Zawadzki d35ef03b15 Fix bug #7668
Use correct field type for lcp.opt.oui

svn path=/trunk/; revision=44688
2012-08-28 08:44:41 +00:00
Evan Huus cb5a320d22 Fix a dead store and a few duplicate 'break' statements as caught by
clang and cppcheck.

svn path=/trunk/; revision=44687
2012-08-28 02:08:42 +00:00
Evan Huus f3ca6e55ef Remove variadic macro that accidentally made it in a while back.
svn path=/trunk/; revision=44686
2012-08-28 02:01:25 +00:00
Bill Meier 99173bf797 Fix 2 memory leaks;
Essentially: 'fid' & 'fragment' hash tables can be global (i.e., need not be 'per call')
               thus removing g_malloc'd storage never freed because it was pointed to in
               se_alloc'd structs.

  Fixes Bug #4134: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4134

  Also: fix a compile error when compiling with '#define DEBUG_DESEGMENT'

svn path=/trunk/; revision=44685
2012-08-27 16:17:38 +00:00
Pascal Quantin 74a43c3ada Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7622 :
Fix dissection of a few TDS fields (line number in ERR and MSG token, user type in RESULTS token, row count in DONE token) when the TDS version is >= 7.2.
Add a mechanism to memorize the TDS 7.X version in the conversation based on the TDS version found in LOGIN ACK token. This version is used for dissection when a TDS version is not set in preferences (TDS protocol type set to "not specified").

svn path=/trunk/; revision=44684
2012-08-27 11:47:37 +00:00
Jörg Mayer df49549abf Infrastructure for tcp decoding - nothing done to actually
decode the contents

svn path=/trunk/; revision=44683
2012-08-27 07:46:23 +00:00
Bill Meier cbd2a8ff25 Fix two minor memory leaks.
svn path=/trunk/; revision=44682
2012-08-26 23:44:25 +00:00
Bill Meier 89c5e9796f Fix 'Warn Dissector bug, protocol IAX2, in packet 62: proto.c:4406: failed assertion "fixed_item->parent == tree"'
svn path=/trunk/; revision=44681
2012-08-26 23:24:27 +00:00
Anders Broman 2aa9312c14 From Ilarion Ishkulov Multisegment PDUs are not reassembled properly with TCP dissector https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7544
svn path=/trunk/; revision=44680
2012-08-26 16:39:11 +00:00
Gerald Combs d0c229641f [Automatic manuf, services and enterprise-numbers update for 2012-08-26]
svn path=/trunk/; revision=44676
2012-08-26 14:03:31 +00:00
Jörg Mayer 15ee8b256a Extend a comment.
svn path=/trunk/; revision=44675
2012-08-26 03:17:53 +00:00
Pascal Quantin 1c76cb5fef From Sylvain Munaut via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7664 :
packet-gmr1_bcch: Add guards in the SI1/2 choice of segment

Although the CSN1 dissector itself will just stop if there is
no matching segment, it will leave the choice field uninitizalized
and so when we use it to fill some other text, it crashes ...

To protect against that, we put a last choice entry that will always
match. As a bonus, it triggers an explicit error in CSN so you
know something is wrong.

svn path=/trunk/; revision=44674
2012-08-25 21:31:29 +00:00
Pascal Quantin f783da2d6d From Sylvain Munaut via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7664 :
packet-gmr1_bcch: Whitespaces fixes

svn path=/trunk/; revision=44673
2012-08-25 21:19:47 +00:00
Pascal Quantin 6c12a7ffdc From Sylvain Munaut via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7664 :
packet-gmr1_rr: Add support for "Assignment Command 1" messages

svn path=/trunk/; revision=44672
2012-08-25 21:16:08 +00:00
Pascal Quantin 88911f9102 From Sylvain Munaut via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7664 :
packet-gsmtap: Call GMR-1 RACH dissector when appropriate

svn path=/trunk/; revision=44671
2012-08-25 21:09:49 +00:00
Pascal Quantin cd1ceaa04a From Sylvain Munaut via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7664 :
Add GMR-1 RACH dissection

svn path=/trunk/; revision=44670
2012-08-25 21:04:48 +00:00
Evan Huus 5e4108c347 Have CMake also consider the include path "lua5.2" (note the dot),
since that is where it can be found on recent Ubuntus, and without it
you get a mix of 5.1 includes and 5.2 libraries, which breaks the build.

svn path=/trunk/; revision=44669
2012-08-25 19:12:03 +00:00
Pascal Quantin 502b9b06c5 Update protocol name to match the changes done in r44661
svn path=/trunk/; revision=44668
2012-08-25 13:54:39 +00:00