osmocom/wireshark
14
0
Fork 1
Code Issues Pull requests Projects Releases Wiki Activity
34874 commits 26 branches 0 tags 795 MiB
Commit graph

11592 commits

Author SHA1 Message Date
Stephen Fisher
59a5ab8788 Enhancement bug #5796: Add Atheros vendor specific 802.11 IE parsing 
svn path=/trunk/; revision=36502
 2011-04-06 19:57:39 +00:00
Anders Broman
cd8af5a050 Add RoHC to the ethertypes. 
svn path=/trunk/; revision=36499
 2011-04-06 18:48:07 +00:00
Anders Broman
2251b8d331 From Johan Wåhl: 
Add dissection of feature list flags.

svn path=/trunk/; revision=36497
 2011-04-06 15:01:42 +00:00
Bill Meier
964690903f Use the correct handle when registering "media_type" "application/vnd.3gpp2.sms": Coverity 835. 
svn path=/trunk/; revision=36496
 2011-04-06 12:19:38 +00:00
Stig Bjørlykke
1fd17eb0d9 Fixed blurb for BER Error. 
svn path=/trunk/; revision=36495
 2011-04-06 09:59:21 +00:00
Stig Bjørlykke
3a1673c04c Made "BER Error" filterable. 
svn path=/trunk/; revision=36494
 2011-04-06 08:52:42 +00:00
Anders Broman
c039f9f8a8 Add a comment 
svn path=/trunk/; revision=36490
 2011-04-06 06:24:19 +00:00
Tomas Kukosa
4e8c772d11 RFC5806 Diversion header 
svn path=/trunk/; revision=36489
 2011-04-06 06:20:50 +00:00
Anders Broman
cb0e7f80da Missing decoding for CalledPartyBCD number in CAMEL 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5788

svn path=/trunk/; revision=36488
 2011-04-06 06:20:32 +00:00
Stephen Fisher
250aa8810f Fix Coverity 1062: UNUSED_VALUE 
svn path=/trunk/; revision=36486
 2011-04-06 00:07:52 +00:00
Bill Meier
982decd6b2 Set the correct properties .... 
svn path=/trunk/; revision=36485
 2011-04-05 23:26:56 +00:00
Chris Maynard
595e5e1c1d Add ICMP tap support, and add a tshark tap to measure such things as: 
* Number of ICMP echo requests, replies, lost replies and percent loss.
  * Min, Max, Average SRT (Service Response Time), and standard deviation.
(This is my first tap, so hopefully I didn't miss something, but we'll see ...)
TODO: Add a Wireshark tap.


svn path=/trunk/; revision=36480
 2011-04-05 20:21:59 +00:00
Stig Bjørlykke
c13f84b345 Compile fix: camel_obj_id -> obj_id. 
svn path=/trunk/; revision=36475
 2011-04-05 15:49:56 +00:00
Anders Broman
909a166343 Actually get the oid string ... 
svn path=/trunk/; revision=36474
 2011-04-05 15:43:15 +00:00
Bill Meier
91991145de Don't assign to a proto_item * if the value won't be used: Coverity 858; 
Fix two cases where items appear to be added to the wrong tree: Coverioty 856 & 857.
Also: remove some unneeded #includes& do some whitespace cleanup.

svn path=/trunk/; revision=36473
 2011-04-05 15:33:56 +00:00
Bill Meier
40892a0f27 Don't assign to a proto_item * if the value won't be used: Coverity 882; 
Also: #include <string.h> not req'd

svn path=/trunk/; revision=36472
 2011-04-05 15:09:32 +00:00
Jeff Morriss
dcdbb29bed Remove some unused hf_ variables. 
svn path=/trunk/; revision=36469
 2011-04-05 02:35:32 +00:00
Jeff Morriss
a148a936b1 From Felix Kraemer: fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5694 : 
This patch adds the capability to create BACnet statistics trees. 
Find the respective menu items under 'Statistics->BACnet'.
Packets can be sorted by different criteria:
- Src/Dst IP adresses
- Instance ID
- Object Type
- Service

From me:
- Don't use C++/C99-style comments.
- Name variables for tick_stat_node() don't need to be static.
- Change updateBacnetInfoValue() to require 'data' to be ep_ allocated.  Change
  the couple of calls that did not send in ep_ allocated data to do so.
- Change one or two functions to be static.
- Do not use (memory-unsafe) g_sprintf().
- Use ep_strconcat() instead of leaking memory with g_strconcat().
- Put back one if(tree) that doesn't appear to do any harm.
- Remove variable declarations and #includes from the header file.

svn path=/trunk/; revision=36468
 2011-04-05 02:18:28 +00:00
Bill Meier
49ac29b682 Don't assign to a proto_item * if the value won't be used: Coverity 850; 
Also: remove some unneeded #includes.

svn path=/trunk/; revision=36466
 2011-04-04 20:03:27 +00:00
Bill Meier
0820763edb Fix "MISSING_BREAK"; Coverity 436. 
svn path=/trunk/; revision=36465
 2011-04-04 19:41:51 +00:00
Bill Meier
747477c7ab Don't assign to a proto_item * if the value won't be used: Coverity 846 & 848; 
Also: remove some unneeded #includes


svn path=/trunk/; revision=36464
 2011-04-04 19:23:39 +00:00
Bill Meier
db925b3bfb Don't assign to a proto_item * if the value won't be used: Coverity 836; 
Also: remove some unneeded #includes.

svn path=/trunk/; revision=36460
 2011-04-04 18:41:49 +00:00
Bill Meier
07e325bf63 Don't assign to a proto_item * if the value won't be used: Coverity 832-834. 
Also: white space cleanup.

svn path=/trunk/; revision=36459
 2011-04-04 18:13:22 +00:00
Stephen Fisher
5499d2a6bd Fix Coverity 1137, 1138, 1139: UNUSED_VALUE 
svn path=/trunk/; revision=36457
 2011-04-04 17:56:16 +00:00
Bill Meier
c6c91f8e76 Don't assign to a proto_item * if the value won't be used: Coverity 829 & 830; 
Fix a minor bug wherein a number of proto_tree_add_...() used the wrong tree: Coverity 831;
Remove some unneeded #includes.

svn path=/trunk/; revision=36456
 2011-04-04 17:49:32 +00:00
Stephen Fisher
39699efe92 Fix compilation error: 
packet-amqp.c:5617:5: error: "/*" within comment

Cause:

Previous comment wasn't terminated right


svn path=/trunk/; revision=36454
 2011-04-04 17:42:37 +00:00
Bill Meier
8b0a085250 Don't assign to a proto_item * if the value won't be used: Coverity 827; 
Comment out some currently unused code: Coverity 828.

svn path=/trunk/; revision=36453
 2011-04-04 17:24:17 +00:00
Bill Meier
e2ee0e52d8 Don't assign to a variable if the value won't be used: Coverity 826; 
Also: Remove some uneeded #includes & use consistent indentation.

svn path=/trunk/; revision=36451
 2011-04-04 16:54:02 +00:00
Bill Meier
cf20622668 Don't assign to a proto_item * if the value won't be used: Coverity 823 & 824; 
Fix a minor bug wherein a proto_tree_add_text used the wrong tree: Coverity 825;
Remove some unneeded #includes;
Use consistent indentation.

svn path=/trunk/; revision=36449
 2011-04-04 16:13:42 +00:00
Bill Meier
aec98c121a Don't assign to a proto_item * if the value won't be used: Coverity 820/821; 
Also: #include <stdio.h> & <string.h> not required;


svn path=/trunk/; revision=36447
 2011-04-04 15:38:19 +00:00
Bill Meier
ede51600c7 Don't assign to a variable if the value won't be used: Coverity 817-821. 
svn path=/trunk/; revision=36446
 2011-04-04 15:31:33 +00:00
Anders Broman
a7d7365f4a Mark pinfo as unused. 
svn path=/trunk/; revision=36445
 2011-04-04 15:09:22 +00:00
Anders Broman
aaf0d277b8 Get rid of gsm_a_dtap_pinfo. 
svn path=/trunk/; revision=36444
 2011-04-04 14:49:14 +00:00
Anders Broman
8d6ca293dc Change the signature of elem_fcn():ns to include pinfo. 
svn path=/trunk/; revision=36443
 2011-04-04 14:37:25 +00:00
Anders Broman
72b69aeaf5 Change the msg_fcn() signature to include pinfo. 
svn path=/trunk/; revision=36441
 2011-04-04 07:45:34 +00:00
Bill Meier
f3af25f270 Don't assign to a proto_item* if the value won't be used: Coverity 885-889 
Also: Significant code rework including:
  - Fix bug wherein a timestamp was incorrectly reported as being an Error;
  - Replace many proto_tree_add_text()/proto_item_set_text() sequences each by a
    single proto_tree_add_text().
  - remove unneeded #include <string.h>
  - Whitespace clanup including replacing mixed space/tab indentation by spaces.


svn path=/trunk/; revision=36437
 2011-04-03 15:39:01 +00:00
Anders Broman
e645e3c4d0 -Whitespace fix in gsm_map-template(no need to regenerate). 
- Fix dissection of extensions in INAP it should now be possible to add
an "OID dissector" for extensions.
Should fix BUG
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5799

svn path=/trunk/; revision=36435
 2011-04-02 09:18:18 +00:00
Jeff Morriss
43f966a0ea From Alexis La Goutte via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5768 : 
Patch 6 :
Enhance the MySQL collation

Patch 7 :
Enhance MySQL : add dissection of command Binlog Dump (replicate command).

svn path=/trunk/; revision=36433
 2011-04-01 19:50:50 +00:00
Chris Maynard
4233a227ef Avoid potential buffer overruns when sscanf'ing strings. 
Should resolve CID's 656 and 657.

svn path=/trunk/; revision=36432
 2011-04-01 18:16:47 +00:00
Chris Maynard
2db46ad8d4 Remove const type qualifier from cast. Resolves CID's 582-585. 
svn path=/trunk/; revision=36430
 2011-04-01 16:30:59 +00:00
Martin Mathieson
5344e9f3d9 Take care not to append RLC mode to proto_item twice. 
svn path=/trunk/; revision=36429
 2011-04-01 13:41:08 +00:00
Chris Maynard
6760848315 Fix 11 occurrences of returned pointer never used. Fixes CID's 1064-1067. 
svn path=/trunk/; revision=36426
 2011-03-31 19:17:06 +00:00
Chris Maynard
f8737dfbcc From Alexis La Goutte via bug 5790: Fix 8 clang warnings, all of which were: 
"warning: Value stored to 'offset' is never read".  The 'offset' is now used.

svn path=/trunk/; revision=36419
 2011-03-31 15:17:49 +00:00
Chris Maynard
0db9556757 Delete unused header fields found by running tools/checkhf.pl. 
svn path=/trunk/; revision=36418
 2011-03-31 14:35:40 +00:00
Chris Maynard
f88037ac41 From Yair via bug 5779: Add option to leave AAL5 in unspecified format. 
(... with whitepsace changes by me.)

svn path=/trunk/; revision=36416
 2011-03-31 14:23:07 +00:00
Chris Maynard
1e71ccef15 From Andrew Feren via bug 5775: Correct types on several info elements. 
svn path=/trunk/; revision=36415
 2011-03-31 14:03:23 +00:00
Stig Bjørlykke
8d62b393a4 Register tcp by name. 
To be used in User DLT's and Lua scripts.

svn path=/trunk/; revision=36414
 2011-03-31 12:18:14 +00:00
Stig Bjørlykke
a54e28e2ec Use correct functions to fetch protocol name for a dissector registered 
by register_dissector().

svn path=/trunk/; revision=36413
 2011-03-31 12:16:41 +00:00
Stig Bjørlykke
0b8be02229 Use correct length for clientaddr4 callback address entry. 
svn path=/trunk/; revision=36411
 2011-03-31 11:01:06 +00:00
Ronnie Sahlberg
13f6b77d92 remove two pointless const in casts 
coverity 580 and 581

svn path=/trunk/; revision=36407
 2011-03-30 04:36:09 +00:00