Commit Graph

2814 Commits

Author SHA1 Message Date
John Thacker e911f8ec9d stats tree: Update plugins for new path separator
Update the pinfo stats tree plugin and the F5 trailer for
the new stats tree path separator

Follow up to 53638f9ccf
2024-02-21 00:23:47 +00:00
Gerald Combs 53638f9ccf Stats tree: Change our path separator
Change our menu path separator to "//" similar to our filter buttons.
Change the "name" configuration element to "path", since it's a menu
path. Add a separate "title" element. This lets us use names like "Foo
I/O".
2024-02-14 08:05:24 +00:00
Gerald Combs a018829a36 Falco bridge: Sort our Container I/O totals 2024-02-12 10:47:55 -08:00
Gerald Combs 0e5416efbe Falco bridge: Fix our default container name
Use "host" to match libsinsp.
2024-02-12 08:42:23 -08:00
Gerald Combs 920d2774bf stats_tree API updates
Add an opaque public type for stats_tree configurations. Get rid of
stats_tree_register_with_group and add stats_tree_set_group. Add
stats_tree_set_first_column_name. Convert some documentation to doxygen.
2024-02-12 12:53:48 +00:00
Gerald Combs 319101f544 Falco bridge: Make sure our strings are UTF-8 2024-02-09 17:46:40 -08:00
Gerald Combs 5e10272450 Falco bridge: Add container I/O stats 2024-02-09 13:59:46 -08:00
Gerald Combs 57a1be8873 Falco bridge: Skip some more syscall fields 2024-02-09 13:32:23 -08:00
Gerald Combs d3c837f6e0 Falco bridge: Fix a couple of integer casts 2024-02-08 13:17:21 -08:00
Gerald Combs 98ebebec80 Sysdig Event+Falco Bridge: Highlight I/O data
Pass the sysdig.param.asyncevent.data start and offset to the Falco Bridge
dissector, and use that to highlight the evt.buffer and fd fields.

Pass the data to the ELF dissector if we find an ELF magic ID.
2024-02-07 16:55:04 -08:00
Gerald Combs 2a73e99cfb Falco bridge: Syscall conversation updates
Add a pinfo conversation filter which enables related packets based on
(container.id, proc.id) combinations. Register the "Process" conversation
filter first so that the "Go" menu behavior matches the related packet
display.

Handle cases where container.id is missing.

Add 64-bit integer type support to conversations.
2024-02-06 12:24:28 -08:00
Martin Mathieson 714e568f66 Fix some more spelling errors 2024-02-06 10:46:08 +00:00
John Thacker 7b114620c7 opcua: Have a default signature length preference
If the OpenSecureChannel message is not captured, then whether
messages are signed, and what the signature length is is unknown.
This creates a preference that can be set to a default value to use,
instead of assuming that all messages on the channel are unsigned.

Fix #15206
2024-02-05 08:30:57 +00:00
Darius Davis 89ce06c459 Fix a grab-bag of typos.
One of these modifies a field name ("hart_ip.pt.rsp.transducer_serail_number"
in packet-hartip.c), a few are in text displayed for fields (in packet-nvme.c)
or for unknown fields (in packet-oer.c and packet-per.c), one is in a
preprocessor macro (in packet-cip.[ch]), and the rest are all in comments.

   arry -> array
   authos -> authors
   compatability -> compatibility
   contigous -> contiguous
   dispaly -> display
   erorr -> error
   filed (where it was obviously incorrect) -> field or filled
   hueristic -> heuristic
   regsiter -> register
   serail -> serial
2024-02-05 11:58:31 +10:00
Gerald Combs 126c95fe2b Falco bridge: Set our sinsp buffer format
Set our buffer format to PF_EOLS_COMPACT, which seems to offer the
closest thing to raw data.
2024-02-03 01:01:22 +00:00
Gerald Combs d053622cea Falco bridge: Allocate our tap data 2024-01-31 09:50:36 -08:00
Gerald Combs 3588090b2a Falco bridge+falcodump: Various fixes
Fix building with Visual C++ and recent versions of falco-libs.
2024-01-31 00:03:48 +00:00
John Thacker 28e9035eec MATE: Update examples
Fix the distributed examples to use the "new" style configuration,
as shown in the WSUG and Wiki. Fix the FTP example in the WSUG,
as it's missing the Match keyword

Related to #12118.
Fix #16940
2024-01-30 16:05:15 +00:00
John Thacker 4ec5c7f78f MATE: Handle fields that are in different data sources
In addition to the start and end offset locations, store a pointer to
the data source tvb in each mate_range. The start and end offsets
are only relevant within a data source.

If a field has a data source different from one of the protocol,
transport protocol, or payload ranges, search in the tree for the
ancestor nodes of the field, and see if an ancestor is located within
one of the ranges.

In order to workaround #17877 (non-visible items can't change length
after being added to the tree, which affects most protocols), set
the tree as visible similar to done with a number of Lua postdissectors
that need all fields. Unfortunately this is overkill that hurts
performance.

Fix #19619
2024-01-30 10:28:32 +00:00
Gerald Combs 3e519a0385 Falco bridge: Correctly handle trailing internal events 2024-01-29 14:27:19 -08:00
Martin Mathieson 4571d9f194 Fix more FT_BOOLEAN items with no mask - set len to BASE_NONE 2024-01-25 22:01:03 +00:00
Loris Degioanni 78a8793cbc "Follow" implementation in logray
Add a syscall-oriented follow window to logray, which shows the read/write buffers of the currently selected file descriptor.
2024-01-23 20:07:11 +00:00
Martin Mathieson 651122a798 Undo some more double colons 2024-01-20 15:11:08 +00:00
Gerald Combs 8d79ea2f0d Falco bridge: Improve our internal event detection 2024-01-17 18:50:33 -08:00
David Perry bf909bf93e Add descriptions for heur dissector tables
Build on !13975 to add human-readable descriptions for all heuristic
dissector tables in Wireshark.

Chosen names are meant to give some info on when a heuristic dissector
lookup will be made. Terms like 'fallback' are used when the heuristic
is only consulted if other checks do not result in dissection, for
example.

People with more intimate knowledge of the protocols and dissectors
involved are encouraged to suggest or implement better descriptions.
2024-01-17 08:35:43 +00:00
Gerald Combs bcfa25bdfc Falco bridge: Add a quick CPU+PID cache
Try caching strings based on their CPU ID, PID, and field index. This
lets us use a constant 64-bit key before spending CPU time hashing
strings. This saves about 500ms when loading a test capture here.
2024-01-16 18:25:51 +00:00
Loris Degioanni f374ddf2fb Falco bridge: Add conversation filters
Add conversation filters for container, process, process, process and
descendant, thread and FD.
2024-01-13 15:04:47 -08:00
Gerald Combs 06f80366d5 Falco bridge: Update our memory stats 2024-01-13 22:11:27 +00:00
John Thacker d4bc9d4036 opcua: Parse more Server and Client Certificates
Even though these files are generated and warn not to change
them, the generator is not working currently, so patch them.
(See the disscussion in !14000)
2024-01-13 01:30:58 +00:00
Gerald Combs eec059c598 Falco bridge: Use ws_strtoi
Fetch an integer value using ws_strtoi. This saves about 400ms when
loading a test capture here.
2024-01-12 14:19:42 -08:00
John Thacker 9152670fe5 opcua: Use fragment_add_seq_offset
This is the reassembly API call for fragments that start at a
different value. This is better than examining the entire
chain, and also would have a better chance of working with
out of order fragments (though TCP should handle that for us.)
2024-01-12 14:18:13 +00:00
Gerald Combs 3c62d285ac Falco bridge: Use g_str_hash
Use g_str_hash for our string interning. This reduces the load time for
a large file here from ~13s to ~10s.
2024-01-12 02:06:19 +00:00
Gerald Combs 8f3756431f Falco bridge: Remove an unused struct member 2024-01-11 15:11:35 -08:00
John Thacker 7ce05b9dd7 opcua: X.509 Certificate dissection
Dissect the X.509 v3 Certificates used in OPC UA.

Use proto_tree_add_bytes_with_length for adding NULL bytes to
the tree with a (0) length different than the length taken up
in the tvb. It's somewhat nicer than changing the item length later.
2024-01-11 10:30:30 -05:00
Gerhard Gappmeier 76f6b5285d opcua: fix payload size for unencrypted chunked messages
fixes #19581
also fix one typo
2024-01-11 14:37:25 +00:00
Gerald Combs 73bf0d5b23 Falco bridge: Minor performance improvement
Use a vector instead of a map. This reduces the load time for
a large file here from ~19s to ~13s.
2024-01-10 18:11:16 -08:00
Gerald Combs ba6f76e0d5 Falco bridge: Add a preference to show internal events 2024-01-10 16:29:04 -08:00
Gerald Combs c659ffbed1 Falco bridge: Disable memory statistics debugging 2024-01-10 15:54:36 -08:00
Loris Degioanni 2fe5b48cf8 Falco bridge: Add a subtree to show process ancestors 2024-01-09 14:17:51 -08:00
Loris Degioanni c0d0e01f95 Falco bridge: Hide some syscall fields
Hide some of the sinsp fields that are not useful in a Wireshark-like
interface.
2024-01-09 14:16:52 -08:00
Gerald Combs 6af57646d7 Falco Bridge: Reduce our cache memory usage
Shrink the sinsp_field_extract_t struct by removing unused members and
shrinking others. Move the parent_category member to a separate lookup.
2024-01-09 13:12:55 -08:00
Loris Degioanni 186706b6cb Falco bridge: Add support for event arguments 2024-01-09 13:12:55 -08:00
Gerald Combs b8bf79eb21 Falco bridge: Cache our extracted data
libsinsp requires that events be processed in order. Cache our extracted
data on the first pass.
2024-01-09 13:12:55 -08:00
Gerald Combs 5822f3d101 Falco bridge: Add a null check 2024-01-09 21:00:11 +00:00
Martin Mathieson 66c607f118 Document discontinuities in OSPF and IRDA dissectors 2024-01-09 16:55:33 +00:00
Guy Harris b0e87a4207 irda: make it clearer that the control field is at the current offset.
Use the offset variable (which has the value 1 at that point), rather
than a constant 1, as the offset argument when calling
dissect_xdlc_control().
2023-12-29 00:07:38 -08:00
Guy Harris c635a0b388 irda: update some comments with new and additional links.
http://www.irdajp.info/specifications.php doesn't work any more; remove
it.

Show some other document links, purportedy uploaded to archive.org by
the IrDA, as well as a link to a collection of those documents.

Show ome links from the archive copy of the IrDA specifications page
from the Wayback Machine.

[skip ci]
2023-12-28 23:41:50 -08:00
João Valverde 36065ab356 Rename some codec plugin folders to lowercase 2023-12-14 16:24:41 +00:00
João Valverde 7f32c90ab9 plugins: Add a codecs API level
Add a minimum and maximum API level. Backward-compatible changes to
the API only bump the maximum API level. Backward incompatible
changes bump the maximum API level and the mininum, to the
new (maximum) level.

This may allow codec plugins to continue working without recompilation,
possibly with reduced functionality.

The API level is only defined for codecs because it is a small
and easy to define API, and very stable.

Maybe we could do the same for wiretap (file type) plugins. For the
various epan plugin types it seems pointless and futile. I cannot
see a scenario where a new Wireshark minor release does not increase
the minimum API level.
2023-12-14 16:18:35 +00:00
João Valverde b51a3933ba CMake: Refactor plugin add_library() macros
Replace the macro subfolder argument with type specific plugin
macros.
2023-12-14 14:18:55 +00:00