a061f50bb0
Fix two cases of adding to COL_INFO w/o checking first
...
svn path=/trunk/; revision=26644
2008-10-31 13:46:03 +00:00
ac88e96246
Thou shalt not "print" a string with a printf-like function by using it
...
as the format string; thou shalt, instead, use "%s" as the format string
and use the string as the argument to "%s". Thanks and a tip of the
Hatlo hat to the version of GCC that comes with Ubuntu 8.10 for catching
this.
svn path=/trunk/; revision=26640
2008-10-31 02:41:45 +00:00
178fda6cfe
Fix bug #3020 : Fix potential memory leaks
...
svn path=/trunk/; revision=26636
2008-10-31 00:36:51 +00:00
1d035a0542
Added support for RPCAP message formats.
...
svn path=/trunk/; revision=26633
2008-10-30 21:22:50 +00:00
0eb5aa20a5
Slight rework related to proto_register & proto_reg_handoff;
...
Among other things: do the prefs callback stuff via the
proto_reg_handoff callback rather than via a registered init
function callback.
svn path=/trunk/; revision=26632
2008-10-30 20:54:25 +00:00
5d6abb0d13
Add id-pkix-ocsp-nocheck.
...
Fixes bug https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3015
svn path=/trunk/; revision=26631
2008-10-30 20:12:00 +00:00
34fdd680ef
Fix:
...
packet-gsm_bsslap.c:374: warning: unused parameter 'len'
packet-gsm_a_rr.c:3035: warning: 'xdd_indic0' may be used uninitialized in this function
svn path=/trunk/; revision=26630
2008-10-30 20:09:14 +00:00
88e85605f6
From Joe Eykholt:
...
The dissector for FIP (FCoE (Fibre Channel over Ethernet) Initialization Protocol)
needs to be updated for recent changes and proposed changes by T11.
The original version was done when the protocol was fairly close to being
ratified, but it is very very close now. The letter ballot has gone out.
The only part of the attached patch that isn't on the current ballot is the
VLAN descriptor. I will update that later if it turns out to be changed before adoption.
The changes are as follows:
The SWWN descriptor is now called a Name descriptor.
The FWWN descriptor is now called a Fabric descriptor and has two new fields,
VFID (virtual fabric ID) and FC-MAP OUI value.
The MRS descriptor is now called FCoE Size.
The FKA descriptor units changed from seconds to milliseconds.
The VLAN request and reply ops have been added.
A VLAN descriptor type has been added.
svn path=/trunk/; revision=26629
2008-10-30 19:58:41 +00:00
95f8f924ca
From Abhik Sarkar:
...
GSM SMS dissector doesn't support filtering based on TPDU parameters.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3012
svn path=/trunk/; revision=26628
2008-10-30 19:50:32 +00:00
51a5c82e9d
Fix bug #3017 : remove un-necessary code (and thus fix a small memory leak)
...
svn path=/trunk/; revision=26626
2008-10-30 19:41:27 +00:00
c83c448173
Add dissection of some IE:s
...
svn path=/trunk/; revision=26625
2008-10-30 19:32:35 +00:00
1e151d673f
From Pascal Quantin:
...
Add dissection for 3GPP 25.331 System information Blocks messages and IRAT related messages.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3016
svn path=/trunk/; revision=26624
2008-10-30 19:31:50 +00:00
e3d3b73a96
From Pascal Quantin:
...
Add 3GPP 44.018 SI5bis, SI5ter, SI6 and SI13 decoding
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3014
svn path=/trunk/; revision=26623
2008-10-30 19:30:08 +00:00
f763c88092
Try to dissect the Topology Descriptor before the command
...
This fixes bug 2665
svn path=/trunk/; revision=26620
2008-10-30 09:53:43 +00:00
be69cc2732
Minor cleanup related to proto_register & proto_reg_handoff
...
svn path=/trunk/; revision=26619
2008-10-29 19:16:29 +00:00
bafe19e58d
fixes some parsing errors revealed by fuzz tests
...
svn path=/trunk/; revision=26618
2008-10-29 16:24:58 +00:00
246fce7b04
Clean up indentation.
...
Fix typoes.
Get rid of C++/C99-style comment.
svn path=/trunk/; revision=26613
2008-10-28 22:15:42 +00:00
209c8de4e5
Make it compile.
...
svn path=/trunk/; revision=26611
2008-10-28 20:55:59 +00:00
de8c90d0fe
packet-gsm_sms.c:1643: warning: unused variable 'str' ...etc
...
svn path=/trunk/; revision=26608
2008-10-28 20:21:52 +00:00
c29d949834
From Shmulik Bezale:
...
gsm sms -> reassemble + wap support
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3004
svn path=/trunk/; revision=26607
2008-10-28 19:48:55 +00:00
d397a165c2
From Shmulik Bezale:
...
GSM_MAP - ucs2 support on USSD.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2991
svn path=/trunk/; revision=26606
2008-10-28 19:31:29 +00:00
1d4e3ad464
From Shmulik Bezale:
...
is-637-ansi support more encoding.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3005
svn path=/trunk/; revision=26605
2008-10-28 19:27:16 +00:00
222869d394
From Pascal Quantin:
...
Buggy 3GPP 44.018 Cell Channel Description / Frequency List IEs decoding.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3007
svn path=/trunk/; revision=26604
2008-10-28 19:19:37 +00:00
dd18d39f92
Move dissect_geographical_description() from gsm_map to gsm_a_common to make it easier to use it in other dissectors including it from gsm_map makes in neccesarry to include asn1.h.
...
Fix some bugs in the code, use it from bssmap.
svn path=/trunk/; revision=26603
2008-10-28 19:16:10 +00:00
5edf350ffc
Wrong value for ELLIPSOID_POINT_WITH_UNCERT_CIRC used in CASE.
...
svn path=/trunk/; revision=26593
2008-10-27 21:57:36 +00:00
357e5e016e
Fixed some true_false_string definitions.
...
svn path=/trunk/; revision=26591
2008-10-27 21:36:02 +00:00
497197b525
From Pascal Quantin:
...
Add 3GPP 44.018 SI3 and SI4 Rest Octets decoding.
svn path=/trunk/; revision=26590
2008-10-27 21:08:54 +00:00
38e28295cd
Update towards 48.008 8.4.0
...
svn path=/trunk/; revision=26589
2008-10-27 21:07:52 +00:00
45e798a430
Minor rework related to proto_reg_handoff
...
svn path=/trunk/; revision=26588
2008-10-27 20:43:47 +00:00
b01d3d77dc
Fix bug in each dissector: port pref change was ignored; Related: proto_reg_handoff rework.
...
svn path=/trunk/; revision=26586
2008-10-27 20:34:44 +00:00
457e4ddd1f
From Tom Hughes:
...
The attached patch extends the X11 protocol dissector to decode the event
contained in a SendEvent request.
svn path=/trunk/; revision=26584
2008-10-27 19:16:25 +00:00
7c07ed69d0
On request from Philip Zimmermann:
...
Additional cypher type and key agreement, and check of the CRC.
svn path=/trunk/; revision=26574
2008-10-27 08:04:26 +00:00
be76528ad8
#if ==> #ifdef
...
svn path=/trunk/; revision=26567
2008-10-27 01:39:32 +00:00
b32c91b5a0
Try to make the build bot hapy.
...
svn path=/trunk/; revision=26562
2008-10-26 21:45:37 +00:00
52aaa7c77f
Match protocol and filter prefix.
...
svn path=/trunk/; revision=26561
2008-10-26 21:29:44 +00:00
f47b645008
From Pascal Quantin:
...
Add 3GPP 44.018 SI1, SI2bis, SI2ter and SI2quater full decoding
svn path=/trunk/; revision=26559
2008-10-26 19:46:46 +00:00
799b8635f3
Update towards 48.008 8.4.0
...
svn path=/trunk/; revision=26558
2008-10-26 19:44:06 +00:00
68d587a24f
Updated to the latest IETF draft draft-zimmermann-avt-zrtp-10.
...
svn path=/trunk/; revision=26555
2008-10-25 23:37:31 +00:00
f9f52e367e
Do not use dot in protocol filter name.
...
svn path=/trunk/; revision=26551
2008-10-25 11:23:05 +00:00
1bc4ea382c
From Sebastian Stollenwerk:
...
While sniffing h264-packets with more than 8 leading zero bits they're displayed in error: fixed.
If there are FU-A(28) encoded packets, you can't see them in Wireshark: upgraded.
svn path=/trunk/; revision=26549
2008-10-25 10:32:01 +00:00
20e131acf7
Add a modeline blurb for the predominant indentation style, and update some
...
whitespace to match.
svn path=/trunk/; revision=26546
2008-10-24 23:35:50 +00:00
3b9c92584b
Put the contents of each CIC range parameter in a REG_REQ in its own tree
...
with a textual summary of the CIC range at the root of the tree.
This makes these parameters much easier to read when there are many of them
in a single message.
svn path=/trunk/; revision=26541
2008-10-24 19:33:19 +00:00
c33f06259d
From Tom Hughes:
...
The attached patch extends the X11 protocol dissector to decode MappingNotify events.
svn path=/trunk/; revision=26540
2008-10-24 18:45:03 +00:00
3934dfb936
From Alexander Dupuy:
...
More complete support for IPFIX RFC 5103 biflows.
svn path=/trunk/; revision=26536
2008-10-24 07:32:16 +00:00
8afa208ffb
Windows build: #include winsock2.h only when needed.
...
#include winsock2.h pulls in about 90 distinct .h files
and about 140 total .h files.
Currently winsock2.h is (mostly unnecessarily) included
for each dissector via packet.h/wtap.h.
This patch removes #include winsock2.h from wtap.h and
then includes winsock2.h (or windows.h) in the
few specific places required.
With this patch, my Windows Wireshark build takes
about 30% less time.
svn path=/trunk/; revision=26535
2008-10-24 00:42:09 +00:00
ede39bfe1f
Take out extra */ to fix compile.
...
svn path=/trunk/; revision=26534
2008-10-23 21:26:19 +00:00
ddce920fd8
Let the dissectors fill the Protocol and Info columns by calling the even when tree == NULL.
...
svn path=/trunk/; revision=26531
2008-10-23 21:01:04 +00:00
607de79a7b
Update towards 48.008 8.4.0
...
svn path=/trunk/; revision=26530
2008-10-23 20:39:43 +00:00
73cd38c1bd
Fix an assignment which is intended as a comparison.
...
svn path=/trunk/; revision=26529
2008-10-23 19:57:19 +00:00
b3256e6d44
Fix:
...
cc1: warnings being treated as errors
packet-gtp.c: In function ‘decode_qos_umts’:
packet-gtp.c:3725: error: ‘guar_dl_ext’ may be used uninitialized in this function
packet-gtp.c:3722: error: ‘max_dl_ext’ may be used uninitialized in this function
packet-gtp.c:3725: error: ‘guar_ul_ext’ may be used uninitialized in this function
packet-gtp.c:3722: error: ‘max_ul_ext’ may be used uninitialized in this function
packet-gtp.c:3726: error: ‘sig_ind’ may be used uninitialized in this function
packet-gtp.c:3726: error: ‘src_stat_desc’ may be used uninitialized in this function
make[4]: *** [libdissectors_la-packet-gtp.lo] Error 1
svn path=/trunk/; revision=26528
2008-10-23 19:44:07 +00:00
10d2e65228
If we only see one half of a SCCP conneversation we can as a last resort make the association on the RLC(if seen).
...
svn path=/trunk/; revision=26527
2008-10-23 19:25:13 +00:00
2ff51cb037
Update the QoS IE
...
svn path=/trunk/; revision=26526
2008-10-23 19:22:54 +00:00
d6556ed5a2
Add the Content-Length header as a header string, while maintaining the content-length filter option.
...
svn path=/trunk/; revision=26522
2008-10-23 06:57:31 +00:00
9b9c51873b
From shmulikB:
...
1. ansi map fail to parser BCD digits when Numbering Plan: Telephony Numbering
(ITU-T Rec. E.164,E.163) (2)
2. fix dissector_try_port if sms-TeleserviceIdentifier RECIEVE BEFORE
sms-BearerData.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2989
svn path=/trunk/; revision=26521
2008-10-23 05:56:28 +00:00
6e901dc4fe
Mark len as unused.
...
svn path=/trunk/; revision=26518
2008-10-22 21:10:45 +00:00
41b70e3a96
Some further updates.
...
svn path=/trunk/; revision=26517
2008-10-22 20:56:26 +00:00
1d5478595c
Mark some unused variables.
...
svn path=/trunk/; revision=26516
2008-10-22 18:55:58 +00:00
03a81916d8
Get rid of /* inside comment.
...
svn path=/trunk/; revision=26515
2008-10-22 17:50:07 +00:00
a4c3055bbb
Update bssap le and BSS MAP.
...
svn path=/trunk/; revision=26514
2008-10-22 16:32:24 +00:00
119d449880
Fix a bit more spacing
...
svn path=/trunk/; revision=26506
2008-10-20 21:38:53 +00:00
6da6ad6451
Oops ! Revert (Remove) development stuff ....
...
svn path=/trunk/; revision=26505
2008-10-20 21:14:21 +00:00
145e8f7b74
Adjust indentation to be more consistent ....
...
svn path=/trunk/; revision=26504
2008-10-20 20:51:04 +00:00
7fb7444eff
Fixed filter name for "nisplus.dummy"
...
svn path=/trunk/; revision=26495
2008-10-19 14:55:30 +00:00
75d4f03f87
From beanniecai:
...
Change non-printable characters(code page 936, simplified Chineses) 0x96 in
packet-ieee80211.c and 0xa7 in packet-sndcp-xid.c to '-' and null character,
otherwise there is always warning C4819 using MS compiler.
Additional some whitespace cleanups applied.
svn path=/trunk/; revision=26489
2008-10-18 14:24:33 +00:00
5bfa442298
From Peter Harris:
...
The attached patch adds support for dissecting 'sent' events to the X11 dissector.
svn path=/trunk/; revision=26488
2008-10-18 14:19:06 +00:00
8384b6976a
Revert files checked in by misstake.
...
svn path=/trunk/; revision=26485
2008-10-16 21:33:00 +00:00
248049bcbb
Add asn1 file from Heimdal use som stuff from it add more dissection in the template and .cnf file.
...
svn path=/trunk/; revision=26484
2008-10-16 21:27:14 +00:00
c38033dfca
Default: "dissector not registered on tcp.port";
...
svn path=/trunk/; revision=26482
2008-10-16 16:13:28 +00:00
e0501b75d3
Remove unnecessary #includes
...
svn path=/trunk/; revision=26481
2008-10-16 14:34:20 +00:00
4528043ab6
Fixed decoding of multiple sequences in a sequence of implict sequence.
...
Removed attempt to fix number of items in indef sequence-of and set-of.
svn path=/trunk/; revision=26476
2008-10-16 10:50:12 +00:00
ebd05a6014
Bugfix from Robin Seggelmann for Certificate Request messages.
...
svn path=/trunk/; revision=26475
2008-10-16 10:11:24 +00:00
25cd2bc4d2
From Scott Roberts:
...
Patch to have the tds dissector register itself by name.
And fix the name of the register function itself.
svn path=/trunk/; revision=26474
2008-10-16 07:20:02 +00:00
3cbb374385
Now Kerberos compiles, a lot of work remains to get it into shape.
...
svn path=/trunk/; revision=26467
2008-10-15 20:08:10 +00:00
369f9243ce
Squelch warnings.
...
svn path=/trunk/; revision=26465
2008-10-15 18:51:41 +00:00
c40304819e
From David Castleford (with some changes by Bill Meier); See Bug #2935
...
svn path=/trunk/; revision=26464
2008-10-15 18:22:01 +00:00
aba73d539f
Add option 22 and 23 dissection.
...
svn path=/trunk/; revision=26463
2008-10-15 17:51:57 +00:00
a60b943947
Fix for bug #2969
...
svn path=/trunk/; revision=26462
2008-10-15 16:26:45 +00:00
1217ba4e77
From Florian Lohoff:
...
Update packet-redback.c with hf fields. Dissect more POS packets and clean up
code. Dissect ISIS packets etc.
svn path=/trunk/; revision=26457
2008-10-14 19:16:28 +00:00
84fe273017
From Florian Lohoff:
...
The redback lawful intercept format is a moving target - redback tends to add
more AVPs in newer software versions. Here is an update which covers the
"direction" avp and the "accounting session id".
svn path=/trunk/; revision=26456
2008-10-14 19:14:57 +00:00
57660e3fb6
Try to get rid of unused code warnings.
...
svn path=/trunk/; revision=26455
2008-10-14 19:07:26 +00:00
c2515c5abd
Count correct number of items in indef sequence-of and set-of.
...
svn path=/trunk/; revision=26451
2008-10-14 16:28:54 +00:00
cf40bd9747
Dump the contents of some elements.
...
Standardize printing of enterprise id.
svn path=/trunk/; revision=26447
2008-10-14 00:17:42 +00:00
f293b1639e
From Alexis La Goutte:
...
I'm a user of Aruba / Alcatel OAW Wireless Switch ( www.arubanetworks.com )
The stream (802.11 Frame) is encapsulated in a tunnel GRE.
svn path=/trunk/; revision=26446
2008-10-13 20:40:26 +00:00
37a91449cb
Try to get rid of unused code warnings.
...
svn path=/trunk/; revision=26445
2008-10-13 19:54:48 +00:00
47a6731043
Remove unused include for conversations.h
...
(File regenerated from template & etc)
svn path=/trunk/; revision=26444
2008-10-13 19:52:55 +00:00
51de8ebdb8
Back out the expert info - it's wrong.
...
svn path=/trunk/; revision=26441
2008-10-13 19:32:06 +00:00
61fdd2f1f6
From Martin Lutz:
...
IEC 61850 GOOSE protocol
svn path=/trunk/; revision=26440
2008-10-13 19:31:12 +00:00
dc2fed3ed3
Remove unused prefs.h, conversation.h & data_handle; Fix typo
...
(File re-generated from the template & etc)
svn path=/trunk/; revision=26432
2008-10-13 16:56:17 +00:00
9168a0a714
Added total time analysis from Address to Ack-Ack PDU.
...
Renamed previous total time to transmission time.
svn path=/trunk/; revision=26428
2008-10-13 14:59:28 +00:00
49fe94aa3f
Fix for bug 2823
...
Do not pass automatic variables back into caller space.
svn path=/trunk/; revision=26426
2008-10-13 06:56:27 +00:00
3893c32000
From David Aggeler:
...
Reworked the item creation.
svn path=/trunk/; revision=26424
2008-10-12 21:35:23 +00:00
b49434dcd2
From SUZUKI, Shinsuke <suz@kame.net> (bug 2956):
...
Remove non-ascii characters to prevent compilation failure on
non-european windows.
svn path=/trunk/; revision=26420
2008-10-12 09:38:40 +00:00
9a50932bcf
From Ward van Wanrooij (bug 2955):
...
Add the fragment to the defragmentation sequence if the SMTP dissector
encouters a packet that contains both a DATA fragment and the terminating
\r\n.\r\n sequence.
svn path=/trunk/; revision=26419
2008-10-11 16:01:48 +00:00
813c6102b3
Really make it compile. Someone should have a look at this.
...
svn path=/trunk/; revision=26417
2008-10-11 15:16:37 +00:00
08b51ea542
Just try to make it compile.
...
svn path=/trunk/; revision=26416
2008-10-11 15:00:39 +00:00
092aab864a
Another instance of Signal info.
...
svn path=/trunk/; revision=26415
2008-10-11 14:33:02 +00:00
93a0edf6dd
From David Aggeler:
...
packet-dcm, improved DICOM Tag support, misc fixes.
svn path=/trunk/; revision=26413
2008-10-11 14:25:02 +00:00
f8a1888e9f
From Bruno Hivert:
...
Pretify Bearer Capability.
svn path=/trunk/; revision=26411
2008-10-11 11:06:58 +00:00
d5677f851a
Add an expert item if src port = dst port.
...
svn path=/trunk/; revision=26410
2008-10-11 10:41:58 +00:00
53708b2c85
Let the dissector call its subdissectors, even when tree==NULL.
...
svn path=/trunk/; revision=26409
2008-10-10 17:55:51 +00:00
Bill Meier